diff options
| author | Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> | 2019-07-01 05:42:08 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-07-01 05:42:08 -0700 |
| commit | 45c10da40912e04c0d0de02af4b23438ed0de49b (patch) | |
| tree | a086ad948b027f666aa2f9f10a096935517f6ee0 | |
| parent | 471d785dc759eb2e9c06f077f323cf136d32506b (diff) | |
| download | cpython-git-45c10da40912e04c0d0de02af4b23438ed0de49b.tar.gz | |
bpo-10945: Drop support for bdist_wininst on non-Windows systems (GH-14506)
bdist_wininst depends on MBCS codec, unavailable on non-Windows,
and bdist_wininst have not worked since at least Python 3.2, possibly
never on Python 3.
Here we document that bdist_wininst is only supported on Windows,
and we mark it unsupported otherwise to skip tests.
Distributors of Python 3 can now safely drop the bdist_wininst .exe files
without the need to skip bdist_wininst related tests.
(cherry picked from commit 72cd653c4ed7a4f8f8fb06ac364b08a97085a2b5)
Co-authored-by: Miro Hrončok <miro@hroncok.cz>
| -rw-r--r-- | Doc/distutils/builtdist.rst | 4 | ||||
| -rw-r--r-- | Lib/distutils/command/bdist_wininst.py | 3 | ||||
| -rw-r--r-- | Misc/NEWS.d/next/Windows/2019-07-01-12-38-48.bpo-10945.s0YBHG.rst | 2 |
3 files changed, 7 insertions, 2 deletions
diff --git a/Doc/distutils/builtdist.rst b/Doc/distutils/builtdist.rst index f1f3471261..0a83f8bd65 100644 --- a/Doc/distutils/builtdist.rst +++ b/Doc/distutils/builtdist.rst @@ -313,8 +313,8 @@ or the :command:`bdist` command with the :option:`!--formats` option:: If you have a pure module distribution (only containing pure Python modules and packages), the resulting installer will be version independent and have a name -like :file:`foo-1.0.win32.exe`. These installers can even be created on Unix -platforms or Mac OS X. +like :file:`foo-1.0.win32.exe`. Note that creating ``wininst`` binary +distributions in only supported on Windows systems. If you have a non-pure distribution, the extensions can only be created on a Windows platform, and will be Python version dependent. The installer filename diff --git a/Lib/distutils/command/bdist_wininst.py b/Lib/distutils/command/bdist_wininst.py index fde56754e8..15434c3a98 100644 --- a/Lib/distutils/command/bdist_wininst.py +++ b/Lib/distutils/command/bdist_wininst.py @@ -55,6 +55,9 @@ class bdist_wininst(Command): boolean_options = ['keep-temp', 'no-target-compile', 'no-target-optimize', 'skip-build'] + # bpo-10945: bdist_wininst requires mbcs encoding only available on Windows + _unsupported = (sys.platform != "win32") + def initialize_options(self): self.bdist_dir = None self.plat_name = None diff --git a/Misc/NEWS.d/next/Windows/2019-07-01-12-38-48.bpo-10945.s0YBHG.rst b/Misc/NEWS.d/next/Windows/2019-07-01-12-38-48.bpo-10945.s0YBHG.rst new file mode 100644 index 0000000000..d39576545e --- /dev/null +++ b/Misc/NEWS.d/next/Windows/2019-07-01-12-38-48.bpo-10945.s0YBHG.rst @@ -0,0 +1,2 @@ +Officially drop support for creating bdist_wininst installers on non-Windows +systems. |