summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAntoine Pitrou <solipsis@pitrou.net>2011-10-18 16:40:50 +0200
committerAntoine Pitrou <solipsis@pitrou.net>2011-10-18 16:40:50 +0200
commit551ba20e8ea9a4a97cf63f28b47175e084eb63cd (patch)
treea4b28e975a3e3b7bef76a97e201d1f0631b1b3e6
parent6bfecd1271b305afcbe3f3f68980f89aa44e1910 (diff)
downloadcpython-git-551ba20e8ea9a4a97cf63f28b47175e084eb63cd.tar.gz
Issue #13188: When called without an explicit traceback argument,
generator.throw() now gets the traceback from the passed exception's `__traceback__` attribute. Patch by Petri Lehtinen.
-rw-r--r--Lib/test/test_generators.py26
-rw-r--r--Misc/NEWS4
-rw-r--r--Objects/genobject.c5
3 files changed, 35 insertions, 0 deletions
diff --git a/Lib/test/test_generators.py b/Lib/test/test_generators.py
index 3ec209ba87..5f47b3eae0 100644
--- a/Lib/test/test_generators.py
+++ b/Lib/test/test_generators.py
@@ -1673,6 +1673,32 @@ Traceback (most recent call last):
...
ValueError: 7
+Plain "raise" inside a generator should preserve the traceback (#13188).
+The traceback should have 3 levels:
+- g.throw()
+- f()
+- 1/0
+
+>>> def f():
+... try:
+... yield
+... except:
+... raise
+>>> g = f()
+>>> try:
+... 1/0
+... except ZeroDivisionError as v:
+... try:
+... g.throw(v)
+... except Exception as w:
+... tb = w.__traceback__
+>>> levels = 0
+>>> while tb:
+... levels += 1
+... tb = tb.tb_next
+>>> levels
+3
+
Now let's try closing a generator:
>>> def f():
diff --git a/Misc/NEWS b/Misc/NEWS
index d610ff45f2..dd31b4bb59 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -10,6 +10,10 @@ What's New in Python 3.2.3?
Core and Builtins
-----------------
+- Issue #13188: When called without an explicit traceback argument,
+ generator.throw() now gets the traceback from the passed exception's
+ ``__traceback__`` attribute. Patch by Petri Lehtinen.
+
- Issue #7833: Extension modules built using distutils on Windows will no
longer include a "manifest" to prevent them failing at import time in some
embedded situations.
diff --git a/Objects/genobject.c b/Objects/genobject.c
index 01cd44ae59..49e2adeaa0 100644
--- a/Objects/genobject.c
+++ b/Objects/genobject.c
@@ -261,6 +261,11 @@ gen_throw(PyGenObject *gen, PyObject *args)
val = typ;
typ = PyExceptionInstance_Class(typ);
Py_INCREF(typ);
+
+ if (tb == NULL) {
+ /* Returns NULL if there's no traceback */
+ tb = PyException_GetTraceback(val);
+ }
}
}
else {