diff options
author | Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> | 2021-10-27 15:00:18 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-10-27 15:00:18 -0700 |
commit | 21150c6fa330f80747d698e4b883c7b4801a25bd (patch) | |
tree | abb5695dacbac6d94210ac25f088fdfaa52c9ab5 | |
parent | 30c1f18ee62cef301e18488b80b4d329290f7b95 (diff) | |
download | cpython-git-21150c6fa330f80747d698e4b883c7b4801a25bd.tar.gz |
bpo-45438: format of inspect.Signature with generic builtins (GH-29212)
Use types.GenericAlias in inspect.formatannotation to correctly add
type arguments of builtin types to the string representation of
Signatures.
Co-authored-by: Martin Rückl <martin.rueckl@codecentric.de>
(cherry picked from commit d02ffd1b5c0fd8dec6dd2f7e3f2b0cfae48b7899)
Co-authored-by: Martin Rueckl <enigma@nbubu.de>
-rw-r--r-- | Lib/inspect.py | 2 | ||||
-rw-r--r-- | Lib/test/test_inspect.py | 11 | ||||
-rw-r--r-- | Misc/NEWS.d/next/Library/2021-10-27-10-05-39.bpo-45438.Xz5lGU.rst | 1 |
3 files changed, 14 insertions, 0 deletions
diff --git a/Lib/inspect.py b/Lib/inspect.py index 976cbb1a23..64605c3cd3 100644 --- a/Lib/inspect.py +++ b/Lib/inspect.py @@ -1233,6 +1233,8 @@ def getargvalues(frame): def formatannotation(annotation, base_module=None): if getattr(annotation, '__module__', None) == 'typing': return repr(annotation).replace('typing.', '') + if isinstance(annotation, types.GenericAlias): + return str(annotation) if isinstance(annotation, type): if annotation.__module__ in ('builtins', base_module): return annotation.__qualname__ diff --git a/Lib/test/test_inspect.py b/Lib/test/test_inspect.py index 17c5d87f8a..8a8844e912 100644 --- a/Lib/test/test_inspect.py +++ b/Lib/test/test_inspect.py @@ -3200,6 +3200,17 @@ class TestSignatureObject(unittest.TestCase): pass self.assertEqual(str(inspect.signature(foo)), '()') + def foo(a: list[str]) -> tuple[str, float]: + pass + self.assertEqual(str(inspect.signature(foo)), + '(a: list[str]) -> tuple[str, float]') + + from typing import Tuple + def foo(a: list[str]) -> Tuple[str, float]: + pass + self.assertEqual(str(inspect.signature(foo)), + '(a: list[str]) -> Tuple[str, float]') + def test_signature_str_positional_only(self): P = inspect.Parameter S = inspect.Signature diff --git a/Misc/NEWS.d/next/Library/2021-10-27-10-05-39.bpo-45438.Xz5lGU.rst b/Misc/NEWS.d/next/Library/2021-10-27-10-05-39.bpo-45438.Xz5lGU.rst new file mode 100644 index 0000000000..cd6cfc1fcd --- /dev/null +++ b/Misc/NEWS.d/next/Library/2021-10-27-10-05-39.bpo-45438.Xz5lGU.rst @@ -0,0 +1 @@ +Fix typing.Signature string representation for generic builtin types. |