diff options
author | Victor Stinner <victor.stinner@gmail.com> | 2015-03-20 10:52:25 +0100 |
---|---|---|
committer | Victor Stinner <victor.stinner@gmail.com> | 2015-03-20 10:52:25 +0100 |
commit | fbd6f9ed124c89753f6e3fd2cd84e4d9c474cc1f (patch) | |
tree | 33e90e8c09bd4db6df2c20a82f1a923799b8406f | |
parent | 99953006df1414b048bfc76f66cb36a0fb31a4b7 (diff) | |
download | cpython-git-fbd6f9ed124c89753f6e3fd2cd84e4d9c474cc1f.tar.gz |
Issue #23696: Chain ZipImportError to the OSError
-rw-r--r-- | Lib/test/test_zipimport.py | 5 | ||||
-rw-r--r-- | Modules/zipimport.c | 6 |
2 files changed, 9 insertions, 2 deletions
diff --git a/Lib/test/test_zipimport.py b/Lib/test/test_zipimport.py index 1e351c8c8a..5b8d77cae7 100644 --- a/Lib/test/test_zipimport.py +++ b/Lib/test/test_zipimport.py @@ -450,7 +450,10 @@ class BadFileZipImportTestCase(unittest.TestCase): fd = os.open(TESTMOD, os.O_CREAT, 000) try: os.close(fd) - self.assertZipFailure(TESTMOD) + + with self.assertRaises(zipimport.ZipImportError) as cm: + zipimport.zipimporter(TESTMOD) + self.assertIsInstance(cm.exception.__context__, PermissionError) finally: # If we leave "the read-only bit" set on Windows, nothing can # delete TESTMOD, and later tests suffer bogus failures. diff --git a/Modules/zipimport.c b/Modules/zipimport.c index e83214c16c..38dc0c4290 100644 --- a/Modules/zipimport.c +++ b/Modules/zipimport.c @@ -875,8 +875,12 @@ read_directory(PyObject *archive) fp = _Py_fopen_obj(archive, "rb"); if (fp == NULL) { - if (PyErr_ExceptionMatches(PyExc_OSError)) + if (PyErr_ExceptionMatches(PyExc_OSError)) { + PyObject *exc, *val, *tb; + PyErr_Fetch(&exc, &val, &tb); PyErr_Format(ZipImportError, "can't open Zip file: %R", archive); + _PyErr_ChainExceptions(exc, val, tb); + } return NULL; } |