diff options
author | Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> | 2022-01-23 09:54:13 -0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-01-23 19:54:13 +0200 |
commit | 94d6434ba7ec3e4b154e515c5583b0b665ab0b09 (patch) | |
tree | dcc62ff23c35c69a084bf6ca9f54ad1947a53a86 | |
parent | 1514d1252f96e6a83eb65c439522a6b5443f6a1a (diff) | |
download | cpython-git-94d6434ba7ec3e4b154e515c5583b0b665ab0b09.tar.gz |
[3.9] bpo-21987: Fix TarFile.getmember getting a dir with a trailing slash (GH-30283) (GH-30738)
(cherry picked from commit cfadcc31ea84617b1c73022ce54d4ae831333e8d)
Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
-rwxr-xr-x | Lib/tarfile.py | 2 | ||||
-rw-r--r-- | Lib/test/test_tarfile.py | 19 | ||||
-rw-r--r-- | Misc/NEWS.d/next/Library/2021-12-28-11-55-10.bpo-21987.avBK-p.rst | 2 |
3 files changed, 22 insertions, 1 deletions
diff --git a/Lib/tarfile.py b/Lib/tarfile.py index 043a4ab5a5..a738e25684 100755 --- a/Lib/tarfile.py +++ b/Lib/tarfile.py @@ -1785,7 +1785,7 @@ class TarFile(object): than once in the archive, its last occurrence is assumed to be the most up-to-date version. """ - tarinfo = self._getmember(name) + tarinfo = self._getmember(name.rstrip('/')) if tarinfo is None: raise KeyError("filename %r not found" % name) return tarinfo diff --git a/Lib/test/test_tarfile.py b/Lib/test/test_tarfile.py index 06fb97212d..a4b63ff82b 100644 --- a/Lib/test/test_tarfile.py +++ b/Lib/test/test_tarfile.py @@ -219,6 +219,25 @@ class UstarReadTest(ReadTest, unittest.TestCase): def test_issue14160(self): self._test_fileobj_link("symtype2", "ustar/regtype") + def test_add_dir_getmember(self): + # bpo-21987 + self.add_dir_and_getmember('bar') + self.add_dir_and_getmember('a'*101) + + def add_dir_and_getmember(self, name): + with support.temp_cwd(): + with tarfile.open(tmpname, 'w') as tar: + try: + os.mkdir(name) + tar.add(name) + finally: + os.rmdir(name) + with tarfile.open(tmpname) as tar: + self.assertEqual( + tar.getmember(name), + tar.getmember(name + '/') + ) + class GzipUstarReadTest(GzipTest, UstarReadTest): pass diff --git a/Misc/NEWS.d/next/Library/2021-12-28-11-55-10.bpo-21987.avBK-p.rst b/Misc/NEWS.d/next/Library/2021-12-28-11-55-10.bpo-21987.avBK-p.rst new file mode 100644 index 0000000000..305dd16d53 --- /dev/null +++ b/Misc/NEWS.d/next/Library/2021-12-28-11-55-10.bpo-21987.avBK-p.rst @@ -0,0 +1,2 @@ +Fix an issue with :meth:`tarfile.TarFile.getmember` getting a directory name +with a trailing slash. |