diff options
author | Sam Gross <colesbury@gmail.com> | 2021-11-17 17:53:33 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-11-17 23:53:33 +0100 |
commit | 87787c8774221c81602b31b0e0dc0678ad494e91 (patch) | |
tree | 74170d3e701298c60a4c10b64342df1d5f807442 | |
parent | ac89f8cab79800195687dd141de472f90c626ec3 (diff) | |
download | cpython-git-87787c8774221c81602b31b0e0dc0678ad494e91.tar.gz |
[3.9] bpo-42540: reallocation of id_mutex should not force default allocator (GH-29564) (GH-29600)
Unlike the other locks reinitialized by _PyRuntimeState_ReInitThreads,
the "interpreters.main->id_mutex" is not freed by _PyRuntimeState_Fini
and should not force the default raw allocator..
(cherry picked from commit 736684b1bb67369a2e95a9f621752deead44e7ef)
Co-authored-by: Sam Gross <colesbury@gmail.com>
-rw-r--r-- | Lib/test/test_os.py | 16 | ||||
-rw-r--r-- | Misc/NEWS.d/next/Core and Builtins/2021-11-15-12-08-27.bpo-42540.V2w107.rst | 2 | ||||
-rw-r--r-- | Python/pystate.c | 5 |
3 files changed, 22 insertions, 1 deletions
diff --git a/Lib/test/test_os.py b/Lib/test/test_os.py index 35933e9c8c..59ddf9e0b3 100644 --- a/Lib/test/test_os.py +++ b/Lib/test/test_os.py @@ -4273,6 +4273,22 @@ class TimesTests(unittest.TestCase): self.assertEqual(times.elapsed, 0) +@requires_os_func('fork') +class ForkTests(unittest.TestCase): + def test_fork(self): + # bpo-42540: ensure os.fork() with non-default memory allocator does + # not crash on exit. + code = """if 1: + import os + from test import support + pid = os.fork() + if pid != 0: + support.wait_process(pid, exitcode=0) + """ + assert_python_ok("-c", code) + assert_python_ok("-c", code, PYTHONMALLOC="malloc_debug") + + # Only test if the C version is provided, otherwise TestPEP519 already tested # the pure Python implementation. if hasattr(os, "_fspath"): diff --git a/Misc/NEWS.d/next/Core and Builtins/2021-11-15-12-08-27.bpo-42540.V2w107.rst b/Misc/NEWS.d/next/Core and Builtins/2021-11-15-12-08-27.bpo-42540.V2w107.rst new file mode 100644 index 0000000000..91160598bd --- /dev/null +++ b/Misc/NEWS.d/next/Core and Builtins/2021-11-15-12-08-27.bpo-42540.V2w107.rst @@ -0,0 +1,2 @@ +Fix crash when :func:`os.fork` is called with an active non-default +memory allocator. diff --git a/Python/pystate.c b/Python/pystate.c index 9beefa8e20..c3520c336a 100644 --- a/Python/pystate.c +++ b/Python/pystate.c @@ -139,11 +139,14 @@ _PyRuntimeState_ReInitThreads(_PyRuntimeState *runtime) _PyMem_SetDefaultAllocator(PYMEM_DOMAIN_RAW, &old_alloc); int interp_mutex = _PyThread_at_fork_reinit(&runtime->interpreters.mutex); - int main_interp_id_mutex = _PyThread_at_fork_reinit(&runtime->interpreters.main->id_mutex); int xidregistry_mutex = _PyThread_at_fork_reinit(&runtime->xidregistry.mutex); PyMem_SetAllocator(PYMEM_DOMAIN_RAW, &old_alloc); + /* bpo-42540: id_mutex is freed by _PyInterpreterState_Delete, which does + * not force the default allocator. */ + int main_interp_id_mutex = _PyThread_at_fork_reinit(&runtime->interpreters.main->id_mutex); + if (interp_mutex < 0) { Py_FatalError("Can't initialize lock for runtime interpreters"); } |