| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
...which happens to define __GNUC__=4, __GNUC_MINOR__=2. (See also
<https://git.libreoffice.org/core/+/9a23239b710e44754e4a28643420c9ba91552645%5E%21>
"external/cppunit: Don't mis-apply GCC < 4.6 workaround for Clang". This change
requires <https://gerrit.libreoffice.org/c/cppunit/+/147383> "Use snprintf
instead of sprintf" to avoid deprecation warnings on macOS, which had originally
been hidden by the mis-applied #pragma.)
Change-Id: I4fcb38a79766238862795ba4019638862e65b041
Reviewed-on: https://gerrit.libreoffice.org/c/cppunit/+/147384
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See
<https://git.libreoffice.org/core/+/bd8a213c8ceccf66ab296ef0aea0fa4c451047e5%5E%21>
"external/cppunit: Use snprintf instead of sprintf" for how sprintf would have
caused deprecation warnings on macOS.
(For MSVC, keep using sprintf_s. According to
<https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/snprintf-snprintf-snprintf-l-snwprintf-snwprintf-l?view=msvc-170>:
"Beginning with the UCRT in Visual Studio 2015 and Windows 10, snprintf is no
longer identical to _snprintf. The snprintf function behavior is now C99
standard conformant." So for older versions, snprintf would potentially not
store a terminating NUL, like _snprintf but unlike sprintf_s.)
Change-Id: Ibf8b228cd1dd57428ecf85ed10e0793b78ae90c9
Reviewed-on: https://gerrit.libreoffice.org/c/cppunit/+/147383
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
belongs to the if body
|
|
|
|
|
|
|
|
|
|
| |
Provide an extension trait message_to_string that allows client code
to call ASSERT_MESSAGE with their own string types.
Also provide a default extension trait that accepts std::ostream
messages.
Change-Id: I516f97063c34d86bc91c40e0ec147d5393e7b6ea
|
|
|
|
|
|
|
|
|
|
|
|
| |
This helps avoid issues like <https://gerrit.libreoffice.org/plugins/gitiles/
core/+/9808486a89c6368f836579f8d8c0dda63fd0063c%5E%21> "Avoid
-Werror,-Wimplicit-fallthrough with clang-cl ...where CPPUNIT_FAIL is marked as
noreturn only for __GNUC__".
Change-Id: Idb33af7375f103f2dd7a7b4c3dbf20ce731b17ad
Reviewed-on: https://gerrit.libreoffice.org/67247
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
This is similar to googletest's TEST_F() macro, allows to avoid spelling
out the test name in a suite only once, not 3 times.
Change-Id: I90804d271d046d8158678617d8db75ed6ca7c420
Reviewed-on: https://gerrit.libreoffice.org/61732
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
...when an implicitly-defined copy function is used that may in a future C++
standard be defined as deleted because of the user-declared destructor. Just
declare all the four copy/move functions as defaulted for a consistent
interface.
(Originally addressed with LibreOffice commit
<https://gerrit.libreoffice.org/58042> "external/cppunit: silence
-Werror=deprecated-copy (GCC trunk towards GCC 9)".)
Change-Id: Ie38ac3a613e6fbc2e4045cb5b14c3f6d167c79c5
Reviewed-on: https://gerrit.libreoffice.org/58690
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
...instead of as characters, as those values often represent numerical values
(e.g., sal_uInt8 aka unsigned char in LibreOffice), and often even have values
outside the printing ASCII range
Change-Id: I72727e98f5af616f6b0c03c57fc1119c0c11c1fc
Reviewed-on: https://gerrit.libreoffice.org/40138
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows to execute the same test with different parameters and
treats each execution as an own test. The change consists of two parts,
the TestCaller can now handle any callable which also makes it easy to
generate programatically more complex test cases as well as the new
CPPUNIT_TEST_PARAMETERIZED macro. That macro takes the test name as well
as an iteratable, e.g. std::initializer_list.
An example for this usage is:
class SimpleTest : public CppUnit::TestFixture
{
public:
CPPUNIT_TEST_SUITE(SimpleTest);
CPPUNIT_TEST_PARAMETERIZED(test, {1, 2, 3, 4});
CPPUNIT_TEST_SUITE_END();
void test(int i)
{
CPPUNIT_ASSERT(i < 5);
}
};
which will execute test 4 times with the values 1 to 4.
|
|
|
|
| |
This allows us to pass in any callable e.g. results of std::bind.
|
| |
|
| |
|
|
|
|
| |
... so check just for existence.
|
| |
|
| |
|
|
|
|
|
|
| |
The asserter now has special handling to convert the enum class to a
std::string. This does not work without some template magic as enum
class has no implicit conversion to int.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using gcc (currently using gcc 5.2) flag -Wzero-as-null-pointer-constant
triggers warnings:
[...]include/cppunit/extensions/HelperMacros.h:171:31: error: zero as null
pointer constant [-Werror=zero-as-null-pointer-constant]
CppUnitExDeleter() : suite (0) {} \
^
[...]include/cppunit/extensions/HelperMacros.h:174:45: error: zero as null
pointer constant [-Werror=zero-as-null-pointer-constant]
CPPUNIT_NS::TestSuite *tmp = suite; suite = NULL; return tmp; \
^
Using nullptr is the c++11 way to initialize pointers with null value [1].
[1] http://en.cppreference.com/w/cpp/language/nullptr
|
|
|
|
|
| |
RTTI is supported by any decent compiler and with the mandatory c++11 support
we are no longer supporting older compilers anyway.
|
|
|
|
| |
Use std::auto_ptr in C++03 mode.
|
|
|
|
|
|
| |
These features will switch the used C++ version from C++03 to C++11. We
are also going to use std::unique_ptr instead of std::auto_ptr for the
c++11 mode.
|
| |
|
|
|
|
|
| |
The code has been commented out for a long time and is not related to a
missing fix.
|
|
|
|
|
|
|
|
|
| |
Now we support the following new macros:
- CPPUNIT_ASSERT_LESS
- CPPUNIT_ASSERT_GREATER
- CPPUNIT_ASSERT_LESSEQUAL
- CPPUNIT_ASSERT_GREATEREQUAL
|
|
|
|
|
| |
that might help clang scan-build understand that execution won't continue after
they fail
|
|
|
|
|
|
|
| |
"'CppUnit::TextTestResult::addFailure' hides overloaded virtual function;
../../include/cppunit/TestResult.h:85:16: note: hidden overloaded virtual
function 'CppUnit::TestResult::addFailure' declared here: different number of
parameters (2 vs 1)." (Clang)
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch allows to compile the code with gcc's -Weffc++
It consists mostly of making copy constructors and assignment operators
explicit and private, and of initializing all members in initializer lists.
Change-Id: I6f1cae812c58e3791c2386a1288501cf2f559610
Reviewed-on: https://gerrit.libreoffice.org/5424
Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Tor Lillqvist <tml@iki.fi>
|
|\
| |
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
.gitignore
autogen.sh
configure.in
doc/Makefile.am
examples/cppunittest/TestAssertTest.cpp
|
| | |
|
| | |
|
| | |
|
| | |
|