all: avoid quoting file names when possible

Quote file names using the "shell-escape" or "shell-escape-always"
methods, which quote as appropriate for most shells,
and better support copy and paste of presented names.
The "always" variant is used when the file name is
embedded in an error message with surrounding spaces.

* cfg.mk (sc_error_shell_quotes): A new syntax check rule
to suggest quotef() where appropriate.
(sc_error_shell_always_quotes): Likewise for quoteaf().
* src/system.h (quotef): A new define to apply shell quoting
when needed.  I.E. when shell character or ':' is present.
(quoteaf): Likewise, but always quote.
* src/*.c: Use quotef() and quoteaf() rather than quote()
where appropriate.
* tests/: Adjust accordingly.

1 files changed, 3 insertions, 5 deletions

diff --git a/src/rm.c b/src/rm.c
index c1a23d5fe..a82252b5d 100644
--- a/src/rm.c
+++ b/src/rm.c
@@ -27,8 +27,6 @@
 #include "system.h"
 #include "argmatch.h"
 #include "error.h"
-#include "quote.h"
-#include "quotearg.h"
 #include "remove.h"
 #include "root-dev-ino.h"
 #include "yesno.h"
@@ -118,8 +116,8 @@ diagnose_leading_hyphen (int argc, char **argv)
           fprintf (stderr,
                    _("Try '%s ./%s' to remove the file %s.\n"),
                    argv[0],
-                   quotearg_n_style (1, shell_quoting_style, arg),
-                   quote (arg));
+                   quotearg_n_style (1, shell_escape_quoting_style, arg),
+                   quoteaf (arg));
           break;
         }
     }
@@ -329,7 +327,7 @@ main (int argc, char **argv)
       x.root_dev_ino = get_root_dev_ino (&dev_ino_buf);
       if (x.root_dev_ino == NULL)
         error (EXIT_FAILURE, errno, _("failed to get attributes of %s"),
-               quote ("/"));
+               quoteaf ("/"));
     }
 
   uintmax_t n_files = argc - optind;