summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* STOUT-FIRMWARE: Add FAFT keyboard remap GBB flagfirmware-stout-2817.BMarc Jones2012-12-132-1/+3
| | | | | | | | | | | | | | | Add a new flag, 0x100, to indicate FAFT key stroke overrides. BUG=chrome-os-partner:16799 TEST=manual BRANCH=stout Change-Id: Ibf9a24842619da644a3fefdd8a77c6a51ec45db1 Original-Change-Id: I76b7f3f4c51abec5528047f690f20a09b257abc2 Signed-off-by: Marc Jones <marc.jones@chromium.org> Reviewed-on: https://gerrit.chromium.org/gerrit/39651 Reviewed-by: Shawn Nematbakhsh <shawnn@google.com> Tested-by: Shawn Nematbakhsh <shawnn@google.com>
* STOUT-FIRMWARE: vboot_reference: Fix keyboard input lag at confirm screen.Shawn Nematbakhsh2012-10-311-1/+3
| | | | | | | | | | | | | | | | | Changing languages is terribly slow at the confirm screen, when switching from dev to normal. Reduce sleep time to improve user experience. BUG=chrome-os-partner:15726 TEST=boot in dev, hit space, hit arrows rapidly to change language, observe no lag. BRANCH=butterfly, stout Change-Id: Ic256b203725d0a096e9129ad2dbb417c5458cec2 Original-Change-Id: I0943debc31d78dcfce87e7f7d4537ae47f5f8cfd Reviewed-on: https://gerrit.chromium.org/gerrit/36988 Tested-by: Shawn Nematbakhsh <shawnn@google.com> Reviewed-by: Shawn Nematbakhsh <shawnn@google.com>
* STOUT-FIRMWARE: Cache GBB images to speed up displaySimon Glass2012-10-181-5/+5
| | | | | | | | | | | | | | | | Rather than read the images from slow flash every time we need them, cache them the first time and use that cache thereafter. BUG=none BRANCH=stout TEST=manual, test basic firmware functions. Change-Id: Ic0ad0bef7a958feb3ac044e41774be5c87f67e22 Original-Change-Id: Ieb39c44bddeb6315da8983669f19f550888659bd Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://gerrit.chromium.org/gerrit/35919 Reviewed-by: Shawn Nematbakhsh <shawnn@google.com> Tested-by: Shawn Nematbakhsh <shawnn@google.com>
* STOUT-FIRMWARE: Print warning in TONORM when GBB flags force DEV.Hung-Te Lin2012-10-181-0/+9
| | | | | | | | | | | | | | | | | | We use gbb-flag-force-dev-switch-on in default firmware images to make things easier for factory and some devs. But when we request normal mode there should be some sort of warning/error telling the user that this is not available, otherwise we can spent time trying to figure out why the firmware doesn't work. BRANCH=stout BUG=chrome-os-partner:14474 TEST=manual, test basic firmware functions. Change-Id: Id48c12693c7575001fae7fad92a868cb5465e83d Reviewed-on: https://gerrit.chromium.org/gerrit/35918 Reviewed-by: Shawn Nematbakhsh <shawnn@google.com> Tested-by: Shawn Nematbakhsh <shawnn@google.com>
* STOUT-FIRMWARE: Print warning in Ctrl-U when dev_boot_usb is not enabled.Hung-Te Lin2012-10-181-0/+3
| | | | | | | | | | | | | | | | | Ctrl-U used to simply beep without messages for why it does not work (due to NV data dev_boot_usb). Since the system is already in Developer mode, it should be fine to provide some debug information otherwise we can spent time trying to figure out why the firmware doesn't work. BRANCH=stout BUG=chrome-os-partner:14474 TEST=manual, test basic firmware functions. Change-Id: Ic4e20fc2df7c1c2dd6fb425f066ebd55d9659ac2 Original-Change-Id: Iab20ecdb2e1c4e267b7257a7bd241006241ddf70 Reviewed-on: https://gerrit.chromium.org/gerrit/35917 Reviewed-by: Shawn Nematbakhsh <shawnn@google.com> Tested-by: Shawn Nematbakhsh <shawnn@google.com>
* STOUT-FIRMWARE: Esc at DEV screen no longer triggers TONORMRandall Spangler2012-09-251-2/+1
| | | | | | | | | | | | | | | | | | | | BUG=chrome-os-partner:13765 BRANCH=all TEST=manual 1. boot in dev mode. see DEV screen 2. press space -> TONORM 3. press esc -> DEV 4. press esc -> (still at DEV) Change-Id: Iaf3505128a17d68e0ca9aac56617d73eadd95666 Original-Change-Id: I9ed2fd2ff2380b058f1aa677ccd516d9fd5679d2 Signed-off-by: Marc Jones <marc.jones@chromium.org> Reviewed-on: https://gerrit.chromium.org/gerrit/33669 Reviewed-by: Randall Spangler <rspangler@chromium.org> Reviewed-by: Ronald G. Minnich <rminnich@chromium.org> Reviewed-by: Shawn Nematbakhsh <shawnn@chromium.org> Tested-by: Shawn Nematbakhsh <shawnn@chromium.org>
* STOUT-FIRMWARE: Add the new GBB_FLAG_ENTER_TRIGGERS_TONORM usageTom Wai-Hong Tam2012-09-251-0/+1
| | | | | | | | | | | | | | | | | | | | | | | This GBB_FLAG_ENTER_TRIGGERS_TONORM is new added for allowing Enter (default is Space) to trigger the TONORM screen. This flag is used by FAFT testing. Chage the usage of set_gbb_flags.sh to help an user. Cherry-picked for faft support for Stout. This is not the complete solution. BRANCH=stout BUG=chrome-os-partner:14056 TEST=None. Trivial comment change. Change-Id: I8f734bd686beed761bdb8b5a2993cf32fec92bb4 Original-Change-Id: I8a1efa880627965570719f22dedfa0e31ab2d5f5 Signed-off-by: Marc Jones <marc.jones@chromium.org> Reviewed-on: https://gerrit.chromium.org/gerrit/33668 Reviewed-by: Tom Wai-Hong Tam <waihong@chromium.org> Reviewed-by: Shawn Nematbakhsh <shawnn@chromium.org> Tested-by: Shawn Nematbakhsh <shawnn@chromium.org>
* STOUT-FIRMWARE: Check keyboard more often in recovery modeSimon Glass2012-09-191-7/+8
| | | | | | | | | | | | | | | | | | | | Currently we check the keyboard each 250ms. This makes for a pretty choppy experience when changing languages. Change to check every 20ms, without changing the disk check interval (which remains 1s). BUG=chrome-os-partner:13993 BRANCH=snow TEST=manual Boot into recovery Try changing language on snow with left/right arrow and see that it updates instantly. Change-Id: I79dd16a7897062fa5540ca22faf132c302a7ef7d Original-Change-Id: I2ae411bc36fdb2badac11595b099bca43f116669 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://gerrit.chromium.org/gerrit/33650 Reviewed-by: Shawn Nematbakhsh <shawnn@chromium.org> Tested-by: Shawn Nematbakhsh <shawnn@chromium.org>
* vbutil_keyblock: Fix argument to PrivateKeyReadPem()Gaurav Shah2012-08-281-1/+1
| | | | | | | | | | | | | | | | | | If the --signprivate_pem option is used to vbutil_keyblock and without an external signer, we were passing the wrong name to PrivateKeyReadPem() causing all such invocations to fail. This CL fixes the typo. (This particular path isn't current being used.) BUG=none TEST=manually verified with --signprivatekey_pem but without --external_signer. BRANCH=none Change-Id: I56df76a965706f654df1de8ac6e42738c15284c7 Reviewed-on: https://gerrit.chromium.org/gerrit/31556 Commit-Ready: Gaurav Shah <gauravsh@chromium.org> Reviewed-by: Gaurav Shah <gauravsh@chromium.org> Tested-by: Gaurav Shah <gauravsh@chromium.org>
* Change FMAP search stride from 4-byte to 64-byte.Louis Yung-Chieh Lo2012-08-271-1/+1
| | | | | | | | | | | | | | | | | | The FMAP requires to be aligned at 64-byte. Searchin at 4-byte could lead bug if a designated FMAP is located at 4-byte address. BUG=chrome-os-partner:13143, TEST=Tested in CL https://gerrit.chromium.org/gerrit/#/c/31436/ BRANCH=link,snow Signed-off-by: Louis Yung-Chieh Lo <yjlou@chromium.org> Change-Id: Ib7f36dc89d7d2763b1a72b641433d45bec6c2bef Reviewed-on: https://gerrit.chromium.org/gerrit/31442 Reviewed-by: Bill Richardson <wfrichar@chromium.org> Reviewed-by: David Hendricks <dhendrix@chromium.org> Reviewed-by: Simon Glass <sjg@chromium.org> Commit-Ready: Yung-Chieh Lo <yjlou@chromium.org> Tested-by: Yung-Chieh Lo <yjlou@chromium.org>
* cgpt: Fix error in modifying size of an existing partitionBill Richardson2012-08-242-2/+27
| | | | | | | | | | | | | | | | | | | Modifying the size of an existing partition without modifying the start as well assumed the start was at block 0. Sometimes it was caught, often it wasn't. Fix the error, add a test to catch the problem. BUG=chrome-os-partner:13090 BRANCH=all TEST=manual make && make runtests Change-Id: I4f5a5031a90a3e78d886ed3573f61305316a3f1f Signed-off-by: Bill Richardson <wfrichar@chromium.org> Reviewed-on: https://gerrit.chromium.org/gerrit/31418 Reviewed-by: Randall Spangler <rspangler@chromium.org>
* Rename $GPT as $CGPT, just for clarity.Bill Richardson2012-08-241-63/+63
| | | | | | | | | | | | | | | | I'm about to add a new test to fix some borkage with cgpt. First step is to clean up the script a little bit. BUG=none (yet) BRANCH=all TEST=manual make && make runtests Change-Id: I2311b5eb20aff80c4a0435cf1d10331c679af3c0 Signed-off-by: Bill Richardson <wfrichar@chromium.org> Reviewed-on: https://gerrit.chromium.org/gerrit/31379 Reviewed-by: Randall Spangler <rspangler@chromium.org>
* Fix broken bitmap testsBill Richardson2012-08-246-6/+6
| | | | | | | | | | | | | | | | When we changed the bmpblk version from 1.2 to 2.0, the tests weren't updated. BUG=chrome-os-partner:11078 BRANCH=all TEST=manual make && make runtests Change-Id: I244a9aeeb34be912fe6058687394c37d0e474890 Signed-off-by: Bill Richardson <wfrichar@chromium.org> Reviewed-on: https://gerrit.chromium.org/gerrit/31377 Reviewed-by: Randall Spangler <rspangler@chromium.org>
* signer scripts: break kernel parameters on spaces rather than word boundariesMike Frysinger2012-08-241-7/+15
| | | | | | | | | | | | | | | | | | | | | The current kernel parameter parsing logic uses word boundaries (\b) to keep from replacing parameters inside of other parameters (like "level=1" mangling "loglevel=1" into "log"), but this fails when the last character isn't a "word" character. e.g. "\bconsole=\b" doesn't match "console=". Change the \b to a space. Since we're already using spaces as our split marker, this shouldn't be a problem. BRANCH=None BUG=chrome-os-partner:12780 BUG=chromium-os:33868 TEST=ran `ensure_secure_kernelparams.sh` on an image with 'console=' and saw it work Change-Id: Id69250179ea76aabfed9cd21c1c59483d78a215d Reviewed-on: https://gerrit.chromium.org/gerrit/31356 Reviewed-by: David McMahon <djmm@chromium.org> Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org>
* signer scripts: include debug output when we failMike Frysinger2012-08-241-0/+21
| | | | | | | | | | | | | | | | When checking kernel params fail, it's useful to know all the variables as to what it's doing. So dump some state when an error occurs. BRANCH=None BUG=None TEST=ran `ensure_secure_kernelparams.sh` on a bad image and saw useful output TEST=ran `ensure_secure_kernelparams.sh` on a good image and saw no output Change-Id: I0e499f87a6d8feed80da72aba75e1e6c1b4076c9 Reviewed-on: https://gerrit.chromium.org/gerrit/31355 Reviewed-by: David McMahon <djmm@chromium.org> Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org>
* Short-circuit looping for audio in Sandbox U-Boot buildsTaylor Hutt2012-08-241-0/+4
| | | | | | | | | | | | | | | | | Sandbox U-Boot has no sound, so there is no point in looping while it doesn't really play. BRANCH=none BUG=chromium-os:32603 TEST=Sandbox U-Boot has no sound, no need to loop Signed-off-by: Taylor Hutt <thutt@chromium.org> Change-Id: I5ff987d9d80c2d24ae6502c36cf399e582dff524 Reviewed-on: https://gerrit.chromium.org/gerrit/31015 Reviewed-by: Bill Richardson <wfrichar@chromium.org> Commit-Ready: Taylor Hutt <thutt@chromium.org> Reviewed-by: Taylor Hutt <thutt@chromium.org> Tested-by: Taylor Hutt <thutt@chromium.org>
* newbitmaps: Add "native 1366x768 USB" profile.Hung-Te Lin2012-08-242-1/+7
| | | | | | | | | | | | BRANCH=none # we always build images in ToT. BUG=chrome-os-partner:13048 TEST=make # got n1366usb bmpblk.bin Change-Id: I5af3c4f599c6789c208013095db86f0836241ced Reviewed-on: https://gerrit.chromium.org/gerrit/31324 Reviewed-by: Bill Richardson <wfrichar@chromium.org> Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org>
* Fix reporting TPM kernel version and firmware version on ZGBRandall Spangler2012-08-231-6/+6
| | | | | | | | | | | | | | | | These fields are part of the version 1 struct, but were mistakenly labeled as version 2 fields. Since ZGB firmware produces a version 1 struct, crossystem was treating the fields as unavailable. BUG=chromium-os:33685 TEST=crossystem tpm_fwver tpm_kernver BRANCH=none (OS utility change, not firmware, and affects only Alex/ZGB) Change-Id: Ic857ee2da9a7ae7f0d42317b711bf102d068de64 Signed-off-by: Randall Spangler <rspangler@chromium.org> Reviewed-on: https://gerrit.chromium.org/gerrit/30904 Tested-by: Sonny Rao <sonnyrao@chromium.org> Reviewed-by: Sonny Rao <sonnyrao@chromium.org>
* newbitmaps: Reduce spacing between for_help and URL text.Hung-Te Lin2012-08-222-1/+6
| | | | | | | | | | | | | | | Both for_help_* and Url bitmaps have margin, so it looks too large as a "margin*2 + 5(x_pad)" gap on screen. BRANCH=none BUG=chrome-os-partner:12893 TEST=make # All bitmaps generated. Change-Id: Ic8d3e9180e52b7476b07367a027793cea0ed3109 Reviewed-on: https://gerrit.chromium.org/gerrit/30988 Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Dave Parker <dparker@chromium.org> Commit-Ready: Hung-Te Lin <hungte@chromium.org>
* mount-encrypted: explicitly use uint64_t for sizesKees Cook2012-08-223-53/+55
| | | | | | | | | | | | | | | On very large HDDs, the sector count was wrapping around. Switch most calculations to bytes using uint64_t, and use BLKGETSIZE64 for checking the loopback device size. BUG=chrome-os-partner:12705 TEST=parrot build, manual testing STATUS=Fixed Change-Id: I1f7aea81151ed5cc130b1f6a05fda83f7a85150f Signed-off-by: Kees Cook <keescook@chromium.org> Reviewed-on: https://gerrit.chromium.org/gerrit/31073 Reviewed-by: Elly Jones <ellyjones@chromium.org>
* newbitmaps: Improve insert_sd_usb2 message.Hung-Te Lin2012-08-2052-52/+166
| | | | | | | | | | | | | | | | | "insert_sd_usb2" message didn't include the "ChromeOS is missing or damaged" text, also is too long for certain locales. We should revise message and check if the locale fits screen width. BRANCH=none BUG=none TEST=cd strings; make # all pass Change-Id: Ie9cb5e4ecd6d143772ffa8e7de29c202e9bde130 Reviewed-on: https://gerrit.chromium.org/gerrit/30824 Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Dave Parker <dparker@chromium.org> Commit-Ready: Hung-Te Lin <hungte@chromium.org>
* newbitmaps: Support more profiles.Hung-Te Lin2012-08-207-3/+31
| | | | | | | | | | | | | | | Added "n1366usb2" profile and remove SD icon in *usb profile. BRANCH=none BUG=chrome-os-partner:11078 TEST=make # all profiles generated. Change-Id: If280cebb847cdc7a599f510f279df03e1cc9b4d5 Reviewed-on: https://gerrit.chromium.org/gerrit/30810 Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Bill Richardson <wfrichar@chromium.org> Reviewed-by: Dave Parker <dparker@chromium.org> Commit-Ready: Hung-Te Lin <hungte@chromium.org>
* newbitmaps: Change build targets from x86/arm to "profiles".Hung-Te Lin2012-08-175-51/+63
| | | | | | | | | | | | | | | | | | | | | The difference of firmware bitmaps won't rely on platform (x86/arm) in future; instead, things will differ by rescaling & message contents. To support that, we need to change build target from "platform" to "profiles". To build all platforms, run "make" in top leve (or "make all" in images). To debug (en locale without rescaling), run "make" in images folder. To debug a specific profile, run "make $PROFILE" in images folder. BRANCH=none BUG=chrome-os-partner:11078, chrome-os-partner:12790 TEST=make # all profiles generated in images/out_*/*.bin Change-Id: Iaabf160b1b2bc844d230188eb593daa8a597d378 Reviewed-on: https://gerrit.chromium.org/gerrit/30683 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org>
* newbitmaps: Replace image source BMP files by PNG format.Hung-Te Lin2012-08-1713-2/+2
| | | | | | | | | | | | | | | PNG files are better for editing and checking than BMP files. Also smaller file size. BRANCH=none BUG=none TEST=make # x86 & arm bitmap blocks generated. Change-Id: I828779aafa4938cb21356a8c42dee27b1b3ad8ae Reviewed-on: https://gerrit.chromium.org/gerrit/30682 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org>
* newbitmaps: Revise fonts, color, layout & messages.Hung-Te Lin2012-08-17163-135/+85
| | | | | | | | | | | | | | | | | | | | | Inspired by https://gerrit.chromium.org/gerrit/#/c/30631/ - Increase gray colored text contrast - Enlarge font size to 17pt - Change standard font to Verdata (which is wider than usually fonts, to provide better quality when stretched in horizontal) - Decomposed tonorm_confirmation & devmode so we can have better control to verif_* prompt, and look more similar to original mock. BUG=chrome-os-partner:11078 TEST=make # All platforms generated BRANCH=none Change-Id: If019b5767f13556df0e4da77f6457e092fa06016 Reviewed-on: https://gerrit.chromium.org/gerrit/30679 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org>
* newbitmaps: Add "insert SD / USB2" text resource.Hung-Te Lin2012-08-1751-0/+51
| | | | | | | | | | | | | | We need the text for "SD or USB2" (i.e., not USB3). BRANCH=none BUG=chrome-os-partner:12790 TEST=none, only adding text translation resource. Change-Id: Id70a2565bb1fb0b6a4ed92d3fceddbc72e60d77a Reviewed-on: https://gerrit.chromium.org/gerrit/30663 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org>
* Improved pretty-print for dump_fmap, with gap detectionBill Richardson2012-08-171-61/+221
| | | | | | | | | | | | | | | BUG=none BRANCH=none TEST=manual Use it to dump the FMAP from a firmware image: dump_fmap -h /build/link/firmware/image-link.bin Change-Id: I94fb9396ea886b072845fadef6ef1e1e2ff85a59 Signed-off-by: Bill Richardson <wfrichar@chromium.org> Reviewed-on: https://gerrit.chromium.org/gerrit/30784 Reviewed-by: Randall Spangler <rspangler@chromium.org>
* Fix vertical placement of bmp images on firmware screens.Dave Parker2012-08-161-11/+5
| | | | | | | | | | | | | BUG=chromium-os:33608 TEST=Run 'make' in newbitmaps directory to generate new bmpblock. Run on DUT. Observe spacing in the footer section is closer together. Change-Id: I96987e827fd395f13244dbc58db600de5dc30958 Reviewed-on: https://gerrit.chromium.org/gerrit/30610 Reviewed-by: Hung-Te Lin <hungte@chromium.org> Commit-Ready: Dave Parker <dparker@chromium.org> Tested-by: Dave Parker <dparker@chromium.org>
* Fix handling of enter and space in developer screens.Randall Spangler2012-08-162-60/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | At DEV screen: - Space triggers TONORM - Enter is ignored unless new GBB flag is set At TONORM screen: - Enter always means YES - Space is ignored So, if you hold the space key at the dev screen, you'll go to tonorm and stay there until you press Enter or Esc. If you hold the Enter key at the dev screen, nothing will happen. Add a GBB flag to allow Enter to trigger the TONORM screen; this will be used by FAFT testing. BRANCH=all BUG=chrome-os-partner:12699 TEST=manual 1. press enter at dev screen. nothing happens. 2. press space at dev screen. tonorm. 3. press space at tonorm. nothing happens. 4. press enter at tonorm. turns off dev mode. Change-Id: I9f3128d5114e1486911cc4d76d0ccd5649de1680 Signed-off-by: Randall Spangler <rspangler@chromium.org> Reviewed-on: https://gerrit.chromium.org/gerrit/30456 Reviewed-by: Tom Wai-Hong Tam <waihong@chromium.org>
* mount-encrypted: calculate inode ratio based on final sizeKees Cook2012-08-162-1/+74
| | | | | | | | | | | | | | | | mkfs.ext4 does not use the resize= hint for calculating inode ratios. This means very tiny initial filesystems will not get enough inodes once it has been resized. This calculates the desired inode ratio based on the expected final size of the filesystem. BUG=chrome-os-partner:12678 TEST=lumpy build, manual testing STATUS=Fixed Change-Id: I216aaaa6e0ef50e82265ee46ecac5a65bb077387 Signed-off-by: Kees Cook <keescook@chromium.org> Reviewed-on: https://gerrit.chromium.org/gerrit/30579 Reviewed-by: Gaurav Shah <gauravsh@chromium.org>
* Make crossystem look for the write protect switch in the chromeos_arm deviceGabe Black2012-08-161-2/+20
| | | | | | | | | | | | | | | | | | The value of the ChromeOS write protect switch is now provided through the new chromeos_arm platform device which avoids the mismatch between U-Boot and kernel GPIO numbering. BUG=chrome-os-partner:11297 TEST=gmerge-ed onto a snow and verified that crossystem got the right value of the write protect switch. BRANCH=snow Change-Id: I466370e4f6bf2d14c067518a9d620e9e60142a0b Signed-off-by: Gabe Black <gabeblack@google.com> Reviewed-on: https://gerrit.chromium.org/gerrit/30534 Reviewed-by: Simon Glass <sjg@chromium.org> Commit-Ready: Randall Spangler <rspangler@chromium.org> Reviewed-by: Randall Spangler <rspangler@chromium.org>
* Fix alignment of HWID on firmware screens and bitmap viewer.Dave Parker2012-08-157-5/+12
| | | | | | | | | | | | | | BUG=chrome-os-partner:12701 TEST=Disable the 'clean' step in the Makefile and run 'make' in newbitmaps directory. Use the bitmap_viewer to verify the HWID is correctly aligned when compared with the "Model" text. Change-Id: Icd3977f50461492a0999059ccd4982d16a373dce Reviewed-on: https://gerrit.chromium.org/gerrit/30453 Reviewed-by: Hung-Te Lin <hungte@chromium.org> Commit-Ready: Dave Parker <dparker@chromium.org> Tested-by: Dave Parker <dparker@chromium.org>
* Prevent color dithering of firmware bitmapsDave Parker2012-08-151-1/+2
| | | | | | | | | | | | | BUG=None TEST=Run 'make' in newbitmaps dir with "clean" removed from the default step in the Makefile. Use bitmap_viewer to check that the images do not show grainy color dithering. Change-Id: I6dff41338a7e54d090bb2f6dedb982fdaa31e657 Reviewed-on: https://gerrit.chromium.org/gerrit/30308 Reviewed-by: Hung-Te Lin <hungte@chromium.org> Commit-Ready: Dave Parker <dparker@chromium.org> Tested-by: Dave Parker <dparker@chromium.org>
* newbitmaps: Refine text layout & font settings.Hung-Te Lin2012-08-15161-147/+341
| | | | | | | | | | | | BRANCH=none BUG=chrome-os-partner:11078 TEST=make # x86 and arm bitmaps both works. Change-Id: I21382c4f4a829703d9249929579f5007a7db1a9e Reviewed-on: https://gerrit.chromium.org/gerrit/30369 Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Bill Richardson <wfrichar@chromium.org> Commit-Ready: Hung-Te Lin <hungte@chromium.org>
* Add clear TPM owner requestRandall Spangler2012-08-1512-26/+122
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This adds two new flags to crossystem: clear_tpm_owner_request clear_tpm_owner_done The first one requests that the firmware clear the TPM owner on the next boot. When the firmware does this, it will set clear_tpm_owner_request=0, and set clear_tpm_owner_done=1. The OS can use the done-flag as a hint that trusted things guarded by the TPM are no longer trustable. BUG=chromium-os:31974 TEST=manual crossystem // both flags initially 0 crossystem clear_tpm_owner_request=1 crossystem clear_tpm_owner_done=1 // request=1, done=0; done can be cleared but not set by crossystem reboot tpmc getownership // owned=no crossystem // request=0, done=1 crossystem clear_tpm_owner_done=0 crossystem // both flags 0 again Signed-off-by: Randall Spangler <rspangler@chromium.org> Change-Id: I49f83f3c39c3efc3945116c51a241d255c2e42cd Reviewed-on: https://gerrit.chromium.org/gerrit/25646
* twostop: Skip kernel verification when built for U-Boot sandboxTaylor Hutt2012-08-151-0/+17
| | | | | | | | | | | | | | | | | | It's not yet possible to verify the kernel in an Chromium OS image with the Sandbox Version of U-Boot due to the lack of keys. For now, stub out the verification process and behave as if everything is ok: Sandbox U-Boot is only interested in the selected kernel and boot mode at this point. BUG=chromium-os:32603 TEST=With this change, it's possible to get valid answers from vboot_twostop command with Sanbox U-Boot. Change-Id: I3b1142889657315675eacd3a1d1448aeee7ccb62 Signed-off-by: Taylor Hutt <thutt@chromium.org> Reviewed-on: https://gerrit.chromium.org/gerrit/30256 Reviewed-by: Simon Glass <sjg@chromium.org> Reviewed-by: Randall Spangler <rspangler@chromium.org>
* Get kernel size/load address from vboot headersVadim Bendebury2012-08-142-8/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Presently kernel load address and buffer size are programmed in the u-boot device tree. There is no reason for this: the address and size are part of the vboot encapsulation headers. Duplicating this information hardcoded in the device tree does not bring any benefit and is in fact harmful, as it is easy to get out of sync. A better way of doing things is to derive kernel load address and size from the appropriate vboot header. ARM people object to this, as they want the very same kernel blob operate on devices with DRAM mapped to different address ranges. The suggested solution is to exclude the kernel memory section from the device tree on the platforms where the load address could be safely taken from the vboot header. In this case u-boot will pass address of zero to vboot, which will know to derive the address/size from the appropriate header. vboot then rewrites fields of the u-boot supplied structure with actual address and size of the kernel blob. There is no sanity check yet, as it is presumed that there is enough memory to load any kernel and u-boot does not use the space above 0x100000 for at least 16 megabytes (the kernel partition size). On x86 platform the check could be verify that the top of the kernel space is well below the stack. BUG=chrome-os-partner:11994 TEST=manual . with the appropriate u-boot change run a Link target through a FAFT cycle, observe it succeed. Change-Id: I3c2c2cefb1e31d16ac497a01894bf32638479ed7 Signed-off-by: Vadim Bendebury <vbendeb@chromium.org> Reviewed-on: https://gerrit.chromium.org/gerrit/29038 Reviewed-by: Kees Cook <keescook@chromium.org> Reviewed-by: Doug Anderson <dianders@chromium.org> Reviewed-by: Bill Richardson <wfrichar@chromium.org> Reviewed-by: Randall Spangler <rspangler@chromium.org> Reviewed-by: Simon Glass <sjg@chromium.org> Commit-Ready: Bill Richardson <wfrichar@chromium.org>
* mocked_tpm: Provide definition of kBootStateSHA1DigestsTaylor Hutt2012-08-141-0/+50
| | | | | | | | | | | | | | Add a definition of kBootStateSHA1Digests[]. Without this, it is not possible to build the Sanbox version of U-Boot. BUG=chromium-os:32603 TEST=Allows vboot to link when using mocked TPM with U-Boot Sandbox Change-Id: Ie84f4ba3f1c266ed8063fbf6aea0093dd21f638b Signed-off-by: Taylor Hutt <thutt@chromium.org> Reviewed-on: https://gerrit.chromium.org/gerrit/30200 Reviewed-by: Randall Spangler <rspangler@chromium.org> Reviewed-by: Simon Glass <sjg@chromium.org> Reviewed-by: Kees Cook <keescook@chromium.org>
* Scale bmp files correctly for x86 when generating bmpblocks.Dave Parker2012-08-131-1/+1
| | | | | | | | | | | | | BUG=None TEST=Run 'make' in newbitmaps directory but remove the "clean" step in the Makefile. Use the bmp_viewer utility to verify all graphic elements are scaled. Change-Id: Ifd62c2ba3a6c354c4de7d9fd052d76de36842fb6 Reviewed-on: https://gerrit.chromium.org/gerrit/30126 Reviewed-by: Hung-Te Lin <hungte@chromium.org> Commit-Ready: Dave Parker <dparker@chromium.org> Tested-by: Dave Parker <dparker@chromium.org>
* newbitmaps: Add ToNorm confirm screen resource.Hung-Te Lin2012-08-1354-190/+124
| | | | | | | | | | | | | | | According to new flow, we need "confirm" screens for TONORM. Also simplified default_source folder, with better hints and using PNG image source. image/assets/* are files from issue page. BUG=chrome-os-partner:11078 TEST=make # x86 and arm bitmaps both works. Change-Id: I3701d6ed5a944305e12a01c1841a197d3e18a8cd Reviewed-on: https://gerrit.chromium.org/gerrit/29983 Reviewed-by: Bill Richardson <wfrichar@chromium.org> Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org>
* firmware: Add TONORM_CONFIRM screen.Hung-Te Lin2012-08-133-0/+6
| | | | | | | | | | | | | | We need to alert user his change has been accepted for 5 seconds. BUG=chrome-os-partner:11078 TEST=emerge-daisy vboot_reference-firmware vboot_reference chromeos-u-boot chromeos-boogimage Change-Id: I6a3b13e7543479fbd6543d759093ecf501fb1d04 Reviewed-on: https://gerrit.chromium.org/gerrit/29982 Reviewed-by: Bill Richardson <wfrichar@chromium.org> Reviewed-by: Randall Spangler <rspangler@chromium.org> Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org>
* Add in Kiev FW keys to vbutil_what_keysBernie Thompson2012-08-101-0/+6
| | | | | | | | | | | BUG=chrome-os-partner:12544 TEST=Manual, verify vbutil_what_keys detects properly on Kiev. Change-Id: I4115b80e56784bbd5177e142a936ce52132fcf7f Reviewed-on: https://gerrit.chromium.org/gerrit/29944 Reviewed-by: Dave Parker <dparker@chromium.org> Commit-Ready: Bernie Thompson <bhthompson@chromium.org> Tested-by: Bernie Thompson <bhthompson@chromium.org>
* newbitmaps: Refine font and text generation.Hung-Te Lin2012-08-1018-1182/+192
| | | | | | | | | | | | | | | | | | The bmpblk build scripts used to rely on lots of pre-generated resources, and the HWID font data was fixed to x86 special size & scaling parameters. Since the screens now rely on more platform dependent parameters, this CL refined whole flow so fonts are now generated and processed (ex, re-scale) in the same way as other text messages. BUG=chrome-os-partner:11078 TEST=make # x86 and arm bitmaps both works. Change-Id: I59a4fb31718ef052c6b54cd4642f4fc487893f2b Reviewed-on: https://gerrit.chromium.org/gerrit/29873 Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Bill Richardson <wfrichar@chromium.org> Commit-Ready: Hung-Te Lin <hungte@chromium.org>
* newbitmaps: Always generate bitmaps in 8bpp mode.Hung-Te Lin2012-08-101-7/+29
| | | | | | | | | | | | | | | ImageMagick may produce 1bpp mode for background if the image is modified (ex, x86 output). We need to ensure the output to be 8bpp mode for firmware to render images correctly. BUG=chrome-os-partner:11078 TEST=make x86 # all images are in 8bpp mode. Change-Id: Ia6e4fbc5e7580ebbb51e1067bcf554ee06f1fbc5 Reviewed-on: https://gerrit.chromium.org/gerrit/29868 Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Bill Richardson <wfrichar@chromium.org> Commit-Ready: Hung-Te Lin <hungte@chromium.org>
* Translated text for "v2" firmware recovery screens.Dave Parker2012-08-09758-411/+1180
| | | | | | | | | | | BUG=chrome-os-partner:11078 TEST=run make in newbitmaps directory to build a new bmpblock. Change-Id: I97683c95c7c0881ce17617ccab4eb674a06704de Reviewed-on: https://gerrit.chromium.org/gerrit/29866 Reviewed-by: Hung-Te Lin <hungte@chromium.org> Commit-Ready: Dave Parker <dparker@chromium.org> Tested-by: Dave Parker <dparker@chromium.org>
* newbitmaps: Add TODEV, TONORM, and UPDATE(WAIT) screens.Hung-Te Lin2012-08-0943-6/+147
| | | | | | | | | | | | | | | An initial draft of missing screens, with only English messages (*.txt in localized folders are now all English - will update them once translation is ready). BUG=chrome-os-partner:11078 TEST=make; bitmap_viewer DEFAULT.yaml # see basic screen. Change-Id: I3209e18bf604030cf8e92d264781add33aab84fe Reviewed-on: https://gerrit.chromium.org/gerrit/29765 Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Bill Richardson <wfrichar@chromium.org> Commit-Ready: Hung-Te Lin <hungte@chromium.org>
* bmplk_utility: Libraries should be in end of build command.Hung-Te Lin2012-08-091-1/+1
| | | | | | | | | | | | | | Libraries (-llzma, -lyaml) should be in end of dependency list, otherwise linking in static mode (-static) would fail. BUG=none TEST=emerge vboot_reference Change-Id: Idd072443d042edfb214f5a958abd064bc18573ed Reviewed-on: https://gerrit.chromium.org/gerrit/29738 Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Tom Wai-Hong Tam <waihong@chromium.org> Commit-Ready: Hung-Te Lin <hungte@chromium.org>
* newbitmaps: Remove Alex files and refer to specific branch.Hung-Te Lin2012-08-09226-3003/+5
| | | | | | | | | | | | | | | | | Alex bitmaps cannot be generated by latest tools anymore, so let's remove the resource files and refer to the correct place that contains everything you need to generate a new Alex bitmap. (Also see https://gerrit-int.chromium.org/#/c/23243/ for more information) BUG=none TEST=none, simply delete files. Change-Id: I170071892df04ad1cf8304da506f2639a8f39b8b Reviewed-on: https://gerrit.chromium.org/gerrit/29743 Reviewed-by: Bill Richardson <wfrichar@chromium.org> Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org>
* Generates x86 and arm firmware bitmap blocks.Hung-Te Lin2012-08-096-84/+115
| | | | | | | | | | | | | | | | | X86 (coreboot) uses 800x600 resolution while ARM systems (uboot) initialze LCD as its maximum size, so we must refine the bmpblk build scripts to generate output with different scaling parameters. BUG=chrome-os-partner:11078 TEST=make # got ARM bmpblock and verified to work on daisy. Change-Id: Ib9e9a0dc3b6695cef451772391f207a5b57977df Reviewed-on: https://gerrit.chromium.org/gerrit/29606 Reviewed-by: Dave Parker <dparker@chromium.org> Reviewed-by: Bill Richardson <wfrichar@chromium.org> Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Tom Wai-Hong Tam <waihong@chromium.org>
* Generate localized messages in PNG format.Hung-Te Lin2012-08-093-56/+32
| | | | | | | | | | | | | | | To support rendering messages in multiple resolution profiles, we need to keep the images in its original format. BUG=chrome-os-partner:11078 TEST=./text_to_png # images were converted correctly. Change-Id: I6e13331eddfa4c40b17b67b5cf56b5a0284e3b34 Reviewed-on: https://gerrit.chromium.org/gerrit/29605 Reviewed-by: Dave Parker <dparker@chromium.org> Reviewed-by: Bill Richardson <wfrichar@chromium.org> Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org>