summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Add crossystem loc_idx, from ToT to R12 factory branch.0.12.369.BHung-Te Lin2011-05-262-1/+23
| | | | | | | | | | | | | | | | | | Cherry-Picked URL: http://codereview.chromium.org/6826057 http://codereview.chromium.org/6826014 BUG=chromium-os:14069 TEST=manual crossystem loc_idx=3 crossystem loc_idx # prints 3 crossystem loc_idx=0 crossystem loc_idx # prints 0 Change-Id: I185b6d45f4c735754553b2a065ce842641741504 Reviewed-on: http://gerrit.chromium.org/gerrit/1618 Reviewed-by: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org>
* Add crossystem arch (merge from ToT to R12 factory branch_Randall Spangler2011-05-0610-604/+960
| | | | | | | | | | | | | | | | | | | | | | This CL is a cherry pick of: Add dummy crossystem_arch implementation for amd64 (host) Change-Id: Ia87cdd9551af1d592ece641c2abcc02db73869e1 Add default arch to fix compiling outside emake Change-Id: I225c2ee7e703aad961c50ec8988ed2466886f266 Review URL: http://codereview.chromium.org/6820018 Add crossystem arch (reports x86 or arm, depending on platform) Change-Id: I857ead5b108d42195145cdbc5cdafa817f3416b4 Review URL: http://codereview.chromium.org/6813054 BUG=none # porting since latest factory tools need to use "crossystem arch" TEST=crossystem arch # see x86 Change-Id: I5049fb7bf88f1cb0cb36ff85813e5a79d2d85d56 Reviewed-on: http://gerrit.chromium.org/gerrit/425 Reviewed-by: Randall Spangler <rspangler@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org>
* Fail verification if the rootfs hash is empty.Gaurav Shah2011-04-051-0/+5
| | | | | | | | | | | This should let the signer catch errors where there are errors parsing verity output. And failing verification if rootfs hash verification is turned off for whatever reason. Change-Id: I1e3f239a5b6afab31accdd8f0a737b8685530e8d BUG=chrome-os-partner:3093, chrome-os-partner:3104 TEST=manually on a badly signed image (verification fails now) Review URL: http://codereview.chromium.org/6720043
* Fix vboot_reference-firmware linking errorGaurav Shah2011-04-042-0/+2
| | | | | | | | | Change-Id: I54052f6d15b9afa52944bf04e09924a3ddb8922e BUG=none TEST=emerge-arm-generic vboot_reference-firmware && emerge-arm-generic chromeos-u-boot-next (running) Review URL: http://codereview.chromium.org/6792031
* Make SHA256 and SHA512 handle >UINT32_MAX data correctly (now with fix for ↵Gaurav Shah2011-04-043-22/+54
| | | | | | | | | | | | | | | | ARM compilation) Change-Id: Iaa0c5675c07e9b54b2a389c53ed503e7a21ba731 BUG=chrome-os-partner:2912 TEST= 1) emerge-x86-generic vboot_reference 2) emerge-arm-generic vboot_reference 3) emerge-arm-generic vboot_reference-firmware 4) emerge-tegra2 vboot_reference-firmware 5) make && make runtests Review URL: http://codereview.chromium.org/6760017
* Fix preamble range checks0.12.362.BRandall Spangler2011-04-011-6/+6
| | | | | | | | | | Change-Id: I0571f4524703566b8840e2b264d868c404f87c80 R=gauravsh@chromium.org,wfrichar@chromium.org BUG=chrome-os-partner:2910 TEST=make && make runtests Review URL: http://codereview.chromium.org/6759075
* Fix duplicate -I's harmless under gcc but which break bunny-gccJim Hebert2011-03-311-17/+17
| | | | | | | | | | | | (This helps us do some instrumented fuzz testing with "bunny the fuzzer".) Change-Id: I4d06129d577115b9dd5cd9bec2c2e1b526490456 BUG=chromium-os:13690 TEST="CC=/usr/local/google/bunny-0.93/bunny-gcc make -k" now builds vbutil_*, and regular gcc/make did not break. STATUS=Fixed Review URL: http://codereview.chromium.org/6783006
* vboot_reference: remove trailing newline/space for make_dev_ssdHung-Te Lin2011-03-301-1/+1
| | | | | | | | | | | | | | To make the output of kernel_config from make_dev_ssd more close to the original images, we should eliminate the trailing newline/space. BUG=chromium-os:13516 TEST=make_dev_ssd.sh # succcess Change-Id: I17f030f8815dea22b04058456d98db6911888ef6 R=rspangler@chromium.org,clchiou@chromium.org Review URL: http://codereview.chromium.org/6735009
* Revert "Make SHA256_update and SHA512_update if the passed in length is ↵David James2011-03-292-50/+22
| | | | | | | | | | | | | | | | greater than UINT32_MAX" Needed to unbreak the tegra build. This reverts commit a01a62bf85e01e1687ea5132286628b2a760f6d8. R=gauravsh@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6731068 Change-Id: I096fde817c0e1cfa0c34f4f1dab986c7844c0714
* Make SHA256_update and SHA512_update if the passed in length is greater than ↵Gaurav Shah2011-03-292-22/+50
| | | | | | | | | | | UINT32_MAX BUG=chrome-os-partner:2912 TEST=make && make runtests Change-Id: If415a023d47b78ae2fc5af0b2fe5e410ef37086d Review URL: http://codereview.chromium.org/6750016
* Add additional checks for size greater than header size.Randall Spangler2011-03-251-0/+12
| | | | | | | | | | Change-Id: Iea64e3df795d1f9299117cbd161b203295211629 R=wfrichar@chromium.org,gauravsh@chromium.org BUG=chrome-os-partner:2908 TEST=make && make runtests Review URL: http://codereview.chromium.org/6745027
* Fix not checking hashed data sizeRandall Spangler2011-03-251-0/+7
| | | | | | | | | | R=wfrichar@chromium.org,gauravsh@chromium.org BUG=chrome-os-partner:2909 TEST=make && make runtests Review URL: http://codereview.chromium.org/6748009 Change-Id: I3251aa6e6dd62ff4351fdf33ca9182b19a29cbbf
* Use uint64_t and avoid down casting as much as possible.Gaurav Shah2011-03-254-16/+16
| | | | | | | | | Change-Id: I231d1b3a059907c3806feced7e1b8f1c06575ba5 BUG=chromeos-partner:2912 TEST=make clean all && make runtests Review URL: http://codereview.chromium.org/6733018
* vboot_reference: fix make_dev_firmware failureHung-Te Lin2011-03-241-0/+4
| | | | | | | | | | | | | | | The script to resign firmware (resign_firmwarefd.sh) has changed its syntax, due to the new "dev firmware" design. BUG=chromium-os:13375 TEST=./make_dev_firmware.sh # seeing the "changed firmware to Developer Keys" message. Change-Id: Id553f3ce1641f13e732bd5e208cb2fb00ca9c078 R=rspangler@chromium.org,gauravsh@chromium.org Review URL: http://codereview.chromium.org/6727019
* Revert "Revert "Add --kloadaddr option to utilities""Che-Liang Chiou2011-03-222-25/+94
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit bc7a84d9a1bef3fb8c1e2709033f6c9777599fe9. It was a false alarm that --kloadaddr causes chromeos-install on a x86 targets to fail. The error of chromeos-install cannot be reproduced, and judging by the reported error message, the error should not be attributed to --kloadaddr, which has no effect in x86 targets. So --kloadaddr is restored. Verification process are below: (Verify that --kloadaddr option is restored) $ dump_kernel_config -h Expected argument after options dump_kernel_config - Prints the kernel command line Usage: dump_kernel_config [--kloadaddr <ADDRESS>] <image/blockdevice> (Setup a x86 target with kernel-next profile) $ rm -rf /build/${X86_TARGET} $ ./setup_board --board=${X86_TARGET} --profile=kernel-next $ ./build_packages --board=${X86_TARGET} $ ./build_image --board=${X86_TARGET} (Run chromeos-install on target machine successfully) $ /usr/sbin/chromeos-install (Change directory to where image sits) $ cd ~/trunk/src/build/images/${X86_TARGET}/latest (Unpack Chromium OS image) $ ./unpack_partitions.sh chromiumos_image.bin (Verify that dump_kernel_config runs successfully) $ dump_kernel_config part_2 console=tty2 init=/sbin/init add_efi_memmap boot=local noresume noswap i915.modeset=1 cros_secure kern_guid=%U tpm_tis.force=1 tpm_tis.interrupts=0 nmi_watchdog=panic,lapic i8042.nomux=1 root=/dev/dm-0 quiet loglevel=1 rootwait ro dm_verity.error_behavior=3 dm_verity.max_bios=-1 dm_verity.dev_wait=1 dm="vroot none ro,0 1740800 verity %U+1 %U+1 1740800 1 sha1 c357e07395150770ce25ebc0e3c6d15941675c58" (Run load_kernel_test) $ load_kernel_test -b 2 chromiumos_image.bin /usr/share/vboot/devkeys/recovery_key.vbpubk Read 2088 bytes of key from /usr/share/vboot/devkeys/recovery_key.vbpubk bootflags = 6 Reading from image: chromiumos_image.bin Ending LBA: 3989538 Read(1, 1) Read(2, 32) Read(3989506, 32) Read(3989538, 1) Read(4096, 128) Read(4224, 6472) LoadKernel() returned 0 Partition number: 2 Bootloader address: 4345856 Bootloader size: 16384 Partition guid: b2a453b0-a64a-5c4d-a957-1388cea384a5 R=marcheu@chromium.org,sjg@chromium.org BUG=none TEST=see verification process above Review URL: http://codereview.chromium.org/6685079 Change-Id: I932753197550b853495f2c03e8880ad71df765a7
* Add a blank screen value into screen index.Tom Wai-Hong Tam2011-03-221-1/+2
| | | | | | | | | | | | | A convenient value that firmware to identity the blank screen. TEST=emerge-tegra2_seaboard vboot_reference-firmware successfully BUG=chromium-os:1305 Change-Id: Ib38f0c5ba571e95c966ae58c81d22487e416e666 R=clchious@chromium.org Review URL: http://codereview.chromium.org/6712029
* Add error checking for poorly-formed crossystem argsRandall Spangler2011-03-211-5/+19
| | | | | | | | | | | | | | | | | | | | | | | | R=petkov@chromium.org BUG=chromium-os:13322 TEST=manual The following command lines should cause crossystem to fail with a warning about a poorly formed parameter: crossystem '' crossystem '=cros_debug' crossystem '?cros_debug' The following command line should warn that you can't use both = and ?: crossystem cros_debug?=0 (that is, it warns, not just compares with '=0') The following should print 'UNEQUAL' crossystem cros_debug? || echo UNEQUAL (because it's comparing cros_debug with an empty string) Review URL: http://codereview.chromium.org/6718012 Change-Id: I2e2851515f4914b16aba64065600fb92d9ad1a63
* Print LoadKernel() debug data from VbSharedDataRandall Spangler2011-03-213-15/+139
| | | | | | | | | | Change-Id: I60cf9c4dd07e83b1ed1a5bac8a3ce8c2a54df45b R=reinauer@chromium.org BUG=chrome-os-partner:2748 TEST=manually check output of 'crossystem vdat_lkdebug' Review URL: http://codereview.chromium.org/6685097
* Use VbSharedData instead of VbNvStorage for fwb_tries and kernkey_vfyRandall Spangler2011-03-186-45/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I5ed3509a9d4e578cd2e98f493dab59bc2fbd5827 R=dlaurie@chromium.org BUG=chrome-os-partner:2748 TEST=manual crossystem fwb_tries=3 (reboot) crossystem tried_fwb (should print 1) crossystem fwb_tries=0 (reboot) crossystem tried_fwb (should print 0) In dev mode... Boot a kernel signed with the same key as in the firmware crossystem kernkey_vfy (should print sig) Boot a kernel signed with a different key than the firmware crossystem kernkey_vfy (should print hash) Review URL: http://codereview.chromium.org/6711045
* Add VbSharedData debug output to LoadKernel()Randall Spangler2011-03-182-30/+220
| | | | | | | | | | Change-Id: Id2837c83877520067e46e2434460349ef001b7b9 R=dlaurie@chromium.org BUG=chrome-os-partner:2748 TEST=nmake uefi64; boot in normal and recovery modes Review URL: http://codereview.chromium.org/6688035
* Add TPM version checkingRandall Spangler2011-03-178-35/+76
| | | | | | | | | | | | | Change-Id: Ic32b7bcf0bc5501e21dc84e79419a256d9b0d095 R=semenzato@chromium.org,reinauer@chromium.org BUG=chrome-os-partner:2832 TEST=manual crossystem tpm_fwver tpm_kernver On a debug system, this will return 0x00010001 0x00010001 Review URL: http://codereview.chromium.org/6685075
* Add VbSharedData field parsingRandall Spangler2011-03-178-96/+225
| | | | | | | | | | | | | | | | | | | | | R=reinauer@chromium.org BUG=chrome-os-partner:2578 TEST=manual crossystem vdat_timers should show 'LFS=0,0 LF=number1,number2 LK=number3,number4' where number1 < number2 < number3 < number4 crossystem vdat_lfdebug run from a dev mode console, should show 'check=12,0 index=0x00 tpmver=(hex number) lowestver=(hex number)' crossystem vdat_flags run from a dev mode console, flags should be 0x04. Review URL: http://codereview.chromium.org/6685068 Change-Id: Id7b958ae300d10cdcdc1b17a1bb17b7e5069166f
* Perform a full self test before one-time initialization.Luigi Semenzato2011-03-171-0/+9
| | | | | | | | | Change-Id: I2f5232d5133c0725ec21f885a4632e980062be8f BUG=chrome-os-partner: 1826 TEST=none Review URL: http://codereview.chromium.org/6688004
* Added timing data to VbSharedData.Randall Spangler2011-03-165-9/+53
| | | | | | | | | Change-Id: I8d52765227fd3355431bebc77dfbe0106c889eca BUG=chrome-os-partner:2748 TEST=compiles; will be porting to H2C next Review URL: http://codereview.chromium.org/6672068
* Move ContinueSelfTest to a later point to save time.Luigi Semenzato2011-03-163-11/+78
| | | | | | | | | Change-Id: I96b413438359e11315101d408033066e6f0a0981 BUG=chrome-os-partner: 1826 TEST=none Review URL: http://codereview.chromium.org/6667051
* Bump tlcl_structures.h.Luigi Semenzato2011-03-161-0/+5
| | | | | | | | | Change-Id: I9346c02244246b82cc6fe7c60090173ff650efc1 BUG=chromium-os:433 TEST=none Review URL: http://codereview.chromium.org/6667050
* Added TPM_SaveState command.Luigi Semenzato2011-03-164-0/+19
| | | | | | | | | Change-Id: If7b6ef3cba733b74ba13db0871e6ac554d0d84ef BUG=chromium-os:433 TEST=none Review URL: http://codereview.chromium.org/6696043
* Fix compiler errors on MSVCRandall Spangler2011-03-163-7/+7
| | | | | | | | | | Change-Id: I47fd6d0be5542e5f540a34410b3f694ae0f67fd9 R=gauravsh@chromium.org BUG=none TEST=make && make runtests Review URL: http://codereview.chromium.org/6676039
* Allow overlap between "pure" fmap areasChe-Liang Chiou2011-03-161-2/+9
| | | | | | | | | | | | | | Firmware specification has several sections that are overlapped. This CL allows limited overlapping that only "pure" fmap areas can be overlapped. See also CL=6694022,6696016 for its application. BUG=chrome-os-partner:2333 TEST=emerge vboot_reference && emerge-${ARM_BOARD} chromeos-bios Review URL: http://codereview.chromium.org/6677040 Change-Id: I9ca34caec3665136b1babd08cd074cf733cf0d51
* vboot_reference/dev_debug_vboot: use new flashrom syntaxHung-Te Lin2011-03-161-2/+2
| | | | | | | | | | | | | | We need to also assign the target in dev_debug_vboot. BUG=chromium-os:11339 TEST=flashrom -p internal:bus=lpc dev_debug_vboot # still seeing success Change-Id: I33cfed77dba5afb668f6d9036ecc077e3bcb19d0 R=wfrichar@chromium.org Review URL: http://codereview.chromium.org/6698022
* Fix LoadKernel() not returning LOAD_KERNEL_RECOVERYRandall Spangler2011-03-151-4/+6
| | | | | | | | | | | | | | | | | Change-Id: Ib147be7442b93ef429a9796e2b76bee27347e0b3 R=adlr@chromium.org BUG=13150 TEST=manual On a current firmware (0052G1+), use 'crossystem vbtest_errfunc=3 vbtest_errno=3' to force a reboot to recovery mode. Then use 'crossystem recovery_reason' to check the recovery reason. It should be 71. It's not. (You'll get a range of other error reasons due to a different firmware bug.) Review URL: http://codereview.chromium.org/6670040
* Add wrapper script for easy signing of firmwareGaurav Shah2011-03-151-0/+47
| | | | | | | | | | | Thought I might as well put this is in the repo since I use it very often. Change-Id: Iecbb2340dce1522b15aab8eefb3b2c346cb7c24f BUG=none TEST=manually signed an image. Review URL: http://codereview.chromium.org/6698014
* Update PCR state with the state of the firmware keyblock flags too.Gaurav Shah2011-03-158-38/+190
| | | | | | | | | | | | I re-factored the extend call into its own module, since it doesn't necessarily need to be couple with rollbackfirmwaresetup. BUG=chrome-os-partner:2372 TEST=Tried emerge-x86-generic and emerge-arm-generic vboot_reference. Change-Id: I0d3115b10b686133e63e304570325ebdbd50ae3a Review URL: http://codereview.chromium.org/6696006
* only update tpm if version if not default valueStefan Reinauer2011-03-151-2/+9
| | | | | | | | | Change-Id: I697de80aa2f0454164cd3651e5a53d06e60a837e BUG=2782 TEST=in progress Review URL: http://codereview.chromium.org/6677067
* Run TPM timing test to completion instead of stopping at the first error.Luigi Semenzato2011-03-151-5/+13
| | | | | | | | | Change-Id: Iae764bfeb2c766abb550f338db3d35d1d7eebf1d BUG=433 TEST=compiled and ran. (QA NOTE: no testing required) Review URL: http://codereview.chromium.org/6462013
* LoadFirmware() and LoadKernel() handling for test errorsRandall Spangler2011-03-153-0/+57
| | | | | | | | | | Change-Id: Icecfcab8f5cc30e80da7a2d77a1b1729f5094fee R=wfrichar@chromium.org BUG=13107 TEST=make && make runtests Review URL: http://codereview.chromium.org/6673048
* Revert "Add --kloadaddr option to utilities"Stéphane Marchesin2011-03-152-94/+25
| | | | | | | | | | | | This reverts commit 1a0975f5f477abe7425e2b7ade655d73138e5c64. This fixes chromeos-install on x86-mario with a kernel-next profile. BUG=None TEST=Build an x86-mario image with kernel-next, check that /usr/sbin/chromeos-install works. Review URL: http://codereview.chromium.org/6677033 Change-Id: I67fc5c0f70a05a4d662952105542edf454da8022
* Add VB test error func/numRandall Spangler2011-03-155-6/+52
| | | | | | | | | Change-Id: Ibe253963f0424935554fe91f166ef5040a723c6f BUG=13107 TEST=make && make runtests Review URL: http://codereview.chromium.org/6698032
* Add function for VDAT processing.Vadim Bendebury2011-03-152-0/+135
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This CL is a user space counterpart of http://codereview.chromium.org/6690023, which provided the ability to retrieve buffers through chromeos_acpi driver. The buffer contents is communicated as a multi line string with each buffer byte represented as a two symbol hex number. `crosstool', on the other has to map the buffer contents into a certain binary structure. This CL add conversion of the multiline string into a binary buffer and also adds a temp. routine to dump the buffer contents on the screen when `crosstool' is invoked. Change-Id: I8dd3eb935332f9bc8769c71de0db302365f12d70 BUG=chromium-os:13069, chromium-os:13091 TEST=manual - Install the new image on a target with firmware providing the VDAT ACPI method. - Run crosstool and watch for the last line: vdat = 11 22 33 44 ff 1f 1c 40 ff 57 74 41 ff ff ff ff # Raw VDAT contents. localhost tmp # Review URL: http://codereview.chromium.org/6695012
* Add --leave_firmware_alone flag for BIOS testing purposes.Bill Richardson2011-03-141-0/+8
| | | | | | | | | BUG=chromium-os:13100 TEST=none (BIOS team will test by using it) Change-Id: Ifedeac1a0d13d36a069531bfaba4bdb7b3457406 Review URL: http://codereview.chromium.org/6696013
* Do not modify the input image while signing.Gaurav Shah2011-03-141-33/+61
| | | | | | | | | Change-Id: I17e1a5abcc4f2fab970a587b338594a7d51ecb2e BUG=chromium-os:13026 TEST=manually tested all signing modes(usb, ssd, recovery, install), input image was not modified in each case. Review URL: http://codereview.chromium.org/6686004
* Don't modify fv old-style bitmapsNick Sanders2011-03-111-2/+7
| | | | | | | | | | | * Just make new "bmp" files as necessary BUG=chrome-os-partner:2558 TEST=runs as expected Change-Id: I3046630ea3e3f0a40429bb63a986c6044b83c6a6 Review URL: http://codereview.chromium.org/6623008
* Add check-value support and check /proc/cmdline for cros_nodebugRandall Spangler2011-03-112-6/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I35158810184be03f18d98893e4dd640088384579 BUG=12904 TEST=manual crossystem fwb_tries=1 crossystem fwb_tries?1 && echo YES || echo NO --> YES crossystem fwb_tries?0x01 && echo YES || echo NO --> YES crossystem fwb_tries?0 && echo YES || echo NO --> NO crossystem fwb_tries=0 crossystem fwb_tries?0 && echo YES || echo NO --> YES crossystem fwb_tries?1 && echo YES || echo NO --> NO crossystem fwb_tries?0x01 && echo YES || echo NO --> NO crossystem ecfw_act --> RW (if it's not, change RW to RO in the tests below) crossystem ecfw_act?RW && echo YES || echo NO --> YES crossystem ecfw_act?BOB && echo YES || echo NO --> NO For the following tests, boot Alex with dev switch on and fwb_tries=1 Expected output of `crossystem mainfw_type mainfw_act cros_debug` under each of the following scenarios: * Neither "cros_debug" nor" cros_nodebug" in kernel command line: normal B 1 * Kernel command line changed to include "cros_nodebug": normal B 0 * Kernel command line changed to include "cros_nodebugg": normal B 1 * Kernel command line changed to include "ccros_nodebug": normal B 1 Review URL: http://codereview.chromium.org/6665005
* Add --kloadaddr option to utilitiesChe-Liang Chiou2011-03-112-25/+94
| | | | | | | | | | | | | | | Kernel body load address was hard-coded to CROS_32BIT_ENTRY_ADDR, which could be an invalid/unavailable memory location on other platforms. This CL adds an option for setting the load address, and it is default to CROS_32BIT_ENTRY_ADDR to maintain backward-compatibility. BUG=chromium-os:1304 TEST=emerge vboot_reference successfully Review URL: http://codereview.chromium.org/6651022 Change-Id: I158cfce10ac59bd019bca41cb061039d0085d5cc
* Add cros_debug option to crossystemRandall Spangler2011-03-102-4/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: Ie62364a87f7f144ee647054d2a9ef83522cdbe7d BUG=12904 TEST=manual Expected output of `crossystem mainfw_type cros_debug` under each of the following scenarios: * Boot Alex with dev switch off: normal 0 * Boot Alex with dev switch on (and dev firmware): developer 1 * Boot Alex with dev switch on (and normal firmware): normal 1 * Boot Alex with recovery firmware: recovery 0 * Boot Alex with dev switch off, then turn the dev switch on after booting: normal 0 * Boot Cr-48 with dev switch off: normal 0 * Boot Cr-48 with dev switch on: developer 1 * Boot Cr-48 with recovery firmware: recovery 0 * Boot Alex with dev switch off and kernel command line changed to include "cros_debug": normal 1 * Boot Alex with dev switch off and kernel command line changed to include "cros_debugg": normal 0 * Boot Alex with dev switch off and kernel command line changed to include "ccros_debug": normal 0 * Boot H2O BIOS with kernel command line changed to include "cros_debug": nonchrome 1 * Boot H2O BIOS with kernel command line changed to include "cros_debugg": nonchrome 0 * Boot H2O BIOS with kernel command line changed to include "ccros_debug": nonchrome 0 Review URL: http://codereview.chromium.org/6659021
* This is necessary to pass additional information about whether firmware A or ↵Randall Spangler2011-03-0912-71/+278
| | | | | | | | | | | | | | | | | | | | | | | B is being run. This change also passes the GBB directly into LoadFirmware() and LoadKernel(). Change-Id: I976c11c82c3d665a4feb88226e919f16c2440f60 BUG=chrome-os-partner:1657 TEST=manual - see below make && make runtests Then test verifying a test image in both dev mode (-b1, no key specified) and recovery mode (key specified) build/utility/load_kernel_test -b1 ~/b/USB_images/0.11.224.0-alex/chromiumos_test_image.bin build/utility/load_kernel_test ~/b/USB_images/0.11.224.0-alex/chromiumos_test_image.bin tests/devkeys/recovery_key.vbpubk And make sure the firmware with this change actually boots to USB and SSD. NOTE: u-boot-next needs to change to work with this change. will attempt a follow-up CL with that change Review URL: http://codereview.chromium.org/6626045
* Only advance kernel version when the booted partition has a valid key blockRandall Spangler2011-03-0413-14/+14
| | | | | | | | | | | | | | | | | | | | Change-Id: I879c18cc139f8a02bcaa6eb80437eaf836a5e851 BUG=chrome-os-partner:2597 TEST=manual install pvt-signed image flip dev switch on and boot install dev-signed firmware reboot reboot sudo bash stop tcsd tpmc read 0x1008 0x0d bytes 6-10 should be 1 0 1 0, not FF FF FF FF Review URL: http://codereview.chromium.org/6626020
* Support new flashmap layout in dev_debug_vboot.Bill Richardson2011-03-032-7/+34
| | | | | | | | | | | | | | Make dev_debug_vboot look first for the new section names, then the old ones. Change-Id: I723f022bbbb23257c7c57db9543d7c35f524f95d BUG=chromium-os:12611 TEST=manual Rerun the steps that reproduce the problem as reported in the initial bug report. You should see much more information. Review URL: http://codereview.chromium.org/6621003
* vboot/make_dev_firmware: extract bitmaps from system firmware instead of ↵Hung-Te Lin2011-03-041-6/+40
| | | | | | | | | | | | | | | | | | | prebuilts. make_dev_firmware should trust system firmware blobs instead of using its own prebuilt binaries. BUG=chromium-os:12400 TEST=1. make a build with .49+ BIOS, and create the firmware updater 2. install the new BIOS, turn on developer switch and reboot 3. an ugly "DEV" screen (in .49) is shown on screen 4. run the new make_dev_firmware.sh 5. reboot. seeing the ugly DEV instead of the prebuilt blue screen (verified successfully) Change-Id: If75d2821170649fa869db6a82d879b697f7588e6 Review URL: http://codereview.chromium.org/6614006
* Bitmap generator for components filesNick Sanders2011-03-032-1/+87
| | | | | | | | | BUG=chrome-os-partner:2558 TEST=some files are generated Change-Id: I6a69bce20d626e9a273711db099d7ec5c3b08686 Review URL: http://codereview.chromium.org/6598091