diff options
author | Yu-Ping Wu <yupingso@chromium.org> | 2020-04-10 08:54:05 +0800 |
---|---|---|
committer | Commit Bot <commit-bot@chromium.org> | 2020-04-28 08:11:14 +0000 |
commit | 3aab301473ec0b95f109a245efeadc20c3b7d57d (patch) | |
tree | 326de14736d5f65a5eda2c6bc71771ced121e272 /tests | |
parent | b2dca286baa74b71da70fb59e8a3f94df57269fe (diff) | |
download | vboot-3aab301473ec0b95f109a245efeadc20c3b7d57d.tar.gz |
vboot: Convert reboot-related errors to vboot2-style
Error codes are renamed as follows:
VBERROR_SHUTDOWN_REQUESTED
--> VB2_REQUEST_SHUTDOWN
VBERROR_REBOOT_REQUIRED
--> VB2_REQUEST_REBOOT
VBERROR_EC_REBOOT_TO_SWITCH_RW
--> VB2_REQUEST_REBOOT_EC_SWITCH_RW
VBERROR_EC_REBOOT_TO_RO_REQUIRED
--> VB2_REQUEST_REBOOT_EC_TO_RO
VBERROR_KEEP_LOOPING
--> VB2_REQUEST_UI_CONTINUE
Since these are not really "errors", they're renamed to VB2_REQUEST_*
instead, with larger values to separate from real errors.
The old vboot1-style errors will be removed once the errors are renamed
in coreboot and depthcharge.
BRANCH=none
BUG=b:124141368, chromium:988410
TEST=make runtests
Change-Id: Ide1328f9c0f2803534fb3f1f1ecd16ad8ea36a4e
Signed-off-by: Yu-Ping Wu <yupingso@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2143030
Reviewed-by: Julius Werner <jwerner@chromium.org>
Reviewed-by: Joel Kitching <kitching@chromium.org>
Diffstat (limited to 'tests')
-rw-r--r-- | tests/vb2_auxfw_sync_tests.c | 10 | ||||
-rw-r--r-- | tests/vb2_ec_sync_tests.c | 42 | ||||
-rw-r--r-- | tests/vb2_kernel_tests.c | 4 | ||||
-rw-r--r-- | tests/vboot_api_kernel4_tests.c | 2 | ||||
-rw-r--r-- | tests/vboot_legacy_clamshell_tests.c | 96 | ||||
-rw-r--r-- | tests/vboot_legacy_menu_tests.c | 76 |
6 files changed, 115 insertions, 115 deletions
diff --git a/tests/vb2_auxfw_sync_tests.c b/tests/vb2_auxfw_sync_tests.c index 823dec0b..104455f9 100644 --- a/tests/vb2_auxfw_sync_tests.c +++ b/tests/vb2_auxfw_sync_tests.c @@ -70,7 +70,7 @@ vb2_error_t vb2ex_auxfw_check(enum vb2_auxfw_update_severity *severity) auxfw_update_severity = auxfw_mock_severity; if (*severity == VB_AUX_FW_SLOW_UPDATE) if (!auxfw_mock_display_available) - return VBERROR_REBOOT_REQUIRED; + return VB2_REQUEST_REBOOT; return VB2_SUCCESS; } @@ -103,7 +103,7 @@ static void VbSoftwareSyncTest(void) ResetMocks(); gbb.flags |= VB2_GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC; auxfw_mock_severity = VB_AUX_FW_FAST_UPDATE; - test_auxsync(VBERROR_EC_REBOOT_TO_RO_REQUIRED, 0, + test_auxsync(VB2_REQUEST_REBOOT_EC_TO_RO, 0, "VB2_GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC" " does not disable auxiliary FW update request"); TEST_EQ(auxfw_update_req, 1, " aux fw update requested"); @@ -134,7 +134,7 @@ static void VbSoftwareSyncTest(void) ResetMocks(); auxfw_mock_severity = VB_AUX_FW_FAST_UPDATE; - test_auxsync(VBERROR_EC_REBOOT_TO_RO_REQUIRED, 0, + test_auxsync(VB2_REQUEST_REBOOT_EC_TO_RO, 0, "Fast auxiliary FW update needed"); TEST_EQ(auxfw_update_req, 1, " aux fw update requested"); TEST_EQ(auxfw_protected, 0, " aux fw protected"); @@ -142,12 +142,12 @@ static void VbSoftwareSyncTest(void) ResetMocks(); auxfw_mock_severity = VB_AUX_FW_SLOW_UPDATE; auxfw_mock_display_available = 0; - test_auxsync(VBERROR_REBOOT_REQUIRED, 0, + test_auxsync(VB2_REQUEST_REBOOT, 0, "Slow auxiliary FW update needed - reboot for display"); ResetMocks(); auxfw_mock_severity = VB_AUX_FW_SLOW_UPDATE; - test_auxsync(VBERROR_EC_REBOOT_TO_RO_REQUIRED, 0, + test_auxsync(VB2_REQUEST_REBOOT_EC_TO_RO, 0, "Slow auxiliary FW update needed"); TEST_EQ(auxfw_update_req, 1, " aux fw update requested"); TEST_EQ(auxfw_protected, 0, " aux fw protected"); diff --git a/tests/vb2_ec_sync_tests.c b/tests/vb2_ec_sync_tests.c index ad747e09..25f047d1 100644 --- a/tests/vb2_ec_sync_tests.c +++ b/tests/vb2_ec_sync_tests.c @@ -179,7 +179,7 @@ vb2_error_t vb2ex_ec_update_image(enum vb2_firmware_selection select) return update_retval; if (!mock_display_available) - return VBERROR_REBOOT_REQUIRED; + return VB2_REQUEST_REBOOT; if (select == VB_SELECT_FIRMWARE_READONLY) { ec_ro_updated = 1; @@ -266,7 +266,7 @@ static void VbSoftwareSyncTest(void) /* AP-RO cases */ ResetMocks(); in_rw_retval = VB2_ERROR_MOCK; - test_ssync(VBERROR_EC_REBOOT_TO_RO_REQUIRED, + test_ssync(VB2_REQUEST_REBOOT_EC_TO_RO, VB2_RECOVERY_EC_UNKNOWN_IMAGE, "Unknown EC image"); TEST_EQ(ec_ro_updated, 0, " ec ro updated"); TEST_EQ(ec_rw_updated, 0, " ec rw updated"); @@ -277,7 +277,7 @@ static void VbSoftwareSyncTest(void) /* Calculate hashes */ ResetMocks(); mock_ec_rw_hash_size = 0; - test_ssync(VBERROR_EC_REBOOT_TO_RO_REQUIRED, + test_ssync(VB2_REQUEST_REBOOT_EC_TO_RO, VB2_RECOVERY_EC_HASH_FAILED, "Bad EC hash"); TEST_EQ(ec_ro_updated, 0, " ec ro updated"); TEST_EQ(ec_rw_updated, 0, " ec rw updated"); @@ -287,7 +287,7 @@ static void VbSoftwareSyncTest(void) ResetMocks(); mock_ec_rw_hash_size = 16; - test_ssync(VBERROR_EC_REBOOT_TO_RO_REQUIRED, + test_ssync(VB2_REQUEST_REBOOT_EC_TO_RO, VB2_RECOVERY_EC_HASH_SIZE, "Bad EC hash size"); TEST_EQ(ec_ro_updated, 0, " ec ro updated"); TEST_EQ(ec_rw_updated, 0, " ec rw updated"); @@ -297,7 +297,7 @@ static void VbSoftwareSyncTest(void) ResetMocks(); hexp_size = 0; - test_ssync(VBERROR_EC_REBOOT_TO_RO_REQUIRED, + test_ssync(VB2_REQUEST_REBOOT_EC_TO_RO, VB2_RECOVERY_EC_EXPECTED_HASH, "Bad precalculated hash"); TEST_EQ(ec_ro_updated, 0, " ec ro updated"); TEST_EQ(ec_rw_updated, 0, " ec rw updated"); @@ -307,7 +307,7 @@ static void VbSoftwareSyncTest(void) ResetMocks(); hexp_size = 16; - test_ssync(VBERROR_EC_REBOOT_TO_RO_REQUIRED, + test_ssync(VB2_REQUEST_REBOOT_EC_TO_RO, VB2_RECOVERY_EC_HASH_SIZE, "Hash size mismatch"); TEST_EQ(ec_ro_updated, 0, " ec ro updated"); @@ -319,7 +319,7 @@ static void VbSoftwareSyncTest(void) ResetMocks(); hexp_size = 4; mock_ec_rw_hash_size = 4; - test_ssync(VBERROR_EC_REBOOT_TO_RO_REQUIRED, VB2_RECOVERY_EC_HASH_SIZE, + test_ssync(VB2_REQUEST_REBOOT_EC_TO_RO, VB2_RECOVERY_EC_HASH_SIZE, "Custom hash size secdata_kernel v1"); TEST_EQ(ec_ro_updated, 0, " ec ro updated"); TEST_EQ(ec_rw_updated, 0, " ec rw updated"); @@ -343,7 +343,7 @@ static void VbSoftwareSyncTest(void) ResetMocks(); ec_run_image = 1; mock_ec_rw_hash[0]++; - test_ssync(VBERROR_EC_REBOOT_TO_RO_REQUIRED, + test_ssync(VB2_REQUEST_REBOOT_EC_TO_RO, 0, "Pending update needs reboot"); TEST_EQ(ec_ro_updated, 0, " ec ro updated"); TEST_EQ(ec_rw_updated, 0, " ec rw updated"); @@ -357,7 +357,7 @@ static void VbSoftwareSyncTest(void) vb2_secdata_kernel_set_ec_hash(ctx, hmir); ec_run_image = 1; mock_ec_rw_hash[0] = 43; - test_ssync(VBERROR_EC_REBOOT_TO_RO_REQUIRED, + test_ssync(VB2_REQUEST_REBOOT_EC_TO_RO, 0, "Reboot after synching Hmir"); TEST_EQ(ec_ro_updated, 0, " ec ro updated"); TEST_EQ(ec_rw_updated, 0, " ec rw updated"); @@ -370,7 +370,7 @@ static void VbSoftwareSyncTest(void) ec_run_image = 0; ctx->flags |= VB2_CONTEXT_NO_BOOT; mock_ec_rw_hash[0] = 43; - test_ssync(VBERROR_EC_REBOOT_TO_RO_REQUIRED, + test_ssync(VB2_REQUEST_REBOOT_EC_TO_RO, 0, "Reboot after synching Heff"); TEST_EQ(ec_ro_updated, 0, " ec ro updated"); TEST_EQ(ec_rw_updated, 1, " ec rw updated"); @@ -385,7 +385,7 @@ static void VbSoftwareSyncTest(void) ec_run_image = 0; ctx->flags |= VB2_CONTEXT_NO_BOOT; mock_ec_rw_hash[0] = 43; - test_ssync(VBERROR_EC_REBOOT_TO_RO_REQUIRED, + test_ssync(VB2_REQUEST_REBOOT_EC_TO_RO, 0, "Reboot after synching Hmir and Heff"); TEST_EQ(ec_ro_updated, 0, " ec ro updated"); TEST_EQ(ec_rw_updated, 1, " ec rw updated"); @@ -399,7 +399,7 @@ static void VbSoftwareSyncTest(void) vb2_secdata_kernel_set_ec_hash(ctx, hmir); ec_run_image = 0; ctx->flags |= VB2_CONTEXT_NO_BOOT; - test_ssync(VBERROR_EC_REBOOT_TO_RO_REQUIRED, + test_ssync(VB2_REQUEST_REBOOT_EC_TO_RO, 0, "Reboot after synching Hmir"); TEST_EQ(ec_ro_updated, 0, " ec ro updated"); TEST_EQ(ec_rw_updated, 0, " ec rw updated"); @@ -454,7 +454,7 @@ static void VbSoftwareSyncTest(void) ResetMocks(); mock_ec_rw_hash[0]++; update_hash++; - test_ssync(VBERROR_EC_REBOOT_TO_RO_REQUIRED, + test_ssync(VB2_REQUEST_REBOOT_EC_TO_RO, VB2_RECOVERY_EC_UPDATE, "Updated hash mismatch"); TEST_EQ(ec_ro_updated, 0, " ec ro updated"); TEST_EQ(ec_rw_updated, 1, " ec rw updated"); @@ -464,8 +464,8 @@ static void VbSoftwareSyncTest(void) ResetMocks(); mock_ec_rw_hash[0]++; - update_retval = VBERROR_EC_REBOOT_TO_RO_REQUIRED; - test_ssync(VBERROR_EC_REBOOT_TO_RO_REQUIRED, + update_retval = VB2_REQUEST_REBOOT_EC_TO_RO; + test_ssync(VB2_REQUEST_REBOOT_EC_TO_RO, 0, "Reboot for rw update"); TEST_EQ(ec_ro_updated, 0, " ec rw updated"); TEST_EQ(ec_rw_updated, 0, " ec rw updated"); @@ -476,7 +476,7 @@ static void VbSoftwareSyncTest(void) ResetMocks(); mock_ec_rw_hash[0]++; update_retval = VB2_ERROR_MOCK; - test_ssync(VBERROR_EC_REBOOT_TO_RO_REQUIRED, + test_ssync(VB2_REQUEST_REBOOT_EC_TO_RO, VB2_RECOVERY_EC_UPDATE, "Update failed"); TEST_EQ(ec_ro_updated, 0, " ec rw updated"); TEST_EQ(ec_rw_updated, 0, " ec rw updated"); @@ -488,7 +488,7 @@ static void VbSoftwareSyncTest(void) ResetMocks(); mock_ec_rw_hash[0]++; mock_display_available = 0; - test_ssync(VBERROR_REBOOT_REQUIRED, 0, + test_ssync(VB2_REQUEST_REBOOT, 0, "Reboot for display - ec rw"); TEST_EQ(ec_ro_updated, 0, " ec ro updated"); TEST_EQ(ec_rw_updated, 0, " ec rw updated"); @@ -501,7 +501,7 @@ static void VbSoftwareSyncTest(void) vb2_nv_set(ctx, VB2_NV_TRY_RO_SYNC, 1); mock_ec_ro_hash[0]++; mock_display_available = 0; - test_ssync(VBERROR_REBOOT_REQUIRED, 0, + test_ssync(VB2_REQUEST_REBOOT, 0, "Reboot for display - ec ro"); TEST_EQ(ec_ro_updated, 0, " ec ro updated"); TEST_EQ(ec_rw_updated, 0, " ec rw updated"); @@ -529,7 +529,7 @@ static void VbSoftwareSyncTest(void) ResetMocks(); jump_retval = VB2_ERROR_MOCK; - test_ssync(VBERROR_EC_REBOOT_TO_RO_REQUIRED, + test_ssync(VB2_REQUEST_REBOOT_EC_TO_RO, VB2_RECOVERY_EC_JUMP_RW, "Jump to RW fail"); TEST_EQ(ec_ro_updated, 0, " ec ro updated"); TEST_EQ(ec_rw_updated, 0, " ec rw updated"); @@ -538,8 +538,8 @@ static void VbSoftwareSyncTest(void) TEST_EQ(ec_run_image, 0, " ec run image"); ResetMocks(); - jump_retval = VBERROR_EC_REBOOT_TO_RO_REQUIRED; - test_ssync(VBERROR_EC_REBOOT_TO_RO_REQUIRED, + jump_retval = VB2_REQUEST_REBOOT_EC_TO_RO; + test_ssync(VB2_REQUEST_REBOOT_EC_TO_RO, 0, "Jump to RW fail because locked"); TEST_EQ(ec_ro_updated, 0, " ec ro updated"); TEST_EQ(ec_rw_updated, 0, " ec rw updated"); diff --git a/tests/vb2_kernel_tests.c b/tests/vb2_kernel_tests.c index ddef912a..30da9ad5 100644 --- a/tests/vb2_kernel_tests.c +++ b/tests/vb2_kernel_tests.c @@ -278,14 +278,14 @@ static void normal_boot_tests(void) reset_common_data(FOR_NORMAL_BOOT); vb2_nv_set(ctx, VB2_NV_DISPLAY_REQUEST, 1); - TEST_EQ(vb2_normal_boot(ctx), VBERROR_REBOOT_REQUIRED, + TEST_EQ(vb2_normal_boot(ctx), VB2_REQUEST_REBOOT, "vb2_normal_boot() reboot to reset NVRAM display request"); TEST_EQ(vb2_nv_get(ctx, VB2_NV_DISPLAY_REQUEST), 0, " display request reset"); reset_common_data(FOR_NORMAL_BOOT); vb2_nv_set(ctx, VB2_NV_DIAG_REQUEST, 1); - TEST_EQ(vb2_normal_boot(ctx), VBERROR_REBOOT_REQUIRED, + TEST_EQ(vb2_normal_boot(ctx), VB2_REQUEST_REBOOT, "vb2_normal_boot() reboot to reset NVRAM diag request"); TEST_EQ(vb2_nv_get(ctx, VB2_NV_DIAG_REQUEST), 0, " diag request reset");} diff --git a/tests/vboot_api_kernel4_tests.c b/tests/vboot_api_kernel4_tests.c index 12a89af4..45ba7be5 100644 --- a/tests/vboot_api_kernel4_tests.c +++ b/tests/vboot_api_kernel4_tests.c @@ -298,7 +298,7 @@ static void select_and_load_kernel_tests(void) /* Boot recovery - memory retraining */ reset_common_data(); sd->recovery_reason = VB2_RECOVERY_TRAIN_AND_REBOOT; - test_slk(VBERROR_REBOOT_REQUIRED, 0, "Recovery train and reboot"); + test_slk(VB2_REQUEST_REBOOT, 0, "Recovery train and reboot"); TEST_FALSE(commit_data_called, " no commit data"); /* Boot BROKEN recovery */ diff --git a/tests/vboot_legacy_clamshell_tests.c b/tests/vboot_legacy_clamshell_tests.c index 054a2239..77944ba8 100644 --- a/tests/vboot_legacy_clamshell_tests.c +++ b/tests/vboot_legacy_clamshell_tests.c @@ -574,7 +574,7 @@ static void VbBootDevTest(void) mock_gpio[1].gpio_flags = GPIO_SHUTDOWN; mock_gpio[1].count = 1; TEST_EQ(VbBootDeveloperLegacyClamshell(ctx), - VBERROR_SHUTDOWN_REQUESTED, + VB2_REQUEST_SHUTDOWN, "Shutdown requested"); TEST_NEQ(audio_looping_calls_left, 0, " aborts audio"); @@ -582,7 +582,7 @@ static void VbBootDevTest(void) ResetMocks(); mock_keypress[0] = VB_BUTTON_POWER_SHORT_PRESS; TEST_EQ(VbBootDeveloperLegacyClamshell(ctx), - VBERROR_SHUTDOWN_REQUESTED, + VB2_REQUEST_SHUTDOWN, "Shutdown requested by keyboard"); /* Space asks to disable virtual dev switch */ @@ -590,7 +590,7 @@ static void VbBootDevTest(void) sd->flags = VB2_SD_FLAG_DEV_MODE_ENABLED; mock_keypress[0] = ' '; mock_keypress[1] = VB_KEY_ENTER; - TEST_EQ(VbBootDeveloperLegacyClamshell(ctx), VBERROR_REBOOT_REQUIRED, + TEST_EQ(VbBootDeveloperLegacyClamshell(ctx), VB2_REQUEST_REBOOT, "Space = tonorm"); TEST_EQ(screens_displayed[0], VB_SCREEN_DEVELOPER_WARNING, " warning screen"); @@ -632,7 +632,7 @@ static void VbBootDevTest(void) gbb.flags |= VB2_GBB_FLAG_ENTER_TRIGGERS_TONORM; mock_keypress[0] = VB_KEY_ENTER; mock_keypress[1] = VB_KEY_ENTER; - TEST_EQ(VbBootDeveloperLegacyClamshell(ctx), VBERROR_REBOOT_REQUIRED, + TEST_EQ(VbBootDeveloperLegacyClamshell(ctx), VB2_REQUEST_REBOOT, "Enter = tonorm"); /* Tonorm ignored if GBB forces dev switch on */ @@ -651,7 +651,7 @@ static void VbBootDevTest(void) mock_keypress[0] = ' '; MockGpioAfter(3, GPIO_SHUTDOWN); TEST_EQ(VbBootDeveloperLegacyClamshell(ctx), - VBERROR_SHUTDOWN_REQUESTED, + VB2_REQUEST_SHUTDOWN, "Shutdown requested at tonorm"); TEST_EQ(screens_displayed[0], VB_SCREEN_DEVELOPER_WARNING, " warning screen"); @@ -663,7 +663,7 @@ static void VbBootDevTest(void) sd->flags = VB2_SD_FLAG_DEV_MODE_ENABLED; mock_keypress[0] = VB_BUTTON_POWER_SHORT_PRESS; TEST_EQ(VbBootDeveloperLegacyClamshell(ctx), - VBERROR_SHUTDOWN_REQUESTED, + VB2_REQUEST_SHUTDOWN, "Shutdown requested by keyboard at nonorm"); /* Ctrl+D dismisses warning */ @@ -697,7 +697,7 @@ static void VbBootDevTest(void) MockGpioAfter(1000, GPIO_SHUTDOWN); gbb.flags |= VB2_GBB_FLAG_FORCE_DEV_BOOT_LEGACY; mock_keypress[0] = VB_KEY_CTRL('L'); - TEST_EQ(VbBootDeveloperLegacyClamshell(ctx), VBERROR_SHUTDOWN_REQUESTED, + TEST_EQ(VbBootDeveloperLegacyClamshell(ctx), VB2_REQUEST_SHUTDOWN, "Ctrl+L force legacy"); TEST_EQ(vbexlegacy_called, 0, " try legacy"); @@ -832,7 +832,7 @@ static void VbBootDevTest(void) fwmp->flags |= VB2_SECDATA_FWMP_DEV_DISABLE_BOOT; mock_keypress[0] = VB_KEY_ESC; /* Just causes TONORM again */ mock_keypress[1] = VB_KEY_ENTER; - TEST_EQ(VbBootDeveloperLegacyClamshell(ctx), VBERROR_REBOOT_REQUIRED, + TEST_EQ(VbBootDeveloperLegacyClamshell(ctx), VB2_REQUEST_REBOOT, "FWMP dev disabled"); TEST_EQ(screens_displayed[0], VB_SCREEN_DEVELOPER_TO_NORM, " tonorm screen"); @@ -849,7 +849,7 @@ static void VbBootDevTest(void) fwmp->flags |= VB2_SECDATA_FWMP_DEV_DISABLE_BOOT; MockGpioAfter(1, GPIO_SHUTDOWN); TEST_EQ(VbBootDeveloperLegacyClamshell(ctx), - VBERROR_SHUTDOWN_REQUESTED, + VB2_REQUEST_SHUTDOWN, "Shutdown requested when dev disabled"); TEST_EQ(screens_displayed[0], VB_SCREEN_DEVELOPER_TO_NORM, " tonorm screen"); @@ -860,7 +860,7 @@ static void VbBootDevTest(void) fwmp->flags |= VB2_SECDATA_FWMP_DEV_DISABLE_BOOT; mock_keypress[0] = VB_BUTTON_POWER_SHORT_PRESS; TEST_EQ(VbBootDeveloperLegacyClamshell(ctx), - VBERROR_SHUTDOWN_REQUESTED, + VB2_REQUEST_SHUTDOWN, "Shutdown requested by keyboard when dev disabled"); VB2_DEBUG("...done.\n"); @@ -878,7 +878,7 @@ static void VbBootDevVendorDataTest(void) mock_keypress[4] = '1'; mock_keypress[5] = VB_KEY_ENTER; /* Set vendor data */ mock_keypress[6] = VB_KEY_ENTER; /* Confirm vendor data (Default YES) */ - TEST_EQ(VbBootDeveloperLegacyClamshell(ctx), VBERROR_REBOOT_REQUIRED, + TEST_EQ(VbBootDeveloperLegacyClamshell(ctx), VB2_REQUEST_REBOOT, "Enter set vendor data, don't confirm, esc"); TEST_EQ(set_vendor_data_called, 1, " VbExSetVendorData() called"); TEST_STR_EQ(set_vendor_data, "4321", " Vendor data correct"); @@ -915,7 +915,7 @@ static void VbBootDevVendorDataTest(void) mock_keypress[9] = 'B'; mock_keypress[10] = VB_KEY_ENTER; /* Set vendor data */ mock_keypress[11] = VB_KEY_ENTER; /* Confirm vendor data */ - TEST_EQ(VbBootDeveloperLegacyClamshell(ctx), VBERROR_REBOOT_REQUIRED, + TEST_EQ(VbBootDeveloperLegacyClamshell(ctx), VB2_REQUEST_REBOOT, "Enter set vendor data esc, don't confirm, change last character"); TEST_EQ(set_vendor_data_called, 1, " VbExSetVendorData() called"); TEST_STR_EQ(set_vendor_data, "432B", " Vendor data correct"); @@ -931,7 +931,7 @@ static void VbBootDevVendorDataTest(void) mock_keypress[5] = '5'; mock_keypress[6] = VB_KEY_ENTER; /* Set vendor data */ mock_keypress[7] = VB_KEY_ENTER; /* Confirm vendor data (Default YES) */ - TEST_EQ(VbBootDeveloperLegacyClamshell(ctx), VBERROR_REBOOT_REQUIRED, + TEST_EQ(VbBootDeveloperLegacyClamshell(ctx), VB2_REQUEST_REBOOT, "Enter set vendor data extra keys ignored"); TEST_EQ(set_vendor_data_called, 1, " VbExSetVendorData() called"); TEST_STR_EQ(set_vendor_data, "4321", " Vendor data correct"); @@ -946,7 +946,7 @@ static void VbBootDevVendorDataTest(void) mock_keypress[4] = 'z'; mock_keypress[5] = VB_KEY_ENTER; /* Set vendor data */ mock_keypress[6] = VB_KEY_ENTER; /* Confirm vendor data (Default YES) */ - TEST_EQ(VbBootDeveloperLegacyClamshell(ctx), VBERROR_REBOOT_REQUIRED, + TEST_EQ(VbBootDeveloperLegacyClamshell(ctx), VB2_REQUEST_REBOOT, "Enter set vendor data converts case"); TEST_EQ(set_vendor_data_called, 1, " VbExSetVendorData() called"); TEST_STR_EQ(set_vendor_data, "ABYZ", " Vendor data correct"); @@ -965,7 +965,7 @@ static void VbBootDevVendorDataTest(void) mock_keypress[8] = '1'; mock_keypress[9] = VB_KEY_ENTER; /* Set vendor data */ mock_keypress[10] = VB_KEY_ENTER; /* Confirm vendor data (Default YES) */ - TEST_EQ(VbBootDeveloperLegacyClamshell(ctx), VBERROR_REBOOT_REQUIRED, + TEST_EQ(VbBootDeveloperLegacyClamshell(ctx), VB2_REQUEST_REBOOT, "Enter set vendor data backspace works"); TEST_EQ(set_vendor_data_called, 1, " VbExSetVendorData() called"); TEST_STR_EQ(set_vendor_data, "A321", " Vendor data correct"); @@ -985,7 +985,7 @@ static void VbBootDevVendorDataTest(void) mock_keypress[9] = '1'; mock_keypress[10] = VB_KEY_ENTER; /* Set vendor data */ mock_keypress[11] = VB_KEY_ENTER; /* Confirm vendor data (Default YES) */ - TEST_EQ(VbBootDeveloperLegacyClamshell(ctx), VBERROR_REBOOT_REQUIRED, + TEST_EQ(VbBootDeveloperLegacyClamshell(ctx), VB2_REQUEST_REBOOT, "Enter set vendor data invalid chars don't print"); TEST_EQ(set_vendor_data_called, 1, " VbExSetVendorData() called"); TEST_STR_EQ(set_vendor_data, "4321", " Vendor data correct"); @@ -1003,7 +1003,7 @@ static void VbBootDevVendorDataTest(void) mock_keypress[7] = '0'; mock_keypress[8] = VB_KEY_ENTER; /* Set vendor data */ mock_keypress[9] = VB_KEY_ENTER; /* Confirm vendor data (Default YES) */ - TEST_EQ(VbBootDeveloperLegacyClamshell(ctx), VBERROR_REBOOT_REQUIRED, + TEST_EQ(VbBootDeveloperLegacyClamshell(ctx), VB2_REQUEST_REBOOT, "Enter set vendor data invalid chars don't print with backspace"); TEST_EQ(set_vendor_data_called, 1, " VbExSetVendorData() called"); TEST_STR_EQ(set_vendor_data, "3210", " Vendor data correct"); @@ -1021,7 +1021,7 @@ static void VbBootDevVendorDataTest(void) mock_keypress[7] = '1'; mock_keypress[8] = VB_KEY_ENTER; /* Set vendor data */ mock_keypress[9] = VB_KEY_ENTER; /* Confirm vendor data (Default YES) */ - TEST_EQ(VbBootDeveloperLegacyClamshell(ctx), VBERROR_REBOOT_REQUIRED, + TEST_EQ(VbBootDeveloperLegacyClamshell(ctx), VB2_REQUEST_REBOOT, "Enter set vendor data backspace only doesn't underrun"); TEST_EQ(set_vendor_data_called, 1, " VbExSetVendorData() called"); TEST_STR_EQ(set_vendor_data, "4321", " Vendor data correct"); @@ -1041,7 +1041,7 @@ static void VbBootDevVendorDataTest(void) mock_keypress[9] = 'D'; mock_keypress[10] = VB_KEY_ENTER; /* Set vendor data */ mock_keypress[11] = VB_KEY_ENTER; /* Confirm vendor data (Default YES) */ - TEST_EQ(VbBootDeveloperLegacyClamshell(ctx), VBERROR_REBOOT_REQUIRED, + TEST_EQ(VbBootDeveloperLegacyClamshell(ctx), VB2_REQUEST_REBOOT, "Enter set vendor data vowels not allowed after first char"); TEST_EQ(set_vendor_data_called, 1, " VbExSetVendorData() called"); TEST_STR_EQ(set_vendor_data, "ABCD", " Vendor data correct"); @@ -1142,13 +1142,13 @@ static void VbBootRecTestGpio(uint32_t first, uint32_t second, uint32_t third, if (confirm) { TEST_EQ(VbBootRecoveryLegacyClamshell(ctx), - VBERROR_EC_REBOOT_TO_RO_REQUIRED, msg); + VB2_REQUEST_REBOOT_EC_TO_RO, msg); TEST_EQ(virtdev_set, 1, " virtual dev mode on"); TEST_EQ(vb2_nv_get(ctx, VB2_NV_DEV_BOOT_USB), !!USB_BOOT_ON_DEV, " NV_DEV_BOOT_USB enabled"); } else { TEST_EQ(VbBootRecoveryLegacyClamshell(ctx), - VBERROR_SHUTDOWN_REQUESTED, msg); + VB2_REQUEST_SHUTDOWN, msg); TEST_EQ(virtdev_set, 0, " virtual dev mode off"); } } @@ -1161,7 +1161,7 @@ static void VbBootRecTest(void) ResetMocks(); MockGpioAfter(10, GPIO_SHUTDOWN); TEST_EQ(VbBootRecoveryLegacyClamshell(ctx), - VBERROR_SHUTDOWN_REQUESTED, + VB2_REQUEST_SHUTDOWN, "Shutdown requested"); TEST_EQ(vb2_nv_get(ctx, VB2_NV_RECOVERY_REQUEST), 0, @@ -1173,7 +1173,7 @@ static void VbBootRecTest(void) ResetMocks(); mock_keypress[0] = VB_BUTTON_POWER_SHORT_PRESS; TEST_EQ(VbBootRecoveryLegacyClamshell(ctx), - VBERROR_SHUTDOWN_REQUESTED, + VB2_REQUEST_SHUTDOWN, "Shutdown requested by keyboard"); /* Ignore power button held on boot */ @@ -1191,7 +1191,7 @@ static void VbBootRecTest(void) vbtlk_retval = VB2_ERROR_LK_NO_DISK_FOUND; vbtlk_expect_removable = 1; TEST_EQ(VbBootRecoveryLegacyClamshell(ctx), - VBERROR_SHUTDOWN_REQUESTED, + VB2_REQUEST_SHUTDOWN, "Ignore power button held on boot"); TEST_EQ(screens_displayed[0], VB_SCREEN_RECOVERY_INSERT, " insert screen"); @@ -1204,7 +1204,7 @@ static void VbBootRecTest(void) mock_num_disks[1] = 1; mock_num_disks[2] = 1; TEST_EQ(VbBootRecoveryLegacyClamshell(ctx), - VBERROR_SHUTDOWN_REQUESTED, + VB2_REQUEST_SHUTDOWN, "Broken"); TEST_EQ(screens_displayed[0], VB_SCREEN_OS_BROKEN, " broken screen"); @@ -1216,7 +1216,7 @@ static void VbBootRecTest(void) mock_num_disks[1] = 1; sd->flags |= VB2_SD_FLAG_DEV_MODE_ENABLED; TEST_EQ(VbBootRecoveryLegacyClamshell(ctx), - VBERROR_SHUTDOWN_REQUESTED, + VB2_REQUEST_SHUTDOWN, "Broken (dev)"); TEST_EQ(screens_displayed[0], VB_SCREEN_OS_BROKEN, " broken screen"); @@ -1228,7 +1228,7 @@ static void VbBootRecTest(void) vbtlk_retval = VB2_ERROR_LK_NO_DISK_FOUND; vbtlk_expect_removable = 1; TEST_EQ(VbBootRecoveryLegacyClamshell(ctx), - VBERROR_SHUTDOWN_REQUESTED, + VB2_REQUEST_SHUTDOWN, "Insert (forced by GBB)"); TEST_EQ(screens_displayed[0], VB_SCREEN_RECOVERY_INSERT, " insert screen"); @@ -1240,7 +1240,7 @@ static void VbBootRecTest(void) mock_num_disks[1] = 1; sd->flags |= VB2_SD_FLAG_MANUAL_RECOVERY; TEST_EQ(VbBootRecoveryLegacyClamshell(ctx), - VBERROR_SHUTDOWN_REQUESTED, + VB2_REQUEST_SHUTDOWN, "No remove in rec"); TEST_EQ(screens_displayed[0], VB_SCREEN_OS_BROKEN, " broken screen"); @@ -1251,7 +1251,7 @@ static void VbBootRecTest(void) mock_num_disks[0] = 0; mock_num_disks[1] = 1; TEST_EQ(VbBootRecoveryLegacyClamshell(ctx), - VBERROR_SHUTDOWN_REQUESTED, + VB2_REQUEST_SHUTDOWN, "Remove"); TEST_EQ(screens_displayed[0], VB_SCREEN_OS_BROKEN, " broken screen"); @@ -1261,7 +1261,7 @@ static void VbBootRecTest(void) MockGpioAfter(10, GPIO_SHUTDOWN); mock_num_disks[0] = -1; TEST_EQ(VbBootRecoveryLegacyClamshell(ctx), - VBERROR_SHUTDOWN_REQUESTED, + VB2_REQUEST_SHUTDOWN, "Bad disk count"); TEST_EQ(screens_displayed[0], VB_SCREEN_OS_BROKEN, " broken screen"); @@ -1273,7 +1273,7 @@ static void VbBootRecTest(void) mock_keypress[0] = VB_KEY_CTRL('D'); trust_ec = 0; TEST_EQ(VbBootRecoveryLegacyClamshell(ctx), - VBERROR_SHUTDOWN_REQUESTED, + VB2_REQUEST_SHUTDOWN, "Ctrl+D ignored if EC not trusted"); TEST_EQ(virtdev_set, 0, " virtual dev mode off"); TEST_NEQ(screens_displayed[1], VB_SCREEN_RECOVERY_TO_DEV, @@ -1286,7 +1286,7 @@ static void VbBootRecTest(void) mock_keypress[0] = VB_KEY_CTRL('D'); vbtlk_expect_removable = 1; TEST_EQ(VbBootRecoveryLegacyClamshell(ctx), - VBERROR_SHUTDOWN_REQUESTED, + VB2_REQUEST_SHUTDOWN, "Ctrl+D ignored if already in dev mode"); TEST_EQ(virtdev_set, 0, " virtual dev mode off"); TEST_NEQ(screens_displayed[1], VB_SCREEN_RECOVERY_TO_DEV, @@ -1298,7 +1298,7 @@ static void VbBootRecTest(void) mock_keypress[0] = VB_KEY_CTRL('D'); vbtlk_expect_removable = 1; TEST_EQ(VbBootRecoveryLegacyClamshell(ctx), - VBERROR_SHUTDOWN_REQUESTED, + VB2_REQUEST_SHUTDOWN, "Ctrl+D ignored if recovery not manually triggered"); TEST_EQ(virtdev_set, 0, " virtual dev mode off"); TEST_NEQ(screens_displayed[1], VB_SCREEN_RECOVERY_TO_DEV, @@ -1316,7 +1316,7 @@ static void VbBootRecTest(void) mock_gpio[1].count = 100; vbtlk_expect_removable = 1; TEST_EQ(VbBootRecoveryLegacyClamshell(ctx), - VBERROR_SHUTDOWN_REQUESTED, + VB2_REQUEST_SHUTDOWN, "Ctrl+D ignored if phys pres button is still pressed"); TEST_NEQ(screens_displayed[1], VB_SCREEN_RECOVERY_TO_DEV, " todev screen"); @@ -1331,7 +1331,7 @@ static void VbBootRecTest(void) mock_keypress[1] = ' '; vbtlk_expect_removable = 1; TEST_EQ(VbBootRecoveryLegacyClamshell(ctx), - VBERROR_SHUTDOWN_REQUESTED, + VB2_REQUEST_SHUTDOWN, "Ctrl+D todev abort"); TEST_EQ(screens_displayed[0], VB_SCREEN_RECOVERY_INSERT, " insert screen"); @@ -1352,7 +1352,7 @@ static void VbBootRecTest(void) mock_keyflags[1] = VB_KEY_FLAG_TRUSTED_KEYBOARD; vbtlk_expect_removable = 1; TEST_EQ(VbBootRecoveryLegacyClamshell(ctx), - VBERROR_EC_REBOOT_TO_RO_REQUIRED, + VB2_REQUEST_REBOOT_EC_TO_RO, "Ctrl+D todev confirm via enter"); TEST_EQ(virtdev_set, 1, " virtual dev mode on"); @@ -1465,11 +1465,11 @@ static void VbBootRecTest(void) vbtlk_expect_removable = 1; if (DIAGNOSTIC_UI) TEST_EQ(VbBootRecoveryLegacyClamshell(ctx), - VBERROR_REBOOT_REQUIRED, + VB2_REQUEST_REBOOT, "Ctrl+C todiag - enabled"); else TEST_EQ(VbBootRecoveryLegacyClamshell(ctx), - VBERROR_SHUTDOWN_REQUESTED, + VB2_REQUEST_SHUTDOWN, "Ctrl+C todiag - disabled"); TEST_EQ(vb2_nv_get(ctx, VB2_NV_DIAG_REQUEST), DIAGNOSTIC_UI, " todiag is updated for Ctrl-C"); @@ -1491,11 +1491,11 @@ static void VbBootRecTest(void) vbtlk_expect_removable = 1; if (DIAGNOSTIC_UI) TEST_EQ(VbBootRecoveryLegacyClamshell(ctx), - VBERROR_REBOOT_REQUIRED, + VB2_REQUEST_REBOOT, "F12 todiag - enabled"); else TEST_EQ(VbBootRecoveryLegacyClamshell(ctx), - VBERROR_SHUTDOWN_REQUESTED, + VB2_REQUEST_SHUTDOWN, "F12 todiag - disabled"); TEST_EQ(vb2_nv_get(ctx, VB2_NV_DIAG_REQUEST), DIAGNOSTIC_UI, " todiag is updated for F12"); @@ -1512,11 +1512,11 @@ static void VbBootRecTest(void) "todiag is zero"); if (DIAGNOSTIC_UI) TEST_EQ(VbBootRecoveryLegacyClamshell(ctx), - VBERROR_REBOOT_REQUIRED, + VB2_REQUEST_REBOOT, "Ctrl+C todiag os broken - enabled"); else TEST_EQ(VbBootRecoveryLegacyClamshell(ctx), - VBERROR_SHUTDOWN_REQUESTED, + VB2_REQUEST_SHUTDOWN, "Ctrl+C todiag os broken - disabled"); TEST_EQ(vb2_nv_get(ctx, VB2_NV_DIAG_REQUEST), DIAGNOSTIC_UI, " todiag is updated for Ctrl-C"); @@ -1534,7 +1534,7 @@ static void VbBootDiagTest(void) /* No key pressed - timeout. */ ResetMocks(); - TEST_EQ(VbBootDiagnosticLegacyClamshell(ctx), VBERROR_REBOOT_REQUIRED, + TEST_EQ(VbBootDiagnosticLegacyClamshell(ctx), VB2_REQUEST_REBOOT, "Timeout"); TEST_EQ(screens_displayed[0], VB_SCREEN_CONFIRM_DIAG, " confirm screen"); @@ -1548,7 +1548,7 @@ static void VbBootDiagTest(void) /* Esc key pressed. */ ResetMocks(); mock_keypress[0] = VB_KEY_ESC; - TEST_EQ(VbBootDiagnosticLegacyClamshell(ctx), VBERROR_REBOOT_REQUIRED, + TEST_EQ(VbBootDiagnosticLegacyClamshell(ctx), VB2_REQUEST_REBOOT, "Esc key"); TEST_EQ(screens_displayed[0], VB_SCREEN_CONFIRM_DIAG, " confirm screen"); @@ -1562,7 +1562,7 @@ static void VbBootDiagTest(void) ResetMocks(); MockGpioAfter(10, GPIO_LID_CLOSED); TEST_EQ(VbBootDiagnosticLegacyClamshell(ctx), - VBERROR_SHUTDOWN_REQUESTED, "Shutdown"); + VB2_REQUEST_SHUTDOWN, "Shutdown"); TEST_EQ(screens_displayed[0], VB_SCREEN_CONFIRM_DIAG, " confirm screen"); TEST_EQ(screens_displayed[1], VB_SCREEN_BLANK, @@ -1575,7 +1575,7 @@ static void VbBootDiagTest(void) ResetMocks(); mock_gpio[0].gpio_flags = GPIO_PRESENCE; mock_gpio[0].count = ~0; - TEST_EQ(VbBootDiagnosticLegacyClamshell(ctx), VBERROR_REBOOT_REQUIRED, + TEST_EQ(VbBootDiagnosticLegacyClamshell(ctx), VB2_REQUEST_REBOOT, "Power held"); TEST_EQ(screens_displayed[0], VB_SCREEN_CONFIRM_DIAG, " confirm screen"); @@ -1587,7 +1587,7 @@ static void VbBootDiagTest(void) /* Power button is pressed and released. */ ResetMocks(); MockGpioAfter(3, GPIO_PRESENCE); - TEST_EQ(VbBootDiagnosticLegacyClamshell(ctx), VBERROR_REBOOT_REQUIRED, + TEST_EQ(VbBootDiagnosticLegacyClamshell(ctx), VB2_REQUEST_REBOOT, "Confirm"); TEST_EQ(screens_displayed[0], VB_SCREEN_CONFIRM_DIAG, " confirm screen"); @@ -1612,7 +1612,7 @@ static void VbBootDiagTest(void) mock_gpio[0].count = 2; mock_gpio[1].gpio_flags = GPIO_PRESENCE; mock_gpio[1].count = 2; - TEST_EQ(VbBootDiagnosticLegacyClamshell(ctx), VBERROR_REBOOT_REQUIRED, + TEST_EQ(VbBootDiagnosticLegacyClamshell(ctx), VB2_REQUEST_REBOOT, "Confirm but tpm fail"); TEST_EQ(screens_displayed[0], VB_SCREEN_CONFIRM_DIAG, " confirm screen"); diff --git a/tests/vboot_legacy_menu_tests.c b/tests/vboot_legacy_menu_tests.c index 39eb0184..80325f85 100644 --- a/tests/vboot_legacy_menu_tests.c +++ b/tests/vboot_legacy_menu_tests.c @@ -365,7 +365,7 @@ static void VbBootDevTest(void) /* Shutdown requested in loop */ ResetMocksForDeveloper(); shutdown_request_calls_left = 2; - TEST_EQ(VbBootDeveloperLegacyMenu(ctx), VBERROR_SHUTDOWN_REQUESTED, + TEST_EQ(VbBootDeveloperLegacyMenu(ctx), VB2_REQUEST_SHUTDOWN, "Shutdown requested"); TEST_EQ(vb2_nv_get(ctx, VB2_NV_RECOVERY_REQUEST), 0, " no recovery"); TEST_EQ(debug_info_displayed, 0, " no debug info"); @@ -382,7 +382,7 @@ static void VbBootDevTest(void) */ ResetMocksForDeveloper(); mock_keypress[0] = VB_BUTTON_POWER_SHORT_PRESS; - TEST_EQ(VbBootDeveloperLegacyMenu(ctx), VBERROR_SHUTDOWN_REQUESTED, + TEST_EQ(VbBootDeveloperLegacyMenu(ctx), VB2_REQUEST_SHUTDOWN, "dev warning menu: default to power off"); TEST_EQ(vb2_nv_get(ctx, VB2_NV_RECOVERY_REQUEST), 0, " no recovery"); TEST_EQ(screens_displayed[0], VB_SCREEN_DEVELOPER_WARNING_MENU, @@ -402,7 +402,7 @@ static void VbBootDevTest(void) mock_keypress[i++] = VB_BUTTON_VOL_DOWN_SHORT_PRESS; // Cancel mock_keypress[i++] = VB_BUTTON_VOL_DOWN_SHORT_PRESS; // Power Off mock_keypress[i++] = VB_BUTTON_POWER_SHORT_PRESS; - TEST_EQ(VbBootDeveloperLegacyMenu(ctx), VBERROR_SHUTDOWN_REQUESTED, + TEST_EQ(VbBootDeveloperLegacyMenu(ctx), VB2_REQUEST_SHUTDOWN, "Power Off in DEVELOPER"); TEST_EQ(debug_info_displayed, 0, " no debug info"); TEST_EQ(vbexlegacy_called, 0, " not legacy"); @@ -430,7 +430,7 @@ static void VbBootDevTest(void) /* Pressing ENTER is equivalent to power button. */ ResetMocksForDeveloper(); mock_keypress[0] = VB_KEY_ENTER; - TEST_EQ(VbBootDeveloperLegacyMenu(ctx), VBERROR_SHUTDOWN_REQUESTED, + TEST_EQ(VbBootDeveloperLegacyMenu(ctx), VB2_REQUEST_SHUTDOWN, "dev warning menu: ENTER is power button"); TEST_EQ(screens_displayed[0], VB_SCREEN_DEVELOPER_WARNING_MENU, " warning screen"); @@ -443,7 +443,7 @@ static void VbBootDevTest(void) ResetMocksForDeveloper(); gbb.flags |= VB2_GBB_FLAG_ENTER_TRIGGERS_TONORM; mock_keypress[0] = VB_KEY_ENTER; - TEST_EQ(VbBootDeveloperLegacyMenu(ctx), VBERROR_SHUTDOWN_REQUESTED, + TEST_EQ(VbBootDeveloperLegacyMenu(ctx), VB2_REQUEST_SHUTDOWN, "dev warning menu: ENTER unaffected by GBB"); TEST_EQ(screens_displayed[0], VB_SCREEN_DEVELOPER_WARNING_MENU, " warning screen"); @@ -457,7 +457,7 @@ static void VbBootDevTest(void) mock_keypress[0] = ' '; mock_keypress[1] = VB_BUTTON_VOL_UP_DOWN_COMBO_PRESS; mock_keypress[2] = VB_BUTTON_POWER_SHORT_PRESS; // select Power Off - TEST_EQ(VbBootDeveloperLegacyMenu(ctx), VBERROR_SHUTDOWN_REQUESTED, + TEST_EQ(VbBootDeveloperLegacyMenu(ctx), VB2_REQUEST_SHUTDOWN, "SPACE or VolUp+Down have no effect"); TEST_EQ(vb2_nv_get(ctx, VB2_NV_RECOVERY_REQUEST), 0, " no recovery"); TEST_EQ(debug_info_displayed, 0, " no debug info"); @@ -474,7 +474,7 @@ static void VbBootDevTest(void) mock_keypress[0] = VB_BUTTON_VOL_UP_SHORT_PRESS; mock_keypress[1] = VB_BUTTON_POWER_SHORT_PRESS; mock_keypress[2] = VB_BUTTON_POWER_SHORT_PRESS; - TEST_EQ(VbBootDeveloperLegacyMenu(ctx), VBERROR_REBOOT_REQUIRED, + TEST_EQ(VbBootDeveloperLegacyMenu(ctx), VB2_REQUEST_REBOOT, "disable developer mode"); TEST_EQ(vb2_nv_get(ctx, VB2_NV_RECOVERY_REQUEST), 0, " no recovery"); TEST_EQ(screens_displayed[0], VB_SCREEN_DEVELOPER_WARNING_MENU, @@ -526,7 +526,7 @@ static void VbBootDevTest(void) mock_keypress[0] = VB_BUTTON_VOL_UP_SHORT_PRESS; mock_keypress[1] = VB_BUTTON_POWER_SHORT_PRESS; shutdown_request_calls_left = 2; - TEST_EQ(VbBootDeveloperLegacyMenu(ctx), VBERROR_SHUTDOWN_REQUESTED, + TEST_EQ(VbBootDeveloperLegacyMenu(ctx), VB2_REQUEST_SHUTDOWN, "Shutdown requested at tonorm"); TEST_EQ(vb2_nv_get(ctx, VB2_NV_RECOVERY_REQUEST), 0, " no recovery"); TEST_EQ(screens_displayed[0], VB_SCREEN_DEVELOPER_WARNING_MENU, @@ -1098,7 +1098,7 @@ static void VbBootDevTest(void) mock_keypress[i++] = VB_BUTTON_VOL_UP_SHORT_PRESS; // enable os verification mock_keypress[i++] = VB_BUTTON_POWER_SHORT_PRESS; mock_keypress[i++] = VB_BUTTON_POWER_SHORT_PRESS; // confirm is the default - TEST_EQ(VbBootDeveloperLegacyMenu(ctx), VBERROR_REBOOT_REQUIRED, + TEST_EQ(VbBootDeveloperLegacyMenu(ctx), VB2_REQUEST_REBOOT, "TONORM via menu"); TEST_EQ(vb2_nv_get(ctx, VB2_NV_DISABLE_DEV_REQUEST), 1, " disable dev request"); @@ -1131,7 +1131,7 @@ static void VbBootDevTest(void) mock_keypress[i++] = VB_BUTTON_VOL_DOWN_LONG_PRESS; /* same */ mock_keypress[i++] = VB_BUTTON_VOL_UP_DOWN_COMBO_PRESS; /* noop */ mock_keypress[i++] = VB_KEY_ENTER; - TEST_EQ(VbBootDeveloperLegacyMenu(ctx), VBERROR_REBOOT_REQUIRED, + TEST_EQ(VbBootDeveloperLegacyMenu(ctx), VB2_REQUEST_REBOOT, "FWMP dev disabled"); TEST_EQ(vb2_nv_get(ctx, VB2_NV_DISABLE_DEV_REQUEST), 1, " disable dev request"); @@ -1177,7 +1177,7 @@ static void VbBootDevTest(void) ResetMocksForDeveloper(); fwmp->flags |= VB2_SECDATA_FWMP_DEV_DISABLE_BOOT; shutdown_request_calls_left = 1; - TEST_EQ(VbBootDeveloperLegacyMenu(ctx), VBERROR_SHUTDOWN_REQUESTED, + TEST_EQ(VbBootDeveloperLegacyMenu(ctx), VB2_REQUEST_SHUTDOWN, "Shutdown requested when dev disabled"); TEST_EQ(vb2_nv_get(ctx, VB2_NV_RECOVERY_REQUEST), 0, " no recovery"); TEST_EQ(vb2_nv_get(ctx, VB2_NV_DISABLE_DEV_REQUEST), 0, @@ -1195,7 +1195,7 @@ static void VbBootDevTest(void) i = 0; mock_keypress[i++] = VB_BUTTON_VOL_DOWN_SHORT_PRESS; // Power Off mock_keypress[i++] = VB_BUTTON_POWER_SHORT_PRESS; - TEST_EQ(VbBootDeveloperLegacyMenu(ctx), VBERROR_SHUTDOWN_REQUESTED, + TEST_EQ(VbBootDeveloperLegacyMenu(ctx), VB2_REQUEST_SHUTDOWN, "Power Off when dev disabled"); TEST_EQ(vb2_nv_get(ctx, VB2_NV_RECOVERY_REQUEST), 0, " no recovery"); TEST_EQ(vb2_nv_get(ctx, VB2_NV_DISABLE_DEV_REQUEST), 0, @@ -1264,7 +1264,7 @@ static void VbBootRecTest(void) /* Shutdown requested in BROKEN */ ResetMocks(); - TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VBERROR_SHUTDOWN_REQUESTED, + TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VB2_REQUEST_SHUTDOWN, "Shutdown requested in BROKEN"); TEST_EQ(vb2_nv_get(ctx, VB2_NV_RECOVERY_REQUEST), 0, " no recovery"); TEST_EQ(debug_info_displayed, 0, " no debug info"); @@ -1282,7 +1282,7 @@ static void VbBootRecTest(void) vbtlk_retval[2] = VB2_SUCCESS - VB_DISK_FLAG_REMOVABLE; vbtlk_retval[3] = VB2_ERROR_LK_NO_DISK_FOUND - VB_DISK_FLAG_REMOVABLE; - TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VBERROR_SHUTDOWN_REQUESTED, + TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VB2_REQUEST_SHUTDOWN, "Shutdown requested in BROKEN with disks"); TEST_EQ(vb2_nv_get(ctx, VB2_NV_RECOVERY_REQUEST), 0, " no recovery"); TEST_EQ(debug_info_displayed, 0, " no debug info"); @@ -1297,7 +1297,7 @@ static void VbBootRecTest(void) vbtlk_retval[0] = VB2_ERROR_LK_NO_DISK_FOUND - VB_DISK_FLAG_REMOVABLE; vbtlk_retval[1] = VB2_SUCCESS - VB_DISK_FLAG_REMOVABLE; - TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VBERROR_SHUTDOWN_REQUESTED, + TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VB2_REQUEST_SHUTDOWN, "Shutdown requested in BROKEN with later disk"); TEST_EQ(vb2_nv_get(ctx, VB2_NV_RECOVERY_REQUEST), 0, " no recovery"); TEST_EQ(debug_info_displayed, 0, " no debug info"); @@ -1314,7 +1314,7 @@ static void VbBootRecTest(void) VB_DISK_FLAG_REMOVABLE; vbtlk_retval[2] = VB2_SUCCESS - VB_DISK_FLAG_REMOVABLE; sd->flags |= VB2_SD_FLAG_DEV_MODE_ENABLED; - TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VBERROR_SHUTDOWN_REQUESTED, + TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VB2_REQUEST_SHUTDOWN, "Shutdown requested in BROKEN with dev switch"); TEST_EQ(vb2_nv_get(ctx, VB2_NV_RECOVERY_REQUEST), 0, " no recovery"); TEST_EQ(debug_info_displayed, 0, " no debug info"); @@ -1328,7 +1328,7 @@ static void VbBootRecTest(void) ResetMocksForManualRecovery(); vbtlk_retval[0] = VB2_ERROR_LK_NO_DISK_FOUND - VB_DISK_FLAG_REMOVABLE; - TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VBERROR_SHUTDOWN_REQUESTED, + TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VB2_REQUEST_SHUTDOWN, "Shutdown requested in INSERT with manual rec"); TEST_EQ(vb2_nv_get(ctx, VB2_NV_RECOVERY_REQUEST), 0, " no recovery"); TEST_EQ(debug_info_displayed, 0, " no debug info"); @@ -1343,7 +1343,7 @@ static void VbBootRecTest(void) vbtlk_retval[0] = VB2_ERROR_LK_NO_DISK_FOUND - VB_DISK_FLAG_REMOVABLE; gbb.flags |= VB2_GBB_FLAG_FORCE_MANUAL_RECOVERY; - TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VBERROR_SHUTDOWN_REQUESTED, + TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VB2_REQUEST_SHUTDOWN, "Shutdown requested in INSERT forced by GBB flag"); TEST_EQ(vb2_nv_get(ctx, VB2_NV_RECOVERY_REQUEST), 0, " no recovery"); TEST_EQ(debug_info_displayed, 0, " no debug info"); @@ -1358,7 +1358,7 @@ static void VbBootRecTest(void) vbtlk_retval[0] = VB2_ERROR_LK_NO_DISK_FOUND - VB_DISK_FLAG_REMOVABLE; sd->flags &= ~VB2_SD_FLAG_MANUAL_RECOVERY; - TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VBERROR_SHUTDOWN_REQUESTED, + TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VB2_REQUEST_SHUTDOWN, "Go to BROKEN if recovery not manually requested"); TEST_EQ(vb2_nv_get(ctx, VB2_NV_RECOVERY_REQUEST), 0, " no recovery"); TEST_EQ(debug_info_displayed, 0, " no debug info"); @@ -1373,7 +1373,7 @@ static void VbBootRecTest(void) vbtlk_retval[0] = VB2_ERROR_LK_NO_DISK_FOUND - VB_DISK_FLAG_REMOVABLE; trust_ec = 0; - TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VBERROR_SHUTDOWN_REQUESTED, + TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VB2_REQUEST_SHUTDOWN, "Go to BROKEN if EC is not trusted"); TEST_EQ(vb2_nv_get(ctx, VB2_NV_RECOVERY_REQUEST), 0, " no recovery"); TEST_EQ(debug_info_displayed, 0, " no debug info"); @@ -1457,7 +1457,7 @@ static void VbBootRecTest(void) mock_keypress[i] = VB_KEY_FLAG_TRUSTED_KEYBOARD; mock_keypress[i++] = VB_BUTTON_VOL_DOWN_LONG_PRESS; mock_keypress[i++] = VB_BUTTON_POWER_SHORT_PRESS; - TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VBERROR_SHUTDOWN_REQUESTED, + TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VB2_REQUEST_SHUTDOWN, "Shortcuts ignored in BROKEN"); TEST_EQ(virtdev_set, 0, " virtual dev mode off"); TEST_NEQ(shutdown_request_calls_left, 0, " powered down explicitly"); @@ -1485,7 +1485,7 @@ static void VbBootRecTest(void) mock_keypress[i++] = VB_BUTTON_POWER_SHORT_PRESS; vbtlk_retval[0] = VB2_ERROR_LK_NO_DISK_FOUND - VB_DISK_FLAG_REMOVABLE; - TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VBERROR_SHUTDOWN_REQUESTED, + TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VB2_REQUEST_SHUTDOWN, "Shortcuts ignored in INSERT"); TEST_EQ(virtdev_set, 0, " virtual dev mode off"); TEST_NEQ(shutdown_request_calls_left, 0, " powered down explicitly"); @@ -1502,7 +1502,7 @@ static void VbBootRecTest(void) mock_keypress[0] = VB_BUTTON_VOL_UP_SHORT_PRESS; // enter options mock_keypress[1] = VB_BUTTON_VOL_DOWN_SHORT_PRESS; // power off mock_keypress[2] = VB_BUTTON_POWER_SHORT_PRESS; - TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VBERROR_SHUTDOWN_REQUESTED, + TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VB2_REQUEST_SHUTDOWN, "Power Off BROKEN through OPTIONS"); TEST_EQ(vb2_nv_get(ctx, VB2_NV_RECOVERY_REQUEST), 0, " no recovery"); TEST_EQ(debug_info_displayed, 0, " no debug info"); @@ -1522,7 +1522,7 @@ static void VbBootRecTest(void) mock_keypress[0] = VB_BUTTON_VOL_UP_SHORT_PRESS; // enter options mock_keypress[1] = VB_BUTTON_VOL_DOWN_SHORT_PRESS; // power off mock_keypress[2] = VB_BUTTON_POWER_SHORT_PRESS; - TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VBERROR_SHUTDOWN_REQUESTED, + TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VB2_REQUEST_SHUTDOWN, "Power Off NOGOOD through OPTIONS"); TEST_EQ(vb2_nv_get(ctx, VB2_NV_RECOVERY_REQUEST), 0, " no recovery"); TEST_EQ(debug_info_displayed, 0, " no debug info"); @@ -1546,7 +1546,7 @@ static void VbBootRecTest(void) mock_keypress[2] = VB_BUTTON_POWER_SHORT_PRESS; vbtlk_retval[0] = VB2_ERROR_LK_NO_DISK_FOUND - VB_DISK_FLAG_REMOVABLE; - TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VBERROR_SHUTDOWN_REQUESTED, + TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VB2_REQUEST_SHUTDOWN, "Power Off INSERT through TO_DEV"); TEST_EQ(vb2_nv_get(ctx, VB2_NV_RECOVERY_REQUEST), 0, " no recovery"); TEST_EQ(debug_info_displayed, 0, " no debug info"); @@ -1566,7 +1566,7 @@ static void VbBootRecTest(void) mock_keypress[0] = VB_BUTTON_VOL_UP_SHORT_PRESS; // enter options mock_keypress[1] = VB_BUTTON_VOL_UP_SHORT_PRESS; // show debug info mock_keypress[2] = VB_BUTTON_POWER_SHORT_PRESS; - TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VBERROR_SHUTDOWN_REQUESTED, + TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VB2_REQUEST_SHUTDOWN, "Show Debug info from BROKEN through OPTIONS"); TEST_EQ(vb2_nv_get(ctx, VB2_NV_RECOVERY_REQUEST), 0, " no recovery"); TEST_EQ(debug_info_displayed, 1, " no debug info"); @@ -1584,7 +1584,7 @@ static void VbBootRecTest(void) /* Show Debug Info on NOGOOD with Tab */ ResetMocksForManualRecovery(); mock_keypress[0] = '\t'; - TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VBERROR_SHUTDOWN_REQUESTED, + TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VB2_REQUEST_SHUTDOWN, "Show Debug info on NOGOOD with Tab"); TEST_EQ(vb2_nv_get(ctx, VB2_NV_RECOVERY_REQUEST), 0, " no recovery"); TEST_EQ(debug_info_displayed, 1, " no debug info"); @@ -1608,7 +1608,7 @@ static void VbBootRecTest(void) mock_keypress[i++] = VB_BUTTON_VOL_DOWN_SHORT_PRESS; // cancel mock_keypress[i++] = VB_BUTTON_POWER_SHORT_PRESS; mock_keypress[i++] = VB_BUTTON_POWER_SHORT_PRESS; // power off - TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VBERROR_SHUTDOWN_REQUESTED, + TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VB2_REQUEST_SHUTDOWN, "go to TO_DEV screen and cancel"); TEST_NEQ(shutdown_request_calls_left, 0, " powered down explicitly"); TEST_EQ(virtdev_set, 0, " virtual dev mode off"); @@ -1639,7 +1639,7 @@ static void VbBootRecTest(void) mock_keyflags[i] = VB_KEY_FLAG_TRUSTED_KEYBOARD; mock_keypress[i++] = VB_BUTTON_VOL_UP_SHORT_PRESS; mock_keypress[i++] = VB_BUTTON_POWER_SHORT_PRESS; - TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VBERROR_REBOOT_REQUIRED, + TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VB2_REQUEST_REBOOT, "go to TO_DEV screen and confirm"); TEST_EQ(vb2_nv_get(ctx, VB2_NV_RECOVERY_REQUEST), 0, " no recovery"); TEST_EQ(debug_info_displayed, 0, " no debug info"); @@ -1661,7 +1661,7 @@ static void VbBootRecTest(void) mock_keypress[i++] = VB_BUTTON_VOL_UP_DOWN_COMBO_PRESS; // try to_dev mock_keypress[i++] = VB_BUTTON_VOL_UP_SHORT_PRESS; // try confirm mock_keypress[i++] = VB_BUTTON_POWER_SHORT_PRESS; - TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VBERROR_SHUTDOWN_REQUESTED, + TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VB2_REQUEST_SHUTDOWN, "Untrusted keyboard cannot enter TO_DEV"); TEST_EQ(vb2_nv_get(ctx, VB2_NV_RECOVERY_REQUEST), 0, " no recovery"); TEST_EQ(debug_info_displayed, 0, " no debug info"); @@ -1684,7 +1684,7 @@ static void VbBootRecTest(void) mock_keypress[i++] = VB_BUTTON_VOL_UP_DOWN_COMBO_PRESS; // enter to_dev mock_keypress[i++] = VB_BUTTON_VOL_UP_SHORT_PRESS; // try to confirm... mock_keypress[i++] = VB_BUTTON_POWER_SHORT_PRESS; - TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VBERROR_SHUTDOWN_REQUESTED, + TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VB2_REQUEST_SHUTDOWN, "Untrusted keyboard cannot navigate in TO_DEV"); TEST_EQ(vb2_nv_get(ctx, VB2_NV_RECOVERY_REQUEST), 0, " no recovery"); TEST_EQ(debug_info_displayed, 0, " no debug info"); @@ -1737,7 +1737,7 @@ static void VbBootRecTest(void) i = 0; mock_keyflags[i] = VB_KEY_FLAG_TRUSTED_KEYBOARD; mock_keypress[i++] = VB_BUTTON_VOL_UP_DOWN_COMBO_PRESS; // enter to_dev - TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VBERROR_SHUTDOWN_REQUESTED, + TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VB2_REQUEST_SHUTDOWN, "Ctrl+D ignored if already in dev mode"); TEST_EQ(vb2_nv_get(ctx, VB2_NV_RECOVERY_REQUEST), 0, " no recovery"); TEST_EQ(debug_info_displayed, 0, " no debug info"); @@ -1766,7 +1766,7 @@ static void VbBootRecTest(void) vbtlk_retval[0] = VB2_ERROR_MOCK - VB_DISK_FLAG_REMOVABLE; vbtlk_retval[1] = VB2_ERROR_LK_NO_DISK_FOUND - VB_DISK_FLAG_REMOVABLE; - TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VBERROR_SHUTDOWN_REQUESTED, + TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VB2_REQUEST_SHUTDOWN, "Drop back to INSERT from TO_DEV when removing invalid USB"); TEST_NEQ(shutdown_request_calls_left, 0, " powered down explicitly"); TEST_EQ(virtdev_set, 0, " virtual dev mode off"); @@ -1801,7 +1801,7 @@ static void VbBootRecTest(void) vbtlk_retval[3] = VB2_ERROR_LK_NO_DISK_FOUND - VB_DISK_FLAG_REMOVABLE; vbtlk_retval[4] = VB2_ERROR_MOCK - VB_DISK_FLAG_REMOVABLE; - TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VBERROR_SHUTDOWN_REQUESTED, + TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VB2_REQUEST_SHUTDOWN, "Drop back to NOGOOD from LANGUAGE when inserting invalid USB"); TEST_EQ(shutdown_request_calls_left, 0, " timed out"); TEST_EQ(virtdev_set, 0, " virtual dev mode off"); @@ -1862,7 +1862,7 @@ static void VbTestLanguageMenu(void) mock_keypress[i++] = VB_BUTTON_POWER_SHORT_PRESS; // select current lang mock_keypress[i++] = VB_BUTTON_POWER_SHORT_PRESS; // cancel -> BROKEN mock_keypress[i++] = VB_BUTTON_POWER_SHORT_PRESS; // power off - TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VBERROR_SHUTDOWN_REQUESTED, + TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VB2_REQUEST_SHUTDOWN, "go to language menu from BROKEN"); TEST_EQ(debug_info_displayed, 0, " no debug info"); TEST_NEQ(shutdown_request_calls_left, 0, " powered down explicitly"); @@ -1910,7 +1910,7 @@ static void VbTestLanguageMenu(void) mock_keyflags[i] = VB_KEY_FLAG_TRUSTED_KEYBOARD; mock_keypress[i++] = VB_BUTTON_VOL_DOWN_SHORT_PRESS; // power off mock_keypress[i++] = VB_BUTTON_POWER_SHORT_PRESS; - TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VBERROR_SHUTDOWN_REQUESTED, + TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VB2_REQUEST_SHUTDOWN, "go to language menus from INSERT"); TEST_EQ(debug_info_displayed, 0, " no debug info"); TEST_NEQ(shutdown_request_calls_left, 0, " powered down explicitly"); @@ -1974,7 +1974,7 @@ static void VbTestLanguageMenu(void) mock_keypress[i++] = VB_BUTTON_VOL_DOWN_SHORT_PRESS; // cancel mock_keypress[i++] = VB_BUTTON_VOL_DOWN_SHORT_PRESS; // power off mock_keypress[i++] = VB_BUTTON_POWER_SHORT_PRESS; - TEST_EQ(VbBootDeveloperLegacyMenu(ctx), VBERROR_SHUTDOWN_REQUESTED, + TEST_EQ(VbBootDeveloperLegacyMenu(ctx), VB2_REQUEST_SHUTDOWN, " scroll through all language menus in developer options"); TEST_EQ(debug_info_displayed, 0, " no debug info"); TEST_NEQ(shutdown_request_calls_left, 0, " powered down explicitly"); @@ -2094,7 +2094,7 @@ static void VbNavigationTest(void) mock_keypress[i++] = VB_BUTTON_VOL_DOWN_SHORT_PRESS; // power off mock_keypress[i++] = VB_BUTTON_VOL_DOWN_SHORT_PRESS; // language mock_keypress[i++] = VB_BUTTON_POWER_SHORT_PRESS; - TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VBERROR_SHUTDOWN_REQUESTED, + TEST_EQ(VbBootRecoveryLegacyMenu(ctx), VB2_REQUEST_SHUTDOWN, "recovery mode long navigation"); TEST_EQ(debug_info_displayed, 1, " showed debug info"); TEST_EQ(shutdown_request_calls_left, 0, " timed out"); |