diff options
author | edisonhello <edisonhello@google.com> | 2021-08-02 14:28:50 +0800 |
---|---|---|
committer | Commit Bot <commit-bot@chromium.org> | 2021-08-12 08:13:14 +0000 |
commit | 51879dc24aea94851fc28ffc2f68cba1b58f3db8 (patch) | |
tree | 832355c3b26b424b9300c92a9fb2a6b93f28e4c6 /tests | |
parent | d8de9942e2fdfdf3f1792740cb5419163faff3ea (diff) | |
download | vboot-51879dc24aea94851fc28ffc2f68cba1b58f3db8.tar.gz |
vboot: Remove unnecessary flag unset operationsstabilize-14150.882.Bstabilize-14150.881.Bstabilize-14150.74.Bstabilize-14150.734.Bstabilize-14150.64.Bstabilize-14150.43.Bstabilize-14150.376.Brelease-R94-14150.Brelease-R94-14150.49.B
Since all flags are initialized as 0 in vb2api_init(),
some flag unset operations are not needed.
Edit few comments to make it more accurate.
BUG=none
TEST=export CC=x86_64-pc-linux-gnu-clang DEBUG=1; \
make -j32 test_setup && make -j32 runtests;
BRANCH=none
Signed-off-by: edisonhello <edisonhello@google.com>
Change-Id: I0129f43342598195800ff671b965100d3d568564
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3066803
Reviewed-by: Julius Werner <jwerner@chromium.org>
Reviewed-by: Yu-Ping Wu <yupingso@chromium.org>
Diffstat (limited to 'tests')
-rw-r--r-- | tests/vb2_ui_action_tests.c | 1 | ||||
-rw-r--r-- | tests/vb2_ui_tests.c | 1 |
2 files changed, 0 insertions, 2 deletions
diff --git a/tests/vb2_ui_action_tests.c b/tests/vb2_ui_action_tests.c index 001d6c2e..514340b4 100644 --- a/tests/vb2_ui_action_tests.c +++ b/tests/vb2_ui_action_tests.c @@ -315,7 +315,6 @@ static void reset_common_data(void) sd = vb2_get_sd(ctx); ctx->flags |= VB2_CONTEXT_DEV_BOOT_ALLOWED; - ctx->flags &= ~(uint64_t)VB2_CONTEXT_DEV_BOOT_ALTFW_ALLOWED; /* For check_shutdown_request */ mock_calls_until_shutdown = 10; diff --git a/tests/vb2_ui_tests.c b/tests/vb2_ui_tests.c index 95d22900..54f76037 100644 --- a/tests/vb2_ui_tests.c +++ b/tests/vb2_ui_tests.c @@ -279,7 +279,6 @@ static void reset_common_data(enum reset_type t) } ctx->flags |= VB2_CONTEXT_DEV_BOOT_ALLOWED; - ctx->flags &= ~(uint64_t)VB2_CONTEXT_DEV_BOOT_ALTFW_ALLOWED; ctx->flags |= VB2_CONTEXT_DEV_BOOT_EXTERNAL_ALLOWED; /* Mock ui_context based on real screens */ |