diff options
author | Joel Kitching <kitching@google.com> | 2019-05-29 16:25:05 +0800 |
---|---|---|
committer | Commit Bot <commit-bot@chromium.org> | 2019-06-07 20:09:43 +0000 |
commit | efd0dc23e855c8ec5a4cd4e0bb08b4ae1e40bfb3 (patch) | |
tree | 7dc12209dcbace8a8c17de3e09e2c54bbb409075 /tests/vboot_detach_menu_tests.c | |
parent | 40c35a022fc9ff9a2be0f394be45747e8f767931 (diff) | |
download | vboot-efd0dc23e855c8ec5a4cd4e0bb08b4ae1e40bfb3.tar.gz |
vboot: check display init when entering normal mode
In order to simplify code which uses VB2_NV_DISPLAY_REQUEST,
centralize disabling this NVRAM flag to a function called at
the start of VbBootNormal. Also disable VB2_NV_DIAG_REQUEST
here, since display init is enabled for this request as well.
BUG=b:124141368, chromium:948592, chromium:967298, b:133175864
TEST=make clean && make runtests
BRANCH=none
Change-Id: I8aa7c44671ada23c0500cd8a0c5d7f737298bb11
Signed-off-by: Joel Kitching <kitching@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1634451
Commit-Queue: Jason Clinton <jclinton@chromium.org>
Tested-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: Joel Kitching <kitching@chromium.org>
Diffstat (limited to 'tests/vboot_detach_menu_tests.c')
-rw-r--r-- | tests/vboot_detach_menu_tests.c | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/tests/vboot_detach_menu_tests.c b/tests/vboot_detach_menu_tests.c index 6949bedb..4d618659 100644 --- a/tests/vboot_detach_menu_tests.c +++ b/tests/vboot_detach_menu_tests.c @@ -255,13 +255,9 @@ uint32_t SetVirtualDevMode(int val) /* Tests */ -static void VbBootTest(void) -{ - ResetMocks(); - VbExEcEnteringMode(0, VB_EC_NORMAL); - TEST_EQ(VbBootNormal(&ctx), vbtlk_retval_fixed, "VbBootNormal()"); - TEST_EQ(VbGetMode(), VB_EC_NORMAL, "vboot_mode normal"); -} +/* + * VbBootNormal tests: Please see VbBootTest in vboot_api_kernel2_tests.c + */ static void VbBootDevTest(void) { @@ -2337,7 +2333,6 @@ static void VbNavigationTest(void) int main(void) { - VbBootTest(); VbBootDevTest(); VbBootRecTest(); VbTestLanguageMenu(); |