diff options
author | Bill Richardson <wfrichar@chromium.org> | 2011-11-10 13:31:39 -0800 |
---|---|---|
committer | Bill Richardson <wfrichar@chromium.org> | 2011-11-11 11:01:20 -0800 |
commit | c8e4ff7c15e6bf5992a578b66bec47d69cde3bea (patch) | |
tree | a714a854e13abd8a9ed4834be84c0fac85da562a /tests/vboot_api_init_tests.c | |
parent | fa9d7782e837848a1aeb0e95295fa48ac23f7a26 (diff) | |
download | vboot-c8e4ff7c15e6bf5992a578b66bec47d69cde3bea.tar.gz |
Add flag to GBB to allow loading PCI Option ROMs
As shipped, H2C only loads the option ROM for the built-in video, and that
only when it needs display the BIOS warning screens.
By setting a flag in the GBB, you can allow all option ROMs to be loaded:
Note that we'll never enable this ourselves (and there's a factory test to
ensure that*) because it executes non-verified code. But if a customer wants
to void their warranty and set this flag in the read-only flash so they can
install and use other PCI devices, they should be able to do so.
BUG=chrome-os-partner:6148
TEST=none
The only way to test this is to use a BIOS that was compiled with serial
debugging enabled, so there's nothing for QA to do. If you have such a BIOS,
you can see the difference like so:
flashrom -r oldbios.bin
gbb_utility -s --flags=2 oldbios.bin newbios.bin
flashrom -w newbios.bin
<reboot>
When bit 1 of the GBB flags is 0, you'll see these lines in the serial
output:
LoadOpRomImage-->GetSystemConfigurationTable Status = Success
LoadOpRomImage-->GetH2cBootMode Status = Success
When bit 1 of the GBB flags is 1, you'll see these lines in the serial
output:
LoadOpRomImage-->GetSystemConfigurationTable Status = Success
LoadOpRomImage-->GetH2cBootMode Status = Success
LoadOpRomImage-->PCI OpRom on 1.0.0 is allowed!!!
This happens in any boot mode (normal, developer, recovery).
--
*The factory test for GBB zero flags is gft_clear_gbb_flags.sh, in
src/platform/factory_test_tools
Change-Id: I31a10cc9d562b4b83669ca8a114b60e87ae28b0a
Reviewed-on: https://gerrit.chromium.org/gerrit/11505
Tested-by: Bill Richardson <wfrichar@chromium.org>
Reviewed-by: Gaurav Shah <gauravsh@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Diffstat (limited to 'tests/vboot_api_init_tests.c')
-rw-r--r-- | tests/vboot_api_init_tests.c | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/tests/vboot_api_init_tests.c b/tests/vboot_api_init_tests.c index 0e1d0311..22010c63 100644 --- a/tests/vboot_api_init_tests.c +++ b/tests/vboot_api_init_tests.c @@ -8,6 +8,7 @@ #include <stdio.h> #include <stdlib.h> +#include "gbb_header.h" #include "host_common.h" #include "rollback_index.h" #include "test_common.h" @@ -24,12 +25,20 @@ static VbSharedDataHeader* shared = (VbSharedDataHeader*)shared_data; static uint64_t mock_timer; static int rollback_s3_retval; static int nv_write_called; +static GoogleBinaryBlockHeader gbb; + /* Reset mock data (for use before each test) */ static void ResetMocks(void) { Memset(&cparams, 0, sizeof(cparams)); cparams.shared_data_size = sizeof(shared_data); cparams.shared_data_blob = shared_data; + cparams.gbb_data = &gbb; + + Memset(&gbb, 0, sizeof(gbb)); + gbb.major_version = GBB_MAJOR_VER; + gbb.minor_version = GBB_MINOR_VER; + gbb.flags = 0; Memset(&iparams, 0, sizeof(iparams)); |