diff options
| author | Randall Spangler <rspangler@chromium.org> | 2016-09-09 10:49:37 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2016-09-15 16:16:13 -0700 |
| commit | f87aa72d4b49ff5fa2760227a99d9a5d90e557c1 (patch) | |
| tree | 03a537886887b7751a067baa22da3d0895f62764 /tests/vb21_common2_tests.c | |
| parent | b56b5f8e06b4cc4d4105a8141b3d2b8647eedff6 (diff) | |
| download | vboot-f87aa72d4b49ff5fa2760227a99d9a5d90e557c1.tar.gz | |
tests: Fix coverity warnings
Assorted minor code issues, which we should fix so any new errors stand
out more.
BUG=chromium:643769
BRANCH=none
TEST=make runtests
Change-Id: I927571f8a30794c70228506afe4da3eda86f765b
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/383953
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Diffstat (limited to 'tests/vb21_common2_tests.c')
| -rw-r--r-- | tests/vb21_common2_tests.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/tests/vb21_common2_tests.c b/tests/vb21_common2_tests.c index e4e1e2fc..15e4d505 100644 --- a/tests/vb21_common2_tests.c +++ b/tests/vb21_common2_tests.c @@ -252,14 +252,16 @@ int test_algorithm(int key_algorithm, const char *keys_dir) printf("***Testing algorithm: %s\n", algo_strings[key_algorithm]); - sprintf(filename, "%s/key_rsa%d.pem", keys_dir, rsa_len); + snprintf(filename, sizeof(filename), + "%s/key_rsa%d.pem", keys_dir, rsa_len); TEST_SUCC(vb2_private_key_read_pem(&prik, filename), "Read private key"); prik->hash_alg = hash_alg; prik->sig_alg = sig_alg; vb2_private_key_set_desc(prik, "private key"); - sprintf(filename, "%s/key_rsa%d.keyb", keys_dir, rsa_len); + snprintf(filename, sizeof(filename), + "%s/key_rsa%d.keyb", keys_dir, rsa_len); TEST_SUCC(vb2_public_key_read_keyb(&pubk, filename), "Read public key"); pubk->hash_alg = hash_alg; |