diff options
| author | Julius Werner <jwerner@chromium.org> | 2019-05-07 12:59:47 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-05-14 20:13:04 -0700 |
| commit | 52fa8c11f8e5217e17da74c04e8ad1e5aee9ff40 (patch) | |
| tree | a4894fe06a3f1c9fcbbfe728955f75a8de59ed93 /host/arch | |
| parent | 88a47ff99952bb4f270a4e80c80c578e39fb9477 (diff) | |
| download | vboot-52fa8c11f8e5217e17da74c04e8ad1e5aee9ff40.tar.gz | |
Makefile: Enable more warnings for host utilities / tests
This patch adds a bunch of more warnings that are already enabled in
coreboot and thus already enabled for firmware builds anyway (because
coreboot just passes its CFLAGS through). Enabling it in the vboot
Makefile means they also apply to host utilities and tests, which sounds
desirable for consistency.
Fix enough of the cruft and bad coding practices that accumulated over
the years of not having warnings enabled to get it to build again (this
includes making functions static, removing dead code, cleaning up
prototypes, etc.).
Also remove -fno-strict-aliasing from the x86 firmware build options,
because it's not clear why it's there (coreboot isn't doing this, so
presumably it's not needed).
BRANCH=None
BUG=None
TEST=make runtests
Change-Id: Ie4a42083c4770a4eca133b22725be9ba85b24184
Signed-off-by: Julius Werner <jwerner@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1598721
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Diffstat (limited to 'host/arch')
| -rw-r--r-- | host/arch/arm/lib/crossystem_arch.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/host/arch/arm/lib/crossystem_arch.c b/host/arch/arm/lib/crossystem_arch.c index 4dabb287..8f469653 100644 --- a/host/arch/arm/lib/crossystem_arch.c +++ b/host/arch/arm/lib/crossystem_arch.c @@ -578,7 +578,7 @@ const char* VbGetArchPropertyString(const char* name, char* dest, { char *str = NULL; char *rv = NULL; - char *prop = NULL; + const char *prop = NULL; if (!strcasecmp(name,"arch")) return StrCopy(dest, "arm", size); @@ -617,8 +617,3 @@ int VbSetArchPropertyString(const char* name, const char* value) /* All is handled in arch independent fashion */ return -1; } - -int VbArchInit(void) -{ - return 0; -} |