diff options
author | Randall Spangler <rspangler@chromium.org> | 2016-09-28 11:54:20 -0700 |
---|---|---|
committer | chrome-bot <chrome-bot@chromium.org> | 2016-10-01 00:04:39 -0700 |
commit | 770202f0c745d68f2635dbb8d0f0765aae75a087 (patch) | |
tree | 46d29849be392aed1a168e0f291ab98a210dca8d /futility | |
parent | fefc682bb70d7fd997f4ef0079e8fec0a4937cf7 (diff) | |
download | vboot-770202f0c745d68f2635dbb8d0f0765aae75a087.tar.gz |
Fix more coverity warnings
Assorted minor code issues, which we should fix so any new errors stand
out more.
BUG=chromium:643769
BRANCH=none
TEST=make runtests
Change-Id: I82ece2de948ef224115c408bdfc09445d3da119b
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/390337
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Diffstat (limited to 'futility')
-rw-r--r-- | futility/cmd_create.c | 5 | ||||
-rw-r--r-- | futility/cmd_vbutil_key.c | 1 |
2 files changed, 5 insertions, 1 deletions
diff --git a/futility/cmd_create.c b/futility/cmd_create.c index 578e3be5..bdec20b5 100644 --- a/futility/cmd_create.c +++ b/futility/cmd_create.c @@ -184,7 +184,10 @@ static int vb2_make_keypair() if (!rsa_key) { /* Check if the PEM contains only a public key */ - fseek(fp, 0, SEEK_SET); + if (0 != fseek(fp, 0, SEEK_SET)) { + fprintf(stderr, "Error seeking in %s\n", infile); + goto done; + } rsa_key = PEM_read_RSA_PUBKEY(fp, NULL, NULL, NULL); } fclose(fp); diff --git a/futility/cmd_vbutil_key.c b/futility/cmd_vbutil_key.c index 4362255d..bc013127 100644 --- a/futility/cmd_vbutil_key.c +++ b/futility/cmd_vbutil_key.c @@ -86,6 +86,7 @@ static int do_pack(const char *infile, const char *outfile, uint32_t algorithm, if (pubkey) { if (0 != vb2_write_packed_key(outfile, pubkey)) { fprintf(stderr, "vbutil_key: Error writing key.\n"); + free(pubkey); return 1; } free(pubkey); |