diff options
| author | Julius Werner <jwerner@chromium.org> | 2020-01-21 15:40:59 -0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-01-25 05:39:33 +0000 |
| commit | f57ad98c29072624bf0977ab972201595efd2b38 (patch) | |
| tree | 975068bb32cfa08a455ee2bb8bd2fcd2272c8afb /futility/vb1_helper.c | |
| parent | 2c41d5e07900efd02e2d4041837669ec2490fe68 (diff) | |
| download | vboot-f57ad98c29072624bf0977ab972201595efd2b38.tar.gz | |
Enable format string warnings for vb2ex_printf()stabilize-12859.B
This patch enables the -Wformat warning and tags vb2ex_printf() with the
appropriate attribute so the compiler recognizes it as a printf variant.
This shows a bunch of (sometimes pretty bad) issues in existing code
that are hereby fixed.
Cannot enable -Wformat-security yet since a lot of code still uses
non-constant format strings and it's unclear whether we can/want to
change that in all circumstances (e.g. stuff like DoError()).
BRANCH=None
BUG=None
TEST=make runtests
Change-Id: I917a4982a97a668a5c0f793f7c771573f2bd3949
Signed-off-by: Julius Werner <jwerner@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2013857
Diffstat (limited to 'futility/vb1_helper.c')
| -rw-r--r-- | futility/vb1_helper.c | 24 |
1 files changed, 12 insertions, 12 deletions
diff --git a/futility/vb1_helper.c b/futility/vb1_helper.c index 74391827..cdc39251 100644 --- a/futility/vb1_helper.c +++ b/futility/vb1_helper.c @@ -185,8 +185,8 @@ static int PickApartVmlinuz(uint8_t *kernel_buf, } kernel32_size = kernel_size - kernel32_start; - VB2_DEBUG(" kernel16_start=0x%" PRIx64 "\n", 0); - VB2_DEBUG(" kernel16_size=0x%" PRIx64 "\n", kernel32_start); + VB2_DEBUG(" kernel16_start=%#x\n", 0); + VB2_DEBUG(" kernel16_size=%#x\n", kernel32_start); /* Copy the original zeropage data from kernel_buf into * g_param_data, then tweak a few fields for our purposes */ @@ -221,8 +221,8 @@ static int PickApartVmlinuz(uint8_t *kernel_buf, break; } - VB2_DEBUG(" kernel32_start=0x%" PRIx64 "\n", kernel32_start); - VB2_DEBUG(" kernel32_size=0x%" PRIx64 "\n", kernel32_size); + VB2_DEBUG(" kernel32_start=%#x\n", kernel32_start); + VB2_DEBUG(" kernel32_size=%#x\n", kernel32_size); /* Keep just the 32-bit kernel. */ if (kernel32_size) { @@ -461,7 +461,7 @@ int WriteSomeParts(const char *outfile, FILE *f; /* Write the output file */ - VB2_DEBUG("writing %s with 0x%" PRIx64 ", 0x%" PRIx64 "\n", + VB2_DEBUG("writing %s with %#x, %#x\n", outfile, part1_size, part2_size); f = fopen(outfile, "wb"); @@ -674,7 +674,7 @@ uint8_t *CreateKernelBlob(uint8_t *vmlinuz_buf, uint32_t vmlinuz_size, * devices. */ g_kernel_blob_size = roundup(g_kernel_blob_size, CROS_ALIGN); - VB2_DEBUG("g_kernel_blob_size 0x%" PRIx64 "\n", g_kernel_blob_size); + VB2_DEBUG("g_kernel_blob_size %#x\n", g_kernel_blob_size); /* Allocate space for the blob. */ g_kernel_blob_data = malloc(g_kernel_blob_size); @@ -682,22 +682,22 @@ uint8_t *CreateKernelBlob(uint8_t *vmlinuz_buf, uint32_t vmlinuz_size, /* Assign the sub-pointers */ g_kernel_data = g_kernel_blob_data + now; - VB2_DEBUG("g_kernel_size 0x%" PRIx64 " ofs 0x%" PRIx64 "\n", + VB2_DEBUG("g_kernel_size %#x ofs %#x\n", g_kernel_size, now); now += roundup(g_kernel_size, CROS_ALIGN); g_config_data = g_kernel_blob_data + now; - VB2_DEBUG("g_config_size 0x%" PRIx64 " ofs 0x%" PRIx64 "\n", + VB2_DEBUG("g_config_size %#x ofs %#x\n", g_config_size, now); now += g_config_size; g_param_data = g_kernel_blob_data + now; - VB2_DEBUG("g_param_size 0x%" PRIx64 " ofs 0x%" PRIx64 "\n", + VB2_DEBUG("g_param_size %#x ofs %#x\n", g_param_size, now); now += g_param_size; g_bootloader_data = g_kernel_blob_data + now; - VB2_DEBUG("g_bootloader_size 0x%" PRIx64 " ofs 0x%" PRIx64 "\n", + VB2_DEBUG("g_bootloader_size %#x ofs %#x\n", g_bootloader_size, now); g_ondisk_bootloader_addr = kernel_body_load_address + now; VB2_DEBUG("g_ondisk_bootloader_addr 0x%" PRIx64 "\n", @@ -706,14 +706,14 @@ uint8_t *CreateKernelBlob(uint8_t *vmlinuz_buf, uint32_t vmlinuz_size, if (g_vmlinuz_header_size) { g_vmlinuz_header_data = g_kernel_blob_data + now; - VB2_DEBUG("g_vmlinuz_header_size 0x%" PRIx64 " ofs 0x%" PRIx64 "\n", + VB2_DEBUG("g_vmlinuz_header_size %#x ofs %#x\n", g_vmlinuz_header_size, now); g_ondisk_vmlinuz_header_addr = kernel_body_load_address + now; VB2_DEBUG("g_ondisk_vmlinuz_header_addr 0x%" PRIx64 "\n", g_ondisk_vmlinuz_header_addr); } - VB2_DEBUG("end of kern_blob at kern_blob+0x%" PRIx64 "\n", now); + VB2_DEBUG("end of kern_blob at kern_blob+%#x\n", now); /* Copy the kernel and params bits into the correct places */ if (0 != PickApartVmlinuz(vmlinuz_buf, vmlinuz_size, |