diff options
| author | Julius Werner <jwerner@chromium.org> | 2019-05-07 12:59:47 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-05-14 20:13:04 -0700 |
| commit | 52fa8c11f8e5217e17da74c04e8ad1e5aee9ff40 (patch) | |
| tree | a4894fe06a3f1c9fcbbfe728955f75a8de59ed93 /futility/updater.h | |
| parent | 88a47ff99952bb4f270a4e80c80c578e39fb9477 (diff) | |
| download | vboot-52fa8c11f8e5217e17da74c04e8ad1e5aee9ff40.tar.gz | |
Makefile: Enable more warnings for host utilities / tests
This patch adds a bunch of more warnings that are already enabled in
coreboot and thus already enabled for firmware builds anyway (because
coreboot just passes its CFLAGS through). Enabling it in the vboot
Makefile means they also apply to host utilities and tests, which sounds
desirable for consistency.
Fix enough of the cruft and bad coding practices that accumulated over
the years of not having warnings enabled to get it to build again (this
includes making functions static, removing dead code, cleaning up
prototypes, etc.).
Also remove -fno-strict-aliasing from the x86 firmware build options,
because it's not clear why it's there (coreboot isn't doing this, so
presumably it's not needed).
BRANCH=None
BUG=None
TEST=make runtests
Change-Id: Ie4a42083c4770a4eca133b22725be9ba85b24184
Signed-off-by: Julius Werner <jwerner@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1598721
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Diffstat (limited to 'futility/updater.h')
| -rw-r--r-- | futility/updater.h | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/futility/updater.h b/futility/updater.h index bb30ffb1..57e5b0b7 100644 --- a/futility/updater.h +++ b/futility/updater.h @@ -47,7 +47,7 @@ struct firmware_section { }; struct system_property { - int (*getter)(); + int (*getter)(void); int value; int initialized; }; @@ -106,7 +106,8 @@ struct updater_config { struct updater_config_arguments { char *image, *ec_image, *pd_image; char *archive, *quirks, *mode; - char *programmer, *model, *signature_id; + const char *programmer; + char *model, *signature_id; char *emulation, *sys_props, *write_protection; char *output_dir; char *repack, *unpack; @@ -167,7 +168,7 @@ enum updater_error_codes update_firmware(struct updater_config *cfg); * Allocates and initializes a updater_config object with default values. * Returns the newly allocated object, or NULL on error. */ -struct updater_config *updater_new_config(); +struct updater_config *updater_new_config(void); /* * Releases all resources in an updater configuration object. |