diff options
| author | Andrey Pronin <apronin@chromium.org> | 2016-11-09 15:20:45 -0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2016-11-10 12:25:29 -0800 |
| commit | 6a2f9c5a5873427d9cb40d5f854b37f611d22f8d (patch) | |
| tree | d7d183dbe25a489767ee61db74b5d8225e819b96 /firmware | |
| parent | 7de120208bca600a79b4f879c1b939ae52e061ab (diff) | |
| download | vboot-6a2f9c5a5873427d9cb40d5f854b37f611d22f8d.tar.gz | |
tpm_lite_stub: clean up debug printouts in VbExTpmSendReceive
1) Callers of VbExTpmSendReceive often use the same buffer for
TPM command and response. So, debug-print the command before
sending to avoid it being overwritten with the response before
printing.
2) VbExTpmSendReceive only prints execution time in debug mode.
Execute gettimeofday() only when debug mode is enabled.
3) Avoid printing "DEBUG: " prefix before every byte in the
command/response.
BUG=none
BRANCH=none
TEST=emerge-$BOARD vboot_reference with and without DEBUG=1,
run tpmc commands, check the output.
Change-Id: I1bfe9a21e1a78227996eb7310a3584a9e5b73a87
Reviewed-on: https://chromium-review.googlesource.com/409613
Commit-Ready: Andrey Pronin <apronin@chromium.org>
Tested-by: Andrey Pronin <apronin@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Diffstat (limited to 'firmware')
| -rw-r--r-- | firmware/stub/tpm_lite_stub.c | 41 |
1 files changed, 18 insertions, 23 deletions
diff --git a/firmware/stub/tpm_lite_stub.c b/firmware/stub/tpm_lite_stub.c index c6996df3..71bf73cd 100644 --- a/firmware/stub/tpm_lite_stub.c +++ b/firmware/stub/tpm_lite_stub.c @@ -57,20 +57,18 @@ static VbError_t DoError(VbError_t result, const char* format, ...) return result; } -/* Print |n| bytes from array |a|, with newlines. +/* Print |n| bytes from array |a| to stderr, with newlines. */ -__attribute__((unused)) static void PrintBytes(const uint8_t* a, int n) +__attribute__((unused)) static void DbgPrintBytes(const uint8_t* a, int n) { int i; + fprintf(stderr, "DEBUG: "); for (i = 0; i < n; i++) { - VBDEBUG(("%02x ", a[i])); - if ((i + 1) % 16 == 0) { - VBDEBUG(("\n")); - } - } - if (i % 16 != 0) { - VBDEBUG(("\n")); + if (i && i % 16 == 0) + fprintf(stderr, "\nDEBUG: "); + fprintf(stderr, "%02x ", a[i]); } + fprintf(stderr, "\n"); } @@ -216,27 +214,24 @@ VbError_t VbExTpmSendReceive(const uint8_t* request, uint32_t request_length, #endif VbError_t result; +#ifdef VBOOT_DEBUG struct timeval before, after; + VBDEBUG(("request (%d bytes):\n", request_length)); + DbgPrintBytes(request, request_length); gettimeofday(&before, NULL); +#endif + result = TpmExecute(request, request_length, response, response_length); if (result != VBERROR_SUCCESS) return result; - gettimeofday(&after, NULL); #ifdef VBOOT_DEBUG - { - int x = request_length; - int y = *response_length; - VBDEBUG(("request (%d bytes): ", x)); - PrintBytes(request, 10); - PrintBytes(request + 10, x - 10); - VBDEBUG(("response (%d bytes): ", y)); - PrintBytes(response, 10); - PrintBytes(response + 10, y - 10); - VBDEBUG(("execution time: %dms\n", - (int) ((after.tv_sec - before.tv_sec) * 1000 + - (after.tv_usec - before.tv_usec) / 1000))); - } + gettimeofday(&after, NULL); + VBDEBUG(("response (%d bytes):\n", *response_length)); + DbgPrintBytes(response, *response_length); + VBDEBUG(("execution time: %dms\n", + (int) ((after.tv_sec - before.tv_sec) * 1000 + + (after.tv_usec - before.tv_usec) / 1000))); #endif #ifndef NDEBUG |