diff options
| author | Julius Werner <jwerner@chromium.org> | 2019-10-11 15:22:34 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-10-22 22:03:31 +0000 |
| commit | 5caaa393b4345ea09e2bf4e336d2c30b80376eab (patch) | |
| tree | 170f483d41d3b9ad38e4c1704e7ea62f460c88a2 /firmware/lib/vboot_api_kernel.c | |
| parent | 0320617a0b9abf44eba822e1cb043a87a6e808fe (diff) | |
| download | vboot-5caaa393b4345ea09e2bf4e336d2c30b80376eab.tar.gz | |
firmware: ui: Unify delays, remove DISK/KEY split in recovery mode
The reason for having a separate REC_DISK_DELAY and REC_KEY_DELAY has
long been lost in time... in fact, with our current coreboot firmware
stack, polling for keys will always also poll for disks, so we're
already polling for disks in the inner loop anyway. Removing this
distinction will resolve some weirdness in certain error cases.
An unintended side effect is that the usual recovery mode console spam
goes from annoying at 4 times a second to unbearable at 50 times a
second. Let's just remove it instead and get the console output more in
line with what our developer and BROKEN screens show (i.e. nothing,
unless there's any change or user input).
BRANCH=None
BUG=chromium:1009850
TEST=Booted Kevin
Change-Id: Ie1754646e7d17a661c9adebf43483df1785e6127
Signed-off-by: Julius Werner <jwerner@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1856831
Reviewed-by: Joel Kitching <kitching@chromium.org>
Diffstat (limited to 'firmware/lib/vboot_api_kernel.c')
| -rw-r--r-- | firmware/lib/vboot_api_kernel.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/firmware/lib/vboot_api_kernel.c b/firmware/lib/vboot_api_kernel.c index ad7be645..5f8eeaf9 100644 --- a/firmware/lib/vboot_api_kernel.c +++ b/firmware/lib/vboot_api_kernel.c @@ -62,9 +62,6 @@ vb2_error_t VbTryLoadKernel(struct vb2_context *ctx, uint32_t get_info_flags) uint32_t disk_count = 0; uint32_t i; - VB2_DEBUG("VbTryLoadKernel() start, get_info_flags=0x%x\n", - (unsigned)get_info_flags); - lkp.fwmp = &fwmp; lkp.disk_handle = NULL; @@ -73,8 +70,6 @@ vb2_error_t VbTryLoadKernel(struct vb2_context *ctx, uint32_t get_info_flags) get_info_flags)) disk_count = 0; - VB2_DEBUG("VbTryLoadKernel() found %d disks\n", (int)disk_count); - /* Loop over disks */ for (i = 0; i < disk_count; i++) { VB2_DEBUG("trying disk %d\n", (int)i); |