diff options
| author | Julius Werner <jwerner@chromium.org> | 2019-05-07 12:59:47 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-05-14 20:13:04 -0700 |
| commit | 52fa8c11f8e5217e17da74c04e8ad1e5aee9ff40 (patch) | |
| tree | a4894fe06a3f1c9fcbbfe728955f75a8de59ed93 /firmware/2lib/2rsa.c | |
| parent | 88a47ff99952bb4f270a4e80c80c578e39fb9477 (diff) | |
| download | vboot-52fa8c11f8e5217e17da74c04e8ad1e5aee9ff40.tar.gz | |
Makefile: Enable more warnings for host utilities / tests
This patch adds a bunch of more warnings that are already enabled in
coreboot and thus already enabled for firmware builds anyway (because
coreboot just passes its CFLAGS through). Enabling it in the vboot
Makefile means they also apply to host utilities and tests, which sounds
desirable for consistency.
Fix enough of the cruft and bad coding practices that accumulated over
the years of not having warnings enabled to get it to build again (this
includes making functions static, removing dead code, cleaning up
prototypes, etc.).
Also remove -fno-strict-aliasing from the x86 firmware build options,
because it's not clear why it's there (coreboot isn't doing this, so
presumably it's not needed).
BRANCH=None
BUG=None
TEST=make runtests
Change-Id: Ie4a42083c4770a4eca133b22725be9ba85b24184
Signed-off-by: Julius Werner <jwerner@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1598721
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Diffstat (limited to 'firmware/2lib/2rsa.c')
| -rw-r--r-- | firmware/2lib/2rsa.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/firmware/2lib/2rsa.c b/firmware/2lib/2rsa.c index f54e83c3..5fda9599 100644 --- a/firmware/2lib/2rsa.c +++ b/firmware/2lib/2rsa.c @@ -13,6 +13,7 @@ #include "2common.h" #include "2rsa.h" #include "2sha.h" +#include "vboot_test.h" /** * a[] -= mod @@ -312,6 +313,13 @@ static const uint8_t sha512_tail[] = { 0x05,0x00,0x04,0x40 }; +/** + * Check pkcs 1.5 padding bytes + * + * @param sig Signature to verify + * @param key Key to take signature and hash algorithms from + * @return VB2_SUCCESS, or non-zero if error. + */ int vb2_check_padding(const uint8_t *sig, const struct vb2_public_key *key) { /* Determine padding to use depending on the signature type */ |