diff options
author | Julius Werner <jwerner@chromium.org> | 2019-05-07 12:59:47 -0700 |
---|---|---|
committer | chrome-bot <chrome-bot@chromium.org> | 2019-05-14 20:13:04 -0700 |
commit | 52fa8c11f8e5217e17da74c04e8ad1e5aee9ff40 (patch) | |
tree | a4894fe06a3f1c9fcbbfe728955f75a8de59ed93 /cgpt/cgpt_show.c | |
parent | 88a47ff99952bb4f270a4e80c80c578e39fb9477 (diff) | |
download | vboot-52fa8c11f8e5217e17da74c04e8ad1e5aee9ff40.tar.gz |
Makefile: Enable more warnings for host utilities / tests
This patch adds a bunch of more warnings that are already enabled in
coreboot and thus already enabled for firmware builds anyway (because
coreboot just passes its CFLAGS through). Enabling it in the vboot
Makefile means they also apply to host utilities and tests, which sounds
desirable for consistency.
Fix enough of the cruft and bad coding practices that accumulated over
the years of not having warnings enabled to get it to build again (this
includes making functions static, removing dead code, cleaning up
prototypes, etc.).
Also remove -fno-strict-aliasing from the x86 firmware build options,
because it's not clear why it's there (coreboot isn't doing this, so
presumably it's not needed).
BRANCH=None
BUG=None
TEST=make runtests
Change-Id: Ie4a42083c4770a4eca133b22725be9ba85b24184
Signed-off-by: Julius Werner <jwerner@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1598721
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Diffstat (limited to 'cgpt/cgpt_show.c')
-rw-r--r-- | cgpt/cgpt_show.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/cgpt/cgpt_show.c b/cgpt/cgpt_show.c index 7240a6a7..5f20988b 100644 --- a/cgpt/cgpt_show.c +++ b/cgpt/cgpt_show.c @@ -49,7 +49,8 @@ static void RawDump(const uint8_t *memory, const int size, #define PARTITION_FMT "%12"PRId64"%12"PRId64"%8d %s\n" #define PARTITION_MORE "%12s%12s%8s %s%s\n", "", "", "" -void PrintSignature(const char *indent, const char *sig, size_t n, int raw) { +static void PrintSignature(const char *indent, const char *sig, size_t n, + int raw) { size_t i; printf("%sSig: ", indent); if (!raw) { @@ -162,7 +163,7 @@ void EntryDetails(GptEntry *entry, uint32_t index, int raw) { printf(PARTITION_MORE, "Attr: ", contents); } -void EntriesDetails(struct drive *drive, const int secondary, int raw) { +static void EntriesDetails(struct drive *drive, const int secondary, int raw) { uint32_t i; for (i = 0; i < GetNumberOfEntries(drive); ++i) { |