diff options
| author | Julius Werner <jwerner@chromium.org> | 2019-04-01 15:42:31 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-04-04 15:10:17 -0700 |
| commit | e8f2bbbeeaecc9b545a512ec0bd7d9979c921acf (patch) | |
| tree | 6aa3c3605408b77ba061fd2ccf313c9119a82c48 | |
| parent | 70ba5afd959e0c3d40c6d6d651302be18f19ebd9 (diff) | |
| download | vboot-e8f2bbbeeaecc9b545a512ec0bd7d9979c921acf.tar.gz | |
VbDisplayDebugInfo: Don't redraw screen
VbDisplayDebugInfo() currently redraws the screen before displaying
debug info for no apparent reason. This should generally not be
necessary because the debug output doesn't tend to change, so redrawing
it over old debug output works fine on its own. Removing this gets rid
of an unnecessary flicker.
BRANCH=None
BUG=None
TEST=Hit Tab a few times on Kevin, flicker is less noticable.
Change-Id: I1e82ece1d25274461fa306c0ab821251a90a2692
Signed-off-by: Julius Werner <jwerner@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1548302
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
| -rw-r--r-- | firmware/lib/vboot_display.c | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/firmware/lib/vboot_display.c b/firmware/lib/vboot_display.c index f9c520da..e7359460 100644 --- a/firmware/lib/vboot_display.c +++ b/firmware/lib/vboot_display.c @@ -284,15 +284,6 @@ VbError_t VbDisplayDebugInfo(struct vb2_context *ctx) VbError_t ret; uint32_t i; - /* Redisplay current screen to overwrite any previous debug output. - * Need to use VbDisplayMenu instead of VbDisplayScreen - * in order to ensure that the selected menu item is - * highlighted. On a non-detachable screen, this will be a - * no-op. - */ - VbDisplayMenu(ctx, disp_current_screen, 1, - disp_current_index, disp_disabled_idx_mask); - /* Add hardware ID */ VbGbbReadHWID(ctx, hwid, sizeof(hwid)); used += StrnAppend(buf + used, "HWID: ", DEBUG_INFO_SIZE - used); |