diff options
| author | Mike Frysinger <vapier@chromium.org> | 2016-08-16 13:43:45 -0400 |
|---|---|---|
| committer | Mike Frysinger <vapier@chromium.org> | 2016-08-16 17:47:47 +0000 |
| commit | 59c4501d8ebe5c574205af0d16f5d4f63b3f9121 (patch) | |
| tree | fff2ad1ebb0216150d67cf8a8ab59e5de9c44f99 | |
| parent | 7573ff7efb99d93274305f69ea07b505f3921a57 (diff) | |
| download | vboot-59c4501d8ebe5c574205af0d16f5d4f63b3f9121.tar.gz | |
image_signing: avoid leaking rootfs mount in android code
When we return early from the release check, we leaked the mount point.
This could in turn cause issues with data syncing and hash calculation.
BUG=b:30891460
TEST=None
BRANCH=None
Change-Id: I7a40007e371b8e64ca7e8210ad9121dc1a4bcf9f
Reviewed-on: https://chromium-review.googlesource.com/370739
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
| -rwxr-xr-x | scripts/image_signing/sign_official_build.sh | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/scripts/image_signing/sign_official_build.sh b/scripts/image_signing/sign_official_build.sh index badfaa92..173dd6b5 100755 --- a/scripts/image_signing/sign_official_build.sh +++ b/scripts/image_signing/sign_official_build.sh @@ -610,6 +610,7 @@ resign_android_image_if_exists() { "${rootfs_dir}/etc/lsb-release" | cut -d= -f2) if [[ "${milestone}" -le 53 ]]; then info "Not signing Android apks before 53 (incl.). Current: ${milestone}." + sudo umount "${rootfs_dir}" return fi |