diff options
| author | Joel Kitching <kitching@google.com> | 2020-02-14 16:00:46 +0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-03-02 06:48:58 +0000 |
| commit | 22f4e12652bacdf260f94c619438bdeebc607c94 (patch) | |
| tree | ba214392b75c9d958eb2583fc81e78fe889897bc | |
| parent | 8f4737628e96b7547b4166c700b218dafb0c5349 (diff) | |
| download | vboot-22f4e12652bacdf260f94c619438bdeebc607c94.tar.gz | |
vboot: remove NEED_VB20_INTERNALS
Since the name is somewhat inaccurate, and since we want to make
it slightly clearer that it should not be used, remove
NEED_VB20_INTERNALS in favour of directly using a separate header
file. The new header file is called vb2_internals_please_do_not_use.h.
BUG=b:124141368, chromium:957880
TEST=make clean && make runtests
BRANCH=none
Change-Id: Icf67eed2d9ae3448387f6c1fbae1501ff6fa5d52
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2055601
Commit-Queue: Joel Kitching <kitching@chromium.org>
Tested-by: Joel Kitching <kitching@chromium.org>
Reviewed-by: Julius Werner <jwerner@chromium.org>
| -rw-r--r-- | firmware/include/vb2_api.h | 20 |
1 files changed, 0 insertions, 20 deletions
diff --git a/firmware/include/vb2_api.h b/firmware/include/vb2_api.h index 0dfc3ddc..a0ad7bdd 100644 --- a/firmware/include/vb2_api.h +++ b/firmware/include/vb2_api.h @@ -9,12 +9,6 @@ * Using vb2_api.h as the single point of contact between calling firmware and * vboot allows subsequent refactoring of vboot (renaming of headers, etc.) * without churning other projects' source code. - * - * #define NEED_VB20_INTERNALS - * Allows the caller to peek into vboot2 data structures, by including a - * specific set of extra header files listed in vb2_api.h. Including this - * switch means the caller is broken and should be fixed. The existence of - * this switch is a bug, and it should be removed when it is no longer used. */ #ifndef VBOOT_REFERENCE_VB2_API_H_ @@ -23,18 +17,4 @@ /* Standard APIs */ #include "../2lib/include/2api.h" -/* - * Coreboot should not need access to vboot2 internals. But right now it does. - * At least this forces it to do so through a relatively narrow hole so vboot2 - * refactoring can continue. - * - * Please do not rip this into a wider hole, or expect this hole to continue. - * - * TODO: Make cleaner APIs to this stuff. - */ -#ifdef NEED_VB20_INTERNALS -#include "../2lib/include/2misc.h" /* for vb2_get_sd() */ -#include "../2lib/include/2struct.h" /* for vb2_shared_data struct */ -#endif - #endif /* VBOOT_REFERENCE_VB2_API_H_ */ |