diff options
| author | Hung-Te Lin <hungte@chromium.org> | 2019-03-29 10:35:45 +0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-04-10 18:07:08 -0700 |
| commit | 516732f868a0c4bade1e718875b3779d3361c72f (patch) | |
| tree | 0c264df6e1bd6abdfbeeaf0209209145d7b81f24 | |
| parent | b9860af322a4c20a9504879b2a944f26e60be238 (diff) | |
| download | vboot-516732f868a0c4bade1e718875b3779d3361c72f.tar.gz | |
futility: updater: report flashrom error code
When flashrom execution failed, it is not very easy to debug what went
wrong especially when loading system active firmware (-r).
The log may say SUCCEED (or no obvious error) and updater simply reports
failure. Reporting the returned termination status should help.
BUG=chromium:943262
TEST=make futil; tests/futility/run_test_scripts.sh $(pwd)/build/futility
BRANCH=None
Change-Id: I4ea09b3d62ebf77eda98084accac582f841e7f7a
Signed-off-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1545590
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
| -rw-r--r-- | futility/updater.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/futility/updater.c b/futility/updater.c index c737f16f..d68a3cff 100644 --- a/futility/updater.c +++ b/futility/updater.c @@ -313,6 +313,8 @@ static int host_flashrom(enum flashrom_ops op, const char *image_path, if (op != FLASHROM_WP_STATUS) { r = system(command); free(command); + if (r) + ERROR("Error code: %d", r); return r; } |