diff options
| author | Julius Werner <jwerner@chromium.org> | 2020-03-23 13:00:25 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-03-27 23:45:05 +0000 |
| commit | 804f7add39971816a5b2816c84376bc9d4f2d1da (patch) | |
| tree | 9a74b2d3b709c7f0c2746a3a43d8002b1047bcc2 | |
| parent | 2399eb9dfba2196f1a8537963e4c312555ef18fe (diff) | |
| download | vboot-804f7add39971816a5b2816c84376bc9d4f2d1da.tar.gz | |
Makefile: Explicitly signal success at the end of 'make runtests'
If you run 'make runtests' with -j (as you should because it takes
forever), it can be hard to see if it passed successfully. A 'make: ***
[Makefile:XXX: ...] Error 255' line might hide somewhere in the middle
with a lot of successful output from other tests running in parallel
hiding it.
It's hard (I think?) to have make output something at the end (after
joining all processes) when it has encountered an error, but at least it
is easy to output something when the 'runtests' target finishes
successfully. This patch adds such a highly visible success message, so
that its absence will make it clear that there was an error further up.
BRANCH=None
BUG=None
TEST='make runtests', both passing and failing
Signed-off-by: Julius Werner <jwerner@chromium.org>
Change-Id: If979a7635f5c05c44a92daca12d31e344563794c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2116750
Reviewed-by: Joel Kitching <kitching@chromium.org>
| -rw-r--r-- | Makefile | 3 |
1 files changed, 3 insertions, 0 deletions
@@ -1261,8 +1261,11 @@ runlongtests: install_for_test genkeys genfuzztestcases .PHONY: rununittests rununittests: runcgpttests runmisctests run2tests +# Print a big green success message at the end of all tests. If you don't see +# that, you know there was an error somewhere further up. .PHONY: runtests runtests: rununittests runtestscripts runfutiltests + ${Q}echo -e "\nruntests: \E[32;1mALL TESTS PASSED SUCCESSFULLY!\E[0;m\n" # Code coverage .PHONY: coverage_init |