diff options
| author | Joel Kitching <kitching@google.com> | 2019-06-25 15:51:30 +0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-06-26 14:24:45 +0000 |
| commit | 000ae5faa84c52e85e5d36b8e755257def90de5c (patch) | |
| tree | 522d629dc3dd4d69e95a2c34454f70f83cfbbb8c | |
| parent | b2ba31fcb178d647fc6ac64b3babe8b3ac503c82 (diff) | |
| download | vboot-000ae5faa84c52e85e5d36b8e755257def90de5c.tar.gz | |
vboot: remove unused CombineUint16Pair function
BUG=b:124141368
TEST=make clean && make runtests
BRANCH=none
Change-Id: Ifd7dcc1414248b025a8a4bc2942db11814bc8be5
Signed-off-by: Joel Kitching <kitching@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1675865
Reviewed-by: Julius Werner <jwerner@chromium.org>
Tested-by: Joel Kitching <kitching@chromium.org>
Commit-Queue: Joel Kitching <kitching@chromium.org>
| -rw-r--r-- | firmware/lib/include/utility.h | 7 | ||||
| -rw-r--r-- | tests/utility_tests.c | 8 |
2 files changed, 0 insertions, 15 deletions
diff --git a/firmware/lib/include/utility.h b/firmware/lib/include/utility.h index e8872492..e5539751 100644 --- a/firmware/lib/include/utility.h +++ b/firmware/lib/include/utility.h @@ -22,13 +22,6 @@ #define VbAssert(expr) #endif -/* - * Combine [msw] and [lsw] uint16s to a uint32_t with its [msw] and [lsw] - * forming the most and least signficant 16-bit words. - */ -#define CombineUint16Pair(msw,lsw) (((uint32_t)(msw) << 16) | \ - (((lsw)) & 0xFFFF)) - /* Return the minimum of (a) or (b). */ #define Min(a, b) (((a) < (b)) ? (a) : (b)) diff --git a/tests/utility_tests.c b/tests/utility_tests.c index 88fe1194..5e22339f 100644 --- a/tests/utility_tests.c +++ b/tests/utility_tests.c @@ -21,14 +21,6 @@ static void MacrosTest(void) uint64_t u = (0xABCD00000000ULL); uint64_t v = (0xABCD000000ULL); - TEST_EQ(CombineUint16Pair(1, 2), 0x00010002, "CombineUint16Pair"); - TEST_EQ(CombineUint16Pair(0xFFFE, 0xFFFF), 0xFFFEFFFF, - "CombineUint16Pair 2"); - TEST_EQ(CombineUint16Pair(-4, -16), 0xFFFCFFF0, - "CombineUint16Pair big negative"); - TEST_EQ(CombineUint16Pair(0x10003, 0x10004), 0x00030004, - "CombineUint16Pair overflow"); - TEST_EQ(Min(1, 2), 1, "Min 1"); TEST_EQ(Min(4, 3), 3, "Min 2"); TEST_EQ(Min(5, 5), 5, "Min 5"); |