diff options
author | Joel Kitching <kitching@google.com> | 2019-01-11 19:15:42 +0800 |
---|---|---|
committer | chrome-bot <chrome-bot@chromium.org> | 2019-02-14 05:27:16 -0800 |
commit | 5113be71daaf3d6e7d5f4a9a0c7335370220680f (patch) | |
tree | 6bc0c24fbb090369f6a6cd4046136946af02bb76 | |
parent | 5b2159a6bbe5b1ecb7fba2654cab82aa8643a6c5 (diff) | |
download | vboot-5113be71daaf3d6e7d5f4a9a0c7335370220680f.tar.gz |
vboot: rename VB2_SD_DEV_MODE_ENABLED
Rename VB2_SD_DEV_MODE_ENABLED to VB2_SD_FLAG_DEV_MODE_ENABLED.
Flag name should be consistent with others in vb2_shared_data_flags.
VB2_SD_DEV_MODE_ENABLED should be removed in subsequent CL.
BUG=b:124141368
TEST=Build locally
BRANCH=none
Change-Id: I301a43ac6bc7c825a7cb9f9b47f57ed330ba2294
Reviewed-on: https://chromium-review.googlesource.com/1460644
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Joel Kitching <kitching@chromium.org>
Tested-by: Julius Werner <jwerner@chromium.org>
Reviewed-by: Joel Kitching <kitching@chromium.org>
Reviewed-by: Julius Werner <jwerner@chromium.org>
-rw-r--r-- | firmware/2lib/2misc.c | 2 | ||||
-rw-r--r-- | firmware/2lib/include/2struct.h | 3 | ||||
-rw-r--r-- | tests/vb2_misc_tests.c | 22 |
3 files changed, 14 insertions, 13 deletions
diff --git a/firmware/2lib/2misc.c b/firmware/2lib/2misc.c index 9e4d3297..0878279b 100644 --- a/firmware/2lib/2misc.c +++ b/firmware/2lib/2misc.c @@ -269,7 +269,7 @@ int vb2_check_dev_switch(struct vb2_context *ctx) /* Handle whichever mode we end up in */ if (is_dev) { /* Developer mode */ - sd->flags |= VB2_SD_DEV_MODE_ENABLED; + sd->flags |= VB2_SD_FLAG_DEV_MODE_ENABLED; ctx->flags |= VB2_CONTEXT_DEVELOPER_MODE; flags |= VB2_SECDATA_FLAG_LAST_BOOT_DEVELOPER; diff --git a/firmware/2lib/include/2struct.h b/firmware/2lib/include/2struct.h index 1d5b353f..0a5c1e21 100644 --- a/firmware/2lib/include/2struct.h +++ b/firmware/2lib/include/2struct.h @@ -31,7 +31,8 @@ enum vb2_shared_data_flags { VB2_SD_FLAG_MANUAL_RECOVERY = (1 << 0), /* Developer mode is enabled */ - /* TODO: should have been VB2_SD_FLAG_DEV_MODE_ENABLED */ + VB2_SD_FLAG_DEV_MODE_ENABLED = (1 << 1), + /* Deprecated name; remove */ VB2_SD_DEV_MODE_ENABLED = (1 << 1), /* diff --git a/tests/vb2_misc_tests.c b/tests/vb2_misc_tests.c index 4186ed59..9089d3da 100644 --- a/tests/vb2_misc_tests.c +++ b/tests/vb2_misc_tests.c @@ -300,7 +300,7 @@ static void dev_switch_tests(void) /* Normal mode */ reset_common_data(); TEST_SUCC(vb2_check_dev_switch(&cc), "dev mode off"); - TEST_EQ(sd->flags & VB2_SD_DEV_MODE_ENABLED, 0, " sd not in dev"); + TEST_EQ(sd->flags & VB2_SD_FLAG_DEV_MODE_ENABLED, 0, " sd not in dev"); TEST_EQ(cc.flags & VB2_CONTEXT_DEVELOPER_MODE, 0, " ctx not in dev"); TEST_EQ(mock_tpm_clear_called, 0, " no tpm clear"); TEST_EQ(vb2_nv_get(&cc, VB2_NV_REQ_WIPEOUT), 0, " no nv wipeout"); @@ -311,7 +311,7 @@ static void dev_switch_tests(void) (VB2_SECDATA_FLAG_DEV_MODE | VB2_SECDATA_FLAG_LAST_BOOT_DEVELOPER)); TEST_SUCC(vb2_check_dev_switch(&cc), "dev mode on"); - TEST_NEQ(sd->flags & VB2_SD_DEV_MODE_ENABLED, 0, " sd in dev"); + TEST_NEQ(sd->flags & VB2_SD_FLAG_DEV_MODE_ENABLED, 0, " sd in dev"); TEST_NEQ(cc.flags & VB2_CONTEXT_DEVELOPER_MODE, 0, " ctx in dev"); TEST_EQ(mock_tpm_clear_called, 0, " no tpm clear"); @@ -363,7 +363,7 @@ static void dev_switch_tests(void) VB2_SECDATA_FLAG_LAST_BOOT_DEVELOPER)); vb2_nv_set(&cc, VB2_NV_DISABLE_DEV_REQUEST, 1); TEST_SUCC(vb2_check_dev_switch(&cc), "disable dev request"); - TEST_EQ(sd->flags & VB2_SD_DEV_MODE_ENABLED, 0, " sd not in dev"); + TEST_EQ(sd->flags & VB2_SD_FLAG_DEV_MODE_ENABLED, 0, " sd not in dev"); TEST_EQ(vb2_nv_get(&cc, VB2_NV_DISABLE_DEV_REQUEST), 0, " request cleared"); @@ -371,7 +371,7 @@ static void dev_switch_tests(void) reset_common_data(); sd->gbb_flags |= VB2_GBB_FLAG_FORCE_DEV_SWITCH_ON; TEST_SUCC(vb2_check_dev_switch(&cc), "dev on via gbb"); - TEST_NEQ(sd->flags & VB2_SD_DEV_MODE_ENABLED, 0, " sd in dev"); + TEST_NEQ(sd->flags & VB2_SD_FLAG_DEV_MODE_ENABLED, 0, " sd in dev"); vb2_secdata_get(&cc, VB2_SECDATA_FLAGS, &v); TEST_EQ(v, VB2_SECDATA_FLAG_LAST_BOOT_DEVELOPER, " doesn't set dev on in secdata but does set last boot dev"); @@ -381,7 +381,7 @@ static void dev_switch_tests(void) reset_common_data(); cc.flags |= VB2_CONTEXT_FORCE_DEVELOPER_MODE; TEST_SUCC(vb2_check_dev_switch(&cc), "dev on via ctx flag"); - TEST_NEQ(sd->flags & VB2_SD_DEV_MODE_ENABLED, 0, " sd in dev"); + TEST_NEQ(sd->flags & VB2_SD_FLAG_DEV_MODE_ENABLED, 0, " sd in dev"); vb2_secdata_get(&cc, VB2_SECDATA_FLAGS, &v); TEST_EQ(v, VB2_SECDATA_FLAG_LAST_BOOT_DEVELOPER, " doesn't set dev on in secdata but does set last boot dev"); @@ -394,7 +394,7 @@ static void dev_switch_tests(void) VB2_SECDATA_FLAG_LAST_BOOT_DEVELOPER)); cc.flags |= VB2_DISABLE_DEVELOPER_MODE; TEST_SUCC(vb2_check_dev_switch(&cc), "disable dev on ctx request"); - TEST_EQ(sd->flags & VB2_SD_DEV_MODE_ENABLED, 0, " sd not in dev"); + TEST_EQ(sd->flags & VB2_SD_FLAG_DEV_MODE_ENABLED, 0, " sd not in dev"); /* Simulate clear owner failure */ reset_common_data(); @@ -421,7 +421,7 @@ static void dev_switch_tests(void) sd->status &= ~VB2_SD_STATUS_SECDATA_INIT; TEST_EQ(vb2_check_dev_switch(&cc), VB2_ERROR_SECDATA_GET_UNINITIALIZED, "secdata fail normal"); - TEST_EQ(sd->flags & VB2_SD_DEV_MODE_ENABLED, 0, " sd not in dev"); + TEST_EQ(sd->flags & VB2_SD_FLAG_DEV_MODE_ENABLED, 0, " sd not in dev"); TEST_EQ(cc.flags & VB2_CONTEXT_DEVELOPER_MODE, 0, " ctx not in dev"); /* Secdata failure in recovery mode continues */ @@ -429,7 +429,7 @@ static void dev_switch_tests(void) cc.flags |= VB2_CONTEXT_RECOVERY_MODE; sd->status &= ~VB2_SD_STATUS_SECDATA_INIT; TEST_SUCC(vb2_check_dev_switch(&cc), "secdata fail recovery"); - TEST_EQ(sd->flags & VB2_SD_DEV_MODE_ENABLED, 0, " sd not in dev"); + TEST_EQ(sd->flags & VB2_SD_FLAG_DEV_MODE_ENABLED, 0, " sd not in dev"); TEST_EQ(cc.flags & VB2_CONTEXT_DEVELOPER_MODE, 0, " ctx not in dev"); /* And doesn't check or clear dev disable request */ @@ -438,7 +438,7 @@ static void dev_switch_tests(void) sd->status &= ~VB2_SD_STATUS_SECDATA_INIT; vb2_nv_set(&cc, VB2_NV_DISABLE_DEV_REQUEST, 1); TEST_SUCC(vb2_check_dev_switch(&cc), "secdata fail recovery disable"); - TEST_EQ(sd->flags & VB2_SD_DEV_MODE_ENABLED, 0, " sd not in dev"); + TEST_EQ(sd->flags & VB2_SD_FLAG_DEV_MODE_ENABLED, 0, " sd not in dev"); TEST_EQ(cc.flags & VB2_CONTEXT_DEVELOPER_MODE, 0, " ctx not in dev"); TEST_EQ(vb2_nv_get(&cc, VB2_NV_DISABLE_DEV_REQUEST), 1, " request not cleared"); @@ -449,7 +449,7 @@ static void dev_switch_tests(void) sd->status &= ~VB2_SD_STATUS_SECDATA_INIT; sd->gbb_flags |= VB2_GBB_FLAG_FORCE_DEV_SWITCH_ON; TEST_SUCC(vb2_check_dev_switch(&cc), "secdata fail recovery gbb"); - TEST_NEQ(sd->flags & VB2_SD_DEV_MODE_ENABLED, 0, " sd in dev"); + TEST_NEQ(sd->flags & VB2_SD_FLAG_DEV_MODE_ENABLED, 0, " sd in dev"); TEST_NEQ(cc.flags & VB2_CONTEXT_DEVELOPER_MODE, 0, " ctx in dev"); TEST_EQ(mock_tpm_clear_called, 1, " tpm clear"); @@ -459,7 +459,7 @@ static void dev_switch_tests(void) cc.flags |= VB2_CONTEXT_FORCE_DEVELOPER_MODE; sd->status &= ~VB2_SD_STATUS_SECDATA_INIT; TEST_SUCC(vb2_check_dev_switch(&cc), "secdata fail recovery ctx"); - TEST_NEQ(sd->flags & VB2_SD_DEV_MODE_ENABLED, 0, " sd in dev"); + TEST_NEQ(sd->flags & VB2_SD_FLAG_DEV_MODE_ENABLED, 0, " sd in dev"); TEST_NEQ(cc.flags & VB2_CONTEXT_DEVELOPER_MODE, 0, " ctx in dev"); TEST_EQ(mock_tpm_clear_called, 1, " tpm clear"); |