diff options
| author | Hung-Te Lin <hungte@chromium.org> | 2022-06-24 10:40:38 +0800 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2022-06-26 17:28:28 +0000 |
| commit | 5d3a51a6e44a0035d6b9021051591e0a02cad5d8 (patch) | |
| tree | a60bcf53eb125d079438b1569af66dd0d94f55f6 | |
| parent | 3bd83883a08fb16069e89c5f6c1b6353e313184a (diff) | |
| download | vboot-5d3a51a6e44a0035d6b9021051591e0a02cad5d8.tar.gz | |
futility: updater: disable broken '--repack' argument
The `--repack` is actually broken if invoked from futility updater
because libzip does not support SFX, and can't open an empty file.
The right way to repack is to use the --repack from the wrapper script
(e.g., chromeos-firmwareupdate) that it will call zip directly.
BUG=b:236399204
TEST=make; test
BRANCH=none
Change-Id: I0a88bb9d9f16acb49029626da76e92e78fcd331d
Signed-off-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3721657
Reviewed-by: YH Lin <yueherngl@chromium.org>
| -rw-r--r-- | futility/cmd_update.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/futility/cmd_update.c b/futility/cmd_update.c index 51893f6f..bd01cc3c 100644 --- a/futility/cmd_update.c +++ b/futility/cmd_update.c @@ -112,7 +112,6 @@ static void print_help(int argc, char *argv[]) "-t, --try \tTry A/B update on reboot if possible\n" "-a, --archive=PATH \tRead resources from archive\n" " --manifest \tPrint out a JSON manifest and exit\n" - " --repack=DIR \tUpdates archive from DIR\n" " --unpack=DIR \tExtracts archive to DIR\n" "-p, --programmer=PRG\tChange AP (host) flashrom programmer\n" " --fast \tReduce read cycles and do not verify\n" @@ -204,6 +203,8 @@ static int do_update(int argc, char *argv[]) break; case OPT_REPACK: args.repack = optarg; + ERROR("Sorry, --repack is only for the script.\n"); + errorcnt ++; break; case OPT_UNPACK: args.unpack = optarg; |