diff options
| author | Martin Roth <martinroth@google.com> | 2018-02-01 09:37:01 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-02-02 13:19:32 -0800 |
| commit | b5c00dbcba5ab315c7f90bf474143eac4bcfde10 (patch) | |
| tree | cf223985de77e21a963dea3264988968abe2e39c | |
| parent | f41a503e7c9a9fd99168a0b148590f79d7821581 (diff) | |
| download | vboot-b5c00dbcba5ab315c7f90bf474143eac4bcfde10.tar.gz | |
detachables: Ensure menu_idx can't be used uninitalized
This fixes a warning with GCC 6.3:
firmware/lib/vboot_ui_menu.c: In function 'enter_developer_menu':
firmware/lib/vboot_ui_menu.c:211:2: error: 'menu_idx' may be used
uninitialized in this function [-Werror=maybe-uninitialized]
vb2_change_menu(VB_MENU_DEV, menu_idx);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
TEST=Build
BUG=None
BRANCH=None
Change-Id: Idd9449322cccca66d8bd8796a444b9a8ceea9d11
Signed-off-by: Martin Roth <martinroth@google.com>
Reviewed-on: https://chromium-review.googlesource.com/897910
Commit-Ready: Martin Roth <martinroth@chromium.org>
Tested-by: Martin Roth <martinroth@chromium.org>
Reviewed-by: Julius Werner <jwerner@chromium.org>
| -rw-r--r-- | firmware/lib/vboot_ui_menu.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/firmware/lib/vboot_ui_menu.c b/firmware/lib/vboot_ui_menu.c index bdd5686d..bc7ff83b 100644 --- a/firmware/lib/vboot_ui_menu.c +++ b/firmware/lib/vboot_ui_menu.c @@ -198,6 +198,7 @@ static VbError_t enter_developer_menu(struct vb2_context *ctx) { int menu_idx; switch(default_boot) { + default: case VB2_DEV_DEFAULT_BOOT_DISK: menu_idx = VB_DEV_DISK; break; |