diff options
| author | Shawn Nematbakhsh <shawnn@google.com> | 2012-10-30 15:17:33 -0700 |
|---|---|---|
| committer | Simon Glass <sjg@chromium.org> | 2012-11-13 13:52:55 -0800 |
| commit | 086192005e9bc691d80196420f23349d108d6119 (patch) | |
| tree | 3e8c192b3733e2870fb5cb64ab7c1984e5b5f357 | |
| parent | 4b6ca4033965ca4e51ed38e5195db03115698521 (diff) | |
| download | vboot-086192005e9bc691d80196420f23349d108d6119.tar.gz | |
vboot_reference: Fix keyboard input lag at confirm screen.
Changing languages is terribly slow at the confirm screen, when
switching from dev to normal. Reduce sleep time to improve user
experience.
BUG=chrome-os-partner:15726
TEST=boot in dev, hit space, hit arrows rapidly to change language,
observe no lag.
BRANCH=butterfly, stout
Change-Id: I0943debc31d78dcfce87e7f7d4537ae47f5f8cfd
Reviewed-on: https://gerrit.chromium.org/gerrit/36956
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
Reviewed-by: Bill Richardson <wfrichar@chromium.org>
Commit-Ready: Shawn Nematbakhsh <shawnn@google.com>
Tested-by: Shawn Nematbakhsh <shawnn@google.com>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/37939
Tested-by: Simon Glass <sjg@chromium.org>
| -rw-r--r-- | firmware/lib/vboot_api_kernel.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/firmware/lib/vboot_api_kernel.c b/firmware/lib/vboot_api_kernel.c index c97caba7..cb9722a3 100644 --- a/firmware/lib/vboot_api_kernel.c +++ b/firmware/lib/vboot_api_kernel.c @@ -105,6 +105,8 @@ uint32_t VbTryLoadKernel(VbCommonParams* cparams, LoadKernelParams* p, return retval; } +#define CONFIRM_KEY_DELAY 20 /* Check confirm screen keys every 20ms */ + /* Ask the user to confirm something. We should display whatever the question * is first, then call this. ESC is always "no", ENTER is always "yes", and * we'll specify what SPACE means. We don't return until one of those keys is @@ -139,7 +141,7 @@ static int VbUserConfirms(VbCommonParams* cparams, int space_means_no) { default: VbCheckDisplayKey(cparams, key, &vnc); } - VbExSleepMs(1000); + VbExSleepMs(CONFIRM_KEY_DELAY); } /* not reached, but compiler will complain without it */ return -1; |