diff options
author | Manoj Gupta <manojgupta@chromium.org> | 2019-09-07 09:51:31 +0000 |
---|---|---|
committer | Commit Bot <commit-bot@chromium.org> | 2019-09-17 14:54:26 +0000 |
commit | 11ba70b77757db4d34eae8ed3de586416924078e (patch) | |
tree | 708eba1bc06a07edc49b7baabb510795334fe7cc | |
parent | 5cb2e84a191583f0e4d01ee6077404f85531f6c7 (diff) | |
download | vboot-11ba70b77757db4d34eae8ed3de586416924078e.tar.gz |
Revert "Use bfd as the linker to build vboot_reference."
This reverts commit 4856877a76a90ab1851c0e24593ec67e6375a60a.
Reason for revert: Root cause fixed by CL:1790955.
Original change's description:
> Use bfd as the linker to build vboot_reference.
>
> Coreboot uses vboot_reference to build futility as a host binary.
> However, it passes a target path for linking which causes LLD to
> error out.
> e.g. x86_64-pc-linux-clang -L/build/veyron_minnie/usr/lib
> where -L/build/veyron_minnie/usr/lib should not be passed
> as futility is being linked as a host binary.
>
> Use bfd as the linker temporarily as it only produces a warning
> and does not error out.
>
> BUG=chromium:999217
> TEST=coreboot builds
> BRANCH=None
>
> Change-Id: I8716ff3a0b4cc8afc54a3cc95ca5c1bfdcba6c9f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1789676
> Tested-by: Manoj Gupta <manojgupta@chromium.org>
> Reviewed-by: Julius Werner <jwerner@chromium.org>
> Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
Bug: chromium:999217
Change-Id: Ibf69ca06e3ae2e681176499b23c673eda8d77b6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1790956
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Julius Werner <jwerner@chromium.org>
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
-rw-r--r-- | Makefile | 3 |
1 files changed, 1 insertions, 2 deletions
@@ -165,8 +165,7 @@ CFLAGS += -DCHROMEOS_ENVIRONMENT ${COMMON_FLAGS} endif # Needs -Wl because LD is actually set to CC by default. -# Build with bfd linker, https://crbub.com/999217. -LDFLAGS ?= -Wl,--gc-sections -fuse-ld=bfd +LDFLAGS ?= -Wl,--gc-sections ifneq (${DEBUG},) CFLAGS += -DVBOOT_DEBUG |