summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDuncan Laurie <dlaurie@google.com>2018-03-08 19:11:34 -0800
committerChromeOS Commit Bot <chromeos-commit-bot@chromium.org>2018-03-28 23:19:14 +0000
commit546f3f9c0528e967c0ec5e32f57a045290e6eff6 (patch)
tree511b9b1102b05f2e67875bb34db2423fbe13b9ff
parent4cc08a7c9afdf344b5a0471779ee135c810c66e1 (diff)
downloadvboot-546f3f9c0528e967c0ec5e32f57a045290e6eff6.tar.gz
ec_sync: Add recovery reason for aux update failure
Add a distinct recovery reason for aux firmware update failures so we have some visibility into failures in eventlog. This is used by the subsequent commit. BUG=b:74336712 BRANCH=eve TEST=manual: force update failure and ensure device goes to recovery with this reason Change-Id: I7ce2cb454e2e1e94cee5e271899084ed5df3479c Signed-off-by: Duncan Laurie <dlaurie@google.com> Reviewed-on: https://chromium-review.googlesource.com/985394
-rw-r--r--firmware/2lib/include/2recovery_reasons.h3
-rw-r--r--firmware/include/vboot_nvstorage.h2
-rw-r--r--firmware/lib/vboot_display.c2
3 files changed, 7 insertions, 0 deletions
diff --git a/firmware/2lib/include/2recovery_reasons.h b/firmware/2lib/include/2recovery_reasons.h
index 21509298..47af0193 100644
--- a/firmware/2lib/include/2recovery_reasons.h
+++ b/firmware/2lib/include/2recovery_reasons.h
@@ -121,6 +121,9 @@ enum vb2_nv_recovery {
/* Error determining firmware slot */
VB2_RECOVERY_FW_SLOT = 0x2f,
+ /* Error updating AUX firmware */
+ VB2_RECOVERY_AUX_FW_UPDATE = 0x30,
+
/* Unspecified/unknown error in read-only firmware */
VB2_RECOVERY_RO_UNSPECIFIED = 0x3f,
diff --git a/firmware/include/vboot_nvstorage.h b/firmware/include/vboot_nvstorage.h
index 8c7ff9d3..21b0560a 100644
--- a/firmware/include/vboot_nvstorage.h
+++ b/firmware/include/vboot_nvstorage.h
@@ -227,6 +227,8 @@ typedef enum VbFwResult {
#define VBNV_RECOVERY_VB2_DEV_SWITCH 0x2E
/* VB2: Error determining firmware slot */
#define VBNV_RECOVERY_VB2_FW_SLOT 0x2F
+/* VB2: Error updating AUX firmware */
+#define VBNV_RECOVERY_VB2_AUX_FW_UPDATE 0x30
/* Unspecified/unknown error in read-only firmware */
#define VBNV_RECOVERY_RO_UNSPECIFIED 0x3F
/*
diff --git a/firmware/lib/vboot_display.c b/firmware/lib/vboot_display.c
index abf2d698..66eb5bb5 100644
--- a/firmware/lib/vboot_display.c
+++ b/firmware/lib/vboot_display.c
@@ -522,6 +522,8 @@ const char *RecoveryReasonString(uint8_t code)
return "Error reading or updating developer switch";
case VBNV_RECOVERY_VB2_FW_SLOT:
return "Error selecting RW firmware slot";
+ case VBNV_RECOVERY_VB2_AUX_FW_UPDATE:
+ return "Error updating AUX firmware";
case VBNV_RECOVERY_RO_UNSPECIFIED:
return "Unspecified/unknown error in RO firmware";
case VBNV_RECOVERY_RW_DEV_SCREEN: