diff options
| author | David Hendricks <dhendrix@chromium.org> | 2015-04-03 13:23:43 -0700 |
|---|---|---|
| committer | ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> | 2015-04-07 00:52:17 +0000 |
| commit | 95ebdd712e29218e2257c265269c7869c36cb193 (patch) | |
| tree | 86852871ed6647eb8941e4e3af7301f722a73fc3 | |
| parent | 9978e0aa0069697816a38c7dcc6a81be5975cab7 (diff) | |
| download | vboot-95ebdd712e29218e2257c265269c7869c36cb193.tar.gz | |
crossystem: Deprecate ddr-type
AFAICT this property is not really used by anything. All factory
scripts that need detailed memory info get it from mosys. Most
platforms display "unknown" which causes confusion whenever
a bug is filed to support crossystem on a new platform.
BUG=chrome-os-partner:36176
BRANCH=none
TEST=no more "unknown" ddr-type shown in crossystem output on speedy
Signed-off-by: David Hendricks <dhendrix@chromium.org>
Change-Id: I97e66c362e9d88c843128a411512d5a76ac5f87d
Reviewed-on: https://chromium-review.googlesource.com/263982
Reviewed-by: Julius Werner <jwerner@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
| -rw-r--r-- | host/arch/arm/lib/crossystem_arch.c | 2 | ||||
| -rw-r--r-- | host/lib/crossystem.c | 4 | ||||
| -rw-r--r-- | utility/crossystem.c | 1 |
3 files changed, 0 insertions, 7 deletions
diff --git a/host/arch/arm/lib/crossystem_arch.c b/host/arch/arm/lib/crossystem_arch.c index 6cd4f2d2..01e37c04 100644 --- a/host/arch/arm/lib/crossystem_arch.c +++ b/host/arch/arm/lib/crossystem_arch.c @@ -568,8 +568,6 @@ const char* VbGetArchPropertyString(const char* name, char* dest, prop = "firmware-type"; else if (!strcasecmp(name, "ecfw_act")) prop = "active-ec-firmware"; - else if (!strcasecmp(name, "ddr_type")) - prop = "ddr-type"; if (prop) str = ReadFdtString(prop); diff --git a/host/lib/crossystem.c b/host/lib/crossystem.c index 00f4f1d2..af0acc40 100644 --- a/host/lib/crossystem.c +++ b/host/lib/crossystem.c @@ -539,8 +539,6 @@ int VbGetSystemPropertyInt(const char* name) { const char* VbGetSystemPropertyString(const char* name, char* dest, size_t size) { - static const char unknown_string[] = "unknown"; - /* Check architecture-dependent properties first */ if (VbGetArchPropertyString(name, dest, size)) return dest; @@ -562,8 +560,6 @@ const char* VbGetSystemPropertyString(const char* name, char* dest, return GetVdatString(dest, size, VDAT_STRING_LOAD_FIRMWARE_DEBUG); } else if (!strcasecmp(name, "vdat_lkdebug")) { return GetVdatString(dest, size, VDAT_STRING_LOAD_KERNEL_DEBUG); - } else if (!strcasecmp(name, "ddr_type")) { - return unknown_string; } else if (!strcasecmp(name, "fw_try_next")) { return VbGetNvStorage(VBNV_FW_TRY_NEXT) ? "B" : "A"; } else if (!strcasecmp(name, "fw_tried")) { diff --git a/utility/crossystem.c b/utility/crossystem.c index 57eab2fc..a6c2d742 100644 --- a/utility/crossystem.c +++ b/utility/crossystem.c @@ -39,7 +39,6 @@ const Param sys_param_list[] = { {"clear_tpm_owner_done", CAN_WRITE, "Clear TPM owner done"}, {"cros_debug", 0, "OS should allow debug features"}, {"dbg_reset", CAN_WRITE, "Debug reset mode request (writable)"}, - {"ddr_type", IS_STRING, "Type of DDR RAM"}, {"debug_build", 0, "OS image built for debug features"}, {"dev_boot_usb", CAN_WRITE, "Enable developer mode boot from USB/SD (writable)"}, |