diff options
| author | Bill Richardson <wfrichar@chromium.org> | 2011-09-14 10:42:54 -0700 |
|---|---|---|
| committer | Bill Richardson <wfrichar@chromium.org> | 2011-09-14 15:22:23 -0700 |
| commit | ec35beb12846b1cb00111285ffaaa9f95cb22f14 (patch) | |
| tree | 9bd25f02d06eff92740f1dcf50a4f6ebcdbfd1e9 | |
| parent | 518d4f39b4ab5fa7d516de397795bc146250c51b (diff) | |
| download | vboot-ec35beb12846b1cb00111285ffaaa9f95cb22f14.tar.gz | |
Make BIOS screens warn when GBB.flags is nonzero.
BUG=chrome-os-partner:5919
TEST=manual
Until the factory flow has completed, BIOS screens should display a warning
message about GBB.flags. This message should disappear once the flags field
is zero.
You can see the state of the GBB flags in a particular BIOS image using
gbb_utility -g --flags BIOS.bin
And set it with
gbb_utility -s --flags=VALUE BIOS.bin NEWBIOS.bin
Change-Id: I15d336bda571978ece0a9744f19d80f0ae385fb1
Reviewed-on: http://gerrit.chromium.org/gerrit/7719
Tested-by: Bill Richardson <wfrichar@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
| -rw-r--r-- | firmware/lib/vboot_display.c | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/firmware/lib/vboot_display.c b/firmware/lib/vboot_display.c index b09c7748..bd2a93c8 100644 --- a/firmware/lib/vboot_display.c +++ b/firmware/lib/vboot_display.c @@ -308,6 +308,17 @@ VbError_t VbDisplayScreenFromGBB(VbCommonParams* cparams, uint32_t screen, /* Successful if all bitmaps displayed */ retval = VBERROR_SUCCESS; + /* If GBB flags is nonzero, complain because that's something that the + * factory MUST fix before shipping. We only have to do this here, because + * it's obvious that something is wrong if we're not displaying screens from + * the GBB. + */ + if (gbb->major_version == GBB_MAJOR_VER && gbb->minor_version >= 1 && + (gbb->flags != 0)) { + (void)VbExDisplayDebugInfo("GBB.flags is nonzero"); + } + + VbDisplayScreenFromGBB_exit: /* Free the bitmap data copy */ |