summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSimon Glass <sjg@chromium.org>2011-11-11 13:21:12 -0800
committerSimon Glass <sjg@chromium.org>2011-11-14 13:59:14 -0800
commitc25904536f2d8e3fe37860dff0ecc437323b760e (patch)
tree811a8db5aead78c4984566c0b207d563556594cb
parent931728a003a417bcb29cc1c203ce36d23feee9e8 (diff)
downloadvboot-c25904536f2d8e3fe37860dff0ecc437323b760e.tar.gz
Add a few comments and warnings when building incorrectly
The Makefile requires a few defines and isn't very friendly if they are missing. This adds some warnings which should alert as to what is wrong. BUG=chromium-os:16808 TEST=emerge vboot_reference-firmware for tegra2-seaboard, x86-mario Change-Id: Id3b20365cfcc7f0aa7d984b33b6a0906ae0d44a5 Reviewed-on: https://gerrit.chromium.org/gerrit/11548 Reviewed-by: Simon Glass <sjg@chromium.org> Tested-by: Simon Glass <sjg@chromium.org>
-rw-r--r--firmware/Makefile3
-rw-r--r--firmware/stub/include/biosincludes.h4
2 files changed, 7 insertions, 0 deletions
diff --git a/firmware/Makefile b/firmware/Makefile
index f23f1b9e..f56addbd 100644
--- a/firmware/Makefile
+++ b/firmware/Makefile
@@ -2,6 +2,8 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+# This Makefile is designed to be called from the top-level vboot_reference one
+
FWTOP := $(shell pwd)
LIBDIR = $(FWTOP)/lib
STUBDIR = $(FWTOP)/stub
@@ -12,6 +14,7 @@ LIBS = $(FWLIB) # Firmware library must be self-contained
# Disable rollback TPM when compiling locally, since otherwise
# load_kernel_test attempts to talk to the TPM.
ifeq ($(FIRMWARE_ARCH),)
+$(warning FIRMWARE_ARCH not defined, assuming local compile)
CFLAGS += -DDISABLE_ROLLBACK_TPM
endif
diff --git a/firmware/stub/include/biosincludes.h b/firmware/stub/include/biosincludes.h
index 1e610f8c..817edfd0 100644
--- a/firmware/stub/include/biosincludes.h
+++ b/firmware/stub/include/biosincludes.h
@@ -33,6 +33,10 @@ extern void debug(const char *format, ...);
#define POSSIBLY_UNUSED
#define INLINE
+#else
+
+#warning "No FIRMARE_ARCH defined and not TARGET_TEST_MODE"
+
#endif
#endif /*CHROMEOS_SRC_PLATFORM_VBOOT_REFERENCE_FIRMWARE_STUB_BIOSINCLUDES_H_*/