diff options
| author | Patrick Georgi <patrick@georgi-clan.de> | 2014-10-02 10:16:28 +0200 |
|---|---|---|
| committer | Stephen Warren <swarren@nvidia.com> | 2014-10-02 17:07:09 -0600 |
| commit | 57f67537af9cdf34ae9edb76f351c7df277a55b4 (patch) | |
| tree | 64b77a59e45bb8416b6db51bedcd8e25f06348fa | |
| parent | 4bc982c3a8f2a4b21e449fc0db93d46d505f7d95 (diff) | |
| download | nvidia-cbootimage-57f67537af9cdf34ae9edb76f351c7df277a55b4.tar.gz | |
data_layout: fail better on file access errors
fread could return only a partial result
(eg. NVBOOT_CONFIG_TABLE_SIZE_MAX - 1 bytes),
which right now would be accepted and only
resolved by later code.
Found-by: Coverity Scan
Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
Signed-off-by: Stephen Warren <swarren@nvidia.com>
| -rw-r--r-- | src/data_layout.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/data_layout.c b/src/data_layout.c index db0a0f0..11a0761 100644 --- a/src/data_layout.c +++ b/src/data_layout.c @@ -1050,7 +1050,7 @@ int get_bct_size_from_image(build_image_context *context) if (!fp) return ENODATA; - if (!fread(buffer, 1, NVBOOT_CONFIG_TABLE_SIZE_MAX, fp)) { + if (fread(buffer, 1, NVBOOT_CONFIG_TABLE_SIZE_MAX, fp) != NVBOOT_CONFIG_TABLE_SIZE_MAX) { fclose(fp); return ENODATA; } |