diff options
| author | Arthur Heymans <arthur@aheymans.xyz> | 2022-03-23 21:33:15 +0100 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2022-03-25 20:02:25 +0000 |
| commit | cc66ff3043bbd735e86bc9f58d654e4e91115ff5 (patch) | |
| tree | 709d75c12b6ec3bc79fa0918b6e1392ef71b398a /src/northbridge | |
| parent | a24bcce321a51c4f2cc3393fcd3ef2a9d4528205 (diff) | |
| download | coreboot-cc66ff3043bbd735e86bc9f58d654e4e91115ff5.tar.gz | |
amd/fam*/northbridge.c: Fix unused hest variable
The variable actually makes to code look a lot better.
TESTED: BUILD_TIMELESS=1 results in identical binaries
Change-Id: Ie9104e4736a3c30b7592bb0e79a8ddc6af579800
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/63041
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Elyes Haouas <ehaouas@noos.fr>
Diffstat (limited to 'src/northbridge')
| -rw-r--r-- | src/northbridge/amd/agesa/family14/northbridge.c | 6 | ||||
| -rw-r--r-- | src/northbridge/amd/agesa/family15tn/northbridge.c | 6 | ||||
| -rw-r--r-- | src/northbridge/amd/agesa/family16kb/northbridge.c | 6 |
3 files changed, 9 insertions, 9 deletions
diff --git a/src/northbridge/amd/agesa/family14/northbridge.c b/src/northbridge/amd/agesa/family14/northbridge.c index 5a8b24d0bb..77e68d8b24 100644 --- a/src/northbridge/amd/agesa/family14/northbridge.c +++ b/src/northbridge/amd/agesa/family14/northbridge.c @@ -714,9 +714,9 @@ static unsigned long agesa_write_acpi_tables(const struct device *device, /* HEST */ current = ALIGN(current, 8); hest = (acpi_hest_t *)current; - acpi_write_hest((void *)current, acpi_fill_hest); - acpi_add_table(rsdp, (void *)current); - current += ((acpi_header_t *)current)->length; + acpi_write_hest(hest, acpi_fill_hest); + acpi_add_table(rsdp, hest); + current += hest->header.length; /* SRAT */ current = ALIGN(current, 8); diff --git a/src/northbridge/amd/agesa/family15tn/northbridge.c b/src/northbridge/amd/agesa/family15tn/northbridge.c index 6994781407..65be7d8a72 100644 --- a/src/northbridge/amd/agesa/family15tn/northbridge.c +++ b/src/northbridge/amd/agesa/family15tn/northbridge.c @@ -475,9 +475,9 @@ static unsigned long agesa_write_acpi_tables(const struct device *device, /* HEST */ current = ALIGN(current, 8); hest = (acpi_hest_t *)current; - acpi_write_hest((void *)current, acpi_fill_hest); - acpi_add_table(rsdp, (void *)current); - current += ((acpi_header_t *)current)->length; + acpi_write_hest(hest, acpi_fill_hest); + acpi_add_table(rsdp, hest); + current += hest->header.length; current = ALIGN(current, 8); printk(BIOS_DEBUG, "ACPI: * IVRS at %lx\n", current); diff --git a/src/northbridge/amd/agesa/family16kb/northbridge.c b/src/northbridge/amd/agesa/family16kb/northbridge.c index 865f5cfcc3..1c630923c7 100644 --- a/src/northbridge/amd/agesa/family16kb/northbridge.c +++ b/src/northbridge/amd/agesa/family16kb/northbridge.c @@ -469,9 +469,9 @@ static unsigned long agesa_write_acpi_tables(const struct device *device, /* HEST */ current = ALIGN(current, 8); hest = (acpi_hest_t *)current; - acpi_write_hest((void *)current, acpi_fill_hest); - acpi_add_table(rsdp, (void *)current); - current += ((acpi_header_t *)current)->length; + acpi_write_hest(hest, acpi_fill_hest); + acpi_add_table(rsdp, hest); + current += hest->header.length; current = ALIGN(current, 8); printk(BIOS_DEBUG, "ACPI: * IVRS at %lx\n", current); |