summaryrefslogtreecommitdiff
path: root/chip/mchp/lpc.c
blob: 3027cfac9aad4b56c54d00dee2a36452ebe6c2ed (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
/* Copyright 2017 The Chromium OS Authors. All rights reserved.
 * Use of this source code is governed by a BSD-style license that can be
 * found in the LICENSE file.
 */

/* LPC module for MCHP MEC family */

#include "common.h"
#include "acpi.h"
#include "console.h"
#include "gpio.h"
#include "hooks.h"
#include "host_command.h"
#include "keyboard_protocol.h"
#include "lpc.h"
#include "lpc_chip.h"
#include "espi.h"
#include "port80.h"
#include "registers.h"
#include "system.h"
#include "task.h"
#include "timer.h"
#include "util.h"
#include "chipset.h"
#include "tfdp_chip.h"

/* Console output macros */

#define CPUTS(outstr) cputs(CC_LPC, outstr)
#define CPRINTS(format, args...) cprints(CC_LPC, format, ## args)

static uint8_t
mem_mapped[0x200] __attribute__((section(".bss.big_align")));

static struct host_packet lpc_packet;
static struct host_cmd_handler_args host_cmd_args;
static uint8_t host_cmd_flags;   /* Flags from host command */

static uint8_t params_copy[EC_LPC_HOST_PACKET_SIZE] __aligned(4);
static int init_done;

static struct ec_lpc_host_args * const lpc_host_args =
	(struct ec_lpc_host_args *)mem_mapped;

#ifdef CONFIG_BOARD_ID_CMD_ACPI_EC1
static uint8_t custom_acpi_cmd;
static uint8_t custom_acpi_ec2os_cnt;
static uint8_t custom_apci_ec2os[4];
#endif


static void keyboard_irq_assert(void)
{
#ifdef CONFIG_KEYBOARD_IRQ_GPIO
	/*
	 * Enforce signal-high for long enough for the signal to be
	 * pulled high by the external pullup resistor. This ensures the
	 * host will see the following falling edge, regardless of the
	 * line state before this function call.
	 */
	gpio_set_level(CONFIG_KEYBOARD_IRQ_GPIO, 1);
	udelay(4);
	/* Generate a falling edge */
	gpio_set_level(CONFIG_KEYBOARD_IRQ_GPIO, 0);
	udelay(4);

	/* Set signal high, now that we've generated the edge */
	gpio_set_level(CONFIG_KEYBOARD_IRQ_GPIO, 1);
#else
	/*
	 * SERIRQ is automatically sent by KBC
	 */
#endif
}

/**
 * Generate SMI pulse to the host chipset via GPIO.
 *
 * If the x86 is in S0, SMI# is sampled at 33MHz, so minimum pulse length
 * is 60ns. If the x86 is in S3, SMI# is sampled at 32.768KHz, so we need
 * pulse length >61us. Both are short enough and events are infrequent,
 * so just delay for 65us.
 */
static void lpc_generate_smi(void)
{
	/* CPRINTS("LPC Pulse SMI"); */
	trace0(0, LPC, 0, "LPC Pulse SMI");
#ifdef CONFIG_HOSTCMD_ESPI
	/* eSPI: pulse SMI# Virtual Wire low */
	espi_vw_pulse_wire(VW_SMI_L, 0);
#else
	gpio_set_level(GPIO_PCH_SMI_L, 0);
	udelay(65);
	gpio_set_level(GPIO_PCH_SMI_L, 1);
#endif
}

static void lpc_generate_sci(void)
{
	/* CPRINTS("LPC Pulse SCI"); */
	trace0(0, LPC, 0, "LPC Pulse SCI");
#ifdef CONFIG_SCI_GPIO
	gpio_set_level(CONFIG_SCI_GPIO, 0);
	udelay(65);
	gpio_set_level(CONFIG_SCI_GPIO, 1);
#else
#ifdef CONFIG_HOSTCMD_ESPI
	espi_vw_pulse_wire(VW_SCI_L, 0);
#else
	MCHP_ACPI_PM_STS |= 1;
	udelay(65);
	MCHP_ACPI_PM_STS &= ~1;
#endif
#endif
}

/**
 * Update the level-sensitive wake signal to the AP.
 *
 * @param wake_events	Currently asserted wake events
 */
static void lpc_update_wake(host_event_t wake_events)
{
	/*
	 * Mask off power button event, since the AP gets that through a
	 * separate dedicated GPIO.
	 */
	wake_events &= ~EC_HOST_EVENT_MASK(EC_HOST_EVENT_POWER_BUTTON);

#ifdef CONFIG_HOSTCMD_ESPI
	espi_vw_set_wire(VW_WAKE_L, !wake_events);
#else
	/* Signal is asserted low when wake events is non-zero */
	gpio_set_level(GPIO_PCH_WAKE_L, !wake_events);
#endif
}

static uint8_t *lpc_get_hostcmd_data_range(void)
{
	return mem_mapped;
}


/**
 * Update the host event status.
 *
 * Sends a pulse if masked event status becomes non-zero:
 *   - SMI pulse via PCH_SMI_L GPIO
 *   - SCI pulse via PCH_SCI_L GPIO
 */
void lpc_update_host_event_status(void)
{
	int need_sci = 0;
	int need_smi = 0;

	CPRINTS("LPC update_host_event_status");
	trace0(0, LPC, 0, "LPC update_host_event_status");

	if (!init_done)
		return;

	/* Disable LPC interrupt while updating status register */
	task_disable_irq(MCHP_IRQ_ACPIEC0_IBF);

	if (lpc_get_host_events_by_type(LPC_HOST_EVENT_SMI)) {
		/* Only generate SMI for first event */
		if (!(MCHP_ACPI_EC_STATUS(0) & EC_LPC_STATUS_SMI_PENDING))
			need_smi = 1;
		MCHP_ACPI_EC_STATUS(0) |= EC_LPC_STATUS_SMI_PENDING;
	} else {
		MCHP_ACPI_EC_STATUS(0) &= ~EC_LPC_STATUS_SMI_PENDING;
	}

	if (lpc_get_host_events_by_type(LPC_HOST_EVENT_SCI)) {
		/* Generate SCI for every event */
		need_sci = 1;
		MCHP_ACPI_EC_STATUS(0) |= EC_LPC_STATUS_SCI_PENDING;
	} else {
		MCHP_ACPI_EC_STATUS(0) &= ~EC_LPC_STATUS_SCI_PENDING;
	}

	/* Copy host events to mapped memory */
	*(uint32_t *)host_get_memmap(EC_MEMMAP_HOST_EVENTS) =
			lpc_get_host_events();

	task_enable_irq(MCHP_IRQ_ACPIEC0_IBF);

	/* Process the wake events. */
	lpc_update_wake(lpc_get_host_events_by_type(LPC_HOST_EVENT_WAKE));

	/* Send pulse on SMI signal if needed */
	if (need_smi)
		lpc_generate_smi();

	/* ACPI 5.0-12.6.1: Generate SCI for SCI_EVT=1. */
	if (need_sci)
		lpc_generate_sci();
}

static void lpc_send_response(struct host_cmd_handler_args *args)
{
	uint8_t *out;
	int size = args->response_size;
	int csum;
	int i;

	/* Ignore in-progress on LPC since interface is synchronous anyway */
	if (args->result == EC_RES_IN_PROGRESS)
		return;

	/* Handle negative size */
	if (size < 0) {
		args->result = EC_RES_INVALID_RESPONSE;
		size = 0;
	}

	/* New-style response */
	lpc_host_args->flags =
			(host_cmd_flags & ~EC_HOST_ARGS_FLAG_FROM_HOST) |
			EC_HOST_ARGS_FLAG_TO_HOST;

	lpc_host_args->data_size = size;

	csum = args->command + lpc_host_args->flags +
			lpc_host_args->command_version +
			lpc_host_args->data_size;

	for (i = 0, out = (uint8_t *)args->response; i < size; i++, out++)
		csum += *out;

	lpc_host_args->checksum = (uint8_t)csum;

	/* Fail if response doesn't fit in the param buffer */
	if (size > EC_PROTO2_MAX_PARAM_SIZE)
		args->result = EC_RES_INVALID_RESPONSE;

	/* Write result to the data byte. */
	MCHP_ACPI_EC_EC2OS(1, 0) = args->result;

	/* 
	 * Clear processing flag in hardware and
         * sticky status in interrupt aggregator.
	 */
	MCHP_ACPI_EC_STATUS(1) &= ~EC_LPC_STATUS_PROCESSING;
	MCHP_INT_SOURCE(MCHP_ACPI_EC_GIRQ) =
				MCHP_ACPI_EC_IBF_GIRQ_BIT(1);

}

static void lpc_send_response_packet(struct host_packet *pkt)
{
	int i;
	uint8_t *p8;

	/* Ignore in-progress on LPC since interface is synchronous anyway */
	if (pkt->driver_result == EC_RES_IN_PROGRESS) {
		/* CPRINTS("LPC EC_RES_IN_PROGRESS"); */
		return;
	}

	/* CPRINTS("LPC Set EC2OS(1,0)=0x%02x",pkt->driver_result); */
	trace1(0, LPC, 0, "LPC Set EC2OS(1,0)=0x%02x", pkt->driver_result);

	p8 = (uint8_t *)pkt->response;
	if (p8 != NULL) {
		for (i = 0; i < pkt->response_size; i++)
			trace2(0, LPC, 0, "response[%d] = 0x%02x", i, *p8++);
	}

	/* Write result to the data byte. */
	MCHP_ACPI_EC_EC2OS(1, 0) = pkt->driver_result;

	/* Clear the busy bit, so the host knows the EC is done. */
	MCHP_ACPI_EC_STATUS(1) &= ~EC_LPC_STATUS_PROCESSING;
	MCHP_INT_SOURCE(MCHP_ACPI_EC_GIRQ) =
				MCHP_ACPI_EC_IBF_GIRQ_BIT(1);
}

uint8_t *lpc_get_memmap_range(void)
{
	return mem_mapped + 0x100;
}

uint32_t lpc_mem_mapped_addr(void)
{
	return (uint32_t)mem_mapped;
}

void lpc_mem_mapped_init(void)
{
	/* We support LPC args and version 3 protocol */
	*(lpc_get_memmap_range() + EC_MEMMAP_HOST_CMD_FLAGS) =
		EC_HOST_CMD_FLAG_LPC_ARGS_SUPPORTED |
		EC_HOST_CMD_FLAG_VERSION_3;
}


/*
 * Most registers in LPC module are reset when the host is off. We need to
 * set up LPC again when the host is starting up.
 * MCHP does not appear to connect LRESET# to an interrupt!
 * MCHP LRESET# can be one of two pins
 *	GPIO_0052 Func 2
 *	GPIO_0064 Func 1
 * Use GPIO interrupt to detect LRESET# changes.
 * Use GPIO_0064 for LRESET#. Must update board/board_name/gpio.inc
 *
 * For eSPI PLATFORM_RESET# virtual wire is used as LRESET#
 *
 */
#ifndef CONFIG_HOSTCMD_ESPI
static void setup_lpc(void)
{
	gpio_config_module(MODULE_LPC, 1);

	/*
	 * MCHP LRESET# interrupt is GPIO interrupt
	 * and configured by GPIO table in board level gpio.inc
	 * Refer to lpcrst_interrupt() in this file.
	 */

	/* Set up ACPI0 for 0x62/0x66 */
	MCHP_LPC_ACPI_EC0_BAR = 0x00628304;

	/* Clear STATUS_PROCESSING bit in case it was set during sysjump */
	MCHP_ACPI_EC_STATUS(0) &= ~EC_LPC_STATUS_PROCESSING;
	MCHP_INT_ENABLE(MCHP_ACPI_EC_GIRQ) =
			MCHP_ACPI_EC_IBF_GIRQ_BIT(0);
	task_enable_irq(MCHP_IRQ_ACPIEC0_IBF);

	/* Set up ACPI1 for 0x200/0x204 */
	MCHP_LPC_ACPI_EC1_BAR = 0x02008407;

	MCHP_ACPI_EC_STATUS(1) &= ~EC_LPC_STATUS_PROCESSING;
	MCHP_INT_ENABLE(MCHP_ACPI_EC_GIRQ) =
			MCHP_ACPI_EC_IBF_GIRQ_BIT(1);
	task_enable_irq(MCHP_IRQ_ACPIEC1_IBF);

	/* Set up 8042 interface at 0x60/0x64 */
	MCHP_LPC_8042_BAR = 0x00608104;

	/* Set up indication of Auxiliary sts */
	MCHP_8042_KB_CTRL |= 1 << 7;

	MCHP_8042_ACT |= 1;

	MCHP_INT_ENABLE(MCHP_8042_GIRQ) = MCHP_8042_OBE_GIRQ_BIT +
			MCHP_8042_IBF_GIRQ_BIT;

	task_enable_irq(MCHP_IRQ_8042EM_IBF);
	task_enable_irq(MCHP_IRQ_8042EM_OBE);

#ifndef CONFIG_KEYBOARD_IRQ_GPIO
	/* Set up SERIRQ for keyboard */
	MCHP_8042_KB_CTRL |= (1 << 5);
	MCHP_LPC_SIRQ(1) = 0x01;
#endif

	/* Set up EMI module for memory mapped region, base address 0x800 */
	MCHP_LPC_EMI0_BAR = 0x0800800f;

	MCHP_INT_ENABLE(MCHP_EMI_GIRQ) = MCHP_EMI_GIRQ_BIT(0);
	task_enable_irq(MCHP_IRQ_EMI0);

	/*
	 * Access data RAM
	 * MCHP EMI Base address register = physical address of buffer
	 * in SRAM. EMI hardware adds 16-bit offset Host programs into
	 * EC_Address_LSB/MSB registers.
	 */
	MCHP_EMI_MBA0(0) = (uint32_t)mem_mapped;

	/*
	 * Limit EMI read / write range. First 256 bytes are RW for host
	 * commands. Second 256 bytes are RO for mem-mapped data.
	 */
	MCHP_EMI_MRL0(0) = 0x200;
	MCHP_EMI_MWL0(0) = 0x100;

	/* Setup Port80 Debug Hardware ports.
	 * First instance for I/O 80h only.
	 * Set FIFO interrupt threshold to maximum of 14 bytes.
	 */
	MCHP_P80_CFG(0) = MCHP_P80_FLUSH_FIFO_WO +
			MCHP_P80_RESET_TIMESTAMP_WO;

	MCHP_LPC_P80DBG0_BAR = (0x80ul << 16) + 0x01ul;

	MCHP_P80_CFG(0) = MCHP_P80_FIFO_THRHOLD_14 +
			MCHP_P80_TIMEBASE_1500KHZ +
			MCHP_P80_TIMER_ENABLE;

	task_enable_irq(MCHP_IRQ_PORT80DBG0);

	lpc_mem_mapped_init();

	/* Sufficiently initialized */
	init_done = 1;

	/* Update host events now that we can copy them to memmap */
	lpc_update_host_event_status();
}
DECLARE_HOOK(HOOK_CHIPSET_STARTUP, setup_lpc, HOOK_PRIO_FIRST);
#endif

static void lpc_init(void)
{
	CPRINTS("LPC HOOK_INIT");
	trace0(0, HOOK, 0, "HOOK_INIT - lpc_init");

	/* Initialize host args and memory map to all zero */
	memset(lpc_host_args, 0, sizeof(*lpc_host_args));
	memset(lpc_get_memmap_range(), 0, EC_MEMMAP_SIZE);

	/*
	 * Clear PCR sleep enables for peripherals we are using for
	 * both LPC and eSPI.
	 * Global Config, ACPI EC0/1, 8042 Keyboard controller,
	 * Port80 Capture0, and EMI.
	 * NOTE: EMI doesn't have a sleep enable.
	 */
	MCHP_PCR_SLP_DIS_DEV_MASK(2, MCHP_PCR_SLP_EN2_GCFG +
		MCHP_PCR_SLP_EN2_ACPI_EC0 + MCHP_PCR_SLP_EN2_ACPI_EC0 +
		MCHP_PCR_SLP_EN2_MIF8042);

	MCHP_PCR_SLP_DIS_DEV(MCHP_PCR_P80CAP0);

#ifdef CONFIG_HOSTCMD_ESPI

	espi_init();

#else
	/* Clear PCR LPC sleep enable */
	MCHP_PCR_SLP_DIS_DEV(MCHP_PCR_LPC);

	/*
	 * b[8]=1(LRESET# is platform reset), b[0]=0 VCC_PWRGD is
	 * asserted when LRESET# is 1(inactive)
	 */
	MCHP_PCR_PWR_RST_CTL = 0x100ul;

	/* Activate LPC interface */
	MCHP_LPC_ACT |= 1;

	/*
	 * Ring Oscillator not permitted to shut down
	 * until LPC activate bit is cleared
	 */
	MCHP_LPC_EC_CLK_CTRL |= 3;

	setup_lpc();
#endif
}
/*
 * Set priority to higher than default; this way LPC memory mapped data
 * is ready before other inits try to initialize their memmap data.
 */
DECLARE_HOOK(HOOK_INIT, lpc_init, HOOK_PRIO_INIT_LPC);

#ifdef CONFIG_CHIPSET_RESET_HOOK
static void lpc_chipset_reset(void)
{
	hook_notify(HOOK_CHIPSET_RESET);
}
DECLARE_DEFERRED(lpc_chipset_reset);
#endif


void lpc_set_init_done(int val)
{
	init_done = val;
}

/*
 * MCHP MCHP family allows selecting one of two GPIO pins alternate
 * functions as LRESET#.
 * LRESET# can be monitored as bit[1](read-only) of the LPC Bus Monitor
 * register.
 * bit[1]==0 -> LRESET# is high
 * bit[1]==1 -> LRESET# is low (active)
 * LRESET# active causes the EC to activate internal signal RESET_HOST.
 * MCHP_PCR_PWR_RST_STS bit[3](read-only) = RESET_HOST_STATUS =
 * 0 = Reset active
 * 1 = Reset not active
 * MCHP is different than MEC1322 in that LRESET# is not connected
 * to a separate interrupt source.
 * If using LPC the board design must select on of the two GPIO pins
 * dedicated for LRESET# and this pin must be configured in the
 * board level gpio.inc
 */
void lpcrst_interrupt(enum gpio_signal signal)
{
#ifndef CONFIG_HOSTCMD_ESPI
	/* Initialize LPC module when LRESET# is deasserted */
	if (!lpc_get_pltrst_asserted()) {
		setup_lpc();
	} else {
		/* Store port 80 reset event */
		port_80_write(PORT_80_EVENT_RESET);

#ifdef CONFIG_CHIPSET_RESET_HOOK
		/* Notify HOOK_CHIPSET_RESET */
		hook_call_deferred(&lpc_chipset_reset_data, MSEC);
#endif
	}

	CPRINTS("LPC RESET# %sasserted",
		lpc_get_pltrst_asserted() ? "" : "de");
#endif
}


void emi0_interrupt(void)
{
	uint8_t h2e;

	h2e = MCHP_EMI_H2E_MBX(0);
	CPRINTS("LPC Host 0x%02x -> EMI0 H2E(0)", h2e);
	trace1(0, LPC, 0, "EMI0 H2E = 0x%02x", h2e);
	port_80_write(h2e);
}
DECLARE_IRQ(MCHP_IRQ_EMI0, emi0_interrupt, 1);

/*
 * ISR empties BIOS Debug 0 FIFO and
 * writes data to circular buffer. How can we be
 * sure this routine can read the last Port 80h byte?
 */
int port_80_read(void)
{
	int data;

	data = PORT_80_IGNORE;
	if (MCHP_P80_STS(0) & MCHP_P80_STS_NOT_EMPTY)
		data = MCHP_P80_CAP(0) & 0xFF;

	return data;
}

#ifdef CONFIG_BOARD_ID_CMD_ACPI_EC1
/*
 * Handle custom ACPI EC0 commands.
 * Some chipset's CoreBoot will send read board ID command expecting
 * a two byte response.
 */
static int acpi_ec0_custom(int is_cmd, uint8_t value, uint8_t *resultptr)
{
	int rval;

	rval = 0;
	custom_acpi_ec2os_cnt = 0;
	*resultptr = 0x00;

	if (is_cmd && (value == 0x0d)) {
		MCHP_INT_SOURCE(MCHP_ACPI_EC_GIRQ) =
				MCHP_ACPI_EC_OBE_GIRQ_BIT(0);
		/* Write two bytes sequence 0xC2, 0x04 to Host */
		if (MCHP_ACPI_EC_BYTE_CTL(0) & 0x01) {
			trace0(0, LPC, 0,
			     "AEC0 ISR: Cmd 0x0d 4-byte mode. Result=0x04c2");
			/* Host enabled 4-byte mode */
			MCHP_ACPI_EC_EC2OS(0, 0) = 0x02; /* was 0xc2 */
			MCHP_ACPI_EC_EC2OS(0, 1) = 0x04;
			MCHP_ACPI_EC_EC2OS(0, 2) = 0x00;
			MCHP_ACPI_EC_EC2OS(0, 3) = 0x00; /* OBF is set */
		} else {
			trace0(0, LPC, 0,
			  "AEC0 ISR: Cmd 0x0d 1-byte mode. Result=0xc2,0x04");
			/* single byte mode */
			*resultptr = 0x02; /* was 0xc2 */
			custom_acpi_ec2os_cnt = 1;
			custom_apci_ec2os[0] = 0x04;
			MCHP_ACPI_EC_EC2OS(0, 0) = 0x02; /* was 0xc2 */
			MCHP_INT_ENABLE(MCHP_ACPI_EC_GIRQ) =
					MCHP_ACPI_EC_OBE_GIRQ_BIT(0);
			task_enable_irq(MCHP_IRQ_ACPIEC0_OBE);
		}
		custom_acpi_cmd = 0;
		rval = 1;
	}

	return rval;
}
#endif

void acpi_0_interrupt(void)
{
	uint8_t value, result, is_cmd;

	is_cmd = MCHP_ACPI_EC_STATUS(0);

	/* Set the bust bi */
	MCHP_ACPI_EC_STATUS(0) |= EC_LPC_STATUS_PROCESSING;

	result = MCHP_ACPI_EC_BYTE_CTL(0);

	/* Read command/data; this clears the FRMH bit. */
	value = MCHP_ACPI_EC_OS2EC(0, 0);

	/* CPRINTS("ACPI EC0 ISR sts=0x%02x OS2EC=0x%02x ",is_cmd,value); */
	trace3(0, LPC, 0,
	  "AEC0 ISR: sts=0x%02x O2SEC=0x%02x byte_ctrl=0x%02x",
	       is_cmd, value, result);

	is_cmd &= EC_LPC_STATUS_LAST_CMD;

	/* Handle whatever this was. */
	result = 0;
	if (acpi_ap_to_ec(is_cmd, value, &result))
		MCHP_ACPI_EC_EC2OS(0, 0) = result;
#ifdef CONFIG_BOARD_ID_CMD_ACPI_EC1
	else
		acpi_ec0_custom(is_cmd, value, &result);
#endif
	/* Clear the busy bit */
	MCHP_ACPI_EC_STATUS(0) &= ~EC_LPC_STATUS_PROCESSING;

	/* Clear R/W1C status bit in Aggregator */
	MCHP_INT_SOURCE(MCHP_ACPI_EC_GIRQ) =
			MCHP_ACPI_EC_IBF_GIRQ_BIT(0);

	/*
	 * ACPI 5.0-12.6.1: Generate SCI for Input Buffer Empty / Output Buffer
	 * Full condition on the kernel channel.
	 */
	lpc_generate_sci();
}
DECLARE_IRQ(MCHP_IRQ_ACPIEC0_IBF, acpi_0_interrupt, 1);

#ifdef CONFIG_BOARD_ID_CMD_ACPI_EC1
/*
 * ACPI EC0 output buffer empty ISR.
 * Used to handle custom ACPI EC0 command requiring
 * two byte response.
 */
void acpi_0_obe_isr(void)
{
	uint8_t sts, data;

	MCHP_INT_SOURCE(MCHP_ACPI_EC_GIRQ) =
			MCHP_ACPI_EC_OBE_GIRQ_BIT(0);

	sts = MCHP_ACPI_EC_STATUS(0);
	data = MCHP_ACPI_EC_BYTE_CTL(0);
	trace3(0, LPC, 0,
	       "AEC0 OBE ISR: sts=0x%02x bytectrl=0x%02x ec2os_cnt=0x%02x",
	       sts, data, custom_acpi_ec2os_cnt);

	data = sts;
	if (custom_acpi_ec2os_cnt) {
		custom_acpi_ec2os_cnt--;
		data = custom_apci_ec2os[custom_acpi_ec2os_cnt];
		trace1(0, LPC, 0,
		       "AEC0 OBE ISR: write EC2OS(0,0)=0x%02x", data);
		MCHP_ACPI_EC_EC2OS(0, 0) = data;
	}

	if (custom_acpi_ec2os_cnt == 0) { /* was last byte? */
		MCHP_INT_DISABLE(MCHP_ACPI_EC_GIRQ) =
				MCHP_ACPI_EC_OBE_GIRQ_BIT(0);
	}

	lpc_generate_sci();
}
DECLARE_IRQ(MCHP_IRQ_ACPIEC0_OBE, acpi_0_obe_isr, 1);
#endif

void acpi_1_interrupt(void)
{
	const struct ec_host_request *r;

	uint8_t st = MCHP_ACPI_EC_STATUS(1);

	CPRINTS("ACPI EC1 ISR: sts=0x%02x", st);
	trace1(0, LPC, 0, "ACPI EC1 ISR: sts=0x%02x", st);

	if (!(st & EC_LPC_STATUS_FROM_HOST) ||
	    !(st & EC_LPC_STATUS_LAST_CMD))
		return;

	/* Set the busy bit */
	MCHP_ACPI_EC_STATUS(1) |= EC_LPC_STATUS_PROCESSING;

	/*
	 * Read the command byte.  This clears the FRMH bit in
	 * the status byte.
	 */
	host_cmd_args.command = MCHP_ACPI_EC_OS2EC(1, 0);
	CPRINTS("ACPI EC1 ISR: OS2EC0=0x%02x", host_cmd_args.command);
	trace1(0, LPC, 0,
	       "ACPI EC1 ISR OS2EC[0]=0x%02x", host_cmd_args.command);

	host_cmd_args.result = EC_RES_SUCCESS;
	host_cmd_args.send_response = lpc_send_response;
	host_cmd_flags = lpc_host_args->flags;
	
	/* We only support new style command (v3) now */
	if (host_cmd_args.command == EC_COMMAND_PROTOCOL_3) {
		lpc_packet.send_response = lpc_send_response_packet;

		lpc_packet.request = (const void *)lpc_get_hostcmd_data_range();
		lpc_packet.request_temp = params_copy;
		lpc_packet.request_max = sizeof(params_copy);
		/* Don't know the request size so pass in the entire buffer */
		lpc_packet.request_size = EC_LPC_HOST_PACKET_SIZE;

		lpc_packet.response = (void *)lpc_get_hostcmd_data_range();
		lpc_packet.response_max = EC_LPC_HOST_PACKET_SIZE;
		lpc_packet.response_size = 0;

		lpc_packet.driver_result = EC_RES_SUCCESS;

		r = lpc_packet.request;
		CPRINTS("ACPI EC1 Packet Command=0x%04x", r->command);
		trace1(0, LPC, 0,
		       "ACPI EC1 ISR: Packet Cmd = 0x%04x", r->command);

		host_packet_receive(&lpc_packet);

	} else {
		CPRINTS("ACPI EC1 ISR: Invalid protocol");
		trace0(0, LPC, 0, "ACPI EC1 ISR: Invalid protocol");
		/* Old style command unsupported */
		host_cmd_args.result = EC_RES_INVALID_COMMAND;

		/* Hand off to host command handler */
		host_command_received(&host_cmd_args);
	}

	CPRINTS("ACPI EC1 ISR: Exit");
	trace0(0, LPC, 0, "ACPI EC1 ISR: Exit");
}
DECLARE_IRQ(MCHP_IRQ_ACPIEC1_IBF, acpi_1_interrupt, 1);

#ifdef HAS_TASK_KEYPROTO
/*
 * Reading data out of input buffer clears read-only status
 * in 8042EM. Next, we must clear aggregator status.
 */
void kb_ibf_interrupt(void)
{
	if (lpc_keyboard_input_pending())
		keyboard_host_write(MCHP_8042_H2E,
				    MCHP_8042_STS & (1 << 3));

	MCHP_INT_SOURCE(MCHP_8042_GIRQ) = MCHP_8042_IBF_GIRQ_BIT;
	task_wake(TASK_ID_KEYPROTO);
}
DECLARE_IRQ(MCHP_IRQ_8042EM_IBF, kb_ibf_interrupt, 1);

/*
 * Interrupt generated when Host reads data byte from 8042EM output buffer.
 * The 8042EM STATUS.OBF bit will clear when the Host reads the data and
 * assert its OBE signal to interrupt aggregator.
 * Clear aggregator 8042EM OBE R/WC status bit before invoking task.
 */
void kb_obe_interrupt(void)
{
	MCHP_INT_SOURCE(MCHP_8042_GIRQ) = MCHP_8042_OBE_GIRQ_BIT;
	task_wake(TASK_ID_KEYPROTO);
}
DECLARE_IRQ(MCHP_IRQ_8042EM_OBE, kb_obe_interrupt, 1);
#endif

/*
 * Bit 0 of 8042EM STATUS register is OBF meaning EC has written data
 * to EC2HOST data register. OBF is cleared when the host reads the data.
 */
int lpc_keyboard_has_char(void)
{
	return (MCHP_8042_STS & (1 << 0)) ? 1 : 0;
}

int lpc_keyboard_input_pending(void)
{
	return (MCHP_8042_STS & (1 << 1)) ? 1 : 0;
}

/*
 * called from common/keyboard_8042.c
 */
void lpc_keyboard_put_char(uint8_t chr, int send_irq)
{
	MCHP_8042_E2H = chr;
	if (send_irq)
		keyboard_irq_assert();
}

/*
 * Read 8042 register and write to read-only register
 * insuring compiler does not optimize out the read.
 */
void lpc_keyboard_clear_buffer(void)
{
	MCHP_PCR_CHIP_OSC_ID = MCHP_8042_OBF_CLR;
}

void lpc_keyboard_resume_irq(void)
{
	if (lpc_keyboard_has_char())
		keyboard_irq_assert();
}

void lpc_set_acpi_status_mask(uint8_t mask)
{
	MCHP_ACPI_EC_STATUS(0) |= mask;
}

void lpc_clear_acpi_status_mask(uint8_t mask)
{
	MCHP_ACPI_EC_STATUS(0) &= ~mask;
}

int lpc_get_pltrst_asserted(void)
{
#ifdef CONFIG_HOSTCMD_ESPI
	/*
	 * eSPI PLTRST# a VWire or side-band signal
	 * Controlled by CONFIG_ESPI_PLTRST_IS_VWIRE
	 */
	return espi_vw_get_wire(VW_PLTRST_L);
#else
	/* returns 1 if LRESET# pin is asserted(low) else 0 */
	return (MCHP_LPC_BUS_MONITOR & (1<<1)) ? 1 : 0;
#endif
}

/* Enable LPC ACPI-EC0 interrupts */
void lpc_enable_acpi_interrupts(void)
{
	task_enable_irq(MCHP_IRQ_ACPIEC0_IBF);
}

/* Disable LPC ACPI-EC0 interrupts */
void lpc_disable_acpi_interrupts(void)
{
	task_disable_irq(MCHP_IRQ_ACPIEC0_IBF);
}

/* On boards without a host, this command is used to set up LPC */
static int lpc_command_init(int argc, char **argv)
{
	lpc_init();
	return EC_SUCCESS;
}
DECLARE_CONSOLE_COMMAND(lpcinit, lpc_command_init, NULL, NULL);

/* Get protocol information */
static int lpc_get_protocol_info(struct host_cmd_handler_args *args)
{
	struct ec_response_get_protocol_info *r = args->response;

	CPRINTS("MEC1701 Handler EC_CMD_GET_PROTOCOL_INFO");
	trace0(0, LPC, 0, "Handler EC_CMD_GET_PROTOCOL_INFO");

	memset(r, 0, sizeof(*r));
	r->protocol_versions = (1 << 3);
	r->max_request_packet_size = EC_LPC_HOST_PACKET_SIZE;
	r->max_response_packet_size = EC_LPC_HOST_PACKET_SIZE;
	r->flags = 0;

	args->response_size = sizeof(*r);

	return EC_SUCCESS;
}
DECLARE_HOST_COMMAND(EC_CMD_GET_PROTOCOL_INFO,
		lpc_get_protocol_info,
		EC_VER_MASK(0));