| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the interest of making long-term branch maintenance incur as little
technical debt on us as possible, we should not maintain any files on
the branch we are not actually using.
This has the added effect of making it extremely clear when merging CLs
from the main branch when changes have the possibility to affect us.
The follow-on CL adds a convenience script to actually pull updates from
the main branch and generate a CL for the update.
BUG=b:204206272
BRANCH=ish
TEST=make BOARD=arcada_ish && make BOARD=drallion_ish
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Change-Id: I17e4694c38219b5a0823e0a3e55a28d1348f4b18
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3262038
Reviewed-by: Jett Rink <jettrink@chromium.org>
Reviewed-by: Tom Hughes <tomhughes@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
find . -name '*.md' | xargs sed -i 's#refs/heads/master#HEAD#g'
find . -name '*.md' | xargs sed -i 's#+/master#+/HEAD#g'
BRANCH=none
BUG=none
TEST=view in gitiles
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: Iaac99ddc3463c8c7bb08038214e3eb22951db6a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3188552
Reviewed-by: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
| |
BRANCH=none
BUG=b:163885307
TEST=buildall passes
Change-Id: I8b5524341e02dbbedbd0f8e7a3b82352aef4091f
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3181500
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The zephyr toolchain has -Werror=maybe-uninitialized enabled by default,
so enable it for all gcc EC builds to prevent possible uninitialized
vars from sneaking into the codebase. For clang builds, use
-Werror=uninitialized instead.
BRANCH=None
BUG=None
TEST=in docker: make -j CRYPTOC_DIR="${MODULES_DIR}/cryptoc" \
FTDIVERSION=1 HOSTGCOV='gcov' \
CROSS_COMPILE_arm=/opt/zephyr-sdk/arm-zephyr-eabi/bin/arm-zephyr-eabi- \
coverage
in chroot; make try_build_boards buildall_only
Change-Id: I3efb4b2958f2037606195743d768870e1d0b18b9
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3171939
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Clear sigaction to 0.
BUG=none
BRANCH=none
TEST=Check it ok by cherry platform.
Signed-off-by: Donald Huang <donald.huang@ite.com.tw>
Change-Id: I5d08158bd1aa8262e2abe6917ac7c4732d22fd46
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3162463
Tested-by: Donald Huang <donald.huang@ite.corp-partner.google.com>
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=b:200542097
TEST=None
BRANCH=None
Signed-off-by: Chris McDonald <cjmcdonald@chromium.org>
Change-Id: I1f6ac70c524dce56fde6c59f3c0129726cfc5761
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3171531
Commit-Queue: Jaques Clapauch <jaquesc@google.com>
Commit-Queue: Chris McDonald <cjmcdonald@chromium.org>
Tested-by: Jaques Clapauch <jaquesc@google.com>
Auto-Submit: Jaques Clapauch <jaquesc@google.com>
Reviewed-by: Chris McDonald <cjmcdonald@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A field (cros_fwid_rw) was added to ec_response_get_version and the
version was updated to v1. Some system components that still use v0
of the version host command fail because the size of the response
does not match the updated ec_response_get_version struct.
Restore ec_response_get_version to match v0. Create a new
ec_response_get_version_v1 structure with the added v1 fields.
This allows legacy code to continue using ec_response_get_version,
which matches the expected response size for the v0 command.
BUG=b:188073399,b:200075921
TEST=EC console 'version' works
Legacy 'ectool version' works with old an new EC firmware.
New 'ectool version' works with old and new EC firmware.
BRANCH=None
Change-Id: I51a052a550c2460f2604da8e04fc43c36acba4d5
Signed-off-by: Rob Barnes <robbarnes@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3169100
Reviewed-by: caveh jalali <caveh@chromium.org>
Reviewed-by: Patryk Duda <patrykd@google.com>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Drop IOEX and IOEX_INT macros during GPIO conversion.
BUG=b:195137794
BRANCH=none
TEST=run for guybrush
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Change-Id: Icb52e31a33efb1b0a3541448614ac5a8520cbe6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3169196
Reviewed-by: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add support for CONFIG_I2C_DEBUG and CONFIG_I2C_DEBUG_PASSTHRU options
to zephyr.
BUG=none
BRANCH=none
TEST=zmake testall
TEST=Add CONFIG_PLATFORM_EC_I2C_DEBUG=y on herobrine, verify "i2ctrace"
command is available and functional.
TEST=Add CONFIG_PLATFORM_EC_I2C_DEBUG_PASSTHRU=y on herobrine, verify
I2C passthru messages shown during TCPC firmware sync.
Signed-off-by: Keith Short <keithshort@chromium.org>
Change-Id: Ic2d9977af4fa707dab4fdaff332fbcc34491c5fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3163211
Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replace all usages of chromite.lib.cros_logging with the stdlib logging
module.
BUG=b:191490453
TEST=None
BRANCH=None
Signed-off-by: Chris McDonald <cjmcdonald@chromium.org>
Change-Id: I661a620fb514b2b53b6e6c5d76c90cca0280959c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3161635
Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
EC version does not follow the the AP and OS version. This causes
confusion during development. This change augments the EC version output
to include the CrOS FWID when available. The CrOS FWID will be missing
when the CrOS EC is built outside of cros_sdk. When CrOS FWID is missing
'CROS_FWID_MISSING' will be used.
Zephyr/zmake support will be added later, CROS_FWID32 is set to
'CROS_FWID_MISSING' in zephyr builds until then.
BUG=b:188073399
TEST=version
21-05-20 16:43:18.627 Chip: Nuvoton NPCX993F A.00160101
21-05-20 16:43:18.631 Board: 1
21-05-20 16:43:18.631 RO: guybrush_v2.0.8770+f47439f75
21-05-20 16:43:18.634 guybrush_13983.0.21_05_20
21-05-20 16:43:18.639 RW_A: * guybrush_v2.0.8770+f47439f75
21-05-20 16:43:18.641 * guybrush_13983.0.21_05_20
21-05-20 16:43:18.644 RW_B: guybrush_v2.0.8770+f47439f75
21-05-20 16:43:18.644 guybrush_13983.0.21_05_20
21-05-20 16:43:18.647 Build: guybrush_v2.0.8770+f47439f75
21-05-20 16:43:18.651 guybrush_13983.0.21_05_20 2021-05-20
21-05-20 16:43:18.657 16:31:19 robbarnes@robbarnes0
ectool version
RO version: guybrush_v2.0.8770+f47439f75
RO cros fwid: guybrush_13983.0.21_05_20
RW version: guybrush_v2.0.8770+f47439f75
RW cros fwid: guybrush_13983.0.21_05_20
Firmware copy: RO
Build info: guybrush_v2.0.8770+f47439f75
guybrush_13983.0.21_05_20 2021-05-20 16:31:19 robbarnes@robbarnes0
Tool version: 1.1.9999-f47439f @robbarnes0
BRANCH=None
Signed-off-by: Rob Barnes <robbarnes@google.com>
Change-Id: Ief0a0c6e9d35edc72ac2d4780ee203be41d7305f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2894145
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add Kconfig options CONFIG_PLATFORM_EC_USB_PD_TCPM_PS8805 and
CONFIG_PLATFORM_EC_USB_PD_TCPM_PS8815 to enable/disable the workaround
for PS8805/PS8815 firmware reporting the incorrect device ID.
BUG=none
BRANCH=none
TEST=zmake testall
TEST=On herobrine, verify that "ectool pdchipinfo 0" reports a device ID
0x02.
Signed-off-by: Keith Short <keithshort@chromium.org>
Change-Id: I16367ae5276e974671b034294275104d5831df21
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3140325
Commit-Queue: Wai-Hong Tam <waihong@google.com>
Reviewed-by: Wai-Hong Tam <waihong@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add the logic to find the gpios on herobrine.
BUG=None
BRANCH=None
TEST=flash_fp_mcu on Herobrine
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Change-Id: I8ed4f0df41d36f279a6e1d3a4dab74063d489f0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3135042
Reviewed-by: Alexandru M Stan <amstan@chromium.org>
Reviewed-by: Craig Hesling <hesling@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Support dynamic PDO selection CONFIG_USB_PD_DPS.
This config controls the charging voltage and power according to the
input power and battery configuration.
DPS would continuously evaluate the system load and current charging
voltage, and decide a new one by below:
1. If the PDO can fulfill system desired power.
2. If the PDO is efficient for the battery configuration.
To detect if the system load cannot be fulfilled by the current PDO,
it checks:
1. if the input current closes to the PDO current limit.
2. if the input power closes to the PDO maximum power.
To detect if the system load can be fulfilled by a more efficient PDO,
it checks:
- if the voltage of a new PDO is closer to the battery voltage than the
current PDO, and the power is able fulfill the system load.
BUG=b:169532537
TEST=1. tested on asurada, the charging voltage is able to switch to
different PDOs under different system loads
2. tested that the DPS is able to switch charge port
(e.g. C1 12V -> C0 9V) based on the provided PDOs.
BRANCH=asurada
Change-Id: I7c7706b331dc0d4f8ac68569dc7ed852fc9308e3
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2897064
Tested-by: Eric Yilun Lin <yllin@google.com>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Eric Yilun Lin <yllin@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When compiling with C++ _GNU_SOURCE is already defined, which generates
a compiler error:
util/comm-i2c.cc:6:9: error: '_GNU_SOURCE' macro redefined
[-Werror,-Wmacro-redefined]
^
<built-in>:393:9: note: previous definition is here
^
For details on why g++ always defines _GNU_SOURCE on Linux see
https://gcc.gnu.org/onlinedocs/libstdc++/faq.html#faq.predefined
BRANCH=none
BUG=b:144959033
TEST=make buildall
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: If7c2f241562a093d4acf32ccccdf247092458fdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2869429
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
run_tests.sh no longer uses the Python unittest module's discovery
functionality, which was forcing util/ec3po/ subdir to be directly in
sys.path as a top-level module location, which is inconsistent with how
ec3po modules are used outside of the tests.
run_tests.sh no longer auto-discovers *_unittest.py files, instead they
are individually listed as ec3po.<name>_unittest modules. It would be
straightforward to implement test module autodiscovery, but probably
isn't worth the complexity.
BRANCH=none
BUG=chromium:1031705,b:174894072,b:197618562
TEST=Within chroot, ran ./runtests.sh from within util/ec3po/ directory.
Within chroot, ran ~/trunk/src/platform/ec/util/ec3po/run_tests.sh from
a different directory.
Verified use of the files-under-test (as opposed to the files installed
in site-packages/) by adding broken code to console.py and then
re-running both invoctions above. Both then failed as intended.
Change-Id: I40c180f1d66a4d3befc548f4d763357e6cc24201
Signed-off-by: Matthew Blecker <matthewb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3123835
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add support for flashing Zephyr images. This includes finding the NPCX
monitor binary built with Zephyr images instead of requiring a cros-ec
build to provide the monitor.
Automatically finding and flashing Zephyr images built with
"emerge-<board> chromeos-zephyr" is not supported by this change.
BUG=b:197162681
BRANCH=none
TEST=Delete cros-ec build directories to ensure NPCX monitor comes from
Zehpyr builds.
TEST=Verify local image programming using "./util/flash_ec --board
volteer --zephyr"
Signed-off-by: Keith Short <keithshort@chromium.org>
Change-Id: Ib85f65b241bd0119bb8cce3193cede5a9fcee4aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3116568
Reviewed-by: Wai-Hong Tam <waihong@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit adds some relevant paths to be included in
the merge commit messages for the dedede firmware branch.
BUG=None
BRANCH=firmware-dedede-13606
TEST=None
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Change-Id: I42b481c6f8dfabed042e5bb701b47323e38d8f3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3120073
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Auto-Submit: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chris suggested some good cleanups in CL:3105736, but this was just a
firmware-branch cherry pick of a CL from >1yr ago.
Making these changes on ToT instead. Summary of the changes:
- Remove obsolete __future__ import since we only run on Python 3 now.
- Use explicit 0, 1, 2, 3 exit codes for success, failure, timeout,
and unexpected termination (respectively). This lets us drop a
property.
- Read from the process in unicode mode, since we just end up decoding
later anyway.
- verbose argument changed from counter to boolean since there's no
additional behavior created by passing multiple times.
BUG=none
BRANCH=none
TEST=make buildall -j32
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Change-Id: Ibc9de7d45f5ac1242429481c6bc5f303cdef6b06
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3107925
Commit-Queue: Chris McDonald <cjmcdonald@chromium.org>
Reviewed-by: Chris McDonald <cjmcdonald@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ADLRVP does not have standard overlays to program EC hence
added adlrvpp_npcx board to NPCX internal SPI array.
BUG=b:196998258
BRANCH=none
TEST=Below command flashes NPCX MECC on ADLRVP
./util/flash_ec --board=adlrvpp_npcx
Change-Id: I132aa21a0bed533c61cc8f2edf159c95774cad0b
Signed-off-by: Vijay Hiremath <vijay.p.hiremath@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3102298
Reviewed-by: caveh jalali <caveh@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Created array for the NPCX internal SPI for the boards which
do not use standard overlays.
BUG=none
BRANCH=none
TEST=Able to flash npcx9m3f using MECC AIC on ADLRVP
Signed-off-by: Vijay Hiremath <vijay.p.hiremath@intel.com>
Change-Id: I57e4909f0b487b0efa4a3fa26f8b3d5465267dd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3101842
Reviewed-by: Tanu Malhotra <tanu.malhotra@intel.com>
Reviewed-by: caveh jalali <caveh@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
E.g. in servod console there is always 'Disabling uart timestamps.'
printed, no matter what we enter to dut-control - on/off.
This patch fixes that issue.
BRANCH=none
BUG=b:173654272
TEST=Perform manual testing:
"sudo servod --board=nocturne"
"dut-control cr50_uart_timestamp:on"
"dut-control cr50_uart_timestamp:off"
observe proper logs in servod console.
Signed-off-by: Lukasz Hajec <lha@semihalf.com>
Change-Id: I52cde5e4a9cd70fdc3e9d9513f8aa4126c5f09f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3077540
Reviewed-by: Michał Barnaś <mb@semihalf.com>
Reviewed-by: Matthew Blecker <matthewb@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=b:195948807
BRANCH=none
TEST=zmake configure -b $PROJ_HAYATO
Signed-off-by: Denis Brockus <dbrockus@google.com>
Change-Id: I6de387725db11ad00356c7cf47cb9c0e2e109652
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3087619
Tested-by: Denis Brockus <dbrockus@chromium.org>
Auto-Submit: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Optimize SPI flash read timing, MEC172x QMSPI controller controls CS#
by hardware, it will add several system clock cycles delay between CS
deassertion to CS assertion at the start of the next transaction, this
guarantees SPI back to back transactions, so 1ms delay can be removed
to optimze timing.
BUG=none
BRANCH=none
TEST=Tested on ADL RVP and MCHP1727 MECC system via FAFT ECBootTime job
save 720ms as EC performs 180KB RW code's SHA256 hash computation
Signed-off-by: martin yan <martin.yan@microchip.corp-partner.google.com>
Change-Id: I5cf9c668efb1cd008b91cdd8aa09f7351c017af0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3074767
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
samus: AUE in M91, M92 pushed to stable already
samus_pd: samus pd chip
dragonegg: canceled
cheza: canceled
flapjack_scp: flapjack was canceled
atlas_ish: atlas shipped, but ish project canceled
sklrvp,glkrvp: these are pretty old intel reference boards and the
portage overlays were already deleted ... assume nobody needs the
EC firmware anymore either
BUG=none
BRANCH=none
TEST=buildall
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Change-Id: I794867ac82f37ffa2267e2e59ac02bc381688c57
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3069716
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a workaround for the dartmonkey RO flash init bug,
where a boot loop occurs when HW-WP is disabled, but SW-WP
is still enabled.
We force a true power-on-reset so that flash init function in RO
sees that SW-WP cannot be removed (and is "stuck").
BRANCH=none
BUG=b:146428434,b:187387061,b:143374692
TEST=# Test on helios, bard, and nocturne
scp util/flash_fp_mcu ${DUT_HOSTNAME}:/usr/local/bin/flash_fp_mcu
ssh ${DUT_HOSTNAME} ectool --name=cros_fp reboot_ec
ssh ${DUT_HOSTNAME} ectool --name=cros_fp uptimeinfo
# No power-on reset flag should be set.
ssh ${DUT_HOSTNAME} flash_fp_mcu
# Check that power-on reset flag is set.
# If you were to check the uptimeinfo after flash_fp_mu
# finished, you would see a few seconds later that the
# power-on flag is gone. This is because biod's startup
# would reinitialize entropy and cause reset.
TEST=# Test on morphius
scp util/flash_fp_mcu ${DUT_HOSTNAME}:/usr/local/bin/flash_fp_mcu
ssh ${DUT_HOSTNAME} flash_fp_mcu
# Just make sure we didn't break the script.
Signed-off-by: Craig Hesling <hesling@chromium.org>
Change-Id: Ib8e239c6c0d5e5de66da2e664374a80479eb4098
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3032665
Commit-Queue: Josie Nordrum <josienordrum@google.com>
Reviewed-by: Josie Nordrum <josienordrum@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update SPI host interface config option for inclusive language.
BUG=b:163885307
BRANCH=none
TEST=compare_build.sh
Signed-off-by: Keith Short <keithshort@chromium.org>
Change-Id: I808d5960fa3e746626465bedc626a95e0f0aaa3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3066271
Commit-Queue: Paul Fagerburg <pfagerburg@chromium.org>
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This requests that cros lint (and repo upload hook) use the new
Chromium OS 4 space indent policy.
Since legacy python scripts still use 2 space, I added pylint ignore
statements to the individual files to disable indentation checking.
Note: There are still valid pylint errors in some of these legacy scripts.
BRANCH=none
BUG=none
TEST=cros lint util/*.py
Signed-off-by: Craig Hesling <hesling@chromium.org>
Change-Id: I439f5a87bc50f1f43a4996e574bbc0626922a88e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3064761
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Keeby is largely based off of dedede so add a relevant paths file which
is just a symlink to dedede's file.
BUG=None
BRANCH=keeby
TEST=Check symlink points to dedede's file.
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Change-Id: Ib347e4a2311cbbb94f4689ed967b9806bea3ed5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3063979
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Auto-Submit: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Delete the following configs which are no longer referenced by any
source files:
CONFIG_CMD_FLASH_LOG
CONFIG_CMD_GSV
CONFIG_CMD_GSV
CONFIG_CMD_LID_ANGLE
CONFIG_CMD_PMU
CONFIG_CMD_USBMUX
BUG=none
BRANCH=none
TEST=make buildall
Signed-off-by: Keith Short <keithshort@chromium.org>
Change-Id: Ia304f0579d991a0fccc7bbc7ca7427fe0ed661a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3061902
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is similar to gsctool, but this tool would only be in the
test image.
This comes from the effort to move away from shell script.
See http://go/deshell.
The idea is that you start with a simple wrapper for the given shell
script. Over time, features are transplanted or added-new to the python
wrapper, until the shell script is no longer needed.
BRANCH=none
BUG=b:172020576
TEST=./util/fptool.py
./util/fptool.py --help
./util/fptool.py flash --help
./util/fptool.py flash
# Error about flash_fp_mcu not existing
TEST=scp util/fptool.py $DUT:/usr/local/bin
ssh $DUT fptool.py flash /root/doesnotexist
ssh $DUT fptool.py flash
ssh $DUT fptool.py flash /opt/google/biod/fw/$(cros_config /fingerprint board)*.bin
Change-Id: I8774bda4a057ee09f70bf474ce3ba2fa0bbcf92d
Signed-off-by: Craig Hesling <hesling@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3060744
Reviewed-by: Josie Nordrum <josienordrum@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CONFIG_PLATFORM_EC_FW_RESET_VECTOR is used to control
CONFIG_FW_RESET_VECTOR in the existing cros-ec code.
This allows a chip specific function to be called
to obtain the firmware reset vector.
BUG=b:194794622
BRANCH=none
TEST=zmake configure -b $PROJ_HAYATO
Signed-off-by: Denis Brockus <dbrockus@google.com>
Change-Id: I49000bc557f86f74af0d8429af6939ad340f21d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3056514
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
Tested-by: Denis Brockus <dbrockus@chromium.org>
Auto-Submit: Denis Brockus <dbrockus@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change does the following:
* allows for J-Link over USB to be the default connection
* allows for passing in hostnames as the remote target, despite
the segger tool only accepting IP addresses
* changes the --ip arg to --remote, since this better describes
the host + port description being provided
BRANCH=none
BUG=none
TEST=# Check over USB
./util/flash_jlink.py
TEST=JLinkRemoteServerCLExe
./util/flash_jlink.py --remote 127.0.0.1
./util/flash_jlink.py --remote 127.0.0.1:19020
./util/flash_jlink.py --remote localhost
./util/flash_jlink.py --remote localhost:19020
./util/flash_jlink.py --remote localtoast
# Should fail
./util/flash_jlink.py --remote localhost:port
# Should fail
Signed-off-by: Craig Hesling <hesling@chromium.org>
Change-Id: I63c5a250f25bcae9828dc88b6282ac301b9a519f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3054818
Reviewed-by: Josie Nordrum <josienordrum@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This server could be either the local JLinkRemoteServerCLExe program
or a physical J-Link connected over the network.
Since we are not sure if the remote server is on the localhost,
we make a TCP connection to the server to check if it is running.
BRANCH=none
BUG=none
TEST=# No JLinkRemoteServerCLExe running
make proj-bloonchipper -j
./util/flash_jlink.py --board bloonchipper
# Ensure the cute error is given
TEST=JLinkRemoteServerCLExe # in background
make proj-bloonchipper -j
./util/flash_jlink.py --board bloonchipper
# Ensure all goes well
Change-Id: I4f24e5f53545aa3b1482066fe8ba12d5f1715d42
Signed-off-by: Craig Hesling <hesling@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3055114
Reviewed-by: Josie Nordrum <josienordrum@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BRANCH=none
BUG=none
TEST=# Force cmd_lookup_name to return NULL
make proj-bloonchipper -j
./util/flash_ec --board=bloonchipper
Change-Id: I5fe3588a9e15b19585c6f8ed005d58f5aed36a75
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3056331
Tested-by: Craig Hesling <hesling@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Craig Hesling <hesling@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The 3 read_* functions attempt to read from areas that are protected
by RDP on the STM32F412. This results in many read failures before
we get to the unprotect function. These are not needed before attempting
the unprotect, so move them to after the unprotect sequence.
The unwanted sequence looks like the following, every time:
Waiting for the monitor startup ...Done.
ChipID 0x441 : STM32F412
| 0%NACK
Failed to get command READMEM ACK
NACK
Failed to get command READMEM ACK
NACK
Failed to get command READMEM ACK
NACK
Failed to get command READMEM ACK
Cannot read 21 bytes from address 0x1FFF7A0FUnable to read flash size register (0x1FFF7A22).
/ 0%NACK
Failed to get command READMEM ACK
NACK
Failed to get command READMEM ACK
NACK
Failed to get command READMEM ACK
NACK
Failed to get command READMEM ACK
Cannot read 13 bytes from address 0x1FFF7A0FUnable to read unique device ID register (0x1FFF7A10). Ignoring non-critical failure.
Bootloader v3.1, commands : GETCMD GETVER GETID READMEM GO WRITEMEM EXTERASE WP WU RP RU
Unprotecting flash read...
Now, the output looks like:
Waiting for the monitor startup ...Done.
ChipID 0x441 : STM32F412
Bootloader v3.1, commands : GETCMD GETVER GETID READMEM GO WRITEMEM EXTERASE WP WU RP RU
Unprotecting flash read...
Timeout
Timeout
Timeout
Flash read unprotected.
Waiting for the monitor startup ...Done.
| 0%Flash size: 1024 KB
/ 0%Unique Device ID: 0x383939313138511900038016
Flash write unprotected.
Waiting for the monitor startup ...Done.
Erasing...
Timeout
Timeout
Timeout
Flash erased.
Writing 1047992 bytes at 0x08000000
1047992 bytes written.
Done.
BRANCH=none
BUG=b:143374692
TEST=make proj-bloonchipper -j
./test/run_device_tests.py --flasher=servo_micro --tests\
flash_write_protect
# This sets RDP
./util/flash_ec --board=bloonchipper
TEST=# Tried flash_fp_mcu on dratini(F412/SPI) and bard(H732/SPI).
Signed-off-by: Craig Hesling <hesling@chromium.org>
Change-Id: I9b9ba2ecd3797cb1a98d7bcd7b226cdbc7872217
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3054465
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After sending CMD_RU, the MCU will send one ACK immediately and then
another one when it is finished erasing all of flash.
We currently only wait MAX_RETRY_COUNT (3) timeouts for that seconds
ACK, which is not enough for the STM32F412 most fo the time. This means
that it requires two invocations of stm32mon to flash a protected chip.
* First unprotects and erases, then stm32mon aborts
* Second sees an erased and unprotected chip which flashes correctly.
We only need a few more attempts. It happens to be that
MAX_ACK_RETRY_COUNT is designed for this type of situation where we
are waiting for a long ACK. It provides 5 vs the old 3.
BRANCH=none
BUG=b:143374692
TEST=./test/run_device_tests.py --flasher=servo_micro --tests \
flash_write_protect
# FPMCU is now readout protected
./test/run_device_tests.py --flasher=servo_micro --tests \
flash_write_protect
# This should succeed the first time stm32mon is run, not the second.
TEST=# Tried flash_fp_mcu on dratini(F412/SPI) and bard(H732/SPI).
Signed-off-by: Craig Hesling <hesling@chromium.org>
Change-Id: I225fa7560fd485e5df601378998f2853b351324c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3054464
Reviewed-by: Patryk Duda <patrykd@google.com>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, the bootloader commands would be printed like
the following, where the RP (0x82) and RU (0x92) commands would not
be identified:
Bootloader v3.1, commands : GETCMD GETVER GETID READMEM GO WRITEMEM \
EXTERASE WP WU 82 92
I believe this is because |cmd| and |cmd_lookup_table[i].cmd| were being
"integer promoted" to accommodate all values. This would result in
both values being converted to 32bit ints. This means that the char
|cmd| could be sign extended and maintain a negative value and
|cmd_lookup_table[i].cmd| would maintain a large unsigned value.
Now, all the commands are recognized:
Bootloader v3.1, commands : GETCMD GETVER GETID READMEM GO WRITEMEM \
EXTERASE WP WU RP RU
BRANCH=none
BUG=none
TEST=make proj-bloonchipper -j
./util/flash_ec --board=bloonchipper
Signed-off-by: Craig Hesling <hesling@chromium.org>
Change-Id: I07ad35fe7e6b69c57f7f69bce3c694c2f887beef
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3054820
Reviewed-by: Patryk Duda <patrykd@google.com>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changes the used port to JLinkRemoteServerCLExe's actual
default port of 19020, so that you don't need to always specify it.
BRANCH=none
BUG=none
TEST=JLinkRemoteServerCLExe # in background
make proj-bloonchipper -j
./util/flash_jlink.py --board bloonchipper
Signed-off-by: Craig Hesling <hesling@chromium.org>
Change-Id: I2a3c1a10e0b5c7b9cc62001a3a26508ea3db8199
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3055111
Reviewed-by: Josie Nordrum <josienordrum@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BRANCH=none
BUG=b:176500425
TEST=make BOARD=dartmonkey -j
./build/dartmonkey/util/ec_parse_panicinfo --help
./build/dartmonkey/util/ec_parse_panicinfo # Ctrl-D
# Ensure it complains that "Panic data too short".
Signed-off-by: Craig Hesling <hesling@chromium.org>
Change-Id: I32bfb0b027cf51f9f17df774cba45abe6c03b5bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3048643
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Patryk Duda <pdk@semihalf.com>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Congratulations! The following options are now in
Kconfig:
CONFIG_HOSTCMD_REGULATOR
CONFIG_SMBUS_PEC
Config removed with './util/build_allowed.sh -u'
Removing these CONFIG options from the allowed list:
CONFIG_HOSTCMD_REGULATOR
CONFIG_SMBUS_PEC
BRANCH=none
BUG=none
TEST=buildall
Signed-off-by: Dino Li <Dino.Li@ite.com.tw>
Change-Id: Ib12637f9e9d25db3af951a7a12989d334e6a1c5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3045035
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
List relevant commits when constructing volteer branch merge commit
messages.
BUG=none
TEST=none
BRANCH=none
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Change-Id: Ibac403353a40055798323b20a9333c757ec305c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3044138
Reviewed-by: Zhuohao Lee <zhuohao@chromium.org>
Commit-Queue: Zhuohao Lee <zhuohao@chromium.org>
Tested-by: Zhuohao Lee <zhuohao@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Nocturne and Nami are legacy kernel v4.4 devices.
The spidev char device naming changed between their v4.4 and newer v5.4.
Since these devices have a kernelnext build+tests, we need an alternative
configuration that uses the new spidev name.
This is achieved by allowing for specific alt configs that match
the full platform name, like "nami-kernelnext". If a config is not
provided for the full platform name, it will fallback to using the
normal base config name, like "nami".
BRANCH=none
BUG=b:194004525
TEST=# Run the following commands on a nocturne, nocturne-kernelnext,
# nami, nami-kernelnext, and hatch setups.
#
# Note, you get a kernelnext setup by flashing the base platform
# device with an xbuddy line similar to
# xbuddy://remote/nami-kernelnext/latest-dev/test
scp util/flash_fp_mcu ${DUT_HOSTNAME}:/usr/local/bin/flash_fp_mcu
ssh ${DUT_HOSTNAME} flash_fp_mcu --hello
# Check that full platform name and base name was identified
# correctly.
# Check that it succeeded.
Signed-off-by: Craig Hesling <hesling@chromium.org>
Change-Id: Ib2ad991291639ef33799abb4bc3379c1659f754d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3035686
Reviewed-by: Jora Jacobi <jora@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Congratulations! The following options are now in
Kconfig:
CONFIG_ARM
Config removed with './util/build_allowed.sh -u'
BUG=none
BRANCH=master
TEST=make buildall passes.
Signed-off-by: Gwendal Grignou <gwendal@google.com>
Change-Id: Ia96c24db5489d9681ae0acf4da2a9133a8f2a3e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3041918
Reviewed-by: Yuval Peress <peress@chromium.org>
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Gwendal Grignou <gwendal@chromium.org>
Tested-by: Gwendal Grignou <gwendal@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Taking control of the pwr_en line causes the FPMCU to power cycle.
This causes an interrupt to the cros-ec driver. The interrupt handler
then races with the subsequent cros-ec unbind attempt.
This can manifest in multiple ways, but one common way is for the
later binding of spidev to fail, since the interrupt handler
reinitialized the cros-ec driver (due to crrev.com/c/1903814).
The spidev attempt then errors out because there are still resources
associated with the device (the reallocated cros-ec objects).
The need to take control of the power enable line to simply keep FPMCU
power enabled is no longer needed on any device.
* The need for this arose during nocturne development, when the pwr_en
line was associated with the SPI interface in ACPI.
This can be seen in https://crrev.com/c/1084686.
This pwr_en control was then added to flash_fp_mcu in
https://crrev.com/c/1114743.
* The pwr_line was then quickly disassociated with the SPI interface
a few days later in https://crrev.com/c/1155565, but wasn't removed
from flash_fp_mcu.
To this day, the FP pwr_en line is controlled in coreboot manually.
It remains powered on when the Chromebook is powered on, irrespective
of drivers.
BRANCH=none
BUG=b:190744837
TEST=Run the following on nocturne, nami, kohaku, dratini, and
volteer.
scp util/flash_fp_mcu ${DUT_HOSTNAME}:/usr/local/bin/flash_fp_mcu
ssh ${DUT_HOSTNAME} flash_fp_mcu --hello
ssh ${DUT_HOSTNAME} flash_fp_mcu
ssh ${DUT_HOSTNAME} flash_fp_mcu --hello
Signed-off-by: Craig Hesling <hesling@chromium.org>
Change-Id: Icc64f7056e21180efd19b2f650b9fe5804cd2906
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3027129
Tested-by: Patryk Duda <patrykd@google.com>
Reviewed-by: Patryk Duda <patrykd@google.com>
Reviewed-by: Josie Nordrum <josienordrum@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We note our flash_fp_mcu actions to the kernel log in order to be
able to debug what action of the script may have triggered a kernel
warning or error.
This is for debugging current and future issues with the kernel
and flash_fp_mcu.
BRANCH=none
BUG=b:190744837
TEST=# On Nami and Zork
scp util/flash_fp_mcu ${DUT_HOSTNAME}:/usr/local/bin/flash_fp_mcu
ssh ${DUT_HOSTNAME} flash_fp_mcu --hello
dmesg
Change-Id: Ie57b1042d20284065a652b0a805c081a9591280c
Signed-off-by: Craig Hesling <hesling@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3010624
Reviewed-by: Patryk Duda <patrykd@google.com>
Reviewed-by: Jora Jacobi <jora@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 9a40c7dbadf8c577660a09807287d9133373803b.
This change turned out to not be very useful and non-functional
on kernel v4.4.
BRANCH=none
BUG=b:190744837
TEST=none
Change-Id: If5d51e0240f93b43410040e99eb48cb5e080f0e3
Signed-off-by: Craig Hesling <hesling@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3027128
Reviewed-by: Patryk Duda <patrykd@google.com>
Reviewed-by: Jora Jacobi <jora@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BRANCH=none
BUG=b:178213305
TEST=Run ectool on Guybrush.
Signed-off-by: Bhanu Prakash Maiya <bhanumaiya@chromium.org>
Change-Id: Ic7ac62f328618d939a71f3735e3c367af3ee5a76
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3021755
Tested-by: Bhanu Prakash Maiya <bhanumaiya@google.com>
Auto-Submit: Bhanu Prakash Maiya <bhanumaiya@google.com>
Commit-Queue: Diana Z <dzigterman@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the following CONFIG options from the allow list which are
obsolete or have been added to Kconfig:
CONFIG_BATT_FULL_FACTOR
CONFIG_FLASH_PSTATE
CONFIG_INTERNAL_STORAGE
CONFIG_MKBP_EVENT_WAKEUP_MASK
CONFIG_MKBP_HOST_EVENT_WAKEUP_MASK
BUG=b:193195946
BRANCH=none
TEST=zmake testall
TEST=make buildall
Signed-off-by: Keith Short <keithshort@chromium.org>
Change-Id: If078d2302726458962d71f0da69cc1de8b9c553b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3015870
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Yuval Peress <peress@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a Kconfig option to control the CONFIG_CMD_S5_TIMEOUT option.
BUG=b:193195946
BRANCH=none
TEST=zmake testall
TEST=make buildall
Signed-off-by: Keith Short <keithshort@chromium.org>
Change-Id: I2f4b8c74a9b710f68d8e07e04d9cb95ca2e39dea
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3015869
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Yuval Peress <peress@chromium.org>
|