summaryrefslogtreecommitdiff
path: root/PRESUBMIT.cfg
Commit message (Collapse)AuthorAgeFilesLines
* util: Add tool to generate cros_ec_commands.hGwendal Grignou2019-04-261-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | Add a rule to generate a new cros_ec_commands.h when ec_commands.h is modified. The rule is checked when buildall is invoked. At Presubmit stage, check a cros_ec_commands.h exists if ec_commands.h is modified. The CL author is responsible to upstream that file. BUG=chromium:945948 BRANCH=none Cq-Depend: chromium:1558853 TEST=Check manually cros_ec_commands.h is generated with make build_cros_ec_commands Check no bread crumbs are left-over when the rule fails. Check checkpatch triggers when it finds an invalid syntax in the output file. Check ../../repohooks/pre-upload.py returns a meaningful error when cros_ec_commands.h file is not present. Change-Id: Ibc8ed7165914d39b5f0bd41643932a8514768925 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1559380 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Reviewed-by: Brian Norris <briannorris@chromium.org>
* PRESUBMIT: enable kernel-doc check for include/ec_commands.hBrian Norris2018-12-121-0/+2
| | | | | | | | | | | | | | | ec_commands.h is often synced with the Linux sources, so it's nice to sanity-check it. CQ-DEPEND=CL:1336039 BRANCH=none BUG=chromium:621123 TEST=.../pre-upload.py Change-Id: I56645e613f8689c26ddf6ded1325e270be35da8a Signed-off-by: Brian Norris <briannorris@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1330107 Reviewed-by: Randall Spangler <rspangler@chromium.org>
* presubmit_check: disable SPDX_LICENSE_TAG checkJett Rink2018-06-121-1/+1
| | | | | | | | | | | | | | The SPDX_LICENSE_TAG doesn't apply to the ec codebase since it would want us to add the SPDX-License-Identifier to every file. BRANCH=none BUG=none TEST=verified a new file does not need SPDX-License-Identifier tag Change-Id: Ie7670f52ecd7a5dd825a56a0e8dc839e66ddd6f1 Signed-off-by: Jett Rink <jettrink@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1098026 Reviewed-by: Mike Frysinger <vapier@chromium.org>
* PRESUBMIT: give real namesBrian Norris2018-05-021-3/+3
| | | | | | | | | | BRANCH=none BUG=none TEST=upload Change-Id: Ied1474ebc347d994a209b31d0dc715318bd2a192 Signed-off-by: Brian Norris <briannorris@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1038730
* ec:Add presubmit hook to enforce host command definitionsSam Hurst2017-02-251-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make sure all public and private host commands starting with EC_CMD_ and EC_PRV_CMD_ are properly formed BUG=chromium:681240 TEST=manual. Added following host commands and verified that they were flagged #define EC_CMD_TESTA 1234 #define EC_CMD_TESTB 0xabcd #define EC_CMD_TESTC 0x1ABCD #define EC_CMD_TESTD 0xXEF01 #define EC_PRV_CMD_TESTA 1234 #define EC_PRV_CMD_TESTB 0xabcd #define EC_PRV_CMD_TESTC 0x1ABCD #define EC_PRV_CMD_TESTD 0XEF01 These were also flagged by the script include/ec_commands.h:#define EC_CMD_ACPI_READ 0x80 include/ec_commands.h:#define EC_CMD_ACPI_WRITE 0x81 include/ec_commands.h:#define EC_CMD_ACPI_BURST_ENABLE 0x82 include/ec_commands.h:#define EC_CMD_ACPI_BURST_DISABLE 0x83 include/ec_commands.h:#define EC_CMD_ACPI_QUERY_EVENT 0x84 CQ-DEPEND=CL:445809 BRANCH=none Change-Id: I4630d6a887ed289a68178e8f1a8f07f5141c80bc Reviewed-on: https://chromium-review.googlesource.com/445811 Commit-Ready: Sam Hurst <shurst@google.com> Tested-by: Sam Hurst <shurst@google.com> Reviewed-by: Randall Spangler <rspangler@chromium.org> Reviewed-by: Shawn N <shawnn@chromium.org>
* Put a newline at the end of PRESUBMIT.cfgBill Richardson2016-10-071-1/+1
| | | | | | | | | | | | | | | | Every time I run "cat PRESUBMIT.cfg" to see what's in here, it annoys me that there's no newline at the end. This adds one. BUG=none BRANCH=none TEST=make buildall Just adding whitespace; no functional change. Change-Id: I7629312c987696fd6c7bbc986ad63222186729c0 Signed-off-by: Bill Richardson <wfrichar@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/395347 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* presubmit: Add hook to check for config options.Aseda Aboagye2015-06-301-0/+1
| | | | | | | | | | | | | | | | | | | | | | This enables a presubmit hook to check for missing configuration options. All CONFIG_* options should be defined in include/config.h along with a brief description of what the config option does. BUG=chrome-os-partner:26304 BRANCH=none CQ-DEPEND=CL:281626 TEST=Create a commit modifying a source file with a new CONFIG_* option and watched the preupload process fail illustrating the error with the CONFIG_* option. TEST=make -j buildall tests Change-Id: I7240b386b4981dcab66811a4829d7d6ebfbf7cb1 Signed-off-by: Aseda Aboagye <aaboagye@google.com> Reviewed-on: https://chromium-review.googlesource.com/281826 Reviewed-by: Randall Spangler <rspangler@chromium.org> Tested-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org> Trybot-Ready: Aseda Aboagye <aaboagye@chromium.org>
* presubmit: enable branch/checkpatch checksMike Frysinger2015-03-261-0/+5
| | | | | | | | | | | | | We're moving the hardcoded check lists out of the pre-upload script. BUG=chromium:466264 TEST=uploading a CL w/out a branch line is rejected BRANCH=None Change-Id: Ifa0f8c3b4be6a20355babb6f9d8896ac8d1fb2be Signed-off-by: Mike Frysinger <vapier@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/262490 Reviewed-by: Bill Richardson <wfrichar@chromium.org>
* Add presubmit check for unit testVic (Chun-Ju) Yang2014-02-061-0/+2
| | | | | | | | | | | | | | | | This enforces that "make buildall" runs at least once after the last file change. TEST=Try to upload without running "make buildall" TEST=Change a file without re-running "make buildall", and try to upload. BUG=None BRANCH=None Change-Id: Ia4abb3c0e17cf4d559975574f398d74c7986c89f Signed-off-by: Vic (Chun-Ju) Yang <victoryang@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/185116 Reviewed-by: Dave Parker <dparker@chromium.org>
* fix pre-submit hookVincent Palatin2011-12-081-0/+6
we are using linux style indentation, so we should not check for the presence of tabs in the common python script, checkpatch will ensure that the indentation is correct. Signed-off-by: Vincent Palatin <vpalatin@chromium.org> BUG=None. TEST="repo upload" a CL with a new line containing tab indentation. Change-Id: Ida3ef3d8274edd3e8e701e2ede43836c944cd263
View Lorry Controller Status