summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* common/usb_pd_host_cmd: Fix EC_CMD_USB_PD_DISCOVERY paramCaveh Jalali2023-01-181-5/+5
| | | | | | | | | | | | | | | | | | | The EC_CMD_USB_PD_DISCOVERY host command should be implemented to use a 'struct ec_params_usb_pd_info' as the input parameter instead of a uint8_t. Callers (ectool, unit tests, kernel) already pass a 'struct ec_params_usb_pd_info' for this host command, so it makes sense to "fix" the implementation. The struct only has a uint8_t member, so no functional change is introduced. BRANCH=none BUG=b:258110734 TEST='./twister -v -T zephyr/test' passes 'make buildall' passes Change-Id: If6ce382d3ccdbe069d69b02fad6976a7ba09c377 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4171494 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* console: Make it obvious when printk is used for console outputAndrew McRae2023-01-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | Prepend any console messages printed by printk with a marker so that it is obvious. Console output uses printk when invoked from an ISR, and since printk is unbuffered and no mutual exclusion is used, it can be expensive. By highlighting the messages, they can be considered for converting to Zephyr logs. BUG=b:265594963 TEST=Verify that printk messages are marked as desired (e.g DPTF). BRANCH=none Change-Id: Id743cf1ff46dc2d2da0e5c49a96a07378ca7021f Signed-off-by: Andrew McRae <amcrae@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4165984 Reviewed-by: Yuval Peress <peress@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Keith Short <keithshort@chromium.org>
* zephyr: Increase deadline on console_cmds testJeremy Bettis2023-01-181-0/+2
| | | | | | | | | | | | | | | | | | | | | The test timed out in postsubmit: https://ci.chromium.org/p/chromeos/builders/postsubmit/firmware-zephyr-cov-postsubmit/10089 Increase test timeout to 3 minutes. BRANCH=None BUG=None TEST=./twister --test external/platform/ec/zephyr/test/drivers/drivers.default.console_cmds Change-Id: I7f0f680041f0c192df0f8a2f7314a6fcb03be027 Signed-off-by: Jeremy Bettis <jbettis@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4175417 Tested-by: Jeremy Bettis <jbettis@chromium.org> Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Al Semjonovs <asemjonovs@google.com> Commit-Queue: Al Semjonovs <asemjonovs@google.com>
* zephyr: test: ps8xxx: Test cache for multiport boardsJason Yuan2023-01-178-3/+144
| | | | | | | | | | | | | | | | | | | | A new test suite for multi-ps8xxx-port boards is created. A test is implemented for the cache of firmware version for multiple ps8xxx ports to be unique. BUG=b:261874683 TEST=twister BRANCH=none Change-Id: I4b540919dca7ffc4fe8109ba1cf10b828341bc30 Signed-off-by: Jason Yuan <jasonyuan@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4175412 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Tested-by: zhi cheng yuan <jasonyuan@chromium.org> Commit-Queue: zhi cheng yuan <jasonyuan@chromium.org> Reviewed-by: Sam Hurst <shurst@google.com> Commit-Queue: Sam Hurst <shurst@google.com> Auto-Submit: zhi cheng yuan <jasonyuan@chromium.org>
* Frostflow: Implement LED behavior for factory testjohnwc_yeh2023-01-171-0/+14
| | | | | | | | | | | | | | | | | | | | Add PWR_STATE_FORCED_IDLE state PWR_STATE_FORCED_IDLE - AC is connected, battery is not charging. Used during factory testing. LOW_COVERAGE_REASON=Skyrim board tests not created yet: b/247151116 BUG=b:264663411; b:246874455 BRANCH=none TEST=zmake build frostflow, factory test not show 'Node with matching prop not found' Change-Id: I856bd340a504ad961640087af73bce9caab7204b Signed-off-by: johnwc_yeh <johnwc_yeh@compal.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4165995 Commit-Queue: Chao Gui <chaogui@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Diana Z <dzigterman@chromium.org> Reviewed-by: SamSP Liu <samsp_liu2@compal.corp-partner.google.com>
* zephyr: fix all yaml files indentationsFabio Baltieri2023-01-17106-3737/+3737
| | | | | | | | | | | | | | | | | | | | Zephyr upstream now has a yamllint configuration and presubmit check: https://github.com/zephyrproject-rtos/zephyr/blob/main/.yamllint This is a pass on our yaml files to make them compliant with the upstream config, final pass just with the indentation errors. BRANCH=none BUG=none TEST=yamllint -f parsable -c ~/zephyr/.yamllint $( find -regex '.*\.y[a]*ml' ) TEST=zmake compare-builds --ref1 main --ref2 HEAD -a Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I3ccebebddf803b0fd79a1a980a19e25f204b0bb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4154895 Reviewed-by: Al Semjonovs <asemjonovs@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: reformat yaml files to comply with Zephyr yamllintFabio Baltieri2023-01-1767-179/+168
| | | | | | | | | | | | | | | | | | | | Zephyr upstream now has a yamllint configuration and presubmit check: https://github.com/zephyrproject-rtos/zephyr/blob/main/.yamllint This is a pass on our yaml files to make them compliant with the upstream config, handled all checks but the indentation ones. BRANCH=none BUG=none TEST=yamllint -f parsable -c ~/zephyr/.yamllint $( find -regex '.*\.y[a]*ml' ) TEST=zmake compare-builds --ref1 main --ref2 HEAD -a Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I664738cf4777e6f03d4ac2a19a5100e326a386fe Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4154894 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Yuval Peress <peress@google.com>
* zephyr: Add coverage for gpio-keys power_button.cAl Semjonovs2023-01-174-1/+28
| | | | | | | | | | | | | | | | | | Enable gpio-keys power button to exercise tests for board specific code. BUG=None BRANCH=NONE TEST=zmake build --coverage herobrine ./twister -v -i --coverage -p native_posix -p unit_testing genhtml -q -s --branch-coverage -o build/zephyr/coverage_rpt/ twister-out/coverage.info build/zephyr/herobrine/output/zephyr.info Change-Id: I79901e458f1e7fc48806779b05e80cc58a5a83e5 Signed-off-by: Al Semjonovs <asemjonovs@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4159985 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Yuval Peress <peress@google.com>
* zephyr:test: Split console command tests into its own suite.Al Semjonovs2023-01-175-41/+57
| | | | | | | | | | | | | | | | Create a new test suite for console commands. Current default test suite takes excessive time to complete leading to increasing the timeout times. BUG=None BRANCH=None TEST=./twister -T zephyr/test Change-Id: Idb453b0b8f7cc9a61265ac287310772f1b8f24a2 Signed-off-by: Al Semjonovs <asemjonovs@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4159984 Reviewed-by: Simon Glass <sjg@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr:drivers: power button driverAl Semjonovs2023-01-1710-2/+230
| | | | | | | | | | | | | | Add power button driver using Zephyr gpio-keys APIs BUG=b:234728861 BRANCH=NONE TEST=./twister -T zephyr/test Change-Id: I8399f7f0689657b6444a300021161cb8a89c50db Signed-off-by: Al Semjonovs <asemjonovs@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4139709 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Keith Short <keithshort@chromium.org>
* zephyr: zmake: Probe coreboot-sdk from environment variableJack Rosenthal2023-01-173-7/+18
| | | | | | | | | | | | | | | | | | | | When probing the presence of coreboot-sdk, check the environment variable COREBOOT_SDK_ROOT to determine the location, and default to /opt/coreboot-sdk (where it is in the chroot). This also enables us to remove the hard-coded /opt/coreboot-sdk from the cmake rules. BUG=b:259306777 BRANCH=none TEST=COREBOOT_SDK_ROOT=$HOME/coreboot/util/crossgcc/xgcc \ zmake build herobrine Change-Id: Icdfd7feb59db87161748bec1fcb44e1e35e779ed Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4166336 Reviewed-by: Aaron Massey <aaronmassey@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: zmake: Allow tool path customizationJack Rosenthal2023-01-174-5/+30
| | | | | | | | | | | | | | | | | Allow callers of zmake to customize the precise execution of external tools by specifying TOOL_PATH_${program} environment variables. This enables bazel to locate tools where it likes, and we can just tell zmake where they are. BUG=b:259306777 BRANCH=none TEST=tests pass Change-Id: I58b153fbb890766f7ac7e9f590aa098a93576cb4 Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4166335 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Aaron Massey <aaronmassey@google.com>
* console: Optionally drop output from ISRsstabilize-15317.B-mainAndrew McRae2023-01-173-3/+23
| | | | | | | | | | | | | | | | Optionally drop console output originating from interrupt level, to avoid printk locking up the EC for any length of time. BUG=b:265594963 TEST=Verify that logs from ISRs are not printed. BRANCH=none Change-Id: Ib6241d66bb3ec518439b46860804d928fd3fcfdf Signed-off-by: Andrew McRae <amcrae@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4165986 Reviewed-by: Peter Marheine <pmarheine@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* flash: allow zero num_banks_desc in flash_info requestTing Shen2023-01-163-16/+41
| | | | | | | | | | | | | | | | | | | | | | | Some external tools (e.g. flashrom) sends EC_CMD_FLASH_INFO with num_banks_desc=0 to get the total number of banks. EC should allow this type of request. Also add a test to cover this use case. BUG=b:265472751 TEST=1) `flashrom -p ec -w <ec.bin>` on tentacruel 2) ./twister -T zephyr/test/drivers/ \ --sub-test drivers.flash.page_layout 3) ./twister -T zephyr/test/drivers/ --sub-test drivers.flash BRANCH=none Change-Id: Iab97ac754bac87067f949cf9435156be91b07ebc Signed-off-by: Ting Shen <phoenixshen@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4167539 Tested-by: Chen-Tsung Hsieh <chentsung@chromium.org> Reviewed-by: Patryk Duda <patrykd@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Patryk Duda <patrykd@google.com>
* Revert "markarth: Modify GPIO config"firmware-ti50-prepvt-15315.B-mainLeilaCY Lin2023-01-162-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 2366c6f0c8d71b107aa02fe43168f77c190ebc16. Reason for revert: <Keep original design> Original change's description: > markarth: Modify GPIO config > > Add markarth-specific GPIO_LID_SW for lid switch. > > LOW_COVERAGE_REASON=no unit tests for Markarth yet, b/247151116 > BUG=b:264208874 > BRANCH=none > TEST=zmake build Markarth success > > Change-Id: I2559ec953a6047622b1f923ad6e1e38836709165 > Signed-off-by: Leila Lin <leilacy_lin@compal.corp-partner.google.com> > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4135919 > Commit-Queue: LeilaCY Lin <leilacy_lin@compal.corp-partner.google.com.test-google-a.com> > Reviewed-by: Chao Gui <chaogui@google.com> > Tested-by: LeilaCY Lin <leilacy_lin@compal.corp-partner.google.com.test-google-a.com> > Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> > Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Bug: b:264208874 Change-Id: Ied6f1576f4546b233f956b86ef61241247ac3210 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4159632 Tested-by: LeilaCY Lin <leilacy_lin@compal.corp-partner.google.com.test-google-a.com> Reviewed-by: Diana Z <dzigterman@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Josh Tsai <josh_tsai@compal.corp-partner.google.com> Commit-Queue: LeilaCY Lin <leilacy_lin@compal.corp-partner.google.com.test-google-a.com>
* Omnigul : Change Charger from BQ25720 to ISL9241.Logan_Liao2023-01-162-9/+8
| | | | | | | | | | | | | | | | | | This patch change Charger from BQ25710 to ISL9241. BUG=b:262693403 BRANCH=none TEST=make BOARD=omnigul success Change-Id: Idedbcb7cf7beed994b46d8853a21088894313781 Signed-off-by: Logan_Liao <Logan_Liao@compal.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4160822 Reviewed-by: Logan Liao <logan_liao@compal.corp-partner.google.com> Tested-by: Logan Liao <logan_liao@compal.corp-partner.google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Reviewed-by: Kyle Lin <kylelinck@google.com> Commit-Queue: Kyle Lin <kylelinck@google.com>
* cr50/README.md: Use futility over obsolete scriptEdward O'Callaghan2023-01-161-1/+1
| | | | | | | | | | | | | | | | BUG=b:260531154 BRANCH=none TEST=none Change-Id: I9e9cb4aadb7b59d7d1f64847d3e4852ca15f5b9e Signed-off-by: Edward O'Callaghan <quasisec@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4160818 Tested-by: Edward O'Callaghan <quasisec@chromium.org> Reviewed-by: Peter Marheine <pmarheine@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Peter Marheine <pmarheine@chromium.org> Auto-Submit: Edward O'Callaghan <quasisec@chromium.org> Reviewed-by: Evan Benn <evanbenn@chromium.org>
* Winterhold: Add fw_config to support two base sensorsjohnwc_yeh2023-01-162-1/+37
| | | | | | | | | | | | | | | | Use fw_config to separate LIS2DW12 and BMI323. LOW_COVERAGE_REASON=Skyrim board tests not created yet: b/247151116 BRANCH=None BUG=b:262321157 TEST=zmake build winterhold Change-Id: I71d78f232867a54c46a003308590521fd687d94b Signed-off-by: johnwc_yeh <johnwc_yeh@compal.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4135921 Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Reviewed-by: Robert Zieba <robertzieba@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* ap_power: Reduce power signal debug name storageAndrew McRae2023-01-162-0/+15
| | | | | | | | | | | | | | | | | Use shortened power signal debug names by default, unless the BRINGUP config option is set. This reduces flash space usage by around 520 bytes. BUG=none TEST=Verify on craask BRANCH=none Change-Id: I69bdb74e7b272b9f5b842b888052e04e3e659c01 Signed-off-by: Andrew McRae <amcrae@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4165982 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Peter Marheine <pmarheine@chromium.org>
* docs: Document the code coverage test requirementsKeith Short2023-01-134-1/+136
| | | | | | | | | | | | | | Document the code coverage test requirements. BUG=b:261987897 BRANCH=none TEST=View docs in preview mode Change-Id: I0bde6ed3f36f88f4e7d1102c29ea73d112b82e74 Signed-off-by: Keith Short <keithshort@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4166320 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* zephyr: make the test emulator's PD revision configurableJameson Thies2023-01-134-6/+14
| | | | | | | | | | | | | | | | This CL updates the tcpci partner emulator to have an internal variable define how it responds to Get_Revision, instead of hardcoding it's RMDO to 0x31000000 (USBPD 3.1). BUG=b:236868370 BRANCH=None TEST=./twister -p native_posix -p unit_testing Signed-off-by: Jameson Thies <jthies@google.com> Change-Id: Ib212383ce2a29c87f7284a971b2ad96cce6b68c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4159990 Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: Test all ports for correct pd informationJason Yuan2023-01-132-4/+7
| | | | | | | | | | | | | | | | | pd_chip_info is tested for all ports instead of just port 0. BUG=b:261874683 TEST=twister BRANCH=none Change-Id: I338af9781539cd1fe325410d085593832f776120 Signed-off-by: Jason Yuan <jasonyuan@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4159971 Auto-Submit: zhi cheng yuan <jasonyuan@chromium.org> Tested-by: zhi cheng yuan <jasonyuan@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Wai-Hong Tam <waihong@google.com> Reviewed-by: Wai-Hong Tam <waihong@google.com>
* skyrim : Remove EC variant for MorthalChao Gui2023-01-1311-689/+0
| | | | | | | | | | | | | LOW_COVERAGE_REASON= cancelled device specific configuration BUG=none BRANCH=none TEST=zmake compare-builds skyrim Change-Id: I2f806322dea1a7c3629311e6c4f49cb61c22c444 Signed-off-by: Chao Gui <chaogui@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4163824 Reviewed-by: Diana Z <dzigterman@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* geralt: remove rt9490-bc12 dt nodeTing Shen2023-01-132-9/+3
| | | | | | | | | | | | | | | | | RT9490's charger and bc12 nodes are merged in CL:4010984. update Geralt dts to reflect this change. BUG=b:264841530 TEST=USB_CHG task doesn't crash BRANCH=none Change-Id: I9b5d057d713ca563095a55e8d2b25a7da9b3d4c4 Signed-off-by: Ting Shen <phoenixshen@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4159978 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Eric Yilun Lin <yllin@google.com> Reviewed-by: Eric Yilun Lin <yllin@google.com> Tested-by: Simon Zhou <zhouguohui@huaqin.corp-partner.google.com>
* usb_hid_touchpad: add missing headersTing Shen2023-01-131-0/+2
| | | | | | | | | | | | | | | | | Add header file for the definition of uintXX_t and __packed. BUG=none TEST=`make buildall` BRANCH=none Change-Id: I91de127fcb0e4042a387f991c4eef6df526058a6 Signed-off-by: Ting Shen <phoenixshen@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4163829 Auto-Submit: Ting Shen <phoenixshen@chromium.org> Tested-by: Eric Yilun Lin <yllin@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Eric Yilun Lin <yllin@google.com> Reviewed-by: Eric Yilun Lin <yllin@google.com>
* syv682x: cached force discharge configEric Yilun Lin2023-01-132-3/+25
| | | | | | | | | | | | | | | | | | | | syv682x vbus discharge function is getting called from ppc_dev_is_connected to reset the discharge config many times. We cached the force discharge config to reduce the i2c traffics on IT81202 i2c ports. BUG=none TEST=i2c traffic reduces. FRS is working. BRANCH=none Change-Id: Iebae413d8f6621b8c99dc28c744220f54d420062 Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4160813 Reviewed-by: Ting Shen <phoenixshen@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Auto-Submit: Eric Yilun Lin <yllin@google.com> Tested-by: Eric Yilun Lin <yllin@google.com> Commit-Queue: Eric Yilun Lin <yllin@google.com>
* Default charger current derating to 5%Peter Marheine2023-01-1267-3/+98
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Not derating seems like a common pitfall that can cause problems with some chargers, so set a reasonably conservative default. 5% is chosen as the most common derating factor used among boards today (counting occurrences in source code, so this may undercount 5% occurrences because several projects set 5% at the project rather than board-level): 1. 38 x 5% 2. 23 x 4% 3. 6 x 10% 3. 2 x 3% 4. 1 x 2% Boards that currently configure this setting are modified only to continue building without warnings regardless of whether they use the new default value in order to signal that they were explicitly configured. BUG=b:260774380 TEST=make buildall / zmake build -a BRANCH=none Change-Id: I017849d38572fbc48090ae1fa2c539b808e426f9 Signed-off-by: Peter Marheine <pmarheine@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4109651 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* dts: Remove upstream SHI driver in favor of our ownTristan Honscheid2023-01-124-32/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | The upstream commit 3ae105e76b1a47c013d6982a79b3f2fa36b19963 introduces an upstream driver that is conflicting with what we have locally in our device tree by merging in some properties (buffer-rx-size) that we don't have declared in our YAML yet. It also creates a naming conflict with our own `struct shi_reg`. This is blocking downstreaming so delete the device tree nodes introduced by the upstream code for now. Rename our structure to `struct cros_shi_reg`. BUG=None BRANCH=None TEST=Built several boards against Zephyr ToT TEST=./twister -T zephyr/test/drivers/ Signed-off-by: Tristan Honscheid <honscheid@google.com> Cq-Depend: chromium:4155744 Cq-Depend: chromium:4155745 Cq-Depend: chromium:4155746 Change-Id: I3c4b44eaf9692fd0411ef7eee411c1fa0eb1f58e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4158571 Tested-by: Tristan Honscheid <honscheid@google.com> Commit-Queue: Tristan Honscheid <honscheid@google.com> Reviewed-by: Keith Short <keithshort@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: npcx9m7f: Add 360 kB padding to output imageScott Collyer2023-01-121-1/+8
| | | | | | | | | | | | | | | | | | | | This CL adds required padding to the output binary so that the image size will match the npcx9m7f reported image size which will allow flashrom to work properly. BUG=b:260549463 BRANCH=none TEST=ec.bin for rex is now 1MB -rw-r--r-- 1 scollyer primarygroup 1048576 Jan 4 14:38 ec.bin Change-Id: I73ec9e7169a5cf53ee876c8eb028377bde0d249e Signed-off-by: Scott Collyer <scollyer@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4137151 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Madhu 🌱 <mparuchuri@google.com> Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com> Commit-Queue: Scott Collyer <scollyer@chromium.org> Tested-by: Scott Collyer <scollyer@chromium.org>
* zephyr: enable Kconfig based on the devicetree - motionsenseMichał Barnaś2023-01-1212-11/+5
| | | | | | | | | | | | | | | This commit adds automatic selection of required Kconfig options based on the device tree nodes for module: motionsense BUG=b:251812799 BRANCH=main TEST=run twister and zcompare script Change-Id: Icbe3f6b503d803a8d75e17c5eb73993d6be8501c Signed-off-by: Michał Barnaś <mb@semihalf.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3982648 Reviewed-by: Wai-Hong Tam <waihong@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: enable Kconfig based on the devicetree - keyboardMichał Barnaś2023-01-123-3/+7
| | | | | | | | | | | | | | | This commit adds automatic selection of required Kconfig options based on the device tree nodes for module: keyboard BUG=b:251812799 BRANCH=main TEST=run twister and zcompare script Change-Id: I7efb4ed68b475b62d5a399d0f68d2b9e0f1c1bf4 Signed-off-by: Michał Barnaś <mb@semihalf.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3982647 Reviewed-by: Yuval Peress <peress@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* vell: Lower priority to set board id 5 GPIOsDevin Lu2023-01-121-1/+1
| | | | | | | | | | | | | | | | | | To avoid setting board id 5 GPIOs early to cbi data ready. BUG=b:253957352 BRANCH=none TEST=On Vell. System boots. Shorting the SEQ_EC_ALL_SYS_PG to ground is able to see the system shutting down. Change-Id: I99d9fb9572e15908dbb3df30d5c4327d76b4bbf3 Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4145098 Tested-by: Devin Lu <devin.lu@quantatw.com> Reviewed-by: caveh jalali <caveh@chromium.org> Commit-Queue: Devin Lu <devin.lu@quantatw.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* kuldax: Remove the bring-up featuresben chen2023-01-121-0/+3
| | | | | | | | | | | | | | | This patch remove CONFIG_CMD_POWERINDEBUG configuration. BUG=b:255199345 BRANCH=none TEST=make BOARD kuldax PASS Change-Id: I23d55bba87c0bd4443d3222a221a305171d45d40 Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4160811 Reviewed-by: Derek Huang <derekhuang@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: caveh jalali <caveh@chromium.org>
* shim/bc12_rt9490: fix compatibleDino Li2023-01-121-2/+2
| | | | | | | | | | | | | | | Correct shim code since both yaml and dtsi compatibility are "richtek,rt9490". BRANCH=none BUG=none TEST=The rt9490_interrupt isr is registered correctly. Change-Id: Idb1e3d19060852514ba98a513f2f5f34cbda5bc3 Signed-off-by: Dino Li <Dino.Li@ite.com.tw> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4154450 Reviewed-by: Ting Shen <phoenixshen@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* battery: extend BATTERY_GET_STATIC hostcmd for 32-byte stringsPeter Marheine2023-01-124-32/+189
| | | | | | | | | | | | | | | | | | | | | | | The Smart Battery Specification defines a string as up to 31 characters, and nissa project has encountered some batteries where the existing 11-character strings for v1 of BATTERY_GET_STATIC are insufficient to differentiate some batteries that can be used on a given device. This change adds a new version of this host command that extends the strings fields to each accommodate up to 31 characters of data, which should be enough to support all smart batteries compliant with the latest version of the specification. BUG=b:263920422 TEST=`ectool battery` with updated ectool works on Nereid and uses the new hostcmd version. If EC support for v2 or v1 is disabled, older command versions are used. BRANCH=nissa Change-Id: Ia6a3a917051d5e641e7d38ef6936ec7174cb8aab Signed-off-by: Peter Marheine <pmarheine@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4150669 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* craask: add Fw_config structure for thermal solution controlben chen2023-01-126-14/+287
| | | | | | | | | | | | | | | | | | | | | | support thermal solution flag of cbi fw_config, decided 6w/15w thermal solution by FW_THERMAL flag. FW_THERMAL flag address bit10 size 3 of cbi fw_config: 0 :FW_THERMAL_6W 1 :FW_THERMAL_6W 2 :FW_THERMAL_15W BUG=b:264701585 BRANCH=none TEST=check with thermal table workable. Change-Id: Iaa70a86ffc08d175422ededc479479bbfed52d30 Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4085594 Code-Coverage: Andrew McRae <amcrae@google.com> Reviewed-by: Andrew McRae <amcrae@google.com> Commit-Queue: Andrew McRae <amcrae@google.com>
* Markarth : Disable chg_alt function.Logan_Liao2023-01-124-54/+5
| | | | | | | | | | | | | | | | | | | | | Markarth just have one charger-ISL9241, so disable chg_alt function. LOW_COVERAGE_REASON=no unit tests for Markarth yet, b/247151116 BUG=none BRANCH=none TEST=zmake build Markarth success. Change-Id: Ic7724248e8ed9d1909082ee7d10d5e9d6d05dbe2 Signed-off-by: Logan_Liao <Logan_Liao@compal.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4145100 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Reviewed-by: Logan Liao <logan_liao@compal.corp-partner.google.com> Reviewed-by: Chao Gui <chaogui@google.com> Tested-by: Logan Liao <logan_liao@compal.corp-partner.google.com> Commit-Queue: Logan Liao <logan_liao@compal.corp-partner.google.com> Reviewed-by: Robert Zieba <robertzieba@google.com> Reviewed-by: Diana Z <dzigterman@chromium.org>
* omnigul: Initial EC imagejamie_chen2023-01-1220-0/+2279
| | | | | | | | | | | | | | | | | | Create the initial EC image for the omnigul variant by copying the brya reference board EC files into a new directory named for the variant. (Auto-Generated by create_initial_ec_image.sh version 1.5.0). BUG=b:263060849 BRANCH=None TEST=make BOARD=omnigul Change-Id: Ic663c847cd46c539ac2ed72cac587de55c4319ff Signed-off-by: jamie_chen <jamie_chen@compal.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4131895 Reviewed-by: Kyle Lin <kylelinck@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* nissa: add a board for Nereid with IT81302 CXPeter Marheine2023-01-124-1/+34
| | | | | | | | | | | | | | | | | Some devices have been reworked to the use the newer CX EC; add a target to build firmware targeting that chip. Existing firmwares should work on the CX chip, but a new target is required to take advantage of some of the new chip's improvements. BUG=b:240485526 TEST=zmake build nereid_cx; flash on reworked board BRANCH=none Change-Id: I5a282c6990f44adfcf792e2889da008688a4d079 Signed-off-by: Peter Marheine <pmarheine@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4159451 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Andrew McRae <amcrae@google.com>
* battery_get_static: use strzcpyPeter Marheine2023-01-111-20/+10
| | | | | | | | | | | | | | | | It's simpler to use strzcpy instead of memcpy and manually inserting terminators, since strzcpy will ensure the output is terminated correctly (unlike strncpy). BUG=none TEST=builds BRANCH=none Change-Id: I21d3f61fb439136ba5c1ecc0b700d4c284267dfc Signed-off-by: Peter Marheine <pmarheine@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4150678 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* board/hyperdebug: Enumerate and configure SPI ports via USBJes B. Klinke2023-01-112-2/+146
| | | | | | | | | | | | | | | | | | | Add console commands: spiget and spisetspeed The first can list information on all SPI port or a particular port. The other, spisetspeed, can be used to modify the clock divisor between SPI transactions. BUG=b:192262089 TEST=Observed different clock speeds on analyzer Change-Id: I113b8bdef48f58d5941212c8a8598f3293b5da91 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4078008 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Tested-by: Jes Klinke <jbk@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Jes Klinke <jbk@chromium.org>
* board/hyperdebug: Add support for OCTOSPIJes B. Klinke2023-01-112-21/+311
| | | | | | | | | | | | | | | Add ability to perform individual SPI transactions on the OCTOSPI controller, so far using only 1 data wire in each direction. BUG=b:192262089 TEST=Observe HyperDebug communicate with SPI flash Change-Id: I19ffdc510c00c8fdce636f2400c395184bbf8e87 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4089988 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Tested-by: Jes Klinke <jbk@chromium.org> Commit-Queue: Jes Klinke <jbk@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* ec: Add #line directive to fix coverageJeremy Bettis2023-01-111-0/+7
| | | | | | | | | | | | | | | | | | Once again, gcc is buggy when importing common.h. Add #line to usb_pd_tcpm.h where the problem is showing up today. BRANCH=None BUG=b:265061949 TEST=See bug Change-Id: I08ed9f5574e026dbc371c7634d0bf046df9c95ac Signed-off-by: Jeremy Bettis <jbettis@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4157000 Tested-by: Jeremy Bettis <jbettis@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Al Semjonovs <asemjonovs@google.com> Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
* gitlab: Disable upstream coverage reportsJeremy Bettis2023-01-111-43/+47
| | | | | | | | | | | | | | | | | | | | | | | | Downloading the zephyr coverage data from codecov.io isn't working. Disable twister_coverage job and comment out the steps that depend on it. BRANCH=None BUG=None TEST=Validated yaml at https://gitlab.com/zephyr-ec/ec/-/ci/editor?branch_name=main&tab=2 Change-Id: I0c70b8124de073c9570c0e94a1758d2f2103c0a9 Signed-off-by: Jeremy Bettis <jbettis@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4156999 Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Simon Glass <sjg@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Tristan Honscheid <honscheid@google.com> Tested-by: Jeremy Bettis <jbettis@chromium.org> Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Yuval Peress <peress@google.com> Reviewed-by: Simon Glass <sjg@chromium.org>
* zephyr/test/drivers/flash: Add flash bank API testsPatryk Duda2023-01-112-0/+106
| | | | | | | | | | | | | | | | | | | | | | Introduce unit tests for functions that implement basic API for operating on information about flash sectors. Tests are run only when CONFIG_PLATFORM_EC_USE_ZEPHYR_FLASH_PAGE_LAYOUT is enabled. BUG=b:239712345 BRANCH=none TEST=./twister -v -i -T zephyr/test/drivers/ --test external/platform/\ ec/zephyr/test/drivers/drivers.flash.page_layout Signed-off-by: Patryk Duda <pdk@semihalf.com> Change-Id: I6e1a37e7137b49983fc3447ebdc9fff73df43458 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4110952 Reviewed-by: Edward Hill <ecgh@chromium.org> Reviewed-by: Bobby Casey <bobbycasey@google.com> Tested-by: Patryk Duda <patrykd@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Patryk Duda <patrykd@google.com>
* zephyr/test/drivers: Add flash page layout test variantPatryk Duda2023-01-112-20/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | Introduce drivers.flash test variant with CONFIG_PLATFORM_EC_USE_ZEPHYR_FLASH_PAGE_LAYOUT enabled. If the option is enabled, we use Zephyr's flash page API to get information about flash sectors, sizes, etc. instead of providing these information in EC. Since the API provides flash sector description, we only support flash info version 2 host command. Also output from "flashinfo" command is slightly different. BUG=b:239712345 BRANCH=none TEST=./twister -v -i -T zephyr/test/drivers/ --test external/platform/\ ec/zephyr/test/drivers/drivers.flash.page_layout Signed-off-by: Patryk Duda <pdk@semihalf.com> Change-Id: I1f459232f6bc1c786e8c16bf2537f68229b90862 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4118762 Reviewed-by: Bobby Casey <bobbycasey@google.com> Commit-Queue: Patryk Duda <patrykd@google.com> Reviewed-by: Ting Shen <phoenixshen@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Tested-by: Patryk Duda <patrykd@google.com>
* shim/src/flash: Add functions for providing flash sectors infoPatryk Duda2023-01-115-0/+206
| | | | | | | | | | | | | | | | | | | | | Introduce Zephyr counterparts of functions that provide information about flash sectors, total number of sectors, size of array to describe sector types, etc. These functions use Zephyr flash pages API. To use functions, enable PLATFORM_EC_USE_ZEPHYR_FLASH_PAGE_LAYOUT config. BUG=b:239712345 BRANCH=none TEST=zmake build -a --clobber Signed-off-by: Patryk Duda <pdk@semihalf.com> Change-Id: I9ee9a8f36401e4643adfa150c745ba502b72c36a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4030378 Tested-by: Patryk Duda <patrykd@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Patryk Duda <patrykd@google.com>
* flash: Introduce functions for filling flash regions infoPatryk Duda2023-01-112-24/+72
| | | | | | | | | | | | | | | | | | | | | | | EC_CMD_FLASH_INFO requires flash_bank_array to be defined if flash banks have different size. When using Zephyr the array is not available. In this case we should use the Zephyr flash API. Moving code that depends on flash_bank_array will make easier to to enable support for variable bank sizes in CrosEC with Zephyr. The change also makes existing code easier to read and understand. BUG=b:239712345 BRANCH=none TEST=make buildall -j Signed-off-by: Patryk Duda <pdk@semihalf.com> Change-Id: I4da19c3c302a9b64cfa4c851b3bdac10b7c438d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3932162 Reviewed-by: Bobby Casey <bobbycasey@google.com> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Patryk Duda <patrykd@google.com> Tested-by: Patryk Duda <patrykd@google.com>
* util: Improve uart_stress_tester.pyEdward Hill2023-01-111-1/+1
| | | | | | | | | | | | | | | | Ignore UTF8 decode errors when reading UART output. We don't care what data is read while flushing during setup, and any errors during the test will still be detected and reported. BUG=b:227228605 BRANCH=none TEST=uart_stress_tester.py -t 10 -d <raw_ec_uart> <raw_cpu_uart> Change-Id: Ie12a3d8a4259f50ec38a85777ae0932f56e4dff1 Signed-off-by: Edward Hill <ecgh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4153075 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Mark Hasemeyer <markhas@google.com>
* body_detection: Remove get_resolutionGwendal Grignou2023-01-113-20/+6
| | | | | | | | | | | | | | | | | EC accelerometer drivers already pad data from sensors when resolution is less than 16 bits. No more resolution processing is needed when measuring body activity. BUG=b:262680246 BRANCH=none TEST=Unit test. Change-Id: Iff7df3915e855e25abc287a3c2caa477fd678f27 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4148783 Reviewed-by: Diana Z <dzigterman@chromium.org> Tested-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
View Lorry Controller Status