summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* flash_ec: change ec_reset to gsc_ec_resetstabilize-quickfix-15278.72.B-mainstabilize-15278.64.B-mainrelease-R110-15278.B-mainScott Chao2023-01-101-4/+4
| | | | | | | | | | | | | | | | | | | | After CL:4108949, the ec_reset have changed to gsc_ec_reset. This CL will avoid flash error due to No control named "ec_reset". BUG=none BRANCH=none TEST=use c2d2 and flash ec Change-Id: I28c8c957b3a5d24b659bb5234e9538bff0898871 Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4135920 Reviewed-by: Mary Ruthven <mruthven@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Mary Ruthven <mruthven@chromium.org> (cherry picked from commit 8163dba9aebb47b2bdca455463060b947fc5c382) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4140104 Tested-by: Garry Wang <xianuowang@chromium.org> Commit-Queue: Garry Wang <xianuowang@chromium.org>
* zephyr: usbc: add a binding for intel,jhl9040rFabio Baltieri2022-12-1511-24/+47
| | | | | | | | | | | | | | | | | | Current projects are reusing the jhl8040r (BB) binding for the jhl9040r (HB) and relying on a Kconfig entry to build the right driver. Add a dedicated compatible and binding so that the correct option can be selected automatically. BRANCH=none BUG=none TEST=zmake compare-builds -a Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: Icffd607d7cad270a33a8cbf7d6d359cbaec3d253 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4101025 Reviewed-by: Aaron Massey <aaronmassey@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: config: drop a bunch of automatic options from testsFabio Baltieri2022-12-155-8/+1
| | | | | | | | | | | | | | | Drop a bunch of options that are already automatically selected based on the devicetree nodes. BRANCH=none BUG=none TEST=./twister Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I52045e478c5c02bdbbda0dd3f30de1a67ff3b6a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4100866 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Wai-Hong Tam <waihong@google.com>
* zephyr: config: drop a bunch of automatic optionsFabio Baltieri2022-12-1514-30/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Drop a bunch of options that are already automatically selected based on the devicetree nodes. Found these hacking this snippet in kconfig.py: ``` f = open("/tmp/options", "w") for name, val in kconf.syms.items(): dep = expr_str(val.direct_dep) if "DT_HAS_" in dep: print(name) f.write(name + "\n") f.close() ``` and ``` for x in $( cat /tmp/options ); do git grep CONFIG_$x=y; done ``` Should make it a presubmit check eventually. BRANCH=none BUG=none TEST=zmake compare-builds -a Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I9005a3cef2073073b88d47192c7b30ccab6c9e58 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4100865 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Keith Short <keithshort@chromium.org>
* zephyr: reorganize dts files in krabby testTing Shen2022-12-156-65/+70
| | | | | | | | | | | | | | | | | | | | The DTC_OVERLAY_FILE line in testcase.yaml is too long now. Migrate to the latest project.overlay style to manage the dts files better. BUG=none TEST=twister -v -i --coverage -p native_posix -p unit_testing \ -T zephyr/test/krabby BRANCH=none Change-Id: Idb5332f84690f8c46bc23b7715b625f247e62d95 Signed-off-by: Ting Shen <phoenixshen@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4109550 Tested-by: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Eric Yilun Lin <yllin@google.com> Auto-Submit: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Eric Yilun Lin <yllin@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* redrix: derate charger current by 6%Boris Mittelberg2022-12-151-0/+2
| | | | | | | | | | | | | | | Measurements taken in b/260774380 indicated excessive current draw. Fixing this by derating the current as many other boards do. BRANCH=none BUG=b:260774380 TEST=manual Change-Id: I8bd151d5d686e4f80015e45adb12fb0864053c84 Signed-off-by: Boris Mittelberg <bmbm@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4109116 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Peter Marheine <pmarheine@chromium.org>
* corsola/ite: Increase MOTIONSENSE stack sizeDino Li2022-12-151-1/+1
| | | | | | | | | | | | | | | | Fixes b:262467846. BRANCH=none BUG=b:262467846 TEST=no stack overflow panic when switching tablet mode. Change-Id: I1f3b53c6e1d91ba215a79ec388e5cc3d579969ec Signed-off-by: Dino Li <Dino.Li@ite.com.tw> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4110088 Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Luluboy Jian <luluboy_jian@asus.corp-partner.google.com> Reviewed-by: Ting Shen <phoenixshen@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* tentacruel: add lid sensor 2nd source BMA422.jeffrey2022-12-159-51/+607
| | | | | | | | | | | | | | | | | add BMA422 lid sensor and modify FW config conditions. BUG=b:255501962 TEST=ectool motionsense info to check sensor are initial success. confirm lid angle. BRANCH=firmware-corsola-15194.B Signed-off-by: jeffrey <jeffrey_lin@pegatron.corp-partner.google.com> Change-Id: Iaf4eb89586854d5accc0643caca52875793e2152 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4087970 Reviewed-by: Eric Yilun Lin <yllin@google.com> Tested-by: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* xivur: remove sub board settingjeffrey2022-12-159-70/+88
| | | | | | | | | | | | | | | | | | | | | Depend on design, sub-board only have Type-C 1. remove sub-board gpio aliases 2. add gpio_usb_c1_int_odl interrupt pin 3. add gpio_en_usb_a1_vbus netname 4. add fan fw config 5. modify fan condition BUG=b:256042758 TEST=zmake build xivur --clobber make sure sub board c1 can use. BRANCH=nissa Change-Id: I79d35c8504a943e3bef51954389839b93f9fcbbf Signed-off-by: jeffrey <jeffrey_lin@pegatron.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4105061 Reviewed-by: Andrew McRae <amcrae@google.com> Code-Coverage: Andrew McRae <amcrae@google.com>
* Frostflow: Implement LED behavior for RSOCjohnwc_yeh2022-12-151-8/+24
| | | | | | | | | | | | | | | | | | | | | | | | The EC modifies the raw battery level to a 'Display' level that is then sent to the AP. Battery Display 0-94%:Amber Battery Low Display 0-10% The Display values map to raw values as: Display Raw 10 13 11 14 94 91 95 92 BUG=b:258153920 BRANCH=none TEST=zmake build frostflow Change-Id: Iec114b47109f57f15db09dcc80cdb077c4ab884b Signed-off-by: johnwc_yeh <johnwc_yeh@compal.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4105800 Reviewed-by: Diana Z <dzigterman@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: SamSP Liu <samsp_liu2@compal.corp-partner.google.com>
* nissa: allow Vconn swap only if 5V power rails are enabledDeepti Deshatty2022-12-151-2/+5
| | | | | | | | | | | | | | | | | change allows port Vconn swap only if the platform power rails are up and stable. Without this change "hard resets" are seen in S5 power state while enumerating typec device on boot. BUG=b:258143457 TEST=Typec Dock enumeration verified on craask. BRANCH=none Change-Id: Ia6c80d05879ad7da61363b4bedb8ee5aeb8cc16e Signed-off-by: Deepti Deshatty <deepti.deshatty@intel.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4105949 Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com> Reviewed-by: Andrew McRae <amcrae@google.com> Code-Coverage: Andrew McRae <amcrae@google.com>
* nissa: Decouple sub-board dependencyAndrew McRae2022-12-1532-82/+54
| | | | | | | | | | | | | | | | Decouple the sub-board processing from common nissa code so that variants do not need to include the fw_config for sub-boards, nor the sub-board support functions. BUG=none TEST=twister -T zephyr/test; zmake build --all BRANCH=none Change-Id: I4382b94c0493b30103d22c1c28d8bf46142136e9 Signed-off-by: Andrew McRae <amcrae@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4104646 Reviewed-by: Peter Marheine <pmarheine@chromium.org>
* flash_ec: add flash_mec1322Mary Ruthven2022-12-151-0/+4
| | | | | | | | | | | | | | | | mec1322 boards are still used in the lab. flash_ec needs to support them. Readd the flash_mec1322 function. BUG=b:262603036 BRANCH=none TEST=none Change-Id: I8a6ebeba19f65a3351ae9932956f2b128660dc47 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4109268 Commit-Queue: Tom Hughes <tomhughes@chromium.org> Reviewed-by: Tom Hughes <tomhughes@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* rex: Enable AP mode entryLi Feng2022-12-141-0/+2
| | | | | | | | | | | | | | | | Data reset feature is required for USB4 products. This CL enables both AP mode entry and data reset. BUG=b:247192444 BRANCH=none TEST=on Rex, boot to OS, log in, connect Dell dock, AP requests to enter TBT mode; connect Gatkex, AP requests to enter USB4 mode. Signed-off-by: Li Feng <li1.feng@intel.com> Change-Id: I7bd0c5ab4a16ad02af089d50657ce7a182ca10e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3883758 Reviewed-by: Scott Collyer <scollyer@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* Raa489000: Remove dependency on BC 1.2Kyle Lin2022-12-141-1/+1
| | | | | | | | | | | | | | | | | | Change the charge supplier from VBUS to type-c during raa489000 initialization to remove the dependency on BC 1.2 feature. BUG=b:256539662 TEST=Disable BC 1.2 feature on Pujjo. Pujjo can boot without battery. BRANCH=None LOW_COVERAGE_REASON=No RAA emulator yet Change-Id: I4156da55d10e9e1fef78e4e4a3e9e7ca5109dca3 Signed-off-by: Kyle Lin <kylelinck@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4037123 Reviewed-by: Diana Z <dzigterman@chromium.org> Commit-Queue: Diana Z <dzigterman@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Code-Coverage: Diana Z <dzigterman@chromium.org>
* USB mux: Remove polarity from SAFE mode setsDiana Z2022-12-141-1/+2
| | | | | | | | | | | | | | | | | Currently, we don't send polarity down to drivers for NONE mode. We should do likewise for SAFE mode, which is generally the same as NONE in most applications. BRANCH=None BUG=b:260045058 TEST=on skyrim, ensure SAFE mode is set for either orientation for dongles Change-Id: I7e63804ed46d082dd8db9cee09739d62b466edb6 Signed-off-by: Diana Z <dzigterman@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4104563 Reviewed-by: Andrew McRae <amcrae@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* marasov: Implement keyboard and keyboard backlight functionMichael5 Chen12022-12-143-8/+38
| | | | | | | | | | | | | | | | | | | | | 1. Depend on keyboard matrix, implement keyboard function. 2. Modify keyboard backlight config depend on fw_config. BUG=b:261915212 BRANCH=none TEST=manual 1. Check all key by evtest. 2. Check Function key behavior. 3. Check keyboard backlight function. (FW Config bit 0 set 0/1) 3.1. Alt + Bright up/down 3.2. Check EC GPIO EC_KB_BL_EN_L status Change-Id: I7fd561e0475c59ac5221be78a1f76b49cb2d974d Signed-off-by: Michael5 Chen1 <michael5_chen1@pegatron.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4085108 Reviewed-by: Kyle Lin <kylelinck@google.com> Commit-Queue: Kyle Lin <kylelinck@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* Xivu: Implement LED behavior for RSOCjohnwc_yeh2022-12-141-8/+25
| | | | | | | | | | | | | | | | | | | | | | | | The EC modifies the raw battery level to a 'Display' level that is then sent to the AP. Battery Display 0-94%:Amber Battery Low Display 0-10% The Display values map to raw values as: Display Raw 10 13 11 14 94 91 95 92 BUG=b:237224850 BRANCH=none TEST=zmake build xivu Change-Id: I28417287710057ac7f37d932251d9e8dc392dfd2 Signed-off-by: johnwc_yeh <johnwc_yeh@compal.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4100346 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: SamSP Liu <samsp_liu2@compal.corp-partner.google.com> Reviewed-by: Andrew McRae <amcrae@google.com>
* geralt: headers cleanupEric Yilun Lin2022-12-145-10/+5
| | | | | | | | | | | | | | | | | | Drop unnecessary headers, and replace them with the shortest include dependency. BUG=none TEST=zmake buildd geralt BRANCH=none Change-Id: I3201c59bddd559f0f0910099eb7e344defa7882b Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4100032 Auto-Submit: Eric Yilun Lin <yllin@google.com> Reviewed-by: Sung-Chi Li <lschyi@chromium.org> Commit-Queue: Eric Yilun Lin <yllin@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Tested-by: Eric Yilun Lin <yllin@google.com>
* Banshee: Set 'DP CONNECTION' bitjohnwc_yeh2022-12-141-4/+48
| | | | | | | | | | | | | | | | | | | | | | | Set 'DP CONNECTION' bit when mux_state gets HPD event only on the ports with HDMI/DP card It will increase BBR power consumption, so set 'DP CONNECTION' bit only when mux_state gets HPD event only on the ports with HDMI/DP card. BUG=b:233975818 BRANCH=None TEST=make BOARD=banshee,test on Banshee, when only hdmi card 'DP CONNECTION' bit is 0. Enter console command bb 1 r 4 =0x403, plug in hdmi monitor bb 1 r 4 =0x8503. Change-Id: Ibe4f3d7fec6349d4033113f7340139dee8736aff Signed-off-by: johnwc_yeh <johnwc_yeh@compal.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4082508 Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Reviewed-by: Boris Mittelberg <bmbm@google.com> Reviewed-by: Diana Z <dzigterman@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* xivur: Implement keyboard functionjeffrey2022-12-145-18/+22
| | | | | | | | | | | | | | | | | | Depend on design, no support keyboard backlight modify keyboard function. 1.remove keyboard backlight 2.keyboard scan setting BUG=b:261942045 TEST=zmake build xivur --clobber BRANCH=nissa Change-Id: I50261a6982a4b3456db83ba765529fc77726ddba Signed-off-by: jeffrey <jeffrey_lin@pegatron.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4090776 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Andrew McRae <amcrae@google.com>
* villager: support keyboard factory testben chen2022-12-135-0/+57
| | | | | | | | | | | | | | | | Enable KB factory test BUG=none BRANCH=none TEST=ectool kbfactorytest workable Change-Id: I4709b6984706cd5e6d599ffcf727aa907338500d Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4090778 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Bob Moragues <moragues@chromium.org> Reviewed-by: Wai-Hong Tam <waihong@google.com> Reviewed-by: Bob Moragues <moragues@chromium.org>
* zephyr: ap_pwrseq: use Kconfig helper symbol for signal featuresFabio Baltieri2022-12-1310-53/+65
| | | | | | | | | | | | | | | | | | Use zephyr Kconfig symbol instead of custom HAS_ macros for compatible based files. This allows dropping some compiler guards as well. Fix some missing #include that got exposed in the process. BRANCH=none BUG=none TEST=cq dry run TEST=zmake compare-builds -a Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I1b76e66b410d01a67944504a2b9ad6651bac1d2f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4097133 Reviewed-by: Al Semjonovs <asemjonovs@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: ap_pwrseq: select CONFIG_AP_PWRSEQ automaticallyFabio Baltieri2022-12-137-10/+2
| | | | | | | | | | | | | | | Select CONFIG_AP_PWRSEQ and drop a few unnecessary #if guards. BRANCH=none BUG=none TEST=cq dry run TEST=zmake compare-builds -a Change-Id: Ia85badce8b5bb998c99c13b8039b2d52f1ab5b22 Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4097132 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Aaron Massey <aaronmassey@google.com>
* zephyr: usb: set a bunch of USBC options automaticallyFabio Baltieri2022-12-1327-59/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Change most of the USBC options with an associated compatible string to enable automatically when the corresponding device is defined in the devicetree. Most of these don't use the actual struct device yet and only enable a corresponding ECOS option, and few boards have not been ported to have the whole usb-c configuration in the devicetree, so some option is a "default y if ..." rather than a "depends on" so that that can still be enabled without the device tree node. That can be fixed in the future as all the boards are ported. This disables an option for: hoglin, villager, zoglin, zombie due to a missing dt device (CONFIG_PLATFORM_EC_USBC_PPC_SN5S330) which was otherwise enabled for all variations. BRANCH=none BUG=none TEST=cq dry run TEST=zmake compare-builds -a # catches the one above Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: Ifd543965c2867b35954f48a3fb7afa5289b6e940 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4054626 Reviewed-by: Yuval Peress <peress@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* Zephyr test: Add tests for AP VDM repliesDiana Z2022-12-131-3/+188
| | | | | | | | | | | | | | | | | | | Add tests verifying we get the expected results for both ACK and NAK commands, as well as some error conditions. This also corrects a logical error in the previous tests for the VDM_REQ host command, which had not correctly verified the message passed through. BRANCH=None BUG=b:208884535 TEST=./twister -T ./zephyr/test Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: I763d0270c7a38b92948ce1b0c2c7fc0dafb07150 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4048914 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* Zephyr test: Add utility for VDM_RESPONSE HCDiana Z2022-12-132-0/+23
| | | | | | | | | | | | | | | Add a utility which tests may use to fetch VDM responses, as the AP would. BRANCH=None BUG=b:208884535 TEST=./twister -T ./zephyr/test/drivers Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: I7b713f7da1d18e78c854ae4f65714eae8e4cfd79 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4048913 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* TCPMv2: Make VDM ACKs available to the APDiana Z2022-12-135-6/+182
| | | | | | | | | | | | | | | | | When the AP is supplying VDM REQ messages, the responses should be delivered to the AP after the message has either sent or failed to send. Add storage of the reply in the DPM. BRANCH=None BUG=b:208884535 TEST=./twister -T ./zephyr/test, on skyrim ensure VDM responses and events are seen for both successful and unsuccessful REQs Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: Ica713c3b3f3f571f193c1458a0e28788cd205c72 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3990995 Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* test: Increase tolerance of timer testAndrea Grandi2022-12-131-1/+1
| | | | | | | | | | | | | | | | | | | Timer test is flaky on hardware so we increase the tolerance to avoid false errors. This is okay since the primary goal of the test is to verify we can build timer functions on all platforms, not verify their accuracy. BUG=b:260723169 TEST=test/run_device_tests.py -b bloonchipper -t timer TEST=test/run_device_tests.py -b dartmonkey -t timer TEST=make run-timer BRANCH=none Signed-off-by: Andrea Grandi <agrandi@google.com> Change-Id: I0442fe212ce305b04ad89ba67e227abd6bcc7fa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4093614 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Tom Hughes <tomhughes@chromium.org>
* BB retimer: Add condition to set 'DP CONNECTION' bitjohnwc_yeh2022-12-134-0/+63
| | | | | | | | | | | | | | | | | | | | | | | | | Set 'DP CONNECTION' bit when mux_state gets HPD event only on the ports with HDMI/DP card It will increase BBR power consumption, so set 'DP CONNECTION' bit only when mux_state gets HPD event only on the ports with HDMI/DP card. BUG=b:233975818 BRANCH=None TEST=Test on Banshee, when only hdmi card 'DP CONNECTION' bit is 0. Enter console command bb 1 r 4 =0x403, plug in hdmi monitor bb 1 r 4 =0x8503. Run ./twister -T zephyr/test/drivers Signed-off-by: johnwc_yeh <johnwc_yeh@compal.corp-partner.google.com> Change-Id: I87b2a4379e66e08830c556d703390a7fb96d3258 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4050320 Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Reviewed-by: Diana Z <dzigterman@chromium.org> Commit-Queue: Boris Mittelberg <bmbm@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Boris Mittelberg <bmbm@google.com>
* driver/tcpm: PD event for VBUS change shouldn't depend on BC 1.2Kyle Lin2022-12-131-5/+7
| | | | | | | | | | | | | | | | PD event for VBUS change should always be set whether BC 1.2 feature is enabled or not. BUG=b:256539662 TEST=Disable BC 1.2 on Pujjo. USB PD charging works OK. BRANCH=None Change-Id: I4e0965f8019fe29a929ce52fc9aab493b7b8b6dd Signed-off-by: Kyle Lin <kylelinck@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4099988 Commit-Queue: Diana Z <dzigterman@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* include/test_util: Unify absolute value macrosTom Hughes2022-12-131-3/+2
| | | | | | | | | | | | | | | | | | The ABS macro already exists in math_util.h, so use that instead of creating a new macro in test_util.h. BRANCH=none BUG=b:234181908 TEST=make buildall TEST=./util/compare_build.sh -b all -j 120 => MATCH Change-Id: I0a034123abd97512b35413c3cef24dcaebf4ce93 Signed-off-by: Tom Hughes <tomhughes@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4098874 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* herobrine: Support board level charger_profile_overrideYu-An Chen2022-12-131-0/+7
| | | | | | | | | | | | | | | | Support board level charger_profile_override BUG=b:259508078 BRANCH=none TEST=zmake build evoker LOW_COVERAGE_REASON=board-specific code is not tested Change-Id: I6b50e3327c38c80b3d40e15f59d23c94850e45f3 Signed-off-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4096357 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Wai-Hong Tam <waihong@google.com> Reviewed-by: Bob Moragues <moragues@chromium.org>
* marasov: modify fw_config settingMichael5 Chen12022-12-132-24/+18
| | | | | | | | | | | | | | | Modify FW_CONFIG setting. BUG=b:256374573 BRANCH=none TEST=make BOARD=marasov Change-Id: I4b0c174048abb331fa3c96388f9026769e4e0ae4 Signed-off-by: Michael5 Chen1 <michael5_chen1@pegatron.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4090782 Commit-Queue: Kyle Lin <kylelinck@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Kyle Lin <kylelinck@google.com>
* endeavour: Increase fan to reduce throttling.Richard Yeh2022-12-131-57/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Chromebox for Meetings (CfM) devices are videoconferencing appliances. Discovering that a significant fraction of our fleet was throttling the CPU due to temperature, resulting in bad video quality, we have decided that these devices should never throttle. The present change reduces the temperature thresholds at which we increase fan speeds. For most of the time, when the CfM is idle, we expect no or little change in fan speeds. During calls, the CfM CPU can exceed 60 C, and the sensors controlling the fan are typically 10-20 degrees C cooler than the CPU, so we set the maximum-fan temperature to 50-55 C in an attempt to arrest any temperature increase before the CPU reaches throttling temperatures. We add fan tables to enable hysteresis in the fan speed setting. Fan RPMs are chosen to span the min-to-max range, while avoiding 50 Hz and 60 Hz line frequencies. fizz and kalista boards are shared with non-CfM versions, while the other boards are CfM-only. Since those boards are several years old, we plan to build these firmware changes only into CfM-branch releases, not all fizz and kalista devices. Additional details at go/cfm-overheating . Temperature traces with load testing on both top-of-tree and firmware with this change are shown at go/cfm-overheating#heading=h.ykpzxotgnu2j BRANCH=update-fan-tables BUG=b:252966838,b:191187610,chromium:1383859 TEST=Confirmed validity of settings with `ectool thermalset`. Built firmware, flashed to endeavour and excelsior (fizz), verified that fan turns on earlier. This does not completely prevent throttling from 47.25 W to 15.00 W on Kaby Lake boards (endeavour, fizz, kalista), but it does prevent dropping below 15.00 W. Comet Lake boards (ambassador, genesis, moonbuggy, scout) start at 15.00 W and rarely throttle anyway. Signed-off-by: Richard Yeh <rcy@google.com> Change-Id: I3719b6828411bda4e0c1efde58065ef2cf35ceea Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4060609 Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* fizz: Increase fan to reduce throttling.Richard Yeh2022-12-131-84/+97
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Chromebox for Meetings (CfM) devices are videoconferencing appliances. Discovering that a significant fraction of our fleet was throttling the CPU due to temperature, resulting in bad video quality, we have decided that these devices should never throttle. The present change reduces the temperature thresholds at which we increase fan speeds. For most of the time, when the CfM is idle, we expect no or little change in fan speeds. During calls, the CfM CPU can exceed 60 C, and the sensors controlling the fan are typically 10-20 degrees C cooler than the CPU, so we set the maximum-fan temperature to 50-55 C in an attempt to arrest any temperature increase before the CPU reaches throttling temperatures. We add fan tables to enable hysteresis in the fan speed setting. Fan RPMs are chosen to span the min-to-max range, while avoiding 50 Hz and 60 Hz line frequencies. fizz and kalista boards are shared with non-CfM versions, while the other boards are CfM-only. Since those boards are several years old, we plan to build these firmware changes only into CfM-branch releases, not all fizz and kalista devices. Additional details at go/cfm-overheating . Temperature traces with load testing on both top-of-tree and firmware with this change are shown at go/cfm-overheating#heading=h.ykpzxotgnu2j BRANCH=update-fan-tables BUG=b:252966838,b:191187610,chromium:1383859 TEST=Confirmed validity of settings with `ectool thermalset`. Built firmware, flashed to endeavour and excelsior (fizz), verified that fan turns on earlier. This does not completely prevent throttling from 47.25 W to 15.00 W on Kaby Lake boards (endeavour, fizz, kalista), but it does prevent dropping below 15.00 W. Comet Lake boards (ambassador, genesis, moonbuggy, scout) start at 15.00 W and rarely throttle anyway. Change-Id: I4eb532977677fbfd939fc46f851948cd4adf9788 Signed-off-by: Richard Yeh <rcy@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4004441 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* kalista: Increase fan to reduce throttling.Richard Yeh2022-12-131-57/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Chromebox for Meetings (CfM) devices are videoconferencing appliances. Discovering that a significant fraction of our fleet was throttling the CPU due to temperature, resulting in bad video quality, we have decided that these devices should never throttle. The present change reduces the temperature thresholds at which we increase fan speeds. For most of the time, when the CfM is idle, we expect no or little change in fan speeds. During calls, the CfM CPU can exceed 60 C, and the sensors controlling the fan are typically 10-20 degrees C cooler than the CPU, so we set the maximum-fan temperature to 50-55 C in an attempt to arrest any temperature increase before the CPU reaches throttling temperatures. We add fan tables to enable hysteresis in the fan speed setting. Fan RPMs are chosen to span the min-to-max range, while avoiding 50 Hz and 60 Hz line frequencies. fizz and kalista boards are shared with non-CfM versions, while the other boards are CfM-only. Since those boards are several years old, we plan to build these firmware changes only into CfM-branch releases, not all fizz and kalista devices. Additional details at go/cfm-overheating . Temperature traces with load testing on both top-of-tree and firmware with this change are shown at go/cfm-overheating#heading=h.ykpzxotgnu2j BRANCH=update-fan-tables BUG=b:252966838,b:191187610,chromium:1383859 TEST=Confirmed validity of settings with `ectool thermalset`. Built firmware, flashed to endeavour and excelsior (fizz), verified that fan turns on earlier. This does not completely prevent throttling from 47.25 W to 15.00 W on Kaby Lake boards (endeavour, fizz, kalista), but it does prevent dropping below 15.00 W. Comet Lake boards (ambassador, genesis, moonbuggy, scout) start at 15.00 W and rarely throttle anyway. Change-Id: I9259b05bcfa1bf4e6433df74913668424d005dbd Signed-off-by: Richard Yeh <rcy@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4060608 Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* fan: Rewrite and test the most common custom fan_percent_to_rpm.Richard Yeh2022-12-133-10/+234
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | temp_ratio_to_rpm_hysteresis uses a sorted fan_table containing a mapping of temp_ratio (percent, 0-100) to fan rpm. This clarifies the relationship of temperature to fan speed, while reducing the number of static variables. The existing temp_ratio expressing the percentage of cooling needed (temperature from temp_fan_off to temp_fan_max) suggests the possibility that a proportional-integral-derivative (PID) feedback controller might have been considered; but the default implementation is purely linear (mapping to fan speed from min to max) and this stepwise one just enables hysteresis --- different speeds when the board is warming up than when cooling down. The hysteresis attempts to avoid oscillations in temperature and fan speed. This refactoring is in preparation for reusing this implementation for {ambassador, genesis, moonbuggy, scout}. {kalista, berknip, chronicler, dewatt, endeavour, ezkinil, fizz} define CONFIG_FAN_RPM_CUSTOM and use this or nearly this implementation of a fan_percent_to_rpm with hysteresis. {chronicler} also performs boxcar smoothing of the input. {osiris}, which has two fans, and {jinlon, redrix, and other boards with multiple sensors}, use a similar but not exactly the same implementation, and would need additional abstraction. See: https://source.chromium.org/search?q=f:ec%2Fb%20fan_step%20-f:board.c BRANCH=refactor-fan-percent-to-rpm BUG=b:252966838,b:191187610,chromium:1383859 TEST=make -j run-fan && make -j buildall && make -j runhosttests Signed-off-by: Richard Yeh <rcy@google.com> Change-Id: I50ad4d78ac1145f92573a417646c1f57b8945463 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4021951 Reviewed-by: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* corsola: headers clean upEric Yilun Lin2022-12-1317-54/+11
| | | | | | | | | | | | | | | | | | | Drop unnecessary headers. BUG=none TEST=zmake compare-builds \ $(find zephyr/program/corsola/ -type f -name project.overlay \ | sed -r 's|/[^/]+$||' | sed -r 's|^.+/||') BRANCH=corsola Change-Id: I45e1a8ac51f6a8dee9488b2d2845422a4fa90652 Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4095602 Commit-Queue: Ting Shen <phoenixshen@chromium.org> Auto-Submit: Eric Yilun Lin <yllin@google.com> Tested-by: Eric Yilun Lin <yllin@google.com> Reviewed-by: Ting Shen <phoenixshen@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* adlrvp: Enable system boot time loggingRajesh Kumar2022-12-132-0/+5
| | | | | | | | | | | | | | | | | This CL enables system boot time logging support for adlrvp. BUG=b:249163956 BRANCH=none TEST='ectool boottime' AP console command is used to fetch data 'reboot' on AP console to trigger warm reboot 'apshutdown' on EC console to trigger cold reboot Signed-off-by: Rajesh Kumar <rajesh3.kumar@intel.com> Change-Id: I7b975aafe7e1846e132827e061551af11e7d1101 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3832585 Reviewed-by: Boris Mittelberg <bmbm@google.com> Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* geralt: change lid sensor to bmi323Ting Shen2022-12-133-10/+10
| | | | | | | | | | | | | | | | | component change requested in go/geralt-sheet. BUG=b:251747125 TEST=zmake build geralt BRANCH=none Change-Id: I3b3d36e1023c77b6d9c0a49cb321e78907ad5c97 Signed-off-by: Ting Shen <phoenixshen@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4094065 Tested-by: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Parker Lin <parkerlin@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Eric Yilun Lin <yllin@google.com> Commit-Queue: Ting Shen <phoenixshen@chromium.org>
* winterhold: Remove fan parameters from dtsiLeila Lin2022-12-131-2/+0
| | | | | | | | | | | | | | | | | | | | Winterhold will dynamically adjust the fan parameters, so remove fan parameters in dtsi. LOW_COVERAGE_REASON=no unit tests for skyrim yet, b/247151116 BUG=b:255732503, b:232946420 BRANCH=none TEST=verify the thermal config on winterhold is correct Change-Id: If496f1b8b0178966ad4422fd84642ca31b7c1dd5 Signed-off-by: Leila Lin <leilacy_lin@compal.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4060801 Commit-Queue: LeilaCY Lin <leilacy_lin@compal.corp-partner.google.com.test-google-a.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Tested-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Tested-by: LeilaCY Lin <leilacy_lin@compal.corp-partner.google.com.test-google-a.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com>
* winterhold: Dynamic switch thermal tableLeila Lin2022-12-131-0/+88
| | | | | | | | | | | | | | | | | | | | | | | | There are 3 modes: DESKTOP_LID_OPEN_MODE态DESKTOP_LID_CLOSE_MODE and LAPTOP_MODE. The mode will base on the condition of lid and body detection, when the hook notification is received, the mode will change and different modes will have corresponding thermal settings. LOW_COVERAGE_REASON=no unit test for skyrim board yet: b/247151116 BRANCH=none BUG=b:232946420 TEST=zmake build winterhold and confirm thermal config change when mode change. Change-Id: I5b4eaba2dbf3b4a833589e45588cf7f1001e22ea Signed-off-by: Leila Lin <leilacy_lin@compal.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4066519 Commit-Queue: LeilaCY Lin <leilacy_lin@compal.corp-partner.google.com.test-google-a.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Tested-by: LeilaCY Lin <leilacy_lin@compal.corp-partner.google.com.test-google-a.com> Reviewed-by: Diana Z <dzigterman@chromium.org> Tested-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com>
* winterhold: Notify host when temperature changeLeila Lin2022-12-133-2/+35
| | | | | | | | | | | | | | | | | | | | | | Send "EC_HOST_EVENT_THERMAL_THRESHOLD" event to host when temp_sensor_amb's value changes +/-1 deg C. LOW_COVERAGE_REASON=no unit test for skyrim board yet: b/247151116 BRANCH=none BUG=b:232946420 TEST=zmake build winterhold and confirm event "EC_HOST_EVENT_THERMAL_THRESHOLD" is send when temp sensor's value changes. Change-Id: I97c64cc4a0e75566823556c0b957a474de15e5d2 Signed-off-by: Leila Lin <leilacy_lin@compal.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4054311 Reviewed-by: Diana Z <dzigterman@chromium.org> Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Commit-Queue: LeilaCY Lin <leilacy_lin@compal.corp-partner.google.com.test-google-a.com> Tested-by: LeilaCY Lin <leilacy_lin@compal.corp-partner.google.com.test-google-a.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Tested-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com>
* hooks: Add HOOK_BODY_DETECT_CHANGELeila Lin2022-12-1311-15/+74
| | | | | | | | | | | | | | | | | | | Add HOOK_BODY_DETECT_CHANGE hook when CONFIG_BODY_DETECTION is enabled to notify body detection's state is changing. BRANCH=none BUG=b:232946420 TEST=zmake build winterhold and confirm that the notification of the hook has been received. Change-Id: Ied9afeef41ee14d7f2de1b423d94600d076bb975 Signed-off-by: Leila Lin <leilacy_lin@compal.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4054308 Tested-by: LeilaCY Lin <leilacy_lin@compal.corp-partner.google.com.test-google-a.com> Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Reviewed-by: Diana Z <dzigterman@chromium.org> Commit-Queue: LeilaCY Lin <leilacy_lin@compal.corp-partner.google.com.test-google-a.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* ec: use standard format specifierRajesh Kumar2022-12-131-1/+1
| | | | | | | | | | | | | | | | | As PRIu64 are not defined in legacy EC, use standard format specifers to avoid build failure if any platform wants to enable CONFIG_SYSTEM_BOOT_TIME_LOGGING conf. BUG=b:249163956 BRANCH=none TEST=make buildall Change-Id: I63bc934189cd3620c4b0132d92c7102f6667c764 Signed-off-by: Rajesh Kumar <rajesh3.kumar@intel.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4086980 Reviewed-by: Boris Mittelberg <bmbm@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Boris Mittelberg <bmbm@google.com>
* frostflow: enable the ghost key screeningFelixTW_Chang2022-12-131-0/+2
| | | | | | | | | | | | | | | | | Add #define KEYBOARD_MASK_PWRBTN KEYBOARD_ROW_TO_MASK(3) to enable the ghost key screening. BUG=b:260618450 TEST=DUT can enter recovery screen BRANCH=none Change-Id: I5291887617b9c1d428f95fa52dfdd616392eeef2 Signed-off-by: FelixTW_Chang <felixtw_chang@compal.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4095603 Reviewed-by: SamSP Liu <samsp_liu2@compal.corp-partner.google.com> Reviewed-by: Chao Gui <chaogui@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Diana Z <dzigterman@chromium.org>
* rex: Enable S0ix error recovery confRajesh Kumar2022-12-131-0/+1
| | | | | | | | | | | | | | | | | This enables S0ix error recovery for rex platform BUG=none BRANCH=none TEST=zmake build rex 'powerd_dbus_suspend' on AP and observed timeout and hang detected through EC logs. Change-Id: I63f1df4f2dacdf83f3b67e665ea25894a23dbefd Signed-off-by: Rajesh Kumar <rajesh3.kumar@intel.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4093741 Reviewed-by: Keith Short <keithshort@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com>
* Revert "dratini: Set TCPC_AUX_SWITCH to 0xC on Port 0 on CCD enable"Boris Mittelberg2022-12-133-29/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 515990a91e4430ff66cae9e532332a0ee33162de. Reason for revert: Doesn't work if rddkeepalive is enabled Original change's description: > dratini: Set TCPC_AUX_SWITCH to 0xC on Port 0 on CCD enable > > When the screen brightness is changed, DP sends signal on AUX channel. > This causes CCD mode to be disconnected. > > This patch sets the MUX to aux+ <-> sbu2, aux- <-> sbu1 to fix it. > > Same change as I3dba1bdfd44a921077a2f60dec17119bb0077238 > > BUG=b:183123775 > BRANCH=none > TEST=manually verify servod doesn't exit when screen brightness is changed > > Signed-off-by: Boris Mittelberg <bmbm@google.com> > Change-Id: Iff91a4b4753b42ee42cd5baac36ba8243d966ce0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2785192 > Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Bug: b:183123775 Change-Id: I6b72f8b0e7d5242c26721ad9024899f697a2da72 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4098336 Reviewed-by: Mary Ruthven <mruthven@chromium.org> Auto-Submit: Boris Mittelberg <bmbm@google.com> Reviewed-by: Boris Mittelberg <bmbm@google.com> Tested-by: Boris Mittelberg <bmbm@google.com> Commit-Queue: Mary Ruthven <mruthven@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* nissa: Disable AP mode DP alt entry processingAndrew McRae2022-12-131-2/+2
| | | | | | | | | | | | | | | | | AP mode based processing for USB-C DP alt mode is only used for TBT/USB4. Disable this for Nissa, which does not support TBT/USB4. BUG=b:261817543 TEST=Confirm that display works with USB-C port BRANCH=none Change-Id: If113e1e8f5c0d47f1d69bb2a0c1617d779beb040 Signed-off-by: Andrew McRae <amcrae@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4095737 Reviewed-by: Diana Z <dzigterman@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Peter Marheine <pmarheine@chromium.org>
View Lorry Controller Status