summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* gitlab: Only run CI in main and coverage branchesstabilize-14989.107.B-mainJeremy Bettis2022-10-061-0/+5
| | | | | | | | | | | | | | | | | | | | | | This workflow rule will prevent this CI config from running unless the branch name is "main" or "coverage". It will have to be cherry-picked into all the other branches to make them stop running sadly. BRANCH=None BUG=b:244766499 TEST=Used yaml validator at https://gitlab.com/zephyr-ec/ec/-/ci/editor?branch_name=main&tab=2 Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: I536de3e3fdbca1c48505e61de5737f865bd0e233 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3872545 Reviewed-by: Simon Glass <sjg@chromium.org> Tested-by: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Simon Glass <sjg@chromium.org> Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Jeremy Bettis <jbettis@chromium.org> (cherry picked from commit 15612bc4af40cb2a824ff2590508df29f27fbf56) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3936949
* nissa: Use low freq clock for keyboard backlightrelease-R105-14989.B-mainAndrew McRae2022-07-203-3/+6
| | | | | | | | | | | | | | | Use low frequency clock for keyboard backlight so that PWM clock does not get turned off when power management turns off the main clocks. BUG=b:230427574 TEST=zmake build nivviks; flash & run on Nirwen BRANCH=none Change-Id: I48bfe4cfaf2095b2b208a0ff6161cd868e6b31f4 Signed-off-by: Andrew McRae <amcrae@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3775276 Reviewed-by: Peter Marheine <pmarheine@chromium.org>
* docs: zephyr: LEDsParth Malkan2022-07-202-1/+224
| | | | | | | | | | | | | | Add a Zephyr doc for setting up LEDs on a board. BRANCH=none BUG=b:222105941 TEST=Browse in Gerrit TEST=Reviewers Change-Id: If92586ed51593d51f7b786e076db0718fa3e31ff Signed-off-by: Parth Malkan <parthmalkan@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3677553 Reviewed-by: Keith Short <keithshort@chromium.org>
* zephyr: test: drivers: Simplify build rulesYuval Peress2022-07-206-68/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | Replace the complicated library mechanism with a more native cmake construct. The idea of having separate libraries works great in theory but it really wasn't working well. For this to properly work one of the following would need to happen: 1. The cros ec would need to be compiled as a library adding the include path with PUBLIC visibility. Test libraries can then link to the cros ec library. 2. The cros ec headers would be added directly to zephyr using zephyr_include_directories. The downside of this approach is that it adds the chromium headers at the same level as Zephyr's (which are visible at the system like <> include brackets). BRANCH=none BUG=none TEST=zmake test test-drivers* Signed-off-by: Yuval Peress <peress@google.com> Change-Id: Iefbab4c4745f6ce4c0a8dc61018db9554c204434 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3774764 Reviewed-by: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Aaron Massey <aaronmassey@google.com> Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* zephyr: Set fan count from fw_config fan flagMoises Garcia2022-07-203-0/+73
| | | | | | | | | | | | | | | | | | | | | | Currently, when there is no fan, EC reports fan stalled. Read FW_CONFIG fan absent/present flag an set fan_count accordingly. BRANCH=NONE BUG=b:234765697 TEST=Tried the 4 different combinations in SKUA2 BOARD_VERSION >=3 && FW_CONFIG[10]=1 -> Fan is on BOARD_VERSION >=3 && FW_CONFIG[10]=0 -> Fan is off BOARD_VERSION <3 && FW_CONFIG[10]=1 -> Fan is on BOARD_VERSION <3 && FW_CONFIG[10]=0 -> Fan is on Change-Id: If4681c9f97c2a4a4c6b200bd1acccd89111f7abf Signed-off-by: Moises Garcia <moisesgarcia@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3756743 Commit-Queue: Jonathon Murphy <jpmurphy@google.com> Reviewed-by: Diana Z <dzigterman@chromium.org> Tested-by: Jonathon Murphy <jpmurphy@google.com> Reviewed-by: Jonathon Murphy <jpmurphy@google.com>
* test: math: support twister buildsYuval Peress2022-07-203-3/+8
| | | | | | | | | | | | | | Add support for twister builds via a symlink to the native_posix overlay and a testcase.yaml BRANCH=none BUG=none TEST=Run twister with -T zephyr/test/math Signed-off-by: Yuval Peress <peress@google.com> Change-Id: I80467a6fa6005bdab655e93eaaf68c47a0b324d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3774888 Reviewed-by: Tristan Honscheid <honscheid@google.com>
* Zephyr: Add AP mux control testDiana Z2022-07-205-0/+118
| | | | | | | | | | | | | | | Add a unit test to exercise the new command to allow the AP to set muxes, and verify we notify the AP of their sets completing. BRANCH=None BUG=b:234839764 TEST=zmake testall Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: I27ba90bfcb3a79479560a392e848ebc684459557 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3768919 Reviewed-by: Aaron Massey <aaronmassey@google.com> Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* Zephyr: Add utilities for mux set and event clearDiana Z2022-07-202-0/+49
| | | | | | | | | | | | | | Add utilities to allow tests to clear port events and set muxes using the TYPEC_CONTROL host command. BRANCH=None BUG=b:234839764 TEST=zmake testall Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: I28af3cbff7b045f41b7af4b282cdae1f03811524 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3774147 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* ec: Set default jobs to number of processorsJeremy Bettis2022-07-201-1/+1
| | | | | | | | | | | | | | | | | | In util/compare_build.sh, it runs make -j with no argument by default. Change that to use the current machine's number of processors instead. BRANCH=None BUG=b:239199935 TEST=./util/compare_build.sh -b all Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: I700e7bc9b892ca4b928f0d162cfa6cd44f5f7c62 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3773937 Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Tested-by: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
* ec: Fix kconfig_check usage in makefileJeremy Bettis2022-07-203-4/+18
| | | | | | | | | | | | | | | | | | BRANCH=None BUG=b:239199935 TEST=make -j$(nproc) buildall && echo SUCCESS TEST=git commit --allow-empty ./util/compare_build.sh -b dartmonkey ./util/compare_build.sh -b all Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: I845ca84920af1ca33457b79fe2a3892867ed693c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3767853 Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Tested-by: Jeremy Bettis <jbettis@chromium.org> Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Jack Rosenthal <jrosenth@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* Zephyr: Sub-divide TYPEC_CONTROL UtilityDiana Z2022-07-203-24/+36
| | | | | | | | | | | | | | | | Sub-divide out the TYPEC_CONTROL utility on a per-subcommand basis. This will ensure we can still type check arguments, while not creating a massive argument list for a one-size-fits-all utility. BRANCH=None BUG=b:234839764 TEST=zmake testall Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: I85b39da986a88fe30c1928a3d17855858db81ec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3768918 Commit-Queue: Abe Levkoy <alevkoy@chromium.org> Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* pujjo: Correct GPIO settings for HDMI hpd functionjimmy.wu2022-07-201-2/+2
| | | | | | | | | | | | | Correct GPIO settings for HDMI hpd function. BUG=b:239653512 TEST=zmake build pujjo BRANCH=none Signed-off-by: jimmy.wu <jimmy.wu@lcfc.corp-partner.google.com> Change-Id: I30dc3901e866c30ccbea7a57b23bb769323eb7a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3775277 Reviewed-by: Andrew McRae <amcrae@google.com>
* zephyr: bindings: drop cros-kb-raw-controller.yamlFabio Baltieri2022-07-205-12/+4
| | | | | | | | | | | | | This is empty now, no sense keeping it around. BRANCH=none BUG=none TEST=zmake testall Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I585008317dab45e0df8755f2d1f4a406ffb5aaff Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3763912 Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* zephyr: cros_kb_raw: drop the label propertyFabio Baltieri2022-07-204-7/+0
| | | | | | | | | | | | | | Seems like this is unused. BRANCH=none BUG=b:239165779 TEST=zmake testall Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I059f388fe3301f6d7f48fdbe9cfdb6cb1c5b7ec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3763911 Reviewed-by: Keith Short <keithshort@chromium.org> Reviewed-by: Tristan Honscheid <honscheid@google.com>
* kingler: rename en_pp5000_usb_a0_vbus_xEric Yilun Lin2022-07-202-2/+2
| | | | | | | | | | | | | | | | | The FAFT config corsola.json requires the name to be en_pp5000_usb_a0_vbus. BUG=b:214325092 TEST=pass firmware_ECUsbPorts BRANCH=none Change-Id: Id8a17f8d5b7183a529297f15df3a086c5050e434 Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3771681 Commit-Queue: Sung-Chi Li <lschyi@chromium.org> Tested-by: Eric Yilun Lin <yllin@google.com> Reviewed-by: Sung-Chi Li <lschyi@chromium.org> Auto-Submit: Eric Yilun Lin <yllin@google.com>
* chip/mt_scp: add define to support inner racing modeXiaoyong Lu2022-07-201-0/+1
| | | | | | | | | | | | | | | | Add define to support inner racing in scp: VDEC_CAP_INNER_RACING BIT(17). BUG=b:209531198 TEST=cts/gts test pass Signed-off-by: Xiaoyong Lu <xiaoyong.lu@mediatek.corp-partner.google.com> Change-Id: I292645a7d976c7a88fae831ae38cd47dad1c7aaa Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3771682 Tested-by: Yunfei Dong <yunfei.dong@mediatek.corp-partner.google.com> Commit-Queue: Chen-Yu Tsai <wenst@chromium.org> Reviewed-by: Yunfei Dong <yunfei.dong@mediatek.corp-partner.google.com> Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
* zephyr: tests: Run test_ps8815_set_cc before tasksTomasz Michalec2022-07-201-1/+4
| | | | | | | | | | | | | | | | | The test_ps8815_set_cc except delay on the role control register change. During delay the PD task can run and change expected state. To prevent that whole test is run before tasks. BUG=b:239513456 TEST=zmake -D test test-drivers BRANCH=None Signed-off-by: Tomasz Michalec <tm@semihalf.com> Change-Id: Ic51da7210543917737e316433a32e4837160c214 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3773856 Tested-by: Tomasz Michalec <tmichalec@google.com> Reviewed-by: Al Semjonovs <asemjonovs@google.com> Commit-Queue: Tomasz Michalec <tmichalec@google.com>
* zephyr: tests: Call PS8xxx init before each testTomasz Michalec2022-07-201-0/+2
| | | | | | | | | | | | | | | | | Product ID in PS8xxx driver is cached on init. To effectively change product ID, test has to call init function after setting product ID in emulator. BUG=b:239513456 TEST=zmake -D test test-drivers BRANCH=None Signed-off-by: Tomasz Michalec <tm@semihalf.com> Change-Id: I7f8f6663102146e23edc5672900291997ab08c09 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3773855 Tested-by: Tomasz Michalec <tmichalec@google.com> Commit-Queue: Tomasz Michalec <tmichalec@google.com> Reviewed-by: Yuval Peress <peress@google.com>
* nissa: reduce max PD voltage on SM5803 to 15VPeter Marheine2022-07-202-0/+2
| | | | | | | | | | | | | | | | | | | Silicon Mitus have stated that VBUS transients at nominal 20V can damage the SM5803 and recommended that the maximum VBUS voltage be limited to 15V to prevent damage. BUG=b:230712704 TEST=Nereid negotiates 15V even when connected to a 60W charger that supports 20V supply. BRANCH=none Change-Id: I8bcfc6fcd9b33d1c1d56b858b28bf61a6ccf998b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3774857 Commit-Queue: Andrew McRae <amcrae@google.com> Commit-Queue: Peter Marheine <pmarheine@chromium.org> Tested-by: Peter Marheine <pmarheine@chromium.org> Auto-Submit: Peter Marheine <pmarheine@chromium.org> Reviewed-by: Andrew McRae <amcrae@google.com>
* nissa: Allow setting OCPC per-projectAndrew McRae2022-07-207-1/+6
| | | | | | | | | | | | | | Some boards may not have multiple type-C ports, so allow setting OCPC on a per-project basis. BUG=b:239506664 TEST=zmake testall BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: Iedb212b1540502c7d0c05d30fbe15a97415fc3bd Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3775784 Reviewed-by: Peter Marheine <pmarheine@chromium.org>
* run_device_tests.py: Refactor main() into smaller functionsAndrea Grandi2022-07-201-95/+103
| | | | | | | | | | | | | | | | | | | | | | | Pylint reports several errors in the main() function, which has grown over time to include many lines: R0914: Too many local variables (21/15) (too-many-locals) R0912: Too many branches (18/12) (too-many-branches) R0915: Too many statements (84/50) (too-many-statements) Break down the function into smaller ones that are within the guidelines recommended by the linter. BUG=b:239100048 TEST=cros lint test/run_device_tests.py TEST=./test/run_device_tests.py --flasher=jtrace --remote=localhost \ --jlink_port=19020 --board dartmonkey => PASS BRANCH=none Signed-off-by: Andrea Grandi <agrandi@google.com> Change-Id: I77d4ddd20b102894428ef6999f4f2ead53ce6d44 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3766499 Reviewed-by: Tom Hughes <tomhughes@chromium.org>
* run_device_tests.py: Update disabled linter optionsAndrea Grandi2022-07-201-4/+2
| | | | | | | | | | | | | | | | | | The latest version of Pylint introduced new checkers that are flagging errors in lines of code where Pylint errors had already been disabled. Update pylint disable directives to suppress import errors. Explicitly set check=False (default value) so subprocess-run-check is no longer required. BUG=b:239100048 TEST=cros lint test/run_device_tests.py BRANCH=none Signed-off-by: Andrea Grandi <agrandi@google.com> Change-Id: I6d2dd2f1660cb34f2bff0a1ed073825b80f5da6a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3766498 Reviewed-by: Tom Hughes <tomhughes@chromium.org>
* run_device_tests.py: Disable pylint error broad-exceptAndrea Grandi2022-07-201-2/+2
| | | | | | | | | | | | | | | | | | Pylint reports an error when generic exception are used: W0703: Catching too general exception Exception (broad-except) This is intentional since we want to ensure all failures in these operations are ignored to avoid disruptions. BUG=b:239100048 TEST=cros lint test/run_device_tests.py BRANCH=none Signed-off-by: Andrea Grandi <agrandi@google.com> Change-Id: Id413d4f46626afa805c734b9abcad931852a471e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3766497 Reviewed-by: Bobby Casey <bobbycasey@google.com> Reviewed-by: Tom Hughes <tomhughes@chromium.org>
* run_device_tests.py: Add missing docstringsAndrea Grandi2022-07-201-1/+6
| | | | | | | | | | | | | | | | Pylint reports several missing docstring errors: C0116: Missing function or method docstring (missing-function-docstring) Add documentation where required. BUG=b:239100048 TEST=cros lint test/run_device_tests.py BRANCH=none Signed-off-by: Andrea Grandi <agrandi@google.com> Change-Id: I006cd21faf3e149b8fb76a49e644afd16db316e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3766496 Reviewed-by: Tom Hughes <tomhughes@chromium.org>
* run_device_tests.py: Simplify code using dataclassAndrea Grandi2022-07-201-58/+36
| | | | | | | | | | | | | | | | | | | | | Pylint reports the following error in the declarations of BoardConfig and TestConfig: R0903: Too few public methods (0/2) (too-few-public-methods) Simplify their declarations using dataclass. Also suppress R0902: too-many-instance-attributes for TestConfig. BUG=b:239100048 TEST=cros lint test/run_device_tests.py TEST=./test/run_device_tests.py --flasher=jtrace --remote=localhost \ --jlink_port=19020 --board dartmonkey => PASS BRANCH=none Signed-off-by: Andrea Grandi <agrandi@google.com> Change-Id: Iba406667546e172e55e30c0044e06419c1d5595c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3766495 Reviewed-by: Tom Hughes <tomhughes@chromium.org>
* moli: modify LED behaviorElsie Shih2022-07-202-16/+38
| | | | | | | | | | | | | | | | - Follow Moli GPIO Table_20220531.xlsx to modify the GPIO. - Add GPIO_LED_BLUE_CONTROL / GPIO_LED_ORANGE_CONTROL to control LED on/off. - Modify LED behavior and add duty cycle for pulsing. BUG=b:238010311 BRANCH=none TEST=make BOARD=moli Signed-off-by: Elsie Shih <elsie_shih@wistron.corp-partner.google.com> Change-Id: Ic838483c43e201c1ee1d8e619759be027cc99133 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3715186 Reviewed-by: Zhuohao Lee <zhuohao@chromium.org>
* pujjo: Correct hotkey function definejimmy.wu2022-07-201-3/+3
| | | | | | | | | | | | | Correct hotkey function define. BUG=b:239511837 TEST=zmake build pujjo BRANCH=none Signed-off-by: jimmy.wu <jimmy.wu@lcfc.corp-partner.google.com> Change-Id: I727a86145ceec1a2d74e8aa520f4b280d0ad3b24 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3771324 Reviewed-by: Andrew McRae <amcrae@google.com>
* Joxer: add batteries supportScott Chao2022-07-207-2/+289
| | | | | | | | | | | BRANCH=none BUG=b:239502723 TEST=zmake build joxer Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com> Change-Id: I13243a7ee7112064d6a416303e0dacd9ca09303f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3769710 Reviewed-by: Andrew McRae <amcrae@google.com>
* Joxer: reduce battery I2C frequency to 50 kHzScott Chao2022-07-201-1/+1
| | | | | | | | | | | | | Follow CL:3721954 to reduce battery I2C frquency. BUG=b:239502723 BRANCH=none TEST=make sure EC can read battery info and battery can be charged. Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com> Change-Id: Ic1dcf4961cd623bcb91907bf01d3728f979ce7e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3775783 Reviewed-by: Andrew McRae <amcrae@google.com>
* nissa: Rearrange projects into sub-directoriesAndrew McRae2022-07-2068-69/+63
| | | | | | | | | | | | | | Rearrange the projects into separate sub-directories to improve clarity and separation. BUG=none TEST=zmake testall BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: I14c3324760d195807f831bd72bdbc129fe76912b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3771363 Reviewed-by: Peter Marheine <pmarheine@chromium.org>
* osiris: Update thermal policyYu-An Chen2022-07-203-10/+158
| | | | | | | | | | | | | | | | This CL updated fan control policy to step control. Each fan has its own control table, and the number of steps can be different between two fans. BUG=b:234545460 BRANCH=none TEST=Thermal team verified thermal policy is expected. Signed-off-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com> Change-Id: I2572868974947beade5e6f83610130d9110814ff Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3760804 Commit-Queue: Boris Mittelberg <bmbm@google.com> Reviewed-by: Boris Mittelberg <bmbm@google.com>
* zmake: Pass USER_CACHE_DIR to cmakeAbe Levkoy2022-07-191-0/+3
| | | | | | | | | | | | | | | | When invoking cmake, set USER_CACHE_DIR to build/zephyr/user-cache. Thereby prevent the Zephyr cmake logic from choosing its own location based on the environment and ensure that deleting build/ deletes the cache. BUG=b:239619222 TEST=zmake -D configure test-drivers; observe cache dir output BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: I6baccd61d18c17c843336c5dc0435645b44c0ef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3773321 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* evoker: Initial EC imageYu-An Chen2022-07-199-0/+724
| | | | | | | | | | | | | | | | Create the initial Zephyr EC image for the evoker variant by copying the herobrine reference board EC files. More changes will be added later. BUG=b:238571507 TEST=zmake build evoker BRANCH=none Signed-off-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com> Change-Id: Id469d14e3859a2f3c3ba70bd9b5c32b15ea70fd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3763023 Reviewed-by: Wai-Hong Tam <waihong@google.com> Commit-Queue: Wai-Hong Tam <waihong@google.com>
* zephyr: Delete ghost projectJack Rosenthal2022-07-192-10/+0
| | | | | | | | | | | | | | | | | Ghost is forced to use legacy EC, and this build is out of date with the configs for the legacy EC build. Delete this as to not cause any confusion. BUG=b:232148718 BRANCH=none TEST=zmake configure -a Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: I5d273fc6767d438fd44b8c8dfcfee29b24f69004 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3773636 Reviewed-by: caveh jalali <caveh@chromium.org> Commit-Queue: caveh jalali <caveh@chromium.org>
* cq: Exclude build dir from coverageJeremy Bettis2022-07-191-1/+17
| | | | | | | | | | | | | | | | | | | The build dir contains a number of generated files, that creates some inconsistent results in the coverage reports. Because of this, and also because those files are generated and don't matter, exclude them from the coverage report. BRANCH=None BUG=b:213374060 TEST=Ran commands in README.md Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: Ie1da42c3cc14faa917d2f0deca6c7acc9a9b7751 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3773934 Tested-by: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org> Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
* util: Delete kconfiglib.pyJeremy Bettis2022-07-191-7462/+0
| | | | | | | | | | | | | | | | | | The missing code has been applied to the ebuild, so this copy is no longer needed. BRANCH=None BUG=b:238773780 FIXED=b:238773780 TEST=util/run_tests.sh Cq-Depend: chromium:3763390 Change-Id: I4f774c5ca4f2ae67eac07be06f06fee93fe1dbb3 Signed-off-by: Jeremy Bettis <jbettis@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3760659 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Tested-by: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
* zephyr: Remove DT_GPIO_LABEL_BY_IDX usageAaron Massey2022-07-191-2/+2
| | | | | | | | | | | | | | | | | | | | | Zephyr upstream deprecated the DT_GPIO_LABEL_BY_IDX macro used by downstream UNUSED_GPIO_CONFIG_BY_IDX macro causing a CQ build failure and blocking Zephyr downstreaming. Replace use of DT_GPIO_LABEL_BY_IDX with DT_GPIO_CTLR_BY_IDX. Note: This change also includes a switch from using DT_LABEL to DEVICE_DT_NAME which is less likely to be deprecated and evaluates to the same result if a LABEL property is present. BRANCH=none BUG=b:239447869 TEST=zmake test build -a # With breaking commit in downstreamed Zephyr Signed-off-by: Aaron Massey <aaronmassey@google.com> Change-Id: I8af3f21dbf5b8ab05cd1c1d9cfc483fa3c25b850 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3773935 Reviewed-by: Tristan Honscheid <honscheid@google.com> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* emul: Remove DT_INST_BUS_LABEL(n) usageAaron Massey2022-07-1914-16/+16
| | | | | | | | | | | | | | | | | | | | | Zephyr upstream deprecated DT_BUS_LABEL(node_id) and DT_INST_BUS_LABEL(inst) macros causing a CQ build failure and blocking Zephyr downstreaming. Replace code occurrences of DT_INST_BUS_LABEL(inst) with DT_LABEL(DT_BUS(DT_DRV_INST(inst))). This macro was only used in emulators. BRANCH=none BUG=b:239447869 TEST=zmake test test-drivers # With breaking commit in downstreamed Zephyr Signed-off-by: Aaron Massey <aaronmassey@google.com> Change-Id: If745caeb1273c7e51331bd45b17dc28960c7f8da Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3767857 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com> Reviewed-by: Tristan Honscheid <honscheid@google.com>
* zephyr: Fix some warnings in zmake buildJeremy Bettis2022-07-192-6/+0
| | | | | | | | | | | | | | | | | | When you run zmake build skyrim there are some warnings printed. Explicitly disable some Kconfigs that are implicitly disabled. BRANCH=None BUG=None TEST=zmake build skyrim Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: I8aff2701bd81c9d337242af6ed68ff654fe6860c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3765444 Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Tested-by: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Diana Z <dzigterman@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org>
* Makefile: Add option to compile with the C standard libraryTom Hughes2022-07-193-2/+27
| | | | | | | | | | | | | | | | | Add the USE_BUILTIN_STDLIB variable, which defaults to 1 and will use the EC standard library implementation (the "builtin" directory). When USE_BUILTIN_STDLIB is set to 0, the toolchain's C standard library will be used instead. BRANCH=none BUG=b:234181908 TEST=./util/compare_build.sh -b all -j 120 => MATCH Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I63285569205b9c560655dfead6a260c270a92494 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3712035 Reviewed-by: Eric Yilun Lin <yllin@google.com>
* tree: Remove HIDE_EC_STDLIBTom Hughes2022-07-194-5/+1
| | | | | | | | | | | | | | HIDE_EC_STDLIB is no longer needed now that the stdlib code has been separated out from the EC code. BRANCH=none BUG=b:234181908 TEST=make runfuzztests Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: Id47327c5061239b97b2e2f82791719f01b4e9ad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3750109 Reviewed-by: Keith Short <keithshort@chromium.org>
* test/printf: Account for differences in the builtin printfTom Hughes2022-07-191-55/+123
| | | | | | | | | | | | | | | | | EC's printf implementation has some bugs, which results in different output when compared to printf from the standard library. Account for these with a conditional until they are fixed. BRANCH=none BUG=b:234181908, b:238433667, b:239233116 TEST=make BOARD=dartmonkey test-printf TEST=make run-printf Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: Ie8006a128f5cc1c32f1248c004697c61f4ac001a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3750110 Reviewed-by: Ting Shen <phoenixshen@chromium.org>
* tree: Move printf declarations to stdio.hTom Hughes2022-07-196-102/+145
| | | | | | | | | | | | | | | | | The "builtin" directory is EC's copy of the C standard library headers. Move the declarations for printf functions that are provided by the standard library to the "builtin" directory. This change makes it easier for future changes to optionally build with the C standard library instead of the standalone EC subset. BRANCH=none BUG=b:172020503, b:234181908, b:237823627 TEST=make buildall Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I4a5b4f8b98b972e86c4cca65d4910b5aa07ec524 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3712034 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* builtin: Move ssize_t to sys/types.hTom Hughes2022-07-194-6/+10
| | | | | | | | | | | | | | | | | According to POSIX ssize_t should be defined in sys/types.h, not stddef.h: https://pubs.opengroup.org/onlinepubs/9699919799.2018edition/basedefs/sys_types.h.html BRANCH=none BUG=b:234181908 TEST=./util/compare_build.sh -b all => MATCH Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I027a2b26dc183c506d691d483c86644d04db9282 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3765450 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* PRESUBMIT.cfg: Enable black_check and drop custom scriptJack Rosenthal2022-07-192-50/+2
| | | | | | | | | | | | | | | | | | Enable the global PRESUBMIT.cfg option for black pre-upload checks, and drop our custom script. isort checks are done by cros lint, so this was redundant in the custom script. BUG=b:238434058 BRANCH=none TEST=Run pre-upload on some recent commits Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: Ib624b619621654949019541f03ffe35ba69f78b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3770681 Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* zephyr: tests: Clear PD disabled by policy flagTomasz Michalec2022-07-191-0/+3
| | | | | | | | | | | | | | | | | While testing pd console command, PD_DISABLED_BY_POLICY flag is set. Because of that some other tests may fail. Clear PD_DISABLE_BY_POLICY flag after pd console command tests. BUG=b:233102631 TEST=zmake -D test test-drivers BRANCH=None Signed-off-by: Tomasz Michalec <tm@semihalf.com> Change-Id: I1cb898f1f680238eb4e14dc640690a8412806b27 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3773853 Tested-by: Tomasz Michalec <tmichalec@google.com> Reviewed-by: Aaron Massey <aaronmassey@google.com> Commit-Queue: Tomasz Michalec <tmichalec@google.com>
* tree: Change non-standard "%pP" printf format to "%p"Tom Hughes2022-07-1914-85/+28
| | | | | | | | | | | | | | | | | | | | | | | | | This is the last non-standard format overloading "%p", so we can change it to the standard "%p" format. Using standard format specifiers makes it easier to switch between the "builtin" EC standard library and the C standard library provided by the toolchain (or Zephyr). BRANCH=none BUG=b:238433667, b:234181908 TEST=On icetower v0.1 with servo_micro and J-Trace attached: Before change: > rw 536870912 read 0x20000000 = 0x45dbfce2 After change: > rw 536870912 read 0x20000000 = 0x45dbfce2 Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: Id5680ab07af5352d463df42daadff1619c06c9af Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3756180 Reviewed-by: Eric Yilun Lin <yllin@google.com>
* tree: Remove non-standard "%ph" printf formatTom Hughes2022-07-1915-78/+151
| | | | | | | | | | | | | | | | | | | | | | | | | | | The non-standard "%ph" format is replaced with snprintf_hex_buffer and then using "%s" to print the resulting buffer. Using standard format specifiers makes it easier to switch between the "builtin" EC standard library and the C standard library provided by the toolchain (or Zephyr). BRANCH=none BUG=b:238433667, b:234181908 TEST=Enable CONFIG_CMD_RAND in nocturne_fp/board.h On icetower v0.1 with servo_micro and J-Trace: Before change: > rand rand 8ab8b15090ca5ae83bdad671c906d51a5f2b98a359a4106054ee6b54a4087190 After change: > rand rand 2a8645235a31936a28b8d1b9c4948f46d39662e7fcb10a185ddb14c6a998e2eb Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I3bff928d32579440d7cdb27a75899e45159accfb Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3759123 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* kinox: modify detect ADP_ID formulaMatt Wang2022-07-192-11/+14
| | | | | | | | | | | | | | | | Modify the comparison value is volage to voltage. Delete the ADP_ID factor_div's +1 method to make sure the method can to get max 2816 value(2.816v). BUG=b:211806236,b:238157622 BRANCH=none TEST=Can get the TIO and Tiny adapter watt. Signed-off-by: Matt Wang <matt_wang@compal.corp-partner.google.com> Change-Id: I1be5b834c40465664a79d50fa8c09603c8b2c94f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3760805 Commit-Queue: Ricky Chang <rickytlchang@chromium.org> Reviewed-by: Ricky Chang <rickytlchang@chromium.org>
* kinox: modify the SIO_LEGO_EN_L for AIO buttonMatt Wang2022-07-192-1/+3
| | | | | | | | | | | | | | | | | Add the SIO_LEGO_EN_L control when using the AIO device. SIO_LEGO_EN_L set to 0 can use the AIO power button. SIO_LEGO_EN_L set to 1 cannot use the AIO power button. BUG=b:238157622 BRANCH=none TEST=Has been confirmed that the AIO power button has a function. Signed-off-by: Matt Wang <matt_wang@compal.corp-partner.google.com> Change-Id: I036a7e177de440f9cf056a778589d97ad5cc1dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3759836 Reviewed-by: Elmo Lan <elmo_lan@compal.corp-partner.google.com> Reviewed-by: Ricky Chang <rickytlchang@chromium.org> Commit-Queue: Ricky Chang <rickytlchang@chromium.org>
View Lorry Controller Status