summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* presubmit: Don't complain about edits to fpsensorstabilize-14536.B-mainJeremy Bettis2022-02-261-1/+1
| | | | | | | | | | | | | | | | | | | Exclude the common/fpsensor dir from the "don't edit legacy EC files" warning. BRANCH=None BUG=b:221487964 TEST=None Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: If69b658e63f1eb3426664a9b4db7d923a6b19071 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3491411 Tested-by: Jeremy Bettis <jbettis@chromium.org> Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Andrea Grandi <agrandi@google.com> Tested-by: Andrea Grandi <agrandi@google.com> Reviewed-by: Yuval Peress <peress@google.com> Commit-Queue: Yuval Peress <peress@google.com>
* zmake: document how to generate coverage reportJeremy Bettis2022-02-262-0/+15
| | | | | | | | | | | | | | | | | Add instructions for running zmake unit tests outside the chroot and generating coverage data. BRANCH=None BUG=b:219062927 TEST=Ran the commands Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: Ib1e9a2ddba95d64c2a20973be444edff0e22c30a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3491404 Tested-by: Jeremy Bettis <jbettis@chromium.org> Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
* villager: Update the USB-C dts overlayWai-Hong Tam2022-02-263-1/+66
| | | | | | | | | | | | | | | Fork the USBC dts overlay and update the PPC nodes to reflect the component change. BRANCH=None BUG=b:221444985 TEST=Built the villager EC image without breaking the herobrine and hoglin images. Change-Id: Ia1af9366c7cc6198172bc9f4188d2b080ba15fd3 Signed-off-by: Wai-Hong Tam <waihong@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3491321 Reviewed-by: Keith Short <keithshort@chromium.org>
* docs: zephyr: add an initial Zephyr PWM doc pageFabio Baltieri2022-02-262-0/+134
| | | | | | | | | | | | | | Add documentation for configuring PWM on Zephyr. BRANCH=none BUG=b:215168520 TEST=browse on gerrit Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I11e5ea336e1fe1535a35c4a890cb9eb224e213a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3416229 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* zephyr: shim: replace few pwm flags with PWM_POLARITY_NORMALFabio Baltieri2022-02-2517-19/+19
| | | | | | | | | | | | | | | | | Zephyr PWM flag is commonly either PWM_POLARITY_NORMAL or PWM_POLARITY_INVERTED. Replacing few instances of flag being set to "0" for PWM_POLARITY_NORMAL to match how this is commonly done in Zephyr upstream. BRANCH=none BUG=b:217741090 TEST=cq dry run Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I7c36989696824e2bf2401cc5695978a71197b668 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3488368 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* villager: Create initial Villager EC imageWai-Hong Tam2022-02-254-0/+20
| | | | | | | | | | | | | | | | | | | | Fork the Villager build from the Herobrine's. These 2 images are the same so far except the runtime Herobrine-specific component swap, which depends on the CONFIG_BOARD_HEROBRINE. The villager image doesn't care about the BOARD ID and just uses the static configs. More changes will be added later. BRANCH=None BUG=b:221444985 TEST=Built the villager EC image. Change-Id: I0c8d71c4b664d6c8b80e94debab0cccf79030778 Signed-off-by: Wai-Hong Tam <waihong@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3489825 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* gitlab: Move to the latest docker imageSimon Glass2022-02-251-1/+1
| | | | | | | | | | | | | | This enables support for testing U-Boot vboot. BUG=b:209799513 BRANCH=none TEST=passes on gitlab: https://gitlab.com/zephyr-ec/ec/-/pipelines/479753623 Signed-off-by: Simon Glass <sjg@chromium.org> Change-Id: I4a94ec7f08236a85b544f7eb73ce277993670af8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3491075 Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* gpio: Enable guard for Zephyr sourcesKeith Short2022-02-251-0/+3
| | | | | | | | | | | | | | Enable the guard that prevents Zephyr source files from including the legacy GPIO header and API. BUG=b:218856245 BRANCH=none TEST=zmake testall Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I4f381a05b9b9825acf6100da6625b3a7bce7f4ed Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3489253 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* zephyr: allow EC gpio.h for shim driverKeith Short2022-02-254-0/+15
| | | | | | | | | | | | | | Allow the GPIO shim driver and keyboard driver to continue to use the legacy EC GPIO header and API. BUG=b:218856245 BRANCH=none TEST=zmake testall Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I3163ed98ef41dcf59ff694801964fba0d774db58 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3489252 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* zephyr: Fix GPIO includes for trogdorKeith Short2022-02-257-27/+9
| | | | | | | | | | | | | | Use the Zephyr driver GPIO include for Zephyr shim code instead of the legacy EC GPIO header. BUG=b:218856245 BRANCH=none TEST=zmake testall Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I0db2fc70e2d918c4c2a8b28e8e9f70f095fc6bf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3489251 Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* zephyr: Fix GPIO includes for skyrimKeith Short2022-02-255-5/+11
| | | | | | | | | | | | | | Use the Zephyr driver GPIO include for Zephyr shim code instead of the legacy EC GPIO header. BUG=b:218856245 BRANCH=none TEST=zmake testall Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: Ib809dbbd438ce53482bc32a3c14603e11ebad82d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3489250 Reviewed-by: Aaron Massey <aaronmassey@google.com>
* zephyr: Fix GPIO includes for nissaKeith Short2022-02-252-2/+2
| | | | | | | | | | | | | | Use the Zephyr driver GPIO include for Zephyr shim code instead of the legacy EC GPIO header. BUG=b:218856245 BRANCH=none TEST=zmake testall Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I6c5487ba4fbad40a764c934743c5c630339367f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3489249 Reviewed-by: Al Semjonovs <asemjonovs@google.com>
* zephyr: Fix GPIO includes for intelrvpKeith Short2022-02-252-1/+3
| | | | | | | | | | | | | | Use the Zephyr driver GPIO include for Zephyr shim code instead of the legacy EC GPIO header. BUG=b:218856245 BRANCH=none TEST=zmake testall Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: Ib2eb4ab3457957c1048976e6a4fa6dd0013c1abf Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3489248 Reviewed-by: Tristan Honscheid <honscheid@google.com>
* zephyr: Fix GPIO includes for herobrineKeith Short2022-02-253-3/+6
| | | | | | | | | | | | | | Use the Zephyr driver GPIO include for Zephyr shim code instead of the legacy EC GPIO header. BUG=b:218856245 BRANCH=none TEST=zmake testall Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I9ae2595e16e8b0ef95f5f0eea9f9387b2ec5e97f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3489247 Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* zephyr: Fix GPIO includes for corsolaKeith Short2022-02-2510-19/+19
| | | | | | | | | | | | | | Use the Zephyr driver GPIO include for Zephyr shim code instead of the legacy EC GPIO header. BUG=b:218856245 BRANCH=none TEST=zmake testall Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I80f9cbf012a9bd49b80f2b0fad1f0663da2e34b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3489246 Reviewed-by: Tristan Honscheid <honscheid@google.com>
* zephyr: Fix GPIO includes for bryaKeith Short2022-02-252-3/+3
| | | | | | | | | | | | | | Use the Zephyr driver GPIO include for Zephyr shim code instead of the legacy EC GPIO header. BUG=b:218856245 BRANCH=none TEST=zmake testall Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: Ic344b5038159692a35a85205fe4ac40d401f37c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3489105 Reviewed-by: Al Semjonovs <asemjonovs@google.com>
* zephyr: Fix GPIO includes for shim driversKeith Short2022-02-255-6/+8
| | | | | | | | | | | | | | | Code under the zephyr subdirectory should use the upstream Zephyr API for accessing GPIOs. There are name conflicts for the GPIO flags, so ensure Zephyr code always includes the Zephyr header file. BUG=b:218856245 BRANCH=none TEST=zmake testall Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: Ide1081400c05957c704a2904b492efab8da3b3e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3489104 Reviewed-by: Yuval Peress <peress@google.com>
* zephyr: Fix GPIO includes for EC chipsKeith Short2022-02-257-10/+5
| | | | | | | | | | | | | | | Code under the zephyr subdirectory should use the upstream Zephyr API for accessing GPIOs. There are name conflicts for the GPIO flags, so ensure Zephyr code always includes the Zephyr header file. BUG=b:218856245 BRANCH=none TEST=zmake testall Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I2be5ca58246bbe0679127ca4a17913dcddadc807 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3489103 Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com>
* zephyr: Move gpio_get_dt_spec prototypeKeith Short2022-02-252-9/+9
| | | | | | | | | | | | | | | Move the gpio_get_dt_spec() prototype into a Zephyr specific file. This allows code under platform/ec/zephyr to avoid including the legacy gpio.h, which has duplicate GPIO flag definitions. BUG=b:218856245 BRANCH=none TEST=zmake testall Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I1390dd1bc7ce3ee81f258cf6aa741e706ff08c8f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3489102 Reviewed-by: Aaron Massey <aaronmassey@google.com>
* zephyr: split legacy and shimmed codes into librariesKeith Short2022-02-2511-22/+49
| | | | | | | | | | | | | | | Split the legacy EC code and shimmed code into separate libraries. This allows for declaring different compiler definitions to the legacy and shim code. BUG=b:218856245 BRANCH=none TEST=zmake testall Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: Ice25c21409d33594e7d465092ad5066be7336dbe Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3489101 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* zephyr: move location where system.c is compiledKeith Short2022-02-252-1/+1
| | | | | | | | | | | | | | | Move the compilation of common/system.c into the main CMakeLists.txt for the EC application. This ensures all legacy files added to the build from the same place. BUG=b:218856245 BRANCH=none TEST=zmake testall Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: Ib1771cb859d9b7fa5b0a5f4ed203ae903e0b5ab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3489100 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* gpio: cleanup header usage for bb_retimerKeith Short2022-02-252-1/+1
| | | | | | | | | | | | | | The bb_retimer source file requires the GPIO header reference while the bb_retimer header does not. BUG=b:218856245 BRANCH=none TEST=compare_build.sh Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I04e83594f81bd2182fb0436d7844f214b08af045 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3489099 Reviewed-by: Yuval Peress <peress@google.com>
* gpio: cleanup header usage for uartKeith Short2022-02-257-1/+7
| | | | | | | | | | | | | | uart.h only requires the enum gpio_signal, so use gpio_signal.h instead of gpio.h. BUG=b:218856245 BRANCH=none TEST=compare_build.sh Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I55cfb132d21f60ed629bbc9397a2a2b3ec8a23c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3489098 Reviewed-by: Al Semjonovs <asemjonovs@google.com>
* gpio: cleanup header usage for powerKeith Short2022-02-252-1/+2
| | | | | | | | | | | | | | power.h only requires the enum gpio_signal, so use gpio_signal.h instead of gpio.h. BUG=b:218856245 BRANCH=none TEST=compare_build.sh Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: Ie9a6894f497695c07aa80fd17b1d92f394886563 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3489097 Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* gpio: cleanup header usage for sensorsKeith Short2022-02-2510-3/+10
| | | | | | | | | | | | | | The motion_sense.h header doesn't reference any GPIO functions or structures so the extra header is removed. BUG=b:218856245 BRANCH=none TEST=compare_build.sh Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: Iee843f0dd35336b264d15e949ca780aa1b2e3f1e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3489096 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* gpio: cleanup header usage for keyboardKeith Short2022-02-253-1/+3
| | | | | | | | | | | | | | keyboard_raw.h only requires the enum gpio_signal, so use gpio_signal.h instead of gpio.h. BUG=b:218856245 BRANCH=none TEST=compare_build.sh Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: Id9e6939323f6d6433dd7cc4899df5e748720561f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3489095 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* gpio: cleanup header usage for i2cKeith Short2022-02-2562-1/+64
| | | | | | | | | | | | | | | | | | | | | | | | | | | i2c.h only requires the enum gpio_signal, so use gpio_signal.h instead of gpio.h. The builld doesn't compare due to an ASSERT() calls in i2c-stm32f4.c because the line numbers changed. Before this change: 80068b2: f240 2332 movw r3, #562 80068b6: 48a4 ldr r0, [pc, #656] 80068b8: f7fc fb1a bl 8002ef0 <panic_assert_fail> After this change: 80068b2: f44f 730d mov.w r3, #564 80068b6: 48a4 ldr r0, [pc, #656] 80068b8: f7fc fb1a bl 8002ef0 <panic_assert_fail> BUG=b:218856245 BRANCH=none TEST=compare_build.sh Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I0f9f428d5c575c444b9df69f71a0ed6c4b3e378c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3489094 Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com>
* gpio: cleanup header usage for chipset taskKeith Short2022-02-258-1/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | chipset.h only requires the enum gpio_signal, so use gpio_signal.h instead of gpio.h. The build doesn't compare due to an ASSERT() call in throttle_ap.c after the number of lines increased by 1. From prochot_input_deferred() before the change: 1009b592: 2158 movs r1, #88 ; 0x58 1009b594: f7fd ff76 bl 10099484 <panic_assert_fail> After the change 1009b592: 2159 movs r1, #89 ; 0x59 1009b594: f7fd ff76 bl 10099484 <panic_assert_fail> BUG=b:218856245 BRANCH=none TEST=compare_build.sh Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I30dcdec6985d51279512c25889f03b5f9b1955e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3489093 Reviewed-by: Tristan Honscheid <honscheid@google.com>
* gpio: cleanup header usage for buttonsKeith Short2022-02-253-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | button.h only requires the enum gpio_signal, so use gpio_signal.h instead of gpio.h. The build compare doesn't match due to the ASSERT() call in keyboard_vivaldi.c. The line number increases by 1, changing the assert output text. From vivaldi_init(), before the change: 21a1 movs r1, #161 ; 0xa1 f7fe f856 bl 10099484 <panic_assert_fail> After the change: 21a2 movs r1, #162 ; 0xa2 f7fe f856 bl 10099484 <panic_assert_fail> BUG=b:218856245 BRANCH=none TEST=compare_build.sh Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: Ib0aae4e7b66dd9f83071095b7db233444f6dc4be Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3489092 Reviewed-by: Aaron Massey <aaronmassey@google.com> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-by: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Yuval Peress <peress@google.com>
* zephyr: drivers: Setup correct cable identity for BB testTomasz Michalec2022-02-251-6/+3
| | | | | | | | | | | | | | | | | BB retimer has different behaviour that depends on cable identity. This patch setups arbitrarily chosen cable identity to make sure that expected connection state is achieved. BUG=b:216307791 BRANCH=none TEST=zmake configure --test test-drivers Signed-off-by: Tomasz Michalec <tm@semihalf.com> Change-Id: I96f7976faad6859e686408b1555ee8ed1978a3f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3479835 Reviewed-by: Tristan Honscheid <honscheid@google.com> Tested-by: Tomasz Michalec <tmichalec@google.com> Commit-Queue: Tomasz Michalec <tmichalec@google.com>
* zephyr: drivers: Remove unnecessary setting test TIDTomasz Michalec2022-02-251-34/+0
| | | | | | | | | | | | | | | | | Now zephyr test API makes sure, that before function is called in the same thread as actual test. Because of that calls to set_test_runner_tid() are not necessary in each test function. BUG=b:216307791 BRANCH=none TEST=zmake configure --test test-drivers Signed-off-by: Tomasz Michalec <tm@semihalf.com> Change-Id: Ibe029b8bfd062d4d3a27b11af007c67e7dec10e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3479834 Reviewed-by: Wai-Hong Tam <waihong@google.com> Tested-by: Tomasz Michalec <tmichalec@google.com> Commit-Queue: Tomasz Michalec <tmichalec@google.com>
* zmake: Add reference to zmake unit test coverageJeremy Bettis2022-02-251-0/+8
| | | | | | | | | | | | | | | | Add a link to the latest coverage report on gitlab. BRANCH=None BUG=b:219062927 TEST=None Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: Ia42e70c245e11c4daa3b3642bd9ce99e18cb99d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3489262 Reviewed-by: Al Semjonovs <asemjonovs@google.com> Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Tested-by: Jeremy Bettis <jbettis@chromium.org> Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
* docs: Update "Getting Started Quickly"Andrea Grandi2022-02-251-14/+25
| | | | | | | | | | | | | | | | | | | | | | Instructions in this document have become out of date. Align the content with the "Chromium OS Developer Guide": - Add missing package to fix local build error with libusb header - Use ~/chromiumos folder for chroot to be consistent with dev guide - Set missing env variable $BOARD - Replace deprecated script ./build_pacakges - Remove minilayout and use stable branch to make the build more reliable BRANCH=none BUG=b:219082979 TEST=View of Markdown preview in VSCode Signed-off-by: Andrea Grandi <agrandi@google.com> Change-Id: I3fdac3b346098575a0957394e80052626ecbb551 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3466428 Reviewed-by: Bobby Casey <bobbycasey@google.com> Reviewed-by: Tom Hughes <tomhughes@chromium.org>
* zephyr: npcx: add build time check for the hibernate DT nodeJun Lin2022-02-256-16/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Nuvoton EC supports two hibernate mode: - PSL mode - non-PSL (disable RAM) mode The PSL mode uses the DT node vsby-psl-in-list to configure the PSL input wakeup pins. The non-PSL mode uses the DT node hibernate-wake-pins to configure the GPIO wakeup pins. This CL adds a build time assert to prevent a user from using the incorrect DT node for different mode. Also, add status = "okay" to the vsby-psl-in-list node because the status was disabled at default with PR:42668. BUG=b:216893756 BRANCH=none TEST=set "zmake testall --clobber" TEST=add "CONFIG_PLATFORM_EC_HIBERNATE_PSL=y" and define hibernate-wake-pins node in the prj.conf of npcx9_evb; see the build error. TEST=set "CONFIG_PLATFORM_EC_HIBERNATE_PSL=n" and define vsby-psl-in-list node in the prj.conf of npcx9_evb; see the build error. Signed-off-by: Jun Lin <CHLin56@nuvoton.com> Change-Id: I83f4c3d427ef479445d5e5b992f53056da9bf1ef Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3449996 Reviewed-by: Wai-Hong Tam <waihong@google.com> Reviewed-by: Keith Short <keithshort@chromium.org> Tested-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* gitlab: Fix zmake unit test coverage regexJeremy Bettis2022-02-251-1/+1
| | | | | | | | | | | | | | | | | | The regex wasn't matching the TOTAL line from the coverage report. Change to the recommended regex from https://docs.gitlab.com/ee/ci/pipelines/settings.html#test-coverage-examples BRANCH=None BUG=b:219062927 TEST=None Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: Ia867148e95f0aa5de3a7e182a13cce952f4b114f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3489261 Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Tested-by: Jeremy Bettis <jbettis@chromium.org> Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
* docs/fingerprint: Add image of Icetower v0.1 boardTom Hughes2022-02-253-5/+14
| | | | | | | | | | | | | | | The development board for dartmonkey firmware is Icetower, which replaces the Dragontalon board. BRANCH=none BUG=b:168656024 TEST=view in gitiles Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: Ic47c18eddc7fd842e211630001fa00c0f82d4ac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3484838 Reviewed-by: Andrea Grandi <agrandi@google.com> Reviewed-by: Eric Yilun Lin <yllin@google.com>
* zephyr: it8xxx2: enable PM configurations for it8xxx2-based boardsDino Li2022-02-251-0/+5
| | | | | | | | | | | | | | | | This applies the configurations to it8xxx2-based boards. BRANCH=none BUG=b:220647142 TEST=The configurations are enabled on both Krabby and Nereid. Power number is reduced significantly on Krabby while sleepmask is 0. Signed-off-by: Dino Li <Dino.Li@ite.com.tw> Change-Id: Ib42fb750d70fbc16ff343ff497ece6ce91219b10 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3475297 Reviewed-by: Eric Yilun Lin <yllin@google.com> Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* felwinter: modify fan rpm settingMatt Wang2022-02-251-2/+2
| | | | | | | | | | | | | | | | Modify the fan rpm min/max value. BUG=b:198371480 BRANCH=brya TEST=make BOARD=felwinter Signed-off-by: Matt Wang <matt_wang@compal.corp-partner.google.com> Change-Id: I33b38e34b9bcaae5252f682b8a3d598ce787016a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3478979 Reviewed-by: Elmo Lan <elmo_lan@compal.corp-partner.google.com> Reviewed-by: caveh jalali <caveh@chromium.org> Reviewed-by: Ko Ko <ko_ko@compal.corp-partner.google.com> Commit-Queue: Ricky Chang <rickytlchang@chromium.org>
* kingler: drop PSL functionEric Yilun Lin2022-02-251-1/+0
| | | | | | | | | | | | | | | | | This is unused on MT8186. BUG=b:203739613 TEST=zmake configure -b kingler BRANCH=none Change-Id: I3358461444fefdd83899f634a75f8d9276905b46 Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3487373 Reviewed-by: Rong Chang <rongchang@chromium.org> Reviewed-by: Ting Shen <phoenixshen@chromium.org> Auto-Submit: Eric Yilun Lin <yllin@google.com> Tested-by: Eric Yilun Lin <yllin@google.com> Commit-Queue: Eric Yilun Lin <yllin@google.com>
* krabby: enable vcc1.8vTing Shen2022-02-251-1/+1
| | | | | | | | | | | | | | | | Set GPMx voltage to 1.8V to enable VCC 1.8V for M group. BUG=none TEST=`md .b 0x00F016ED`, verify bit 2..4 == 0b100 BRANCH=none Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: Ia4e24694320e9998ea7ee53b0b528e931ddbd227 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3489905 Reviewed-by: Dino Li <dino.li@ite.corp-partner.google.com> Reviewed-by: Eric Yilun Lin <yllin@google.com> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org>
* zephyr: corsola: fix Kconfig typoEric Yilun Lin2022-02-251-1/+1
| | | | | | | | | | | | | | BUG=b:207802869 TEST=kingler boots BRANCH=none Change-Id: I4073c25fee7e7e27fcccfaf49bafefed9667cced Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3490447 Tested-by: Eric Yilun Lin <yllin@google.com> Auto-Submit: Eric Yilun Lin <yllin@google.com> Reviewed-by: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Eric Yilun Lin <yllin@google.com>
* kingler: config wake eventsEric Yilun Lin2022-02-256-36/+39
| | | | | | | | | | | | | | | | | Configure common events, and moves common mkbp configs into corsola. BUG=b:220951682 TEST=powerd_dbus_suspend, and AP won't wake BRANCH=none Change-Id: I9ae794cab576e797218c9d09e28777085ee12df3 Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3489121 Tested-by: Eric Yilun Lin <yllin@google.com> Auto-Submit: Eric Yilun Lin <yllin@google.com> Reviewed-by: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Ting Shen <phoenixshen@chromium.org>
* zephyr: subsys/ap_pwrseq: handle power signalsLi Feng2022-02-2511-15/+617
| | | | | | | | | | | | | | | | | | | | | Input power signals change results power state transition. Signals are from either GPIO interrupts or ESPI via virtual wires. Add power signals handling in power state machine. 1. Config power signals GPIO interrupts 2. Add power signals list 3. Check power signals for power state transition 4. Add S5 inactive timer BUG=b:203446068 BRANCH=none TEST=On Brya platform, tested boot up to S0; AP "shutdown -h now", power state enters S5 then G3 after 10 seconds. Signed-off-by: Li Feng <li1.feng@intel.com> Change-Id: I34535fa8f8d1e5ba20fca578a638bf1bd7da250f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3449792 Reviewed-by: Andrew McRae <amcrae@google.com>
* npcx: power down unused modulesJun Lin2022-02-253-9/+21
| | | | | | | | | | | | | | | | | | | This CL sets the power down bit for unused module SDP and I3C to get better power efficiency. BUG=b:219388463 BRANCH=none TEST=pass "make buiilall" TEST=observe registers by "rw .b 0x4000d008" and "rw .b 0x4000d025" berfore/after this CL. Signed-off-by: Jun Lin <CHLin56@nuvoton.com> Change-Id: Idc399af40588a650e9031c6eadffc70c058d4ac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3467378 Reviewed-by: Keith Short <keithshort@chromium.org> Tested-by: CH Lin <chlin56@nuvoton.com> Reviewed-by: caveh jalali <caveh@chromium.org> Commit-Queue: caveh jalali <caveh@chromium.org>
* kingler: enable USB-AEric Yilun Lin2022-02-252-1/+5
| | | | | | | | | | | | | | BUG=b:203739613 TEST=zmake configure -b kingler BRANCH=none Change-Id: I2e916a655fb4b306c13306e2db865da1ebeaff04 Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3487372 Tested-by: Eric Yilun Lin <yllin@google.com> Auto-Submit: Eric Yilun Lin <yllin@google.com> Reviewed-by: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Ting Shen <phoenixshen@chromium.org>
* ps8xxx: Remove resolved TODOCaveh Jalali2022-02-251-3/+0
| | | | | | | | | | | | | | | This removes a resolved TODO. Based on https://issuetracker.google.com/issues/183127346#comment12, there is no preferred order for writing these registers. BRANCH=none BUG=b:183127346 TEST=buidlall passes Change-Id: Ieb1a1dfb4bd9cab78cce032ae467c240bc5e965a Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3462929 Reviewed-by: Boris Mittelberg <bmbm@google.com>
* ps8xxx: Remove P1 designator from some regsCaveh Jalali2022-02-252-8/+8
| | | | | | | | | | | | | | | | This renames the PS8815_P1_REG_RESERVED_F4 and PS8815_P1_REG_RESERVED_D1 to indicate they are on page 3. The original P1 naming was wrong. By convention, P3 registers do not include P3 in their name as that is the primary TCPM page. BRANCH=none BUG=b:183127346 TEST=buildall passes Change-Id: Ia6a8bcfafe277e2a871182d518e0f401b0319013 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3462928 Reviewed-by: Boris Mittelberg <bmbm@google.com>
* vell: Update charging LEDs behaviorDevin Lu2022-02-251-6/+25
| | | | | | | | | | | | | | | | | | | | | | | This patch updates the LEDs behavior. Change as below: 1. battery error: Original - Blinking white quickly. (0.5 sec ON, 0.5 sec OFF) New - Blinking amber quickly. (0.5 sec ON, 0.5 sec OFF) 2. battery low: Original - Blinking white slowly on right side led. (1 sec ON, 1 sec OFF) New - Blinking amber slowly on both side leds. (1 sec ON, 1 sec OFF) BUG=b:203158255 BRANCH=none TEST=On Vell, Verify LEDs worked indeed. Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Change-Id: I9c091c6e7b17e1741c2c88dca98b1389a4eea8b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3489110 Reviewed-by: caveh jalali <caveh@chromium.org>
* nissa: enable battery cutoffScott Chao2022-02-251-0/+1
| | | | | | | | | | | | | BUG=b:220271651 BRANCH=none TEST=zmake configure -b nereid TEST=zmeke configure -b nivviks TEST=make sure BT+ is 0V. Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com> Change-Id: I4cb5e10a868392770e25eb3472b1b1c2747ad4db Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3482995 Reviewed-by: Peter Marheine <pmarheine@chromium.org>
* krabby: enable daughter board detectionEric Yilun Lin2022-02-251-0/+3
| | | | | | | | | | | | | BUG=none TEST=zmake configure -b krabby BRANCH=none Change-Id: Id7b41c23da00c5c75d7fdbf8aafdc57288e2e6c4 Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3486603 Reviewed-by: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Eric Yilun Lin <yllin@google.com> Tested-by: Eric Yilun Lin <yllin@google.com>
View Lorry Controller Status