summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* eldrid: dropping eldrid_npcx796stabilize-14150.882.B-mainstabilize-14150.74.B-mainstabilize-14150.64.B-mainstabilize-14150.43.B-mainstabilize-14150.376.B-mainrelease-R94-14150.B-mainYH Lin2021-08-123-10/+0
| | | | | | | | | | | | | eldrid_npcx796 variant is only used for EVT and hence deprecated. BRANCH=firmware-volteer-13672.B BUG=b:196059702 TEST=make BOARD=eldrid Signed-off-by: YH Lin <yueherngl@chromium.org> Change-Id: I6b593b8b412674fa4330fa4fe30d0c522fea3a69 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3088585 Reviewed-by: Zhuohao Lee <zhuohao@chromium.org>
* Cappy2: Add EC_CBI_WPwangganxiang2021-08-121-2/+1
| | | | | | | | | | | | | | | Add EC_CBI_WP pin to EC. BUG=b:195103187 BRANCH=keeby TEST=make BOARD=cappy2 pass Signed-off-by: wangganxiang <wangganxiang@huaqin.corp-partner.google.com> Change-Id: If0c181a2c690d4425590e54bbc9fe46b054fa288 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3088959 Reviewed-by: Mike Lee <mike5@huaqin.corp-partner.google.com> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
* asurada/cherry/goroh: add missing newlineTing Shen2021-08-123-3/+3
| | | | | | | | | | | | | | | | Add a newline to the debug message to make it easier to read. BUG=none TEST=none BRANCH=main Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: Ice108ca54cc4247c1d76c9f29c1392f15a4de5b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3087982 Tested-by: Ting Shen <phoenixshen@chromium.org> Auto-Submit: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Eric Yilun Lin <yllin@google.com> Commit-Queue: Eric Yilun Lin <yllin@google.com>
* gimble: configure PPVAR_SYSScott Chao2021-08-121-0/+8
| | | | | | | | | | | | | The PPVAR_SYS must same as battery voltage(3 cells * 4.4V) BUG=b:196184163 BRANCH=none TEST=make -j BOARD=gimble Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com> Change-Id: Ibc0c9104fba00f33ab2168b78455ca809a746643 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3088964 Reviewed-by: caveh jalali <caveh@chromium.org>
* bq25710: add min system voltage configurationScott Chao2021-08-122-0/+33
| | | | | | | | | | | | | Add this function to let each board can control it. BUG=b:196184163 BRANCH=none TEST=make -j BOARD=gimble Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com> Change-Id: Ic47c67e11eba1bfadef5f5942cff9fcad8b49ad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3086786 Reviewed-by: caveh jalali <caveh@chromium.org>
* primus: enable CONFIG_USB_PD_REQUIRE_AP_MODE_ENTRYScott Chao2021-08-121-0/+1
| | | | | | | | | | | BUG=b:196287208 BRANCH=none TEST=make -j BOARD=primus Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com> Change-Id: I7a3a484b1a4f47292688698fb49c833e19bffc35 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3088967 Reviewed-by: caveh jalali <caveh@chromium.org>
* chip/mt_scp: add define to support wait decode interrupt in scpYunfei Dong2021-08-121-0/+1
| | | | | | | | | | | | | | | Add define to support irq in scp: VDEC_CAP_IRQ_IN_SCP BIT(16). BRANCH=none BUG=b:184793035 TEST=make BOARD=cherry_scp Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com> Change-Id: I7d4583f7c4bce07c6fb4f22bd9152edb23fe9e05 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3054225 Reviewed-by: Tzung-Bi Shih <tzungbi@chromium.org> Commit-Queue: Tzung-Bi Shih <tzungbi@chromium.org> Tested-by: Tzung-Bi Shih <tzungbi@chromium.org>
* gimble: set 90% input current limitstabilize-14149.B-mainWill Tsai2021-08-121-0/+15
| | | | | | | | | | | | BUG=b:196186949 BRANCH=none TEST=make -j BOARD=gimble Signed-off-by: Will Tsai <will_tsai@wistron.corp-partner.google.com> Change-Id: I4b1675ad17b05267191c8a6262d7bb9cc7a05265 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3088598 Reviewed-by: Boris Mittelberg <bmbm@google.com> Tested-by: Scott Chao <scott_chao@wistron.corp-partner.google.com>
* delbin: gyro sensor add 2nd source icm-40608Michael5 Chen12021-08-123-4/+75
| | | | | | | | | | | | | | | | | gyro sensor add 2nd source icm-40608 BUG=b:192990527 BRANCH=volteer TEST=make BOARD=delbin 1. Set CBI SSFC 0x2 and using command "watch ectool motionsense lid_angle" for sensor icm-40608. 2. Using command "watch ectool motionsense lid_angle" for BMI260. Signed-off-by: Michael5 Chen1 <michael5_chen1@pegatron.corp-partner.google.com> Change-Id: I4a9fef206cdbd49106deaa1411a3481bbd18d78c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3011103 Reviewed-by: Zhuohao Lee <zhuohao@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org>
* TCPMv2: Fix ordering of Vbus application in Attached.SRC entryDiana Z2021-08-111-12/+24
| | | | | | | | | | | | | | | | | | | Per the TCPCI spec figures, we should be setting the CC lines and enabling Auto Discharge Disconnect before attempting to source Vbus. Doing these things out of order may cause Vbus sourcing to appear to fail when a TCPC is waiting for ADD to set before enabling Vbus. BRANCH=None BUG=b:195966013 TEST=on guybrush, verify both C0 and C1 successfully detect that they are sourcing Vbus with an unpowered Apple 3-in-1 dongle Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: Icb0bd221a7d8eb069b74327c27894e5d92e95329 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3088003 Reviewed-by: Edward Hill <ecgh@chromium.org> Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Edward Hill <ecgh@chromium.org>
* zephyr: rename kconfig PLATFORM_EC_VBOOTJack Rosenthal2021-08-1116-21/+21
| | | | | | | | | | | | | | | | | | | Rename CONFIG_PLATFORM_EC_VBOOT to CONFIG_PLATFORM_EC_VBOOT_EFS2, since this is what is actually toggled by the config. EFS2 is only a small component of verified boot, and we have many boards which don't actually use it (e.g., trogdor family) for verified boot, making the existing name very confusing. BUG=none BRANCH=none TEST=zmake testall Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: I68ea5815b4a001c680fc78196bb7a02815799b52 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3088164 Commit-Queue: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* Trondo: Free up flash spaceDiana Z2021-08-111-0/+3
| | | | | | | | | | | | | | Trondo is nearly out of space on ToT, so remove the PRL debug strings in order to free up some bytes. BRANCH=None BUG=None TEST=make -j buildall Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: I8534495ed82f2c27cd9b2b9a293e7117a67e3062 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3078410 Reviewed-by: Keith Short <keithshort@chromium.org>
* Bobba: Free up flash spaceDiana Z2021-08-111-0/+1
| | | | | | | | | | | | | | Bobba needs more flash space on ToT, so remove the PRL debug strings. BRANCH=None BUG=None TEST=make -j buildall Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: Iacb3a95cda12bb6c6c29eb3cfbc55cfe54287258 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3078409 Reviewed-by: Keith Short <keithshort@chromium.org> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* Eldrid: Free space on NPCX796 boardDiana Z2021-08-111-0/+3
| | | | | | | | | | | | | Remove the PD PRL debug strings in order to free up space on this board. BRANCH=None BUG=None TEST=make -j buildall Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: Id8deceaf28ffbecbe6ce1d9accdf66726d7af9d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3078408 Reviewed-by: Keith Short <keithshort@chromium.org>
* zephyr: npcx: SHI: select the host interface to SHI explicitlyJun Lin2021-08-111-4/+4
| | | | | | | | | | | | | | | | | | | | | | We use the property 'hif-type-auto' in the node /booter-variant to track if the booter of a NPCX chip series sets the host interface type or not. If it is not set, the SHI driver should set it explicitly. BRANCH=none BUG=none TEST=pass "zmake testall" TEST=verify the HIF_TYP_SEL field in DEVCNT register is set correctly. Signed-off-by: Jun Lin <CHLin56@nuvoton.com> Change-Id: Ic96d03a6eaf347638684f533ea8ff0e447f95b40 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3067145 Tested-by: CH Lin <chlin56@nuvoton.com> Tested-by: Wai-Hong Tam <waihong@google.com> Reviewed-by: Keith Short <keithshort@chromium.org> Reviewed-by: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Wai-Hong Tam <waihong@google.com> Commit-Queue: Keith Short <keithshort@chromium.org> Commit-Queue: Wai-Hong Tam <waihong@google.com>
* zephyr: npcx_evb: Enable eSPIWealian Liao2021-08-114-0/+12
| | | | | | | | | | | | | | This CL enables eSPI for npcx7/9_evb. BUG=none BRANCH=none TEST=Read EC host register by eSPI host emulator. Cq-Depend: chromium:3074381 Signed-off-by: Wealian Liao <whliao@nuvoton.corp-partner.google.com> Change-Id: I9308095eb5cca8fdcd6466fe776d699e3a4a97c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3077761 Reviewed-by: Keith Short <keithshort@chromium.org>
* zephyr: cleanup Zephyr v2.5 ifdefsJack Rosenthal2021-08-114-47/+1
| | | | | | | | | | | | | | We no longer support version 2.5. Drop these obsolete ifdefs. BUG=b:195571108 BRANCH=none TEST=zmake testall Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: I85985108bcf175a2756a2f8096b0aa9e3c22fce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3086368 Reviewed-by: Keith Short <keithshort@chromium.org> Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com>
* zephyr: zmake: drop support for v2.5Jack Rosenthal2021-08-113-9/+9
| | | | | | | | | | | | | | v2.5 is now unused, cleanup the last tidbits in zmake supporting it. BUG=b:195571108 BRANCH=none TEST=zephyr/zmake/run_test.sh Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: Iea93f1d8703ad7e9c5c9bac18af0c47aed1e9a7b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3086367 Reviewed-by: Keith Short <keithshort@chromium.org> Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com>
* volet: general cleanup CONFIG_USB_PD_TCPM_RT1715Ben Chen2021-08-111-3/+0
| | | | | | | | | | | | | | | | | | CONFIG_USB_PD_TCPM_RT1715 is already defined by the volteer baseboard header. Cleanup the predefine in volet portion. BUG=none BRANCH=volteer TEST=make buildall PASS Change-Id: I1688369a2ea8533781871de1a3ab6eaa2ceb789a Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3068497 Reviewed-by: Zhuohao Lee <zhuohao@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org> Reviewed-by: Isaac Lee <isaaclee@google.com> Reviewed-by: YH Lin <yueherngl@chromium.org> Commit-Queue: Isaac Lee <isaaclee@google.com>
* zephyr: asurada: enable zephyr_print use printkDenis Brockus2021-08-111-0/+1
| | | | | | | | | | | | | | | | | | | | | | Asurada is not currently able to output fast enough using shell_fprintf and they timeout unrelated functionality. For this case it will be allowed to use a define CONFIG_PLATFORM_EC_CONSOLE_USES_PRINTK to force zephyr_print to use printk BUG=b:193585176 BRANCH=none TEST=zmake configure -b $PROJ_HAYATO TEST=boot asurada Signed-off-by: Denis Brockus <dbrockus@google.com> Change-Id: Ia9c3d38754e298e3ef7fe8e72ff1e30a7dc775d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3082329 Commit-Queue: Jack Rosenthal <jrosenth@chromium.org> Tested-by: Denis Brockus <dbrockus@chromium.org> Auto-Submit: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org>
* zephyr: shim: zephyr_print option to use printkDenis Brockus2021-08-112-1/+20
| | | | | | | | | | | | | | | | | | | | Some devices are not able to output fast enough using shell_fprintf and they timeout unrelated functionality. For this case it will be allowed to use a define CONFIG_PLATFORM_EC_CONSOLE_USES_PRINTK to force zephyr_print to use printk BUG=b:193585176 BRANCH=none TEST=zmake configure -b $PROJ_HAYATO Signed-off-by: Denis Brockus <dbrockus@google.com> Change-Id: I8a08fc730637e1d9e2b612b877572fac235a4be4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3082328 Tested-by: Denis Brockus <dbrockus@chromium.org> Auto-Submit: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
* eel: initial commitTing Shen2021-08-113-1/+15
| | | | | | | | | | | | | | | | | Eel is the detachable keyboard (Hammer derivative) for Wormdingler project. BUG=b:195625351 TEST=make BRANCH=trogdor Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: I01449f0058c857e52d5b40e7fb69d9474e3b18b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3084326 Tested-by: Ting Shen <phoenixshen@chromium.org> Auto-Submit: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Wai-Hong Tam <waihong@google.com> Commit-Queue: Wai-Hong Tam <waihong@google.com>
* zephyr: zmake: drop "print-versions" subcommandJack Rosenthal2021-08-113-50/+0
| | | | | | | | | | | | | | | | This command was intended for use in ebuild, but never instrumented. Remove the dead code. BUG=b:195571108 BRANCH=none TEST=zephyr/zmake/run_tests.sh Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: I68d3da2e4dfdb4a44b5a58d2b8e2c01da373c06f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3086366 Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com> Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* zephyr: drop v2.5 support from all projectsJack Rosenthal2021-08-117-7/+0
| | | | | | | | | | | | | | | | Remove support for v2.5 for all projects which still indicate it's supported. BUG=b:195571108 BRANCH=none TEST=zmake testall Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: I5c22e382545741181866a4e88cb3d486a392f2f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3086365 Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com> Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* zephyr: update gitlab external CI to use v2.6 on all buildsJack Rosenthal2021-08-111-8/+7
| | | | | | | | | | | | | | | 2.5 support is going away. Drop any builds which use 2.5 still. BUG=b:195571108 BRANCH=none TEST=gitlab pipeline results UI Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: I9f18f934db9267e3f074c82fa6f64c603c62b842 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3086364 Commit-Queue: Keith Short <keithshort@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org> Reviewed-by: Simon Glass <sjg@chromium.org>
* zephyr: cros_kb_raw_npcx: Add output high driver config optionWealian Liao2021-08-113-1/+13
| | | | | | | | | | | | | | | This CL adds a Kconfig option 'CROS_KB_RAW_NPCX_KSO_HIGH_DRIVE' for npcx output buffer high driver function. BUG=none BRANCH=none TEST=zmake testall Signed-off-by: Wealian Liao <whliao@nuvoton.corp-partner.google.com> Change-Id: I91f98581f43ca88991345b2e23ab11e5b99353be Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3077763 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* zephyr: herobrine_npcx9: enable shell historyJack Rosenthal2021-08-111-0/+3
| | | | | | | | | | | | | | | | Enable the shell history for developer convenience. BUG=b:192253134 BRANCH=none TEST=compiles Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: Id48cc36ba54d03879434fca7bf992d44cfcabbb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3087835 Commit-Queue: Wai-Hong Tam <waihong@google.com> Commit-Queue: Keith Short <keithshort@chromium.org> Reviewed-by: Wai-Hong Tam <waihong@google.com> Reviewed-by: Keith Short <keithshort@chromium.org>
* delbin: Remove delbin_npcx796cMichael5 Chen12021-08-103-8/+0
| | | | | | | | | | | | | | | | Remove delbin_npcx796c because it will cause image size is too big. BUG=b:195968642 BRANCH=firmware-volteer-13672.B TEST=make BOARD=delbin Signed-off-by: Michael5 Chen1 <michael5_chen1@pegatron.corp-partner.google.com> Change-Id: I0ec0b86e442d15a99662963df790c7bb76113b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3084401 Reviewed-by: Jacky Wang <jacky5_wang@pegatron.corp-partner.google.com> Reviewed-by: Zhuohao Lee <zhuohao@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* zephyr: lazor: add keyscan parametersKeith Short2021-08-102-1/+30
| | | | | | | | | | | | | Add the keyscan parameters specific to the Lazor board. BUG=b:195945894 BRANCH=none TEST=zmake testall Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I07718e093c2ac1c12f6af854d4656fb4f224db32 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3083723 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* zephyr: volteer: add keyscan parametersKeith Short2021-08-102-1/+30
| | | | | | | | | | | | | Add the keyscan parameters specific to the Volteer board. BUG=b:195945894 BRANCH=none TEST=verify keyboard on Volteer Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I36af888faf9a9401f61aee3c7ed5bd31cb308be0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3083722 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* zephyr: Create devicetree node for keyscanKeith Short2021-08-103-0/+117
| | | | | | | | | | | | | | Create devicetree node to specify the keyscan runtime parameters. BUG=b:195945894 BRANCH=none TEST=zmake testall TEST=verify keyboard on Volteer with next CL Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I4dbf5e4f2205f31651d33b6ffc1ecd1dd6696795 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3083721 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* zephyr: hooks: change priority to uint16_tFabio Baltieri2021-08-101-1/+1
| | | | | | | | | | | | | | | | | Priority field goes from 0 to HOOK_PRIO_LAST, so 16 bits are enough. Switching to a 2 bytes field allows struct zephyr_shim_hook_list to pack up in 12 bytes, saves a bit of ram. BRANCH=none BUG=b:195521227 TEST=build and run on volteer Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: Ia8899d3d47a3c38ed20dfa5121d375a4419567f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3080573 Reviewed-by: Keith Short <keithshort@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* zephyr: shim: reimplement hooks using iterablesFabio Baltieri2021-08-104-36/+26
| | | | | | | | | | | | | | | | | | Reimplement the hooks shim code using Zephyr iterable sections. Keep the existing hook_registry based structure, gets rid of the per-hook init functions and instead initializes all the list nodes from a single init call. BRANCH=none BUG=b:195521227 TEST=build and run on volteer Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: Ic166d214ee1dcd1431ec484e5014cb297f7fb8c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3069399 Reviewed-by: Keith Short <keithshort@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* zephyr: shim: reimplement mkbp_event using iterablesFabio Baltieri2021-08-103-48/+12
| | | | | | | | | | | | | | | Rewrite the MKBP events shim using iterable sections. BRANCH=none BUG=b:195521227 TEST=build and run on volteer Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: Ia96fb9ec06b1a86b1be293209db317a361ae4741 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3069398 Reviewed-by: Keith Short <keithshort@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* zephyr: shim: reimplement host commands using iterablesFabio Baltieri2021-08-104-59/+14
| | | | | | | | | | | | | | | | | Rewrite the host command shim using Zephyr iterable sections. This allows initializing the HC structure statically and gets rid of the runtime init code entirely. BRANCH=none BUG=b:195521227 TEST=build and run on volteer Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I94a55f8eb3e1d58de6a1d93c31b6170a5541a1fc Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3010284 Commit-Queue: Keith Short <keithshort@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* firmware_builder: Make cros lint happyCraig Hesling2021-08-101-15/+24
| | | | | | | | | | | | | | BRANCH=none BUG=none TEST=cros lint ./firmware_builder.py TEST=./firmware_builder.py --help TEST=./firmware_builder.py --metrics $(mktemp /tmp/fwbld.XXX) test TEST=./firmware_builder.py --metrics $(mktemp /tmp/fwbld.XXX) build Signed-off-by: Craig Hesling <hesling@chromium.org> Change-Id: I0c2b03d3197fc021e93ce8a0029cdd465b9eb457 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3082336 Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
* firmware_builder: Add printing of make commandsCraig Hesling2021-08-101-2/+7
| | | | | | | | | | | | | | | This helps people parsing the build output log to understand what commands were invoked. BRANCH=none BUG=b:195718112 TEST=./firmware_builder.py --metrics <(echo) test TEST=./firmware_builder.py --metrics <(echo) build Signed-off-by: Craig Hesling <hesling@chromium.org> Change-Id: Iacceae2bba3db3631456a5d5012fc933730031ba Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3082335 Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
* firmware_builder: Add dartmonkey to unit test listCraig Hesling2021-08-101-4/+13
| | | | | | | | | | | | | | | | | Currently both bloonchipper and dartmonkey on-device unit tests are compiled in the cros-ec.eclass. That means that this CQ check will miss compilation failures for dartmonkey, but other packages that trigger the chromeos-ec test routine will fail. See b/195718112 for an example of this. BRANCH=none BUG=b:195718112, b:172501728 TEST=./firmware_builder.py --metrics <(echo) test Signed-off-by: Craig Hesling <hesling@chromium.org> Change-Id: Ifb7799f1ed56e4b849f115339d1a936d76b57ccd Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3082334 Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
* taeko: initinal board configurationamber.chen2021-08-1012-626/+385
| | | | | | | | | | | | | | | | | | | | | | | | Following taeko hardware design update set as below, 1. Update GPIO pin define 2. Update battery setting 3. Update LED setting 4. Update I2C configuration 5. Update TCPC configuration 6. Remove unnecessary tasklist 7. Remove unnecessary setting for sensors 8. Add Vivaldi keyboard configuration 9. Add fan configuration BUG=b:193377622 BRANCH=main TEST=make -j BOARD=taeko Signed-off-by: amber.chen <amber.chen@lcfc.corp-partner.google.com> Change-Id: I3b73b5a4b1188acfad94a18747300b9b8e534348 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3060239 Reviewed-by: Boris Mittelberg <bmbm@google.com> Reviewed-by: YH Lin <yueherngl@chromium.org> Commit-Queue: YH Lin <yueherngl@chromium.org>
* zephyr: eSPI: npcx: unify the access to eSPI event dataJun Lin2021-08-101-0/+38
| | | | | | | | | | | | | | | | | | | | | Follow PR:37194 to access KBC/ACPI event data via structure if the Zephyr version is v2.6. Otherwise, use the original chip-vendor-specific macro on version v2.5. BUG=none BRANCH=none TEST=pass "zmake testall" TEST=test on Volteer, verify that the platform can boot up to OS screen; make sure keyboard is functional. Cq-Depend: chromium:3054142 Signed-off-by: Jun Lin <CHLin56@nuvoton.com> Change-Id: Iff857809b3c11e734825c113cb8d9913a7a177f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3053140 Tested-by: CH Lin <chlin56@nuvoton.com> Reviewed-by: Yuval Peress <peress@chromium.org> Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* zephyr: switch posix-ec and host tests to v2.6Jack Rosenthal2021-08-1011-10/+16
| | | | | | | | | | | | | | | | Switch the host tests and posix-ec build to Zephyr v2.6. Note: need to disable one assert in the hooks test until b/195971523 is resolved. BUG=b:195571108,b:195971523 BRANCH=none TEST=zmake testall Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: I01b386b2f54cf5b752bede707ff9fbda0faad80a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3072414 Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com>
* pazquel: Modify LED behavior.Tang Qijun2021-08-101-69/+60
| | | | | | | | | | | | | | | | | | | | LED behavior: Charging | Red on (S0/S3/S5) Full Charged | Blue on (S0/S3/S5) Discharging S3 | Red on 1 sec, off 3 sec Discharging S5 | off Error | Red on 1 sec, off 1 sec Discharging S0 | Blue on Factory mode | Blue on 2 sec, Red on 2 sec BRANCH=trogdor BUG=b:194866181 TEST=make buildall -j; check led behavior in every state on pazquel Signed-off-by: Tang Qijun <qijun.tang@ecs.corp-partner.google.com> Change-Id: I84b15d0c1bd7de310a22aab8f44f0f5842f9e688 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3060165 Reviewed-by: Philip Chen <philipchen@chromium.org>
* Redrix: Enable hardware charging rampDevin Lu2021-08-103-36/+1
| | | | | | | | | | | | | | | | | | This patch enables hw charging ramp, the bq25720 have hw ramp function (call Input Current Optimizer (ICO)). Enable it instead of sw ramp. BUG=b:195826406 BRANCH=none TEST=On Redrix. Plug in CDP, SDP, DCP, type-C and PD charger: 1. EC console chgsup to make sure voltage/current is indeed. 2. PDtrace to make sure we ramp current to a reasonable value. Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Change-Id: I37c7854769b4bc1f1eafbe8134bf0804ea35474a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3077590 Reviewed-by: Boris Mittelberg <bmbm@google.com> Reviewed-by: Keith Short <keithshort@chromium.org>
* collis: Remove config for first stable firmwareJacky Wang2021-08-101-4/+0
| | | | | | | | | | | | | | | 1.Remove CONFIG_SYSTEM_UNLOCKED 2.Remove CONFIG_BYPASS_CBI_EEPROM_WP_CHECK BUG=b:186334929 BRANCH=firmware-volteer-13672.B TEST=make BOARD=collis Signed-off-by: Jacky Wang <jacky5_wang@pegatron.corp-partner.google.com> Change-Id: Ia8563c578bca64a828817dfe2ffb09623a60050d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3081040 Reviewed-by: Michael5 Chen <michael5_chen1@pegatron.corp-partner.google.com> Reviewed-by: Keith Short <keithshort@chromium.org>
* primus: add fan controlScott Chao2021-08-102-7/+4
| | | | | | | | | | | | | | - Need EN_P5000_FAN to be off when S5. - Don't let fan keep on in S5 when using dummy fan. BUG=b:195901486, b:195387997 BRANCH=none TEST=make -j BOARD=primus Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com> Change-Id: I3f2d060967d0538e54dfe2f99df7025ccb9a36ef Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3081041 Reviewed-by: caveh jalali <caveh@chromium.org>
* waddledoo: disable console commands to save spaceBoris Mittelberg2021-08-101-0/+4
| | | | | | | | | | | | | Disabling accelspoof and battfake EC console commands BRANCH=main,dedede BUG=none TEST=make -j BOARD=waddledoo Signed-off-by: Boris Mittelberg <bmbm@google.com> Change-Id: Ib4f93185e6f4b63099ea7d600037b03fc306a56d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3078052 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* chgstv2/sustainer: Stop AC current when dischargingDaisuke Nojiri2021-08-092-7/+79
| | | | | | | | | | | | | | | | | | | Currently, the battery sustainer discharges the battery using CHARGE_CONTROL_IDLE, which uses the AC current and stops the current from the battery. With this change, when lower < upper, the sustainer discharges using DISCHARGE. When lower == upper, the sustainer discharges using IDLE. BUG=b:188457962 BRANCH=None TEST=run-sbs_charging_v2 Change-Id: I4af31eff488bc9cfa627f84994b685488c3c9061 Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3049290 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-by: Derek Basehore <dbasehore@chromium.org>
* dartmonkey: Moved unused SLP_ALT_DEV_L to RWCraig Hesling2021-08-092-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | BRANCH=none BUG=b:178746753 TEST=make -j tests-dartmonkey TEST=# Connect servo_micro and J-Link to an icetower board. make proj-dartmonkey -j sudo servod --board=icetower ./util/flash_jlink.py --board=dartmonkey --image=./build/dartmonkey/ec.bin # Unplug J-Link dut-control fpmcu_slp:off fpmcu_slp_alt:off dut-control pp3300_dx_mcu_mw # Should be more than 40mw dut-control fpmcu_slp:on fpmcu_slp_alt:off dut-control pp3300_dx_mcu_mw # Should be less than 10mw dut-control fpmcu_slp:off fpmcu_slp_alt:on dut-control pp3300_dx_mcu_mw # Should be less than 10mw dut-control fpmcu_slp:on fpmcu_slp_alt:on dut-control pp3300_dx_mcu_mw # Should be less than 10mw dut-control fpmcu_slp:off fpmcu_slp_alt:off minicom -D$(dut-control -o raw_fpmcu_console_uart_pty) > reboot ro # Ctrl-A Q # RO no longer enters low-power-idle. dut-control fpmcu_slp:off fpmcu_slp_alt:off dut-control pp3300_dx_mcu_mw # Should be more than 40mw dut-control fpmcu_slp:on fpmcu_slp_alt:off dut-control pp3300_dx_mcu_mw # Should be more than 40mw dut-control fpmcu_slp:off fpmcu_slp_alt:on dut-control pp3300_dx_mcu_mw # Should be more than 40mw dut-control fpmcu_slp:on fpmcu_slp_alt:on dut-control pp3300_dx_mcu_mw # Should be more than 40mw dut-control fpmcu_slp:off fpmcu_slp_alt:off minicom -D$(dut-control -o raw_fpmcu_console_uart_pty) > gpioget # Check that SLP_ALT_DEV_L is missing. # Ctrl-A Q Signed-off-by: Craig Hesling <hesling@chromium.org> Change-Id: I677838148f5aeff6d2f613272e29dc8accb0417e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3078826 Reviewed-by: Josie Nordrum <josienordrum@google.com>
* dartmonkey/bloonchipper: Disable low-power-idle in ROCraig Hesling2021-08-092-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In https://crrev.com/c/2657778 and https://crrev.com/c/2673909 sleeping was explicitly forbidden in RO, in addition to moving the sleep lines explicitly to RW. CLs https://crrev.com/c/3012241 and https://crrev.com/c/3052750 bring the sleep lines back to RO (and RW), since they serve to gate host interface communications when the AP is sleeping. This CL restores the part of the original two refactoring CLs that blocks the more complicated low power sleeping. BRANCH=none BUG=b:178746753 TkEST=make -j tests-dartmonkey tests-bloonchipper TEST=# Connect servo_micro and J-Link to an icetower board. make proj-dartmonkey -j sudo servod --board=icetower ./util/flash_jlink.py --board=dartmonkey --image=./build/dartmonkey/ec.bin # Unplug J-Link dut-control fpmcu_slp:off fpmcu_slp_alt:off dut-control pp3300_dx_mcu_mw # Should be more than 40mw dut-control fpmcu_slp:on fpmcu_slp_alt:off dut-control pp3300_dx_mcu_mw # Should be less than 10mw dut-control fpmcu_slp:off fpmcu_slp_alt:on dut-control pp3300_dx_mcu_mw # Should be less than 10mw dut-control fpmcu_slp:on fpmcu_slp_alt:on dut-control pp3300_dx_mcu_mw # Should be less than 10mw dut-control fpmcu_slp:off fpmcu_slp_alt:off minicom -D$(dut-control -o raw_fpmcu_console_uart_pty) > reboot ro # Ctrl-A Q # RO no longer enters low-power-idle. dut-control fpmcu_slp:off fpmcu_slp_alt:off dut-control pp3300_dx_mcu_mw # Should be more than 40mw dut-control fpmcu_slp:on fpmcu_slp_alt:off dut-control pp3300_dx_mcu_mw # Should be more than 40mw dut-control fpmcu_slp:off fpmcu_slp_alt:on dut-control pp3300_dx_mcu_mw # Should be more than 40mw dut-control fpmcu_slp:on fpmcu_slp_alt:on dut-control pp3300_dx_mcu_mw # Should be more than 40mw dut-control fpmcu_slp:off fpmcu_slp_alt:off minicom -D$(dut-control -o raw_fpmcu_console_uart_pty) > reboot > fpenroll > fpmatch # Ctrl-A Q TEST=# Connect servo_micro to a dragonclaw board. make proj-bloonchipper -j sudo servod --board=dragonclaw ./util/flash_ec --board=bloonchipper dut-control fpmcu_slp:off fpmcu_slp_alt:off dut-control pp3300_dx_mcu_mw # Should be around 20mw dut-control fpmcu_slp:on fpmcu_slp_alt:off dut-control pp3300_dx_mcu_mw # Should be less the 5mw dut-control fpmcu_slp:off fpmcu_slp_alt:on dut-control pp3300_dx_mcu_mw # Should be less the 5mw dut-control fpmcu_slp:on fpmcu_slp_alt:on dut-control pp3300_dx_mcu_mw # Should be less the 5mw dut-control fpmcu_slp:off fpmcu_slp_alt:off minicom -D$(dut-control -o raw_fpmcu_console_uart_pty) > reboot ro # Ctrl-A Q # RO no longer enters low-power-idle. dut-control fpmcu_slp:off fpmcu_slp_alt:off dut-control pp3300_dx_mcu_mw # Should be around 20mw dut-control fpmcu_slp:on fpmcu_slp_alt:off dut-control pp3300_dx_mcu_mw # Should be around 20mw dut-control fpmcu_slp:off fpmcu_slp_alt:on dut-control pp3300_dx_mcu_mw # Should be around 20mw dut-control fpmcu_slp:on fpmcu_slp_alt:on dut-control pp3300_dx_mcu_mw # Should be around 20mw dut-control fpmcu_slp:off fpmcu_slp_alt:off minicom -D$(dut-control -o raw_fpmcu_console_uart_pty) > reboot > fpenroll > fpmatch # Ctrl-A Q Signed-off-by: Craig Hesling <hesling@chromium.org> Change-Id: Iee0cad2dc46aaf9a4499637fce0d446530ff49b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3078825 Reviewed-by: Josie Nordrum <josienordrum@google.com>
* dartmonkey: Reintroduce sleep lines to ROCraig Hesling2021-08-098-45/+102
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change https://crrev.com/c/2657778 removed the sleep lines from RO in an effort to minimize the RO complexity. Most notably, this isolated the deep-sleep/low-power-idle logic to RW only. Unfortunately, the sleep lines also control whether the SPI host interface is listening, which allows it to ignore spurious communication. It seems safer to reinstate the the sleep line with low power idle active and directly disable CONFIG_LOW_POWER_IDLE in subsequent CL. We reinstate the sleep line gpio logic from the following: crrev.com/c1b5095aa8404709bb447bd7a58f262d7d471a01/board/nocturne_fp/board.c This is the parent commit to the CL that refactors the sleep lines. Considering dartmonkey has a sleep line modification for dev boards, we keep this in RW only. Since nearly all functionality would need to be conditioned and communicated between RO and RW, I decided to just create a clean break between RO and RW board init. The original board.c no longer spans both RO and RW, there are exclusive board_ro.c and board_rw.c files. BRANCH=none BUG=b:178746753, b:195718112 TEST=make -j tests-dartmonkey TEST=# Connect servo_micro and J-Link to an icetower board. make proj-dartmonkey -j sudo servod --board=icetower ./util/flash_jlink.py --board=dartmonkey --image=./build/dartmonkey/ec.bin # Unplug J-Link and unplug/replug servo connector. dut-control fpmcu_slp:off fpmcu_slp_alt:off dut-control pp3300_dx_mcu_mw # Should be more than 40mw dut-control fpmcu_slp:on fpmcu_slp_alt:off dut-control pp3300_dx_mcu_mw # Should be less than 10mw dut-control fpmcu_slp:off fpmcu_slp_alt:on dut-control pp3300_dx_mcu_mw # Should be less than 10mw dut-control fpmcu_slp:on fpmcu_slp_alt:on dut-control pp3300_dx_mcu_mw # Should be less than 10mw dut-control fpmcu_slp:off fpmcu_slp_alt:off minicom -D$(dut-control -o raw_fpmcu_console_uart_pty) > reboot ro # Ctrl-A Q # RO does not have the code to adjust to SLP_ALT_DEV_L, thus # it will use SLP_ALT_L, which is 0. This means it will always # think sleep is asserted. dut-control fpmcu_slp:off fpmcu_slp_alt:off dut-control pp3300_dx_mcu_mw # Should be less than 10mw minicom -D$(dut-control -o raw_fpmcu_console_uart_pty) > gpioget # Should see SLP_L=1, SLP_ALT_L=0, and SLP_ALT_DEV_L=1 > reboot > fpenroll > fpmatch # Ctrl-A Q Signed-off-by: Craig Hesling <hesling@chromium.org> Change-Id: I6183a4afa61817c552da5272f7d66a5c58d96f66 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3078824 Reviewed-by: Josie Nordrum <josienordrum@google.com>
View Lorry Controller Status