summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* i2c-pseudo: Add udev ruleDavid Schneider2020-04-072-0/+9
| | | | | | | | | | | | | | | | This removes the need for servod and iteflash to run as root when run from outside the chroot. BRANCH=none BUG=b:153196340 TEST=ran script outside chroot and confirmed permissions Change-Id: I4bb9230eb4f581ddb3a095fc5fec0f56c7c573eb Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2136338 Reviewed-by: Matthew Blecker <matthewb@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> Commit-Queue: David Schneider <dnschneid@chromium.org> Tested-by: David Schneider <dnschneid@chromium.org>
* kohaku: fixup names to temp sensorsTodd Broch2020-04-071-8/+8
| | | | | | | | | | | | | | | | | | | | | | | Names for charger & ambient and gt & ia were reversed by 03cdf27fc7. Lets fix them. Note, this should have no material impact with regard to DPTF as those configurations in coreboot look correct. Signed-off-by: Todd Broch <tbroch@chromium.org> BRANCH=firmware-hatch-12672.B BUG=b:151271332 TEST=make -j buildall Change-Id: I50f80e2791b844e3c326d0dc02e3d8017dd5124f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2137928 Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Commit-Queue: Todd Broch <tbroch@chromium.org> Tested-by: Todd Broch <tbroch@chromium.org> Auto-Submit: Todd Broch <tbroch@chromium.org>
* flash_ec: remove warm_reset for it83xx caseJett Rink2020-04-071-6/+5
| | | | | | | | | | | | | | | | We removed the warm reset code for it I2C flashing recent, so we should remove the warm reset clean up section. The cold reset is a superset of warm reset. BRANCH=none BUG=b:153165576 TEST=waddledee flashing works Signed-off-by: Jett Rink <jettrink@chromium.org> Change-Id: Iac691bfa127dac0f279ac92519c58b0e4211873b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2137922 Tested-by: David Schneider <dnschneid@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* flash_fp_mcu: Add a config for the Volteer fingerprint MCUZhuohao Lee2020-04-071-0/+21
| | | | | | | | | | | | | | | To enable the flash_fp_mcu to update the fingerprint MCU firmware, we need to add a config for the Volteer fingerprint MCU. BUG=b:147687800 BRANCH=None TEST=use 'flash_fp_mcu ${BINARY_PATH}', the firmware is programmed correctly. Change-Id: Ib62ae29ca805985e0256c2ebee5fee633ccef082 Signed-off-by: Zhuohao Lee <zhuohao@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2089214 Reviewed-by: Alex Levin <levinale@chromium.org>
* zork: move thermal setting to variantZick Wei2020-04-074-58/+174
| | | | | | | | | | | | | This CL move thermal setting from baseboard to variant. BUG=b:153277249 BRANCH=none TEST=make buildall Change-Id: I456a00f2b72a079b875267bfa0a56dc7f87b7f9b Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2120765 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* it83xx/gpio: disable unused cc port moduleRuibin Chang2020-04-0710-12/+30
| | | | | | | | | | | | | | | | | | | | | | | | To prevent cc pins leakage and cc pins can be used as gpio. We will check if the chip supported tcpc physical port count is more than board active ITE port count. If yes, we will disable unused cc port module. BUG=none BRANCH=none TEST=1) on board it8xxx2_pdevb with chip it81202, check the pd port connection with adapter and dongle when hibernate and resume. adapter: connect dongle: disconnect then re-connect 2) on board it83xx_evb with chip it8320, set cc pins as gpio, check output level when hibernate and resume. Change-Id: I13511741b2e066dd87277db9f71f2b4a9323ad6d Signed-off-by: Ruibin Chang <ruibin.chang@ite.com.tw> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1994693 Tested-by: Ruibin Chang <Ruibin.Chang@ite.com.tw> Commit-Queue: Ruibin Chang <Ruibin.Chang@ite.com.tw> Reviewed-by: Jett Rink <jettrink@chromium.org>
* puff: explicitly enable the barrel jack interruptPeter Marheine2020-04-071-0/+1
| | | | | | | | | | | | | | | | | While I believe this was working correctly before, without explicitly enabling the interrupt now it won't fire when the barrel jack is connected when the system is powered but off (such as when a low-power USB-C power source is attached). BUG=b:153283569 TEST=Puff detects barrel jack connection while in "insufficient power" state. BRANCH=None Change-Id: Id8c4c5707401d1ad834424542a68e10af09821fa Signed-off-by: Peter Marheine <pmarheine@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2138733 Reviewed-by: Sam McNally <sammc@chromium.org>
* Zork: avoid losing edges from MST hub to DP1_HPDEdward Hill2020-04-071-2/+12
| | | | | | | | | | | | BUG=b:152512560 BRANCH=none TEST=scope shows 1ms HPD pulses preserved by EC Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: I37c983385582955f31f24aed65b4b2c5b15e93ae Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2131051 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* i2c: Fix port bug with i2ctrace and i2cscan commandsEdward Hill2020-04-073-6/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | 'port' is not the index into i2c_ports[]. Fix i2ctrace and i2cscan to use get_i2c_port() to find the matching port in i2c_ports[] table. Add the port name to the 'i2ctrace list' output to make it clear which port it is. > i2ctrace list id port address -- ---- ------- 0 8 ap_audio 0x4A 1 9 ap_hdmi 0x5A to 0x5F 2 3 ap_mux 0x30 3 4 thermal 0x40 4 5 sensor 0x50 BUG=none BRANCH=none TEST=i2ctrace for I2C_PORT_AP_HDMI on Zork: i2ctrace enable 9 0x4a Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: I7b897ac9154751a46ef5961aded569aaec49bfd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2136526 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* HACK: dratini: Prevent system can't power onDevin Lu2020-04-071-0/+21
| | | | | | | | | | | | | | | | | | Apply CL:2014001 to dratini. Currently few systems can't power on, because pp2500_dram_u doesn't assert. To prevent potential risk, this patch trigger re-power on again. BUG=b:152456965 BRANCH=firmware-hatch-12672.B TEST=Verified with defect system and make sure boot up normally. Change-Id: Ia88703286ed6b9d26060cb7fee8cfce98a500d26 Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2130151 Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Commit-Queue: Tim Wawrzynczak <twawrzynczak@chromium.org> Tested-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
* PD: Create unified structure for all SOP* identityDiana Z2020-04-072-52/+117
| | | | | | | | | | | | | | | | | Creates a structure to be used by all SOP* types to store identity information. Combines the full response size storage currently used for SOP, as well as some of the structure accessibility introduced with the cable attributes. Currently not all product type VDOs have defined structures, but these may be added as needed by the code. BRANCH=None BUG=b:152417977 TEST=make -j buildall Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: I7b57b43447653dfbe1024b8fe71375916e0821b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2130475 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* PD: Move pd_discovery init out of dfp_consume_identityDiana Z2020-04-073-8/+7
| | | | | | | | | | | | | | | | | | | | | Moves initialization of pd_discovery from dfp_consume_identity in order to support folding the cable identity into the pd_discovery structure (the cable discovery may or may not precede partner discovery). Also removes a cable structure reset which would clear the cable during a power role swap, and unnecessary references to the TCPMv1 message ID trackers which are a part of the PRL in TCPMv2. BRANCH=None BUG=b:152417977 TEST=on kindred with TCPMv2, ensure discovery information is cleared when unpluggging discovered partner and inserting one with no discover identity response Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: I646b3796704fb6980c64d1b9c60327abee19e371 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2130474 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* PD: Rename pd_policy to pd_discoveryDiana Z2020-04-076-88/+89
| | | | | | | | | | | | | | Rename struct pd_policy to struct pd_discovery to more accurately reflect what the structure contains. BRANCH=None BUG=b:152417977 TEST=make -j buildall Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: I51de48103053aa60b3cdb15cf9fbf15dd75d727a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2130473 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* docs/case_closed_debugging_cr50.md: Unify shell prompt formattingTom Hughes2020-04-061-140/+211
| | | | | | | | | | | | | | | | | | | | | Use the standard used across the documentation for specifying different shell prompts: (chroot) $ (dut) $ cr50 > This makes it clear where the command should be run. BRANCH=none BUG=none TEST=view in gitiles Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I0383e00825b5d9b500464ac1979555ca5afd8296 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2136870 Commit-Queue: Mary Ruthven <mruthven@chromium.org> Reviewed-by: Mary Ruthven <mruthven@chromium.org>
* flash_ec: fix issue with h1 resetJett Rink2020-04-061-31/+35
| | | | | | | | | | | | | | | | When we call cold_reset on waddledee, it actually pulls the H1 down, which will make h1 stop driving the I2C mux, which makes i2c communication fail. We already have a way to hold only the EC in reset from recent Doo changes, so make use of those now for Dee flashing BRANCH=none BUG=b:152936415,b:153165576 TEST=flash Dee and Doo Signed-off-by: Jett Rink <jettrink@chromium.org> Change-Id: I0cafcf1696216ef9ea2ee2169a0b0094140bccc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2135139 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* docs/case_closed_debugging_cr50.md: Run mdformatTom Hughes2020-04-061-133/+126
| | | | | | | | | | | | | | | | | | No content changes. Command used: mdformat --compatibility -w docs/case_closed_debugging_cr50.md BRANCH=none BUG=none TEST=view in gitiles Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: Ieb84866ad610122da08873087f79a6d45ea17ab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2137633 Reviewed-by: Justin TerAvest <teravest@chromium.org> Commit-Queue: Justin TerAvest <teravest@chromium.org>
* asurada: build.mk: change chip variant to it81202axtim2020-04-061-1/+1
| | | | | | | | | | | BUG=None BRANCH=none TEST=make BOARD=asurada -j Signed-off-by: tim <tim2.lin@ite.corp-partner.google.com> Change-Id: I2dbd2dcb03f3624f67edb6aaeaf6eb8024dbc210 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2137179 Reviewed-by: Ting Shen <phoenixshen@chromium.org>
* sushi: Initial EC imagePaul Fagerburg2020-04-047-0/+1028
| | | | | | | | | | | | | | | | | | | | Create the initial EC image for the sushi variant of the hatch baseboard by copying the baseboard EC files into a new directory named for the variant. (Auto-Generated by create_initial_ec_image.sh version 1.0.1). BUG=None BRANCH=none TEST=make BOARD=sushi Signed-off-by: Paul Fagerburg <pfagerburg@google.com> Change-Id: I94b18ca808370a2b69d370c5ae4e3dc3ebb5fa24 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2125163 Tested-by: Paul Fagerburg <pfagerburg@chromium.org> Auto-Submit: Paul Fagerburg <pfagerburg@chromium.org> Reviewed-by: Justin TerAvest <teravest@chromium.org> Commit-Queue: Paul Fagerburg <pfagerburg@chromium.org>
* make: Force --no-print-directoriesCraig Hesling2020-04-041-5/+7
| | | | | | | | | | | | | | | | | | | | | | | | | Before this fix, some sub-make invocations did not use the --no-print-directories and some did. So, you would still see the build output contaminated by make's "Entering directory .../ec" and "Leaving directory .../ec" messages. They are pretty much useless, since they all mention the same ec directory. This fix * once and for all, kills all of those messages. * simplifies the make file by removing the need to specify the flag * cleans up the build output by removing the specified flag BRANCH=none BUG=none TEST=make buildall -j # Ensure that no "Entering dir ..." or "Leaving dir ..." # messages were emitted. Signed-off-by: Craig Hesling <hesling@chromium.org> Change-Id: I5cd7ac8fd2fcf1cde3b03485c17f5fd6969ee7aa Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2132615 Reviewed-by: Jett Rink <jettrink@chromium.org>
* test: add tc_drp testsJett Rink2020-04-031-0/+463
| | | | | | | | | | | | | | Add polarity tests Add try source tests Add no try source test BRANCH=none BUG=b:153071799 TEST=all unit tests pass Signed-off-by: Jett Rink <jettrink@chromium.org> Change-Id: Ib3d8b6afa2e8fdd80642e026deb4322e2c3e1e9b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2132872
* tcpmv2: move function from TC layer to PEJett Rink2020-04-0312-220/+170
| | | | | | | | | | | | | | | | | | | | | - Move pd_ function that belong in PE layer to PE layer. Remove the extra pe_ layer. - Remove unnecessary PE and Vconn ifdef guards in TC layer - Remove unused print_dev_info function - Move host commands in TC layer to host command file - Move RW hash stuff from TC to PE, since this only has to do with VDO (Which is a PE layer thing) - Removed dependency for tc_drp test on usbc_fake as we don't really need it anymore once we don't pull in the PRL and PE layers anymore (based on previously landed CLs) BRANCH=none BUG=b:153071799 TEST=everything still builds and passes tests Change-Id: Id1d1efa291c3525f57bc26af9fddda6ddace1b58 Signed-off-by: Jett Rink <jettrink@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2132871
* test: isolate tc_drp test cases betterJett Rink2020-04-032-15/+19
| | | | | | | | | | | | | | Ensure that state between test cases is getting fully cleared between different test cases BRANCH=none BUG=b:153071799 TEST=child CL pass when commenting various tests out without issue Signed-off-by: Jett Rink <jettrink@chromium.org> Change-Id: I7628d580c5c16bc404694a93ecc2418241d432b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2131050 Reviewed-by: LaMont Jones <lamontjones@chromium.org>
* mock: add callback functionality to tcpc mockstabilize-13020.87.B-masterstabilize-13020.67.B-masterstabilize-13020.55.B-masterrelease-R83-13020.B-masterJett Rink2020-04-034-41/+175
| | | | | | | | | | | | | | Also update prints functionality to make tests easier to see what is happening BRANCH=none BUG=b:153071799 TEST=use mock in child CL Change-Id: Ia9cfeeff220e3255e6fc0aa41f0795df3b1920e4 Signed-off-by: Jett Rink <jettrink@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2131049 Commit-Queue: LaMont Jones <lamontjones@chromium.org>
* TCPMv2: Transition to SNK_HARD_RESET on sender response timeoutSam Hurst2020-04-031-1/+1
| | | | | | | | | | | | | | | | While operating as a sink and sending a soft reset message, if a sender response timeout occurs, transition to SNK_HARD_RESET state. BUG=b:153103860 BRANCH=none TEST=make -j buildall Change-Id: I0d4552f89f9364086654f2c26a1f60d1681c3f08 Signed-off-by: Sam Hurst <shurst@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2134491 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* tcpm/anx7447.c: use chip internal timer to generate HPD IRQstabilize-sylas-13019.B-masterXin Ji2020-04-022-10/+31
| | | | | | | | | | | | | | | | | | | Anx7447 has 2 ways to generate HPD IRQ: 1): internal timer delay ~750ms. 2): outside timer delay(configured by EC anx7447.c). Some board didn't have accurate timer cause method #2 cannot be used, this patch change the default policy to method #1. BRANCH=none BUG=b:151696902 TEST=tested on STM32 board Change-Id: Ifcccacc484f82e4ed047d4caa7d86318f60d0192 Signed-off-by: Xin Ji <xji@analogixsemi.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2112312 Tested-by: Devin Lu <Devin.Lu@quantatw.com> Reviewed-by: Jett Rink <jettrink@chromium.org> Commit-Queue: Jett Rink <jettrink@chromium.org>
* docs: Run mdformat on case_closed_debugging.mdTom Hughes2020-04-021-97/+107
| | | | | | | | | | | BRANCH=none BUG=none TEST=view in gitiles Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: Id55665d87e80a472af61f0ccb7ecb8bc097ebb3c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2134646 Reviewed-by: Furquan Shaikh <furquan@chromium.org>
* ec: Enlarged Task Stack size on platformsBrian J. Nemec2020-04-023-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The task stack size of is small enough that the process was triggering stack overflows when responding to commands. These actions had a small chance of causing EC hardfaults. This was apparent with the gpioget command which had the attributes of performing many calls to a printf function which also has many parameters. Since the structure of a printf with 10 or more parameters is common when constructing console responses, this enlarges the stack for that task. This is more important since the probability of it creating a hardfault is low. To reduce the chance of this issue on other platforms, the platforms with 488 byte tasks were also enlarged to 512 bytes. BUG=chromium:1056780 BRANCH=none TEST=Connected servod to servo_v4 looped the command 'dut-control servo_v4_uart_cmd:gpioget' 1000 times TEST=make buildall -j Verified free ram space remains over 60 bytes on impacted platforms Change-Id: I6b50b204c83a10068153f3e01bc134446047f235 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2133130 Tested-by: Brian Nemec <bnemec@chromium.org> Commit-Queue: Brian Nemec <bnemec@chromium.org> Reviewed-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org> Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
* TCPMv2: Restore PD state after SysjumpSam Hurst2020-04-029-96/+226
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a PD explicit contract is negotiated in RO, the contract is maintained while performing a sysjump to RW. This is done by serializing the PD Power, Data, and VCONN Roles, along with the explicit contract flag. After jumping to RW, deserialization is performed by restoring the power roles and setting the explicit contract flag. BUG=b:152350558,b:152027807,b:152967274 BRANCH=none TEST=make -j buildall Manual tests: Used total phase to verify that charging voltage was maintained across sysjump from RO to RW and that DP was reestablished when a dock was used. Tested that Kohaku booted properly without a battery and a charger connected to port 0. This test was repeated with a charger connected to port 1. Signed-off-by: Sam Hurst <shurst@google.com> Change-Id: I349c41f2279e9af9830564d44ac73ad8435f1f80 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2119131 Tested-by: Sam Hurst <shurst@google.com> Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* ec: Reduced stack usage of gpioget console commandBrian J. Nemec2020-04-021-15/+29
| | | | | | | | | | | | | | | | | | | | | | The gpioget console command has a ccprintf() function with over a dozen parameters. This has excessive stack usage and can trigger stack overflows. Split the 11 GPIO flags into unique calls with a loop. This reduces the number of parameters that are passed and handled by the ccprintf() at once and reduces stack usage. BUG=chromium:1056780 BRANCH=none TEST=Connected servod to servo_v4 looped the command 'dut-control servo_v4_uart_cmd:gpioget' 1000 times TEST=Manual connection to device in the console and executed gpioget, verified that the format is identical to before. TEST=make buildall -j Change-Id: Ied98bab92d68ec248d626375023da4547b052963 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2133368 Tested-by: Brian Nemec <bnemec@chromium.org> Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> Commit-Queue: Brian Nemec <bnemec@chromium.org>
* it83xx/spi: enable auto reset rx fifo functiontim2020-04-023-83/+69
| | | | | | | | | | | | | | | | | | | | | | | | In this change, we enable IT83XX_SPI_AUTO_RESET_RX_FIFO. When CS# deasserted, the rx fifo and fifo count can auto reset in time by the hardware way to avoid the time delay caused. And we removed the spi_chipset_startup and shutdown. we don't need to disable the interrupt of GPIO_SPI0_CS via hook during chipset suspend and enable it during chipset resume. Instead, when the interrupt of GPIO_SPI0_CS occurs, we judge whether the chipset state is enabled and then to disable deep sleep. BUG=none BRANCH=none TEST=boot to kernel with it81202 on elm board. Press the button to shutdown and resume testing 10 times are normal. Signed-off-by: tim <tim2.lin@ite.corp-partner.google.com> Change-Id: I263d63fa5c22ef430d8f807c694317b7496f238f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2100372 Reviewed-by: Jett Rink <jettrink@chromium.org> Commit-Queue: Dino Li <Dino.Li@ite.com.tw>
* nightfury : Enable PWM and Tach for FanYongBeum.Ha2020-04-022-3/+5
| | | | | | | | | | | | | | Enable PWM and Tach to control fan BUG=b:149226871 BRANCH=firmware-hatch-12672.B TEST=make -j BOARD=nightfury Signed-off-by: YongBeum.Ha <ybha@samsung.corp-partner.google.com> Change-Id: I9ce748d81c1015565a37b2fb0d29792df4a8997a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2130148 Reviewed-by: Bob Moragues <moragues@chromium.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
* EFS2: Enable Early Firmware Selection V2 for Puffdnojiri2020-04-022-39/+2
| | | | | | | | | | | | | | | | | | | | Puff currently uses EFS1. This patch upgrades EFS to V2. Signed-off-by: dnojiri <dnojiri@chromium.org> BUG=b/147298634 BRANCH=none TEST=Verify software sync on Puff. Cq-Depend: chromium:2132693 Change-Id: I23de5b46c6e82577569246bd9cd8952e82a6b2f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2132870 Reviewed-by: Peter Marheine <pmarheine@chromium.org> Reviewed-by: Andrew McRae <amcrae@chromium.org> Tested-by: Peter Marheine <pmarheine@chromium.org> Tested-by: Daisuke Nojiri <dnojiri@chromium.org> Commit-Queue: Daisuke Nojiri <dnojiri@chromium.org> Auto-Submit: Daisuke Nojiri <dnojiri@chromium.org>
* Lazor: Initial commit for Lazor boardWai-Hong Tam2020-04-027-0/+962
| | | | | | | | | | | | | | | | | | Major changes: * EC chip: NPCX796FC * Flash size: 512KB * TCPC chips: PS8751 * BC1.2 chips: PI3USB9201 * Update GPIOs BRANCH=None BUG=b:150793669 TEST=Built the Lazor image successfully. Change-Id: I28b53b9aa7867153f86c947e3a441f3c5c081549 Signed-off-by: Wai-Hong Tam <waihong@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2123050 Reviewed-by: Alexandru M Stan <amstan@chromium.org>
* TCPMv2: Set dual-role state basing on chipset statePatryk Duda2020-04-011-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | Set DRP state during TCPMv2 initialization, basing on current chipset state. This was found when running master branch on nocturne. When EC jumps from RO to RW and chipset state is S0 already, then it is expected that DRP state is PD_DRP_TOGGLE_ON but actually the state is PD_DRP_TOGGLE_OFF. DRP state is changed only during chipset power state change, so it was necessary to shutdown and power on chromebook in order to get USB-C devices working. BUG=b:151301058 BRANCH=none TEST= Run ChromeOS Plug some USB-C device and make sure device is working Reboot EC from EC console (EC should start from RO image) Run board Check if USB-C device is working. Do not replug it or reboot board Signed-off-by: Patryk Duda <pdk@semihalf.com> Change-Id: If83a463aabf8ee6493ba3dba44ad8829539c90cc Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2124647 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
* nightfury: fix new lid accel orientation and odr configInno.Park2020-04-011-4/+4
| | | | | | | | | | | | | | | Adjust rotation matrix and modify initial odr value for new lid accel. BUG=b:152930837 BRANCH=none TEST=Boot and run 'ectool motionsense' on each LCD position. *left-side, bottom-side and face-up. Signed-off-by: Inno.Park <ih.yoo.park@samsung.corp-partner.google.com> Change-Id: Ib20b894c8bd7cf19b67c8bcea5e47cdf3ae6ea3d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2130153 Reviewed-by: Bob Moragues <moragues@chromium.org> Commit-Queue: Bob Moragues <moragues@chromium.org>
* test: add better test printsJett Rink2020-04-012-9/+11
| | | | | | | | | | | | | | | | Update test runner and mux mock to print information with tags Also print out when a test passes for easier debugging BRANCH=none] BUG=none TEST=used in child CL Change-Id: I29a1193831239c160cf75be20380e677936ba9d8 Signed-off-by: Jett Rink <jettrink@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2131048 Reviewed-by: Diana Z <dzigterman@chromium.org>
* cleanup: correct max port count on testJett Rink2020-04-011-1/+1
| | | | | | | | | | | | | | Looking at code, we only test one port, so make the test defines match the test code BRANCH=none BUG=none TEST=all tests pass Change-Id: I0b793425e20678173f3ec52fdcff4567f0b8ccb4 Signed-off-by: Jett Rink <jettrink@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2131047 Reviewed-by: Diana Z <dzigterman@chromium.org>
* dalboz: use physical pin to generate SCI to SOCPaul Ma2020-04-012-0/+4
| | | | | | | | | | | | | | Use physical pin (GPIO) to generate SCI to SOC. BUG=b:152820928, b:150239200 BRANCH=none TEST=build and boot dalboz, console command 'tabletmode on' and 'tabletmode off' work well. Change-Id: I2f8396891c2be58f2518a2c8d33ed5f55cd08d3b Signed-off-by: Paul Ma <magf@bitland.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2130147 Reviewed-by: Edward Hill <ecgh@chromium.org>
* nightfury : remove ambient thermal sensorYongBeum.Ha2020-04-012-15/+6
| | | | | | | | | | | | | | | | nightfury has 3 thermal sensor for Charger, IA and GT BUG=b:149226871 BRANCH=firmware-hatch-12672.B TEST=make -j BOARD=nightfury Signed-off-by: YongBeum.Ha <ybha@samsung.corp-partner.google.com> Change-Id: I9d1c33949577126deb3e4345ee0d679c98f9d977 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2126627 Reviewed-by: Bob Moragues <moragues@chromium.org> Reviewed-by: Scott Collyer <scollyer@chromium.org> Tested-by: Bob Moragues <moragues@chromium.org> Commit-Queue: Bob Moragues <moragues@chromium.org>
* nightfury: Enable fanYongBeum.Ha2020-04-013-2/+59
| | | | | | | | | | | | | | | | nigthfury has a fan BUG=b:149226871 BRANCH=firmware-hatch-12672.B TEST=make -j BOARD=nightfury Signed-off-by: YongBeum.Ha <ybha@samsung.corp-partner.google.com> Change-Id: Ic71a0e50aee9750c1c4e535de4176a8bfcc18ab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2094860 Reviewed-by: Bob Moragues <moragues@chromium.org> Reviewed-by: Scott Collyer <scollyer@chromium.org> Tested-by: Bob Moragues <moragues@chromium.org> Commit-Queue: Bob Moragues <moragues@chromium.org>
* Revert "volteer: Disable Burnside Bridge with TCPMv2"Ayushee2020-03-312-11/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit f062e3e0e7243ee4c75f7fd0d54a4b4dadad2c21. Reason for revert: On enabling TCPMv2 and connecting a Type-C dock to port 1, the Burnside bridge gets set correctly. Original change description: > volteer: Disable Burnside Bridge with TCPMv2 > > Burnside Bridge support has not yet been ported to TCPMv2. Don't build > Burnside Bridge support with TCPMv2, but allow code that supports the > USB3 daughter board to compile. > > BUG=b:145756626 > TEST=make buildall > BRANCH=none > > Change-Id: I949cabb26779a48ce3ca3f5f3a97ccdd3f30f58d > Signed-off-by: Abe Levkoy <alevkoy@chromium.org> > Reviewed-by: Keith Short <keithshort@chromium.org> BUG=b:15030104 BRANCH=None TEST=Tested on Volteer with TCPMv2 enabled by pluging in the Type-C dock 1. Without the monitor connected 2. With the monitor connected The Burnside bridge works as expected. Able to get the HPD request on connecting the monitor. Change-Id: I69eb3605b264801c0019297f0894ff064e2af89b Signed-off-by: Ayushee <ayushee.shah@intel.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2125378 Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com> Reviewed-by: Keith Short <keithshort@chromium.org>
* tcpmv2: default tc state change needs to be to a tc stateDenis Brockus2020-03-311-3/+6
| | | | | | | | | | | | | | | | | | | | | leaving auto_toggle_run can have a next state of default but this causes the tc state change to transition to a PD state which if all of the options are enabled it will line up but if something is gone it can direct the tc to the wrong state. BUG=b:152028728 BRANCH=none TEST=check trembyle to still be working Signed-off-by: Denis Brockus <dbrockus@google.com> Change-Id: Ic3b6ac3faf04ee6cad9d7f74d9ab67a5c23776ad Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2129342 Commit-Queue: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Edward Hill <ecgh@chromium.org> Tested-by: Denis Brockus <dbrockus@chromium.org> Auto-Submit: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Edward Hill <ecgh@chromium.org>
* ec_features: Add feat console commanddnojiri2020-03-311-0/+10
| | | | | | | | | | | | | | | | | | | | | | EC_CMD_GET_FEATURES (used by ectool inventory) requires the AP to be running. When the AP is running, EC is already running RW in EFS2. Thus, the host command can only query RW features. This patch adds 'feat' console command. It allows RO features to be queried since it doesn't require the AP to be powered. Signed-off-by: dnojiri <dnojiri@chromium.org> BUG=b/152449880 BRANCH=none TEST=Run feat command on Helios. Change-Id: I7a053f1544a8187437e99d34f6e78b580d07aa10 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2125411 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Tested-by: Daisuke Nojiri <dnojiri@chromium.org> Commit-Queue: Daisuke Nojiri <dnojiri@chromium.org> Auto-Submit: Daisuke Nojiri <dnojiri@chromium.org>
* EFS2: Add EC_FEATURE_EFS2dnojiri2020-03-313-0/+10
| | | | | | | | | | | | | | | | | | This patch adds EC_EEATURE_EFS2. It allows AP, servo, and a developer to query whether EFS2 is supported or not. Signed-off-by: dnojiri <dnojiri@chromium.org> BUG=b/152449880 BRANCH=none TEST=Verify ectool inventory prints 38 on Helios. Change-Id: Id308cad4115314380ca47c45c3212e2e6fb4095d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2125410 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Tested-by: Daisuke Nojiri <dnojiri@chromium.org> Auto-Submit: Daisuke Nojiri <dnojiri@chromium.org> Commit-Queue: Daisuke Nojiri <dnojiri@chromium.org>
* Pantheon: Make precharge current conform to the specdnojiri2020-03-311-1/+1
| | | | | | | | | | | | | | | | | | | Sunwoda battery datasheet pre-charge current has been reduced in datasheet from 363mA to 200mA and EC code needs to be reduced. Signed-off-by: dnojiri <dnojiri@chromium.org> BUG=b/151445389 BRANCH=Nami TEST=build Change-Id: I6f046ca0168840083866289dbe01e82e6fc96e6a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2103569 Tested-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-by: caveh jalali <caveh@chromium.org> Commit-Queue: Daisuke Nojiri <dnojiri@chromium.org> Auto-Submit: Daisuke Nojiri <dnojiri@chromium.org>
* TCPMv2: Treat more Type-C states, like TC_DBG_ACC_SNK, as connectedWai-Hong Tam2020-03-312-2/+9
| | | | | | | | | | | | | | | | Some Type-C states are connected states, like TC_DBG_ACC_SNK, but have not been put into the conditions. This resulted the TCPC not ack and receive any PD message; so failed to do any PD negotiation. BRANCH=None BUG=b:152650710 TEST=Connected Trogdor to Servo v4 with dts-mode enabled. They negotiated to 20V. Change-Id: I04bb5dc62721963c0fc3ea4aae9446c55ea6ae5e Signed-off-by: Wai-Hong Tam <waihong@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2128689 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* Ezkinil: Fix rotation matrices of base/lid accel configDavid Huang2020-03-311-3/+15
| | | | | | | | | | | | | | | | Fix rotation matrices of base/lid accel BUG=b:152722116 BRANCH=ezkinil TEST=Use "ectool motionsense lid_angle" or console "accelinfo on" verified lid angle correct. Signed-off-by: David Huang <david.huang@quanta.corp-partner.google.com> Change-Id: I040cbf00817d9a2c2c2cb8dddcf0234d306556c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2126629 Reviewed-by: Edward Hill <ecgh@chromium.org> Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* trembyle: LED_FULL is blue, not greenEdward Hill2020-03-311-15/+15
| | | | | | | | | | | | BUG=b:146085773 BRANCH=none TEST=none Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: Icdbccb6df2ba5320fa7a5eb8227952520354509b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2128890 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* dratini: change thermal configuration for PVTDevin Lu2020-03-311-1/+1
| | | | | | | | | | | | BUG=b:152695211 BRANCH=firmware-hatch-12672.B TEST=manually remove dptf control then do following: make sure system shutdown when over 80 degree with temp sensor 1. Change-Id: Idf5ee08ed58239239aa9d7b326b8fcf2be5946b9 Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2123625 Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
* baseboard/kukui: correct FUSB302 VBUS turn-on delayEric Yilun Lin2020-03-311-4/+12
| | | | | | | | | | | | | | | | | TCPC FUSB302 needs more time to raise VBUS to 5V. This CL increases the delay to ensure that in SRC_DISCOVER state, the VBUS is already raised to 5V. BRANCH=kukui BUG=b:152544526 TEST=Tested on kappa, kappa source to servo-v4, and issue hard reset, and ensure they can recover from the hard reset. Change-Id: I5d656c1941c4f75410e51374ba6859d6d29776fe Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2128394 Reviewed-by: Ting Shen <phoenixshen@chromium.org>
View Lorry Controller Status