summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* flash_ec: change ec_reset to gsc_ec_resetstabilize-15236.66.B-mainrelease-R109-15236.B-mainScott Chao2023-01-061-4/+4
| | | | | | | | | | | | | | | | | | | | After CL:4108949, the ec_reset have changed to gsc_ec_reset. This CL will avoid flash error due to No control named "ec_reset". BUG=none BRANCH=none TEST=use c2d2 and flash ec Change-Id: I28c8c957b3a5d24b659bb5234e9538bff0898871 Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4135920 Reviewed-by: Mary Ruthven <mruthven@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Mary Ruthven <mruthven@chromium.org> (cherry picked from commit 8163dba9aebb47b2bdca455463060b947fc5c382) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4140103 Auto-Submit: Garry Wang <xianuowang@chromium.org> Tested-by: Garry Wang <xianuowang@chromium.org>
* flash_ec: add flash_mec1322Mary Ruthven2023-01-031-0/+4
| | | | | | | | | | | | | | | | | | | | mec1322 boards are still used in the lab. flash_ec needs to support them. Readd the flash_mec1322 function. BUG=b:262603036 BRANCH=none TEST=none Change-Id: I8a6ebeba19f65a3351ae9932956f2b128660dc47 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4109268 Commit-Queue: Tom Hughes <tomhughes@chromium.org> Reviewed-by: Tom Hughes <tomhughes@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> (cherry picked from commit f9811afbb6ac67ec1f2092613316a4f305576ac3) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4121101 Tested-by: Garry Wang <xianuowang@chromium.org> Commit-Queue: Garry Wang <xianuowang@chromium.org>
* zephyr: Devicetree organization - herobrineJason Yuan2022-11-0923-471/+172
| | | | | | | | | | | | | | | | | | | | | Organized herobrine devicetrees and merged into program directory. Small devicetree changes are made in the overlay file. LED pins, LED policy, GPIO, and motion sense are kept as separate .dtsi files in the project directory. BUG=b:254097836 TEST=Ran zmake compare-builds BRANCH=none Change-Id: Ie9bfeb2a19365c8067e715cb1c5c0e3679e4ea8f Signed-off-by: Jason Yuan <jasonyuan@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4014808 Tested-by: zhi cheng yuan <jasonyuan@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: zhi cheng yuan <jasonyuan@chromium.org> Reviewed-by: Wai-Hong Tam <waihong@google.com>
* test: add wp interrupt aliasYuval Peress2022-11-091-0/+6
| | | | | | | | | | | | | | Add the wp interrupt alias to DT. Additional tests will be added later. BRANCH=none BUG=none TEST=twister Signed-off-by: Yuval Peress <peress@google.com> Change-Id: I552ac33eda5917ab9d7af0d6a460b0b2ae2b1398 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4018172 Reviewed-by: Al Semjonovs <asemjonovs@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* Revert "hibernate: Add hibernate support to ap power code"Diana Z2022-11-0913-374/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 16c8fce71986d50d9e10ea089d9d9352818129ad. Reason for revert: Breaks hibernation on PSL boards (undefines CONFIG_HIBERNATE, which disables hibernate in common/system.c) BUG=b:258093781 Original change's description: > hibernate: Add hibernate support to ap power code > > Add hibernate support to the AP power sequence code. > > The smart discharge system isn't supported yet. > > The system will hibernate after a delay when the AP is in G3 > and there is no external power connected. > > v2: add tests > > BUG=b:246643307 > TEST=Run on nivviks with short delay > BRANCH=none > > Signed-off-by: Andrew McRae <amcrae@google.com> > Cq-Depend: chromium:3985352 > Change-Id: Ib7bb62c3d650a607343a6ea243645346f4b2a797 > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3983631 > Reviewed-by: Peter Marheine <pmarheine@chromium.org> > Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Bug: b:246643307 Change-Id: Ia33273d4ebd1903b628cd163a5e3b35882badf14 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4017054 Auto-Submit: Diana Z <dzigterman@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Tested-by: Diana Z <dzigterman@chromium.org> Commit-Queue: Diana Z <dzigterman@chromium.org>
* zephyr: Kconfig: enable CONFIG_ADC automaticallyFabio Baltieri2022-11-0917-22/+5
| | | | | | | | | | | | | | Enable CONFIG_ADC automatically based devicetree compatible nodes. BRANCH=none BUG=none TEST=cq dry run Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I6ed3e352cf442d260c55073ec5e7cb82a5b3d52d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3999721 Reviewed-by: Yuval Peress <peress@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: shim: use a Kconfig option for building power.cFabio Baltieri2022-11-094-34/+37
| | | | | | | | | | | | | | | | | | Use an automatic Kconfig option to include power.c in the build, rather than including it unconditionally. Removes some precompiler guards from the source file and also move some macro that are only used in power.c out of the header file. BRANCH=none BUG=none TEST=cq dry run Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I021ec1384ef374f1c1dc841ea861e848ee9e65f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4003277 Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: cbi_eeprom: stop silently drop the code if misconfiguredFabio Baltieri2022-11-094-7/+40
| | | | | | | | | | | | | | | | Change the cbi_eeprom code to not get blanked if enabled but no eeprom device is defined, fire a build warning instead. Also make sure that the device is ready before trying to use it. BRANCH=none BUG=none TEST=cq dry run Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I9c3a00be98c40ea8c1be307ef02c08c856aa770f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3999729 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Al Semjonovs <asemjonovs@google.com>
* zephyr: ioex: select PLATFORM_EC_USBA automaticallyFabio Baltieri2022-11-0911-25/+2
| | | | | | | | | | | | | | | | Enable PLATFORM_EC_USBA automatically based devicetree compatible nodes. Drop a bunch of now unnecessary config and a macro guard. BRANCH=none BUG=none TEST=cq dry run Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I824e7f7f01fda9145b682897d3262de221f9000a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4003282 Reviewed-by: Aaron Massey <aaronmassey@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: gpio_id: use nodelabels, add a build optionFabio Baltieri2022-11-0910-51/+37
| | | | | | | | | | | | | | | | | | | | Few minor cleanups around the gpio_id.c file: - stop using DT_PATH, use a known nodelabel instead, makes it easier to define bits in dts files without relying on a known path - use an explicit Kconfig automatic option instead of always having the file in the build and macro'ing out if not needed - add a build warning if neither sku or board nodes are found, should catch misconfigured nodes at build time BRANCH=none BUG=none TEST=cq dry run Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: Iddaf737a2a2efd647ffd303d3f3692e90a49318b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4003281 Reviewed-by: Aaron Massey <aaronmassey@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: ioex: select PLATFORM_EC_IOEX_CROS_DRV automaticallyFabio Baltieri2022-11-093-3/+2
| | | | | | | | | | | | | | | Enable PLATFORM_EC_IOEX_CROS_DRV automatically based devicetree compatible nodes. BRANCH=none BUG=none TEST=cq dry run Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: Ic42cdfc3ce19580219a0ac00750d237aa66a7736 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4003280 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Wai-Hong Tam <waihong@google.com>
* gitlab: Add instructions for adding vms to docJeremy Bettis2022-11-091-0/+69
| | | | | | | | | | | | | | | | | | | | Document the commands needed to add a new VM to the gitlab runners. One of the VMs ran out of disk space, so add a daily cleanup cron job to delete old docker data. BRANCH=None BUG=b:244590155 TEST=Ran the crontab commands Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: I0196cad3fbe113614feea33582741a3d15f27fca Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4016955 Tested-by: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Al Semjonovs <asemjonovs@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Al Semjonovs <asemjonovs@google.com>
* zephyr: tests: Test charger.c charger_set_voltage()Tristan Honscheid2022-11-091-0/+28
| | | | | | | | | | | | | | | Test charger_set_voltage in common/charger.c BRANCH=None BUG=None TEST=./twister Signed-off-by: Tristan Honscheid <honscheid@google.com> Change-Id: I719540c87271b57ab60a7bd87eba6671daed9c62 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4000832 Commit-Queue: Aaron Massey <aaronmassey@google.com> Reviewed-by: Aaron Massey <aaronmassey@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* Revert "cq: Run verbose make for better debugging"Jeremy Bettis2022-11-092-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 23fd725b83abdcb50eb99f69e6a4b102489ba3f7. Reason for revert: The build output for EC is 109Mb. Too big. Original change's description: > cq: Run verbose make for better debugging > > There have been several mysterious failures in the CQ and it's hard to > see what is going on since make doesn't print the commands by default. > > BRANCH=None > BUG=b:257393779 > TEST=CQ > > Signed-off-by: Jeremy Bettis <jbettis@google.com> > Change-Id: I4e4db7ef328b01f52d820405db036ef881d06405 > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4005654 > Commit-Queue: Jeremy Bettis <jbettis@chromium.org> > Tested-by: Jeremy Bettis <jbettis@chromium.org> > Auto-Submit: Jeremy Bettis <jbettis@chromium.org> > Reviewed-by: Al Semjonovs <asemjonovs@google.com> > Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> > Commit-Queue: Al Semjonovs <asemjonovs@google.com> Bug: b:257393779 Change-Id: I9fbde348c12ec77b2447a264d7190c3d75423958 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4014811 Reviewed-by: Al Semjonovs <asemjonovs@google.com> Commit-Queue: Al Semjonovs <asemjonovs@google.com> Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Tested-by: Jeremy Bettis <jbettis@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* test/kb_scan: Add 1ms delay at the beginning of each test stepRob Barnes2022-11-091-0/+3
| | | | | | | | | | | | | | | | | | | | | There's a race condition between this test and system init. Specifically, calling weak functions during system init can cause kb_scan test to fail. I don't fully understand the source of the race condition, but adding just a 1ms delay at the beginning of each test step resolves the issue. BUG=b:258231435 BRANCH=None TEST=kb_scan and kb_scan_strict pass on host Change-Id: I624d4f62533d25fb128ab6f39408fd643c2fa869 Signed-off-by: Rob Barnes <robbarnes@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4012962 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* zephyr: shi: select SHI driver automaticallyFabio Baltieri2022-11-091-4/+7
| | | | | | | | | | | | | | | Change SHI device driver config entries to select the right one automatically based on what's enabled in the devicetree. BRANCH=none BUG=none TEST=cq dry run Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I0b82a52b8da4c9b6021c5bdfbedc273454dadf37 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4003279 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Al Semjonovs <asemjonovs@google.com>
* zephyr: rtc: select CROS_RTC_TYPE automaticallyFabio Baltieri2022-11-093-3/+6
| | | | | | | | | | | | | | Use DT_HAS_* config to select the correct RTC TYPE automatically. BRANCH=none BUG=none TEST=cq dry run Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I7895d7a1cae339f168c063e225222222ff434cbd Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4003278 Reviewed-by: Sam Hurst <shurst@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: Kconfig: enable CONFIG_CROS_KB_RAW_NPCX automaticallyFabio Baltieri2022-11-098-12/+1
| | | | | | | | | | | | | | | Enable CONFIG_CROS_KB_RAW_NPCX automatically based devicetree compatible nodes. BRANCH=none BUG=none TEST=cq dry run Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I340b51d0337644b828c09df59a63819201b1cdbe Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4000386 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* zephyr: Kconfig: enable CONFIG_CROS_KB_RAW_XEC automaticallyFabio Baltieri2022-11-092-2/+1
| | | | | | | | | | | | | | | Enable CONFIG_CROS_KB_RAW_XEC automatically based devicetree compatible nodes. BRANCH=none BUG=none TEST=cq dry run Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I6acaef6880dab79f16d3d394c83c54601d1c09c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4000385 Reviewed-by: Tristan Honscheid <honscheid@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: Kconfig: enable CONFIG_CROS_KB_RAW_ITE automaticallyFabio Baltieri2022-11-092-2/+1
| | | | | | | | | | | | | | | Enable CONFIG_CROS_KB_RAW_ITE automatically based devicetree compatible nodes. BRANCH=none BUG=none TEST=cq dry run Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: Ib58406766c74ab1839c75879ac74ed064749b21d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4000384 Reviewed-by: Keith Short <keithshort@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: Kconfig: enable CROS_FLASH_NPCX automaticallyFabio Baltieri2022-11-095-5/+1
| | | | | | | | | | | | | | Enable CROS_FLASH_NPCX automatically based devicetree compatible nodes. BRANCH=none BUG=none TEST=cq dry run Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I59b2559a1db08ab9e33f7b6409d5774a247ee1ed Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4000383 Reviewed-by: Yuval Peress <peress@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: Kconfig: enable CONFIG_CROS_FLASH_XEC automaticallyFabio Baltieri2022-11-092-2/+1
| | | | | | | | | | | | | | | Enable CONFIG_CROS_FLASH_XEC automatically based devicetree compatible nodes. BRANCH=none BUG=none TEST=cq dry run Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: Ia887e3743b47a4383b4d13db12fd5f4f5b255aeb Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4000382 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Keith Short <keithshort@chromium.org>
* zephyr: Kconfig: enable PLATFORM_EC_CHARGER_RT9490 automaticallyFabio Baltieri2022-11-094-3/+2
| | | | | | | | | | | | | | | Enable PLATFORM_EC_CHARGER_RT9490 automatically based devicetree compatible nodes. BRANCH=none BUG=none TEST=cq dry run Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I0d45ea628e539b9bed608be346e7051bc465f405 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4000381 Reviewed-by: Keith Short <keithshort@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: config drop explicit CONFIG_PLATFORM_EC_CHARGER=yFabio Baltieri2022-11-095-5/+0
| | | | | | | | | | | | | | | The option already defaults to the correct value, no need to set it explicitly. BRANCH=none BUG=none TEST=cq dry run Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I66b0722df26d3685d3e8414aab8f14786ba09b73 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4000380 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Aaron Massey <aaronmassey@google.com>
* zephyr: shim: select the correct CBI source automaticallyFabio Baltieri2022-11-0912-16/+2
| | | | | | | | | | | | | | | Select the right CBI data source config option depending on what's defined in the devicetree for the project. BRANCH=none BUG=none TEST=cq dry run Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: Ia1d2755fdaae9062d1265e9ae9bd0017530d2ae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3999728 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Sam Hurst <shurst@google.com>
* zephyr: bindings: rename named-cbi-ssfc to cros-ec,cbi-ssfcFabio Baltieri2022-11-0910-57/+55
| | | | | | | | | | | | | | Rename the SSFC dts bindings for consistency with the FW_CONFIG ones. BRANCH=none BUG=none TEST=cq dry run Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: Ic47e60948ca6cf3face5903ecbfc8d9b3d0b6c7e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3999727 Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: shim: add a CONFIG_PLATFORM_EC_CBI option.Fabio Baltieri2022-11-093-10/+15
| | | | | | | | | | | | | | | | Add a CONFIG_PLATFORM_EC_CBI option that way we can associate it with an explicit build rule instead of having overlapping file list for the various CBI storage types. BRANCH=none BUG=none TEST=cq dry run Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: If7f8e68979118392cc4f7af236640b15c74d91fa Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3999726 Reviewed-by: Jeremy Bettis <jbettis@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: Kconfig: enable CONFIG_PLATFORM_EC_BATTERY automaticallyFabio Baltieri2022-11-0912-11/+2
| | | | | | | | | | | | | | | Enable CONFIG_PLATFORM_EC_BATTERY automatically based devicetree compatible nodes. BRANCH=none BUG=none TEST=cq dry run Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I909a29f6516b225541d878fd6df7de93d8d61754 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3999725 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Wai-Hong Tam <waihong@google.com>
* krabby: rename i2c_krabby_tentacruel.dtsiTing Shen2022-11-094-3/+3
| | | | | | | | | | | | | | | | | | | This file is shared with all krabby followers, it should not have the _tentacruel suffix. rename to ite_i2c.dtsi to comply with the new layout standard. BUG=none TEST=zmake build BRANCH=none Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: I931f6a1bc0f51bd68ee8eb2001f716142f136eef Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4010983 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Eric Yilun Lin <yllin@google.com> Tested-by: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Eric Yilun Lin <yllin@google.com> Auto-Submit: Ting Shen <phoenixshen@chromium.org>
* zephyr: tests: Test charger.c charger_get_actual_voltage()Tristan Honscheid2022-11-091-0/+45
| | | | | | | | | | | | | | Test charger_get_actual_voltage in common/charger.c BRANCH=None BUG=None TEST=./twister Signed-off-by: Tristan Honscheid <honscheid@google.com> Change-Id: I82421e3141d657d7b6290187eb7ed18024732af2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4000831 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Simon Glass <sjg@chromium.org>
* zephyr: tests: Test charger.c charger_get_actual_current()Tristan Honscheid2022-11-091-0/+45
| | | | | | | | | | | | | | Test charger_get_actual_current in common/charger.c BRANCH=None BUG=None TEST=./twister Signed-off-by: Tristan Honscheid <honscheid@google.com> Change-Id: Idd220b05371d90621f874e9b8152522d124da131 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4000830 Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: tests: Test charger.c charger_is_sourcing_otg_power()Tristan Honscheid2022-11-091-0/+19
| | | | | | | | | | | | | | Test charger_is_sourcing_otg_power in common/charger.c BRANCH=None BUG=None TEST=./twister Signed-off-by: Tristan Honscheid <honscheid@google.com> Change-Id: I8cd233035230264e8da6cbbd543fc7cd31bbe50f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4000829 Reviewed-by: Al Semjonovs <asemjonovs@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: tests: Test charger.c charger_set_otg_current_voltage()Tristan Honscheid2022-11-091-0/+34
| | | | | | | | | | | | | | Test charger_set_otg_current_voltage in common/charger.c BRANCH=None BUG=None TEST=./twister Signed-off-by: Tristan Honscheid <honscheid@google.com> Change-Id: Ibbb3e36b51809aca754d802c6b4f9cc4267e0eb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4000828 Reviewed-by: Tomasz Michalec <tmichalec@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: test: common charger code charger_enable_otg_powerTristan Honscheid2022-11-093-0/+100
| | | | | | | | | | | | | | | | Add some infrastructure for mocking out the charger driver functions to simplify testing the remainder of `common/charger.c` and use it to test charger_enable_otg_power() BUG=None BRANCH=None TEST=./twister Signed-off-by: Tristan Honscheid <honscheid@google.com> Change-Id: I61b74c4cd2f8b7303b37c78cff0156db03c6191e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4000827 Reviewed-by: Jeremy Bettis <jbettis@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* nissa: enable CONFIG_PLATFORM_EC_BACKLIGHT_LIDZick Wei2022-11-091-3/+0
| | | | | | | | | | | | | BUG=b:257861378 BRANCH=none TEST=verify panel backlight turn off when system in factory image with lid close. Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: Idf2565cd78e6a98d43cc85d6a13ba238438292bb Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4011740 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Peter Marheine <pmarheine@chromium.org>
* nissa: update usba1 enable pin initial stateZick Wei2022-11-091-2/+2
| | | | | | | | | | | | | | | | Set USBA1 enable pin to output only during initialize, which retaining current value. BUG=b:255269471 BRANCH=none TEST=Not lost USBA storage after sysjump manually. Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: Ib2b6d1900de974150d5a8d677016deeb40e98a26 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4012839 Reviewed-by: Devin Lu <devin.lu@quantatw.com> Reviewed-by: Peter Marheine <pmarheine@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* winterhold: fix battery cannot be chargedMatt Wang2022-11-098-2/+95
| | | | | | | | | | | | | | | | | | | | After battery is over-drained, EC_BATT_PRES_ODL will be always high cause EC won't wake battery. BUG=b:249438144 BRANCH=none TEST=zmake build winterhold successfully TEST=winterhold can boot up to OS from battery cut off TEST=use the battery cell voltage less than 2.5V can boot to OS LOW_COVERAGE_REASON=Skyrim board not create the battery hw present function Signed-off-by: Matt Wang <matt_wang@compal.corp-partner.google.com> Change-Id: I02a7da58d51693595fc7bb18d01e8e12a5f42908 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3980937 Reviewed-by: Diana Z <dzigterman@chromium.org> Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* Makefile.toolchain: Enable -ftrapv for fingerprint boardsTom Hughes2022-11-098-1/+283
| | | | | | | | | | | | | | | | | | | | | | The "-ftrapv" flag generates an exception for *signed* integer overflow: https://gcc.gnu.org/onlinedocs/gcc/Code-Gen-Options.html. This commit adds a unit test to verify the behavior. For now this is clang-only, since the gcc toolchain is missing the "trapping arithmetic functions": __addvsi3, __subvsi3, etc. https://gcc.gnu.org/onlinedocs/gccint/Integer-library-routines.html BRANCH=none BUG=b:144957935, b:258074414 TEST=./test/run_device_tests.py --board dartmonkey -t ftrapv TEST=./test/run_device_tests.py --board bloonchipper -t ftrapv Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I2235c2d289bab2a17d7915978c17aaa07302403d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4007158 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Andrea Grandi <agrandi@google.com>
* joxer: enable interrupts for lid accelPeter Marheine2022-11-092-6/+10
| | | | | | | | | | | | | | | The BMA4xx driver now supports interrupts, so stop polling the lid accel. BUG=b:254380338 TEST=zmake build joxer BRANCH=none LOW_COVERAGE_REASON=board-specific code is not tested Signed-off-by: Peter Marheine <pmarheine@chromium.org> Change-Id: Iff99f9b9d912f56054085dad0fb0560d0766e0a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4005048 Reviewed-by: Andrew McRae <amcrae@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* craask: use interrupts for lid accelPeter Marheine2022-11-093-4/+21
| | | | | | | | | | | | | | | | The BMA4xx driver now supports interrupts, so use them instead of polling the lid accelerometer. BUG=b:254380338 TEST=lid angle still reports correctly on craask with BMA422 BRANCH=none LOW_COVERAGE_REASON=board-specific code is not tested Change-Id: I8ec9565b9c160b9a4274610f7b91ab1bc0836620 Signed-off-by: Peter Marheine <pmarheine@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4005617 Reviewed-by: Andrew McRae <amcrae@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* pujjo: enable interrupts for lid accelPeter Marheine2022-11-094-4/+23
| | | | | | | | | | | | | | | | The BMA4xx driver now supports interrupts, so stop polling the lid accel. BUG=b:254380338 TEST=accelinfo still shows accurate lid angle on pujjo with LIS2DW12 sensor installed BRANCH=none LOW_COVERAGE_REASON=board-specific code is not tested Signed-off-by: Peter Marheine <pmarheine@chromium.org> Change-Id: I29b8675736d38e1f737f9faf139ae9aa0058758c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4005683 Reviewed-by: Andrew McRae <amcrae@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* ec: Track coverage for rex.Jeremy Bettis2022-11-092-1/+11
| | | | | | | | | | | | | | BRANCH=None BUG=None TEST=None Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: I67a103199dbb07178c3f263e44eb6aeb7eb2af16 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4012963 Tested-by: Jeremy Bettis <jbettis@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
* zephyr/shell: enable convenience features by defaultPeter Marheine2022-11-092-6/+20
| | | | | | | | | | | | | | | | CONFIG_MINIMAL_SHELL provides meaningful flash size reduction (about 8k on NPCX) but turns off features that are important to us. Add EC defaults that keep those on, even if MINIMAL_SHELL=y. BUG=b:230486318 TEST=no change in flash usage on nivviks BRANCH=none Signed-off-by: Peter Marheine <pmarheine@chromium.org> Change-Id: I3e4e37f409a473ff38e145ecacb0c4f24382fd14 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4011358 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Keith Short <keithshort@chromium.org>
* util/ectool: Fix EC_CMD_GSV_PAUSE_IN_S5 result parameter typeCaveh Jalali2022-11-081-1/+1
| | | | | | | | | | | | | | | | | | This fixes the struct type for EC_CMD_GSV_PAUSE_IN_S5 responses. Verified in the command implementation that EC_CMD_GSV_PAUSE_IN_S5 takes a struct ec_params_get_set_value and returns a struct ec_response_get_set_value. The two structs are identical, so there should be no functional impact. BRANCH=none BUG=none TEST=rebuilt ectool Change-Id: I9ca4f6889b4fecec8b1a964cdf5788daf49be01a Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4010707 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* gitlab: Remove twister workaroundsJeremy Bettis2022-11-081-5/+1
| | | | | | | | | | | | | | | | | | Twister should use toolchain host and set the toolchain dir to zephyr by default in gitlab now. BRANCH=None BUG=None TEST=Ran gitlab runner locally on zephyr_coverage and zephyr_boards_coverage Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: I8b8d14f21722e42bc903303b98cf185ea68b198e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4011463 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Tested-by: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Tristan Honscheid <honscheid@google.com> Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
* twister: Implement --gcc and --clang optionsJeremy Bettis2022-11-082-49/+79
| | | | | | | | | | | | | | | | | | | | | | | | | | | | In the CQ we call twister with quite a lot of flags, and those could be in the twister wrapper instead. Add twister arg --toolchain=xxx (with aliases --gcc, --llvm, --clang) which will set the gcov-tool, ZEPHYR_TOOLCHAIN_VARIANT env var, cmake vars CMAKE_C_COMPILER and CMAKE_CXX_COMPILER. Remove now surplus args from firmware_builder.py. BRANCH=None BUG=None TEST=./twister --clobber --gcc --coverage TEST=./twister --clobber --toolchain=host --coverage TEST=./twister --clobber --toolchain=llvm --coverage TEST=./twister --clobber --clang --coverage TEST=./twister --clobber --llvm --coverage Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: Ida16653bbe24891fd1114d71cdd3445b4146757d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4010583 Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Tested-by: Jeremy Bettis <jbettis@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Tristan Honscheid <honscheid@google.com>
* herobrine: Enable USB C1 PPC interruptYu-An Chen2022-11-081-0/+1
| | | | | | | | | | | | | | | | | | Enable USB C1 PPC interrupt BUG=b:256996124 BRANCH=none TEST=manual check evoker C1 PPC interrupt working LOW_COVERAGE_REASON=no unit test for herobrine board yet. Also, It is a 1-line CL. Signed-off-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com> Change-Id: I51f97c4842ec8cf6db5a22a983a2e41428db8fc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4000343 Reviewed-by: Wai-Hong Tam <waihong@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Bob Moragues <moragues@chromium.org> Commit-Queue: Wai-Hong Tam <waihong@google.com>
* test: add wake_mask_eventsYuval Peress2022-11-081-0/+14
| | | | | | | | | | | | | | | Enable the 'ec-mkbp-host-event-wakeup-mask' node. Currently, all tests should pass the same, additional tests will be added later. BRANCH=none BUG=none TEST=twister Signed-off-by: Yuval Peress <peress@google.com> Change-Id: I9fcb2e4e2e3bc7a34b8a2af6401fe920a404c70e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4012961 Reviewed-by: Aaron Massey <aaronmassey@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* test: add more edge case tests for "chgstate sustain"Yuval Peress2022-11-081-0/+10
| | | | | | | | | | | | | | | Catch cases when non-numbers are passed into "chgstate sustain" console command. BRANCH=none BUG=none TEST=twister Signed-off-by: Yuval Peress <peress@google.com> Change-Id: I541897ecb27e87cda63b5650d06c187a09186a7b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4011173 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Tristan Honscheid <honscheid@google.com>
* test: verify paths in charge_is_consuming_full_input_current()Yuval Peress2022-11-081-0/+14
| | | | | | | | | | | | BRANCH=none BUG=none TEST=twister Signed-off-by: Yuval Peress <peress@google.com> Change-Id: Ib5e1861a033c6df08a41efe3f74389ec84b44fba Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4011172 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Aaron Massey <aaronmassey@google.com>
View Lorry Controller Status